diff options
author | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-07 19:03:32 +0000 |
---|---|---|
committer | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-07 19:03:32 +0000 |
commit | cf5e1beaa20d2cd67296a45c779378f44363dc7f (patch) | |
tree | db04a9d7923fd93f95d3e38cd0fbce134b2ef463 /webkit | |
parent | 37a4d3c48ce25dbac523034d257135f207ed01ec (diff) | |
download | chromium_src-cf5e1beaa20d2cd67296a45c779378f44363dc7f.zip chromium_src-cf5e1beaa20d2cd67296a45c779378f44363dc7f.tar.gz chromium_src-cf5e1beaa20d2cd67296a45c779378f44363dc7f.tar.bz2 |
Fix 3 layout tests, annotate 3 others.
- Add missing binding for activeElement (http://trac.webkit.org/changeset/30866)
- Add missing binding for hasFocus
- Account for system colors in expected results (http://trac.webkit.org/changeset/28775)
- Remove custom "HTMLDocument.idl:clear" method.
Review URL: http://codereview.chromium.org/6298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2954 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
6 files changed, 14 insertions, 24 deletions
diff --git a/webkit/data/layout_test_results/kjs/LayoutTests/tables/mozilla/bugs/bug103533-expected.txt b/webkit/data/layout_test_results/kjs/LayoutTests/tables/mozilla/bugs/bug103533-expected.txt index 3d3f367..205d167 100644 --- a/webkit/data/layout_test_results/kjs/LayoutTests/tables/mozilla/bugs/bug103533-expected.txt +++ b/webkit/data/layout_test_results/kjs/LayoutTests/tables/mozilla/bugs/bug103533-expected.txt @@ -3,13 +3,13 @@ layer at (0,0) size 800x600 layer at (0,0) size 800x600 RenderBlock {HTML} at (0,0) size 800x600 RenderBody {BODY} at (8,8) size 784x584 - RenderTable {TABLE} at (0,0) size 204x26 + RenderTable {TABLE} at (0,0) size 204x26 [bgcolor=#6363CE] RenderTableSection {TBODY} at (0,0) size 204x26 RenderTableRow {TR} at (0,2) size 204x22 RenderTableCell {TD} at (2,2) size 200x22 [r=0 c=0 rs=1 cs=1] RenderText {#text} at (1,1) size 198x19 text run at (1,1) width 198: "This table should NOT be visible" - RenderTable {TABLE} at (0,26) size 204x26 + RenderTable {TABLE} at (0,26) size 204x26 [bgcolor=#6363CE] RenderTableSection {TBODY} at (0,0) size 204x26 RenderTableRow {TR} at (0,2) size 204x22 RenderTableCell {TD} at (2,2) size 200x22 [r=0 c=0 rs=1 cs=1] diff --git a/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug103533-expected.txt b/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug103533-expected.txt index 3d3f367..205d167 100644 --- a/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug103533-expected.txt +++ b/webkit/data/layout_test_results/v8/LayoutTests/tables/mozilla/bugs/bug103533-expected.txt @@ -3,13 +3,13 @@ layer at (0,0) size 800x600 layer at (0,0) size 800x600 RenderBlock {HTML} at (0,0) size 800x600 RenderBody {BODY} at (8,8) size 784x584 - RenderTable {TABLE} at (0,0) size 204x26 + RenderTable {TABLE} at (0,0) size 204x26 [bgcolor=#6363CE] RenderTableSection {TBODY} at (0,0) size 204x26 RenderTableRow {TR} at (0,2) size 204x22 RenderTableCell {TD} at (2,2) size 200x22 [r=0 c=0 rs=1 cs=1] RenderText {#text} at (1,1) size 198x19 text run at (1,1) width 198: "This table should NOT be visible" - RenderTable {TABLE} at (0,26) size 204x26 + RenderTable {TABLE} at (0,26) size 204x26 [bgcolor=#6363CE] RenderTableSection {TBODY} at (0,0) size 204x26 RenderTableRow {TR} at (0,2) size 204x22 RenderTableCell {TD} at (2,2) size 200x22 [r=0 c=0 rs=1 cs=1] diff --git a/webkit/port/bindings/v8/v8_custom.cpp b/webkit/port/bindings/v8/v8_custom.cpp index 3986295..325ae92 100644 --- a/webkit/port/bindings/v8/v8_custom.cpp +++ b/webkit/port/bindings/v8/v8_custom.cpp @@ -2654,18 +2654,6 @@ CALLBACK_FUNC_DECL(HTMLDocumentOpen) { return v8::Undefined(); } -CALLBACK_FUNC_DECL(HTMLDocumentClear) { - INC_STATS(L"DOM.HTMLDocument.clear()"); - // Do nothing (unimplemented) - - // KJS's bindings do do the same thing in JSHTMLDocument::clear(). - // Invoking HTMLDocument::clear() can cause a crash, since it - // deletes the document's tokenizer while it may still be in use. - // See b:1055485 for details. - return v8::Undefined(); -} - - // Document -------------------------------------------------------------------- CALLBACK_FUNC_DECL(DocumentEvaluate) { diff --git a/webkit/port/bindings/v8/v8_custom.h b/webkit/port/bindings/v8/v8_custom.h index 6c60e33..776f6fd 100644 --- a/webkit/port/bindings/v8/v8_custom.h +++ b/webkit/port/bindings/v8/v8_custom.h @@ -195,7 +195,6 @@ DECLARE_CALLBACK(HTMLOptionsCollectionAdd) DECLARE_CALLBACK(HTMLDocumentWrite) DECLARE_CALLBACK(HTMLDocumentWriteln) DECLARE_CALLBACK(HTMLDocumentOpen) -DECLARE_CALLBACK(HTMLDocumentClear) // Document customized functions DECLARE_CALLBACK(DocumentEvaluate) diff --git a/webkit/port/html/HTMLDocument.idl b/webkit/port/html/HTMLDocument.idl index 568746e..074bc61 100644 --- a/webkit/port/html/HTMLDocument.idl +++ b/webkit/port/html/HTMLDocument.idl @@ -43,9 +43,10 @@ module html { readonly attribute HTMLCollection all; - [Custom] void clear(); #endif + void clear(); + void captureEvents(); void releaseEvents(); @@ -55,6 +56,9 @@ module html { attribute [ConvertNullToNullString] DOMString designMode; readonly attribute DOMString compatMode; + readonly attribute Element activeElement; + boolean hasFocus(); + // Deprecated attributes attribute [ConvertNullToNullString] DOMString bgColor; attribute [ConvertNullToNullString] DOMString fgColor; diff --git a/webkit/tools/layout_tests/test_lists/tests_fixable.txt b/webkit/tools/layout_tests/test_lists/tests_fixable.txt index 95a8df6..edf746c 100644 --- a/webkit/tools/layout_tests/test_lists/tests_fixable.txt +++ b/webkit/tools/layout_tests/test_lists/tests_fixable.txt @@ -633,6 +633,8 @@ V8 | KJS # LayoutTests/fast/dom/gc-7.html = TIMEOUT V8 | KJS # LayoutTests/fast/frames/frame-set-same-location.html = TIMEOUT V8 | KJS # LayoutTests/fast/frames/frame-set-same-src.html = TIMEOUT V8 | KJS # LayoutTests/fast/frames/hover-timer-crash.html = TIMEOUT +V8 | KJS # LayoutTests/fast/loader/data-url-encoding-html.html = FAIL +V8 | KJS # LayoutTests/fast/loader/data-url-encoding-svg.html = FAIL // Bug: 1045048 // We haven't implemented GCController in test shell @@ -806,6 +808,9 @@ V8 # LayoutTests/fast/js/delete-getters-setters.html = FAIL // location property over same-named iframe. V8 | KJS # LayoutTests/fast/dom/Window/window-special-properties.html = FAIL +// Exception message capitalizes "Cyclic", expected to be lower case. (trivial) +V8 | KJS # LayoutTests/fast/js/cyclic-proto.html = FAIL + # Console output won't have line numbers until V8 gives us a way to get that # information. <http://crbug.com/2960> V8 # LayoutTests/fast/dom/Window/console-functions.html = FAIL @@ -941,8 +946,6 @@ V8 | KJS # LayoutTests/fast/dom/Document/createAttributeNS-namespace-err.html = V8 | KJS # LayoutTests/fast/dom/Document/createElementNS-namespace-err.html = FAIL V8 | KJS # LayoutTests/fast/dom/documenturi-assigned-junk-implies-relative-urls-do-not-resolve.html = FAIL V8 | KJS # LayoutTests/fast/dom/gc-acid3.html = FAIL -V8 | KJS # LayoutTests/fast/dom/HTMLDocument/activeElement.html = FAIL -V8 | KJS # LayoutTests/fast/dom/HTMLDocument/hasFocus.html = FAIL | TIMEOUT V8 | KJS # LayoutTests/fast/dom/SelectorAPI/NSResolver-exceptions.xhtml = FAIL V8 | KJS # LayoutTests/fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml = FAIL V8 | KJS # LayoutTests/fast/text/align-center-rtl-spill.html = FAIL @@ -1074,9 +1077,6 @@ V8 | KJS # LayoutTests/fast/forms/textAreaLineHeight.html = FAIL V8 | KJS # LayoutTests/fast/forms/textarea-hard-linewrap.html = FAIL V8 | KJS # LayoutTests/fast/images/svg-as-background.html = FAIL V8 | KJS # LayoutTests/fast/images/svg-as-tiled-background.html = FAIL -V8 | KJS # LayoutTests/fast/js/cyclic-proto.html = FAIL -V8 | KJS # LayoutTests/fast/loader/data-url-encoding-html.html = FAIL -V8 | KJS # LayoutTests/fast/loader/data-url-encoding-svg.html = FAIL V8 | KJS # LayoutTests/fast/loader/url-parse-1.html = FAIL V8 | KJS # LayoutTests/fast/parser/entity-comment-in-style.html = FAIL V8 | KJS # LayoutTests/fast/parser/entity-comment-in-textarea.html = FAIL @@ -1287,7 +1287,6 @@ V8 | KJS # LayoutTests/svg/text/kerning.svg = FAIL V8 | KJS # LayoutTests/svg/text/multichar-glyph.svg = FAIL V8 | KJS # LayoutTests/svg/text/text-fonts-02-t.svg = FAIL V8 | KJS # LayoutTests/svg/text/textPathBoundsBug.svg = FAIL -V8 | KJS # LayoutTests/tables/mozilla/bugs/bug103533.html = FAIL V8 | KJS # LayoutTests/tables/mozilla/bugs/bug43854-1.html = FAIL V8 | KJS # LayoutTests/tables/mozilla_expected_failures/bugs/bug14007-2.html = FAIL V8 | KJS # LayoutTests/tables/mozilla_expected_failures/bugs/bug220653.html = FAIL |