diff options
| author | dennisjeffrey@chromium.org <dennisjeffrey@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-23 16:20:47 +0000 |
|---|---|---|
| committer | dennisjeffrey@chromium.org <dennisjeffrey@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-23 16:20:47 +0000 |
| commit | 1fed59867bd9b8ea27d14c631f94c3c2ab830254 (patch) | |
| tree | 01d4db65db29f53414c9bc84ceb67a68e4455eae /webkit | |
| parent | e62c6edaf6338d89fe6562ff8c398fd5e80192ff (diff) | |
| download | chromium_src-1fed59867bd9b8ea27d14c631f94c3c2ab830254.zip chromium_src-1fed59867bd9b8ea27d14c631f94c3c2ab830254.tar.gz chromium_src-1fed59867bd9b8ea27d14c631f94c3c2ab830254.tar.bz2 | |
Fix 2 threading-related bugs in pyauto's remote inspector module.
The first problem was a small typo where the wrong variable was being used (a boolean
value was being used where a threading.Condition object should have been used).
The second problem was in the API functions StartTimelineEventMonitoring and
StopTimelineEventMonitoring. Previously, these two functions would send a
request to tell the remote inspector to start/stop timeline mode, but they did
not wait until the requests were serviced before returning. This sometimes led
to subtle multithreading problems where the remote inspector module would hang.
The fix is to ensure these two API functions wait until their requests are
serviced before returning.
BUG=None
TEST=Ran a Chrome Endure test for 5 seconds with --repeat=100. Previously, we'd see
a hang within the first 10 runs or so. Now, all 100 runs pass.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10795055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147859 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
0 files changed, 0 insertions, 0 deletions