diff options
| author | ojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-03 05:47:19 +0000 |
|---|---|---|
| committer | ojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-03 05:47:19 +0000 |
| commit | 36336ee3bf3668fc8c9c536a9e5caa0e462ffca4 (patch) | |
| tree | e155b5e5c3bbd5bded026023fbf9a8f615ca4fee /webkit | |
| parent | e99977ceff19046bb4620706c7b30acc3a2a4a75 (diff) | |
| download | chromium_src-36336ee3bf3668fc8c9c536a9e5caa0e462ffca4.zip chromium_src-36336ee3bf3668fc8c9c536a9e5caa0e462ffca4.tar.gz chromium_src-36336ee3bf3668fc8c9c536a9e5caa0e462ffca4.tar.bz2 | |
Take number three at running tests in parallel for Windows-release
builds. TBR to submit while the tree is less active.
Review URL: http://codereview.chromium.org/56210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13074 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
| -rwxr-xr-x | webkit/tools/layout_tests/run_webkit_tests.py | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/webkit/tools/layout_tests/run_webkit_tests.py b/webkit/tools/layout_tests/run_webkit_tests.py index 8c62c0a..7a04814 100755 --- a/webkit/tools/layout_tests/run_webkit_tests.py +++ b/webkit/tools/layout_tests/run_webkit_tests.py @@ -724,8 +724,8 @@ def main(options, args): options.platform = path_utils.PlatformDir() if not options.num_test_shells: - # All configurations are still to flaky to have this on by default. - if False: + # Only run stable configurations with multiple test_shells by default. + if sys.platform in ('win32', 'cygwin') and options.target == 'Release': cpus = 1 if sys.platform in ('win32', 'cygwin'): cpus = int(os.environ.get('NUMBER_OF_PROCESSORS', 1)) @@ -738,13 +738,9 @@ def main(options, args): elif sys.platform in ('darwin'): # OSX: cpus = int(os.popen2("sysctl -n hw.ncpu")[1].read()) - # TODO: Do timing tests on a single-core machine. - options.num_test_shells = 2 * cpus - - # Some HTTP tests start timing out when tests are run in parallel. - # TODO(ojan): Impelement per-test-timeouts instead. http://crbug.com/9613 - if not options.time_out_ms: - options.time_out_ms = '20000' + # TODO: Do timing tests 1/2/4/8 cores and mac, linux, win to see what + # the optimal number here is. + options.num_test_shells = cpus + 1 else: options.num_test_shells = 1 |