diff options
author | yurys@google.com <yurys@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-18 17:12:12 +0000 |
---|---|---|
committer | yurys@google.com <yurys@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-18 17:12:12 +0000 |
commit | fb452133d3571bc94e725fdb5aee3f812a16e40e (patch) | |
tree | e4daa02ceb3f765a256621e192e02a69a03314b7 /webkit | |
parent | 5f9b70e7fe486eaa6726703c9857d02a954e07d8 (diff) | |
download | chromium_src-fb452133d3571bc94e725fdb5aee3f812a16e40e.zip chromium_src-fb452133d3571bc94e725fdb5aee3f812a16e40e.tar.gz chromium_src-fb452133d3571bc94e725fdb5aee3f812a16e40e.tar.bz2 |
Reverting 9944.
This change broke ui, interactive and Vista Perf tests. I felt like reverting.
Review URL: http://codereview.chromium.org/24020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9947 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r-- | webkit/glue/glue.vcproj | 4 | ||||
-rw-r--r-- | webkit/glue/tools_proxy.h | 75 | ||||
-rw-r--r-- | webkit/glue/webview.h | 5 | ||||
-rw-r--r-- | webkit/glue/webview_impl.cc | 5 | ||||
-rw-r--r-- | webkit/glue/webview_impl.h | 2 |
5 files changed, 0 insertions, 91 deletions
diff --git a/webkit/glue/glue.vcproj b/webkit/glue/glue.vcproj index 1f7e9d7..acaad6f 100644 --- a/webkit/glue/glue.vcproj +++ b/webkit/glue/glue.vcproj @@ -173,10 +173,6 @@ > </File> <File - RelativePath=".\tools_proxy.h" - > - </File> - <File RelativePath=".\webdatasource.h" > </File> diff --git a/webkit/glue/tools_proxy.h b/webkit/glue/tools_proxy.h deleted file mode 100644 index d4d70b5..0000000 --- a/webkit/glue/tools_proxy.h +++ /dev/null @@ -1,75 +0,0 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// Developer tools consist of following parts:
-//
-// ToolsAgent lives in the renderer of an inspected page and provides access to
-// the pages resources, DOM, v8 etc. by means of IPC messages.
-//
-// ToolsClient is a thin delegate that lives in the tools front-end renderer and
-// converts IPC messages to frontend methods calls and allows the frontend to
-// send messages to the ToolsAgent.
-//
-// All the messages are routed through browser process.
-//
-// Chain of communication between the components may be described by the
-// following diagram:
-// --------------------------
-// | (tools frontend |
-// | renderer process) |
-// | | --------------------
-// |tools <--> ToolsClient+<-- IPC -->+ (browser process) |
-// |frontend | | |
-// -------------------------- -----------+--------
-// ^
-// |
-// IPC
-// |
-// v
-// --------------------------+-------
-// | inspected page <--> ToolsAgent |
-// | |
-// | (inspected page renderer process)|
-// ----------------------------------
-//
-// This file describes interface between tools frontend and ToolsClient in the
-// above diagram.
-
-#ifndef WEBKIT_GLUE_TOOLS_PROXY_H_
-#define WEBKIT_GLUE_TOOLS_PROXY_H_
-
-#include "base/basictypes.h"
-
-class ToolsUI;
-
-// Interface for sending messages to remote ToolsAgent.
-class ToolsProxy {
- public:
- ToolsProxy() {}
- virtual ~ToolsProxy() {}
-
- virtual void SetToolsUI(ToolsUI* tools_ui) = 0;
-
- virtual void DebugAttach() = 0;
- virtual void DebugDetach() = 0;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(ToolsProxy);
-};
-
-
-// Interface for accessing tools frontend.
-class ToolsUI {
- public:
- ToolsUI() {}
- virtual ~ToolsUI() {}
-
- virtual void OnDidDebugAttach() = 0;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(ToolsUI);
-};
-
-#endif // WEBKIT_GLUE_TOOLS_PROXY_H_
-
diff --git a/webkit/glue/webview.h b/webkit/glue/webview.h index f0f3e26..39d608c 100644 --- a/webkit/glue/webview.h +++ b/webkit/glue/webview.h @@ -12,7 +12,6 @@ #include "base/ref_counted.h" #include "webkit/glue/webwidget.h" -class ToolsProxy; struct WebDropData; struct WebPreferences; class GURL; @@ -166,10 +165,6 @@ class WebView : public WebWidget { // Show the JavaScript console. virtual void ShowJavaScriptConsole() = 0; - // Set up developer tools UI bindings. It is guaranteed that tools_proxy will - // overlive this webview. - virtual void SetUpToolsProxy(ToolsProxy* tools_proxy) = 0; - // Notifies the webview that a drag has terminated. virtual void DragSourceEndedAt( int client_x, int client_y, int screen_x, int screen_y) = 0; diff --git a/webkit/glue/webview_impl.cc b/webkit/glue/webview_impl.cc index 496aa7d..7959b6f 100644 --- a/webkit/glue/webview_impl.cc +++ b/webkit/glue/webview_impl.cc @@ -1429,11 +1429,6 @@ void WebViewImpl::ShowJavaScriptConsole() { page_->inspectorController()->showPanel(InspectorController::ConsolePanel); } -void WebViewImpl::SetUpToolsProxy(ToolsProxy* tools_proxy) { - DCHECK(page_ != NULL); - // TODO(yurys): implement -} - void WebViewImpl::DragSourceEndedAt( int client_x, int client_y, int screen_x, int screen_y) { PlatformMouseEvent pme(IntPoint(client_x, client_y), diff --git a/webkit/glue/webview_impl.h b/webkit/glue/webview_impl.h index ed0dbce..c511e7b 100644 --- a/webkit/glue/webview_impl.h +++ b/webkit/glue/webview_impl.h @@ -37,7 +37,6 @@ class Widget; class AutocompletePopupMenuClient; class ImageResourceFetcher; class SearchableFormData; -class ToolsProxy; struct WebDropData; class WebHistoryItemImpl; class WebKeyboardEvent; @@ -90,7 +89,6 @@ class WebViewImpl : public WebView, public base::RefCounted<WebViewImpl> { virtual void CopyImageAt(int x, int y); virtual void InspectElement(int x, int y); virtual void ShowJavaScriptConsole(); - virtual void SetUpToolsProxy(ToolsProxy* tools_proxy); virtual void DragSourceEndedAt( int client_x, int client_y, int screen_x, int screen_y); virtual void DragSourceMovedTo( |