summaryrefslogtreecommitdiffstats
path: root/webkit
diff options
context:
space:
mode:
authornsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-07 16:13:11 +0000
committernsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-07 16:13:11 +0000
commit7c825a47e993f941e13d505727e0d3bc6699d193 (patch)
tree5892e892aed7ad3b4d85fcc1affe43ee0f38ef5f /webkit
parent44986391568796028c6ecf84f4112facdaee7e22 (diff)
downloadchromium_src-7c825a47e993f941e13d505727e0d3bc6699d193.zip
chromium_src-7c825a47e993f941e13d505727e0d3bc6699d193.tar.gz
chromium_src-7c825a47e993f941e13d505727e0d3bc6699d193.tar.bz2
Revert change 11197 because it created 138 new layout tests
failures. Review URL: http://codereview.chromium.org/39311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11201 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r--webkit/glue/resource_handle_impl.cc8
-rw-r--r--webkit/glue/resource_loader_bridge.h3
-rw-r--r--webkit/tools/test_shell/simple_resource_loader_bridge.cc12
3 files changed, 9 insertions, 14 deletions
diff --git a/webkit/glue/resource_handle_impl.cc b/webkit/glue/resource_handle_impl.cc
index dbc8606..ee7acb4 100644
--- a/webkit/glue/resource_handle_impl.cc
+++ b/webkit/glue/resource_handle_impl.cc
@@ -227,8 +227,7 @@ class ResourceHandleInternal : public ResourceLoaderBridge::Peer {
const ResourceLoaderBridge::ResponseInfo& info,
bool content_filtered);
virtual void OnReceivedData(const char* data, int len);
- virtual void OnCompletedRequest(const URLRequestStatus& status,
- const std::string& security_info);
+ virtual void OnCompletedRequest(const URLRequestStatus& status);
virtual std::string GetURLForDebugging();
// Handles a data: url internally instead of calling the bridge.
@@ -300,7 +299,7 @@ void ResourceHandleInternal::HandleDataUrl() {
OnReceivedData(data.c_str(), data.size());
}
- OnCompletedRequest(status, info.security_info);
+ OnCompletedRequest(status);
// We are done using the object. ResourceHandle and ResourceHandleInternal
// might be destroyed now.
@@ -605,8 +604,7 @@ void ResourceHandleInternal::OnReceivedData(const char* data, int data_len) {
}
void ResourceHandleInternal::OnCompletedRequest(
- const URLRequestStatus& status,
- const std::string& security_info) {
+ const URLRequestStatus& status) {
if (multipart_delegate_.get()) {
multipart_delegate_->OnCompletedRequest();
multipart_delegate_.reset(NULL);
diff --git a/webkit/glue/resource_loader_bridge.h b/webkit/glue/resource_loader_bridge.h
index d5ca181..948bc74 100644
--- a/webkit/glue/resource_loader_bridge.h
+++ b/webkit/glue/resource_loader_bridge.h
@@ -111,8 +111,7 @@ class ResourceLoaderBridge {
// Called when the response is complete. This method signals completion of
// the resource load.ff
- virtual void OnCompletedRequest(const URLRequestStatus& status,
- const std::string& security_info) = 0;
+ virtual void OnCompletedRequest(const URLRequestStatus& status) = 0;
// Returns the URL of the request, which allows us to display it in
// debugging situations.
diff --git a/webkit/tools/test_shell/simple_resource_loader_bridge.cc b/webkit/tools/test_shell/simple_resource_loader_bridge.cc
index c6c7b78..f6b10f3 100644
--- a/webkit/tools/test_shell/simple_resource_loader_bridge.cc
+++ b/webkit/tools/test_shell/simple_resource_loader_bridge.cc
@@ -173,10 +173,9 @@ class RequestProxy : public URLRequest::Delegate,
peer_->OnReceivedData(buf_copy.get(), bytes_read);
}
- void NotifyCompletedRequest(const URLRequestStatus& status,
- const std::string& security_info) {
+ void NotifyCompletedRequest(const URLRequestStatus& status) {
if (peer_) {
- peer_->OnCompletedRequest(status, security_info);
+ peer_->OnCompletedRequest(status);
DropPeer(); // ensure no further notifications
}
}
@@ -247,10 +246,9 @@ class RequestProxy : public URLRequest::Delegate,
this, &RequestProxy::NotifyReceivedData, bytes_read));
}
- virtual void OnCompletedRequest(const URLRequestStatus& status,
- const std::string& security_info) {
+ virtual void OnCompletedRequest(const URLRequestStatus& status) {
owner_loop_->PostTask(FROM_HERE, NewRunnableMethod(
- this, &RequestProxy::NotifyCompletedRequest, status, security_info));
+ this, &RequestProxy::NotifyCompletedRequest, status));
}
// --------------------------------------------------------------------------
@@ -291,7 +289,7 @@ class RequestProxy : public URLRequest::Delegate,
void Done() {
DCHECK(request_.get());
- OnCompletedRequest(request_->status(), std::string());
+ OnCompletedRequest(request_->status());
request_.reset(); // destroy on the io thread
}