diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-19 18:41:31 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-19 18:41:31 +0000 |
| commit | 2e39d2ebf7e388595bd7fe17d99e30e8a35a43fc (patch) | |
| tree | 88d7dc914fed1e9303b05a5bc4f2a454c066872f /webkit | |
| parent | 1933eb200c4bb16e4df535d779c98561f85c1e25 (diff) | |
| download | chromium_src-2e39d2ebf7e388595bd7fe17d99e30e8a35a43fc.zip chromium_src-2e39d2ebf7e388595bd7fe17d99e30e8a35a43fc.tar.gz chromium_src-2e39d2ebf7e388595bd7fe17d99e30e8a35a43fc.tar.bz2 | |
Send over the HTTP status code in the ViewHostMsg_FrameNavigate message coming in from the renderer.
A failed HTTP navigation like a 404 response to a request is followed by two responses. The first one which is associated with the failed response. This does not send over any information about the failure to the browser and thus appears as a normal navigation.The second response is for the actual 404 page being loaded.
For network errors the browser does get notified via RenderView::DidFailProvisionalLoadWithError. However due to a prototype mismatch the corresponding function in WebContents is never invoked.
Added a new automation message AutomationMsg_NavigationFailed, which carries information about failed navigations to automation clients.The changes to the navigation controller include sending over the http status code and the URL to observers.
The ExternalTabContainer also subscribes to the FAIL_PROVISIONAL_LOAD_WITH_ERROR notification, so it can inform clients about errors. We also ignore the next NAV_ENTRY_COMMITTED notification after an error due to the reasons mentioned above.
Review URL: http://codereview.chromium.org/21495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10023 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
| -rw-r--r-- | webkit/glue/webview_delegate.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/webkit/glue/webview_delegate.h b/webkit/glue/webview_delegate.h index 359d45c..7ef577a 100644 --- a/webkit/glue/webview_delegate.h +++ b/webkit/glue/webview_delegate.h @@ -256,6 +256,7 @@ class WebViewDelegate : virtual public WebWidgetDelegate { // @discussion This method is called after the provisional data source has // failed to load. The frame will continue to display the contents of the // committed data source if there is one. + // This notification is only received for errors like network errors. virtual void DidFailProvisionalLoadWithError(WebView* webview, const WebError& error, WebFrame* frame) { |