diff options
author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-25 18:00:48 +0000 |
---|---|---|
committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-25 18:00:48 +0000 |
commit | 32bc515fb904ffff1cb883f5c28dee66251a52f5 (patch) | |
tree | 797170ed69a75b2f95081022e7287796ed81dff0 /webkit | |
parent | 42f5fe544fe4023d3bbac1e96406d3a405c524f9 (diff) | |
download | chromium_src-32bc515fb904ffff1cb883f5c28dee66251a52f5.zip chromium_src-32bc515fb904ffff1cb883f5c28dee66251a52f5.tar.gz chromium_src-32bc515fb904ffff1cb883f5c28dee66251a52f5.tar.bz2 |
Cleanup webkit_child target and dependencies on it.
BUG=338338
TEST=None
R=jamesr@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/417973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285619 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r-- | webkit/child/BUILD.gn | 37 | ||||
-rw-r--r-- | webkit/child/webkit_child.gyp | 59 |
2 files changed, 2 insertions, 94 deletions
diff --git a/webkit/child/BUILD.gn b/webkit/child/BUILD.gn index 025e934..6ac5c23 100644 --- a/webkit/child/BUILD.gn +++ b/webkit/child/BUILD.gn @@ -11,46 +11,9 @@ component("child") { ] defines = [ "WEBKIT_CHILD_IMPLEMENTATION" ] - include_dirs = [ - # For JNI generated header. - "$root_gen_dir/webkit", - ] - - configs += [ "//build/config/compiler:wexit_time_destructors" ] - if (is_win) { - # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. - cflags = [ "/wd4267" ] - } - - if (is_mac) { - libs = [ "QuartzCore.framework" ] - } - if (is_android) { - #deps += [ ":overscroller_jni_headers" ] TODO(GYP) - } deps = [ "//base", - "//base:i18n", - "//base/third_party/dynamic_annotations", "//net", - "//skia", - "//third_party/WebKit/public:blink", - "//ui/gfx", - "//ui/gfx/geometry", - "//ui/native_theme", - "//url", - "//v8", - "//webkit/common", ] } - -#TODO(GYP) -#'target_name': 'overscroller_jni_headers', -#'type': 'none', -#'variables': { -# 'jni_gen_package': 'webkit', -# 'input_java_class': 'android/widget/OverScroller.class', -#}, -#'includes': [ '../../build/jar_file_jni_generator.gypi' ], - diff --git a/webkit/child/webkit_child.gyp b/webkit/child/webkit_child.gyp index 49a1ffe..388809d 100644 --- a/webkit/child/webkit_child.gyp +++ b/webkit/child/webkit_child.gyp @@ -6,77 +6,22 @@ 'variables': { 'chromium_code': 1, }, - 'conditions': [ - ['OS=="android"', - { - 'targets': [ - { - 'target_name': 'overscroller_jni_headers', - 'type': 'none', - 'variables': { - 'jni_gen_package': 'webkit', - 'input_java_class': 'android/widget/OverScroller.class', - }, - 'includes': [ '../../build/jar_file_jni_generator.gypi' ], - }, - ], - } - ], - ], 'targets': [ { 'target_name': 'webkit_child', 'type': '<(component)', - 'variables': { 'enable_wexit_time_destructors': 1, }, 'defines': [ 'WEBKIT_CHILD_IMPLEMENTATION', ], 'dependencies': [ - '<(DEPTH)/base/base.gyp:base', - '<(DEPTH)/base/base.gyp:base_i18n', - '<(DEPTH)/base/base.gyp:base_static', - '<(DEPTH)/base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations', - '<(DEPTH)/net/net.gyp:net', - '<(DEPTH)/skia/skia.gyp:skia', - '<(DEPTH)/third_party/WebKit/public/blink.gyp:blink', - '<(DEPTH)/ui/gfx/gfx.gyp:gfx', - '<(DEPTH)/ui/gfx/gfx.gyp:gfx_geometry', - '<(DEPTH)/ui/native_theme/native_theme.gyp:native_theme', - '<(DEPTH)/url/url.gyp:url_lib', - '<(DEPTH)/v8/tools/gyp/v8.gyp:v8', - ], - 'include_dirs': [ - # For JNI generated header. - '<(SHARED_INTERMEDIATE_DIR)/webkit', + '../../base/base.gyp:base', + '../../net/net.gyp:net', ], - # This target exports a hard dependency because dependent targets may - # include the header generated above. - 'hard_dependency': 1, 'sources': [ 'resource_loader_bridge.cc', 'resource_loader_bridge.h', 'webkit_child_export.h', ], - # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. - 'msvs_disabled_warnings': [ 4267 ], - 'conditions': [ - ['OS=="mac"', - { - 'link_settings': { - 'libraries': [ - '$(SDKROOT)/System/Library/Frameworks/QuartzCore.framework', - ], - }, - } - ], - ['OS=="android"', - { - 'dependencies': [ - 'overscroller_jni_headers', - ], - } - ], - ], }, ], } |