diff options
author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-26 01:31:20 +0000 |
---|---|---|
committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-26 01:31:20 +0000 |
commit | 459c700eb320d8bb3d43dbf0607044d794bda4d7 (patch) | |
tree | 9b05d648b63f7603293118125a12337e14eb8742 /webkit | |
parent | c4a0cda0f19ce2c19edb0742832953ae846bf821 (diff) | |
download | chromium_src-459c700eb320d8bb3d43dbf0607044d794bda4d7.zip chromium_src-459c700eb320d8bb3d43dbf0607044d794bda4d7.tar.gz chromium_src-459c700eb320d8bb3d43dbf0607044d794bda4d7.tar.bz2 |
plugins: unfork WebPluginDelegateImpl between linux/win
Algorithm:
- copy win to shared
- for each diff between shared and lin, delete/refactor shared
- for each diff between shared and lin, delete in lin
- for each diff between shared and win, delete in win
The change should be mostly deletes.
Please verify that I didn't change any behavior on Windows or GTK.
Note: coincidentally, this change also fixes a bug that we've seen
on Linux that was fixed in the Windows version of the file. I only
noticed it because the Windows/Linux files differed, but after this
unforking the change is now in the shared code.
Mac shouldn't be too hard to do too.
Review URL: http://codereview.chromium.org/174479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24404 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r-- | webkit/glue/plugins/webplugin_delegate_impl.cc | 1132 | ||||
-rw-r--r-- | webkit/glue/plugins/webplugin_delegate_impl.h | 7 | ||||
-rw-r--r-- | webkit/glue/plugins/webplugin_delegate_impl_gtk.cc | 205 | ||||
-rw-r--r-- | webkit/glue/plugins/webplugin_delegate_impl_mac.mm | 7 | ||||
-rw-r--r-- | webkit/glue/plugins/webplugin_delegate_impl_win.cc | 202 | ||||
-rw-r--r-- | webkit/webkit.gyp | 13 |
6 files changed, 51 insertions, 1515 deletions
diff --git a/webkit/glue/plugins/webplugin_delegate_impl.cc b/webkit/glue/plugins/webplugin_delegate_impl.cc index 37efc33..a76e5d9 100644 --- a/webkit/glue/plugins/webplugin_delegate_impl.cc +++ b/webkit/glue/plugins/webplugin_delegate_impl.cc @@ -8,13 +8,11 @@ #include <vector> #include "base/file_util.h" -#include "base/iat_patch.h" -#include "base/lazy_instance.h" #include "base/message_loop.h" +#include "base/process_util.h" #include "base/stats_counters.h" #include "base/string_util.h" #include "webkit/api/public/WebInputEvent.h" -#include "webkit/default_plugin/plugin_impl.h" #include "webkit/glue/glue_util.h" #include "webkit/glue/plugins/plugin_constants_win.h" #include "webkit/glue/plugins/plugin_instance.h" @@ -22,85 +20,12 @@ #include "webkit/glue/plugins/plugin_list.h" #include "webkit/glue/plugins/plugin_stream_url.h" #include "webkit/glue/webkit_glue.h" -#include "webkit/glue/webplugin.h" using WebKit::WebCursorInfo; using WebKit::WebKeyboardEvent; using WebKit::WebInputEvent; using WebKit::WebMouseEvent; -namespace { - -const wchar_t kWebPluginDelegateProperty[] = L"WebPluginDelegateProperty"; -const wchar_t kPluginNameAtomProperty[] = L"PluginNameAtom"; -const wchar_t kDummyActivationWindowName[] = L"DummyWindowForActivation"; -const wchar_t kPluginOrigProc[] = L"OriginalPtr"; -const wchar_t kPluginFlashThrottle[] = L"FlashThrottle"; - -// The fastest we are willing to process WM_USER+1 events for Flash. -// Flash can easily exceed the limits of our CPU if we don't throttle it. -// The throttle has been chosen by testing various delays and compromising -// on acceptable Flash performance and reasonable CPU consumption. -// -// I'd like to make the throttle delay variable, based on the amount of -// time currently required to paint Flash plugins. There isn't a good -// way to count the time spent in aggregate plugin painting, however, so -// this seems to work well enough. -const int kFlashWMUSERMessageThrottleDelayMs = 5; - -// Flash displays popups in response to user clicks by posting a WM_USER -// message to the plugin window. The handler for this message displays -// the popup. To ensure that the popups allowed state is sent correctly -// to the renderer we reset the popups allowed state in a timer. -const int kWindowedPluginPopupTimerMs = 50; - -// The current instance of the plugin which entered the modal loop. -WebPluginDelegateImpl* g_current_plugin_instance = NULL; - -base::LazyInstance<std::list<MSG> > g_throttle_queue(base::LINKER_INITIALIZED); - -// Helper object for patching the TrackPopupMenu API. -base::LazyInstance<iat_patch::IATPatchFunction> g_iat_patch_track_popup_menu( - base::LINKER_INITIALIZED); - -// Helper object for patching the SetCursor API. -base::LazyInstance<iat_patch::IATPatchFunction> g_iat_patch_set_cursor( - base::LINKER_INITIALIZED); - -// http://crbug.com/16114 -// Enforces providing a valid device context in NPWindow, so that NPP_SetWindow -// is never called with NPNWindoTypeDrawable and NPWindow set to NULL. -// Doing so allows removing NPP_SetWindow call during painting a windowless -// plugin, which otherwise could trigger layout change while painting by -// invoking NPN_Evaluate. Which would cause bad, bad crashes. Bad crashes. -// TODO(dglazkov): If this approach doesn't produce regressions, move class to -// webplugin_delegate_impl.h and implement for other platforms. -class DrawableContextEnforcer { - public: - explicit DrawableContextEnforcer(NPWindow* window) - : window_(window), - disposable_dc_(window && !window->window) { - // If NPWindow is NULL, create a device context with monochrome 1x1 surface - // and stuff it to NPWindow. - if (disposable_dc_) - window_->window = CreateCompatibleDC(NULL); - } - - ~DrawableContextEnforcer() { - if (!disposable_dc_) - return; - - DeleteDC(static_cast<HDC>(window_->window)); - window_->window = NULL; - } - - private: - NPWindow* window_; - bool disposable_dc_; -}; - -} // namespace - WebPluginDelegate* WebPluginDelegate::Create( const FilePath& filename, const std::string& mime_type, @@ -119,150 +44,6 @@ WebPluginDelegate* WebPluginDelegate::Create( return new WebPluginDelegateImpl(containing_view, instance.get()); } -bool WebPluginDelegateImpl::IsPluginDelegateWindow(HWND window) { - // We use a buffer that is one char longer than we need to detect cases where - // kNativeWindowClassName is a prefix of the given window's class name. It - // happens that GetClassNameW will just silently truncate the class name to - // fit into the given buffer. - wchar_t class_name[arraysize(kNativeWindowClassName) + 1]; - if (!GetClassNameW(window, class_name, arraysize(class_name))) - return false; - return wcscmp(class_name, kNativeWindowClassName) == 0; -} - -bool WebPluginDelegateImpl::GetPluginNameFromWindow( - HWND window, std::wstring *plugin_name) { - if (NULL == plugin_name) { - return false; - } - if (!IsPluginDelegateWindow(window)) { - return false; - } - ATOM plugin_name_atom = reinterpret_cast<ATOM>( - GetPropW(window, kPluginNameAtomProperty)); - if (plugin_name_atom != 0) { - WCHAR plugin_name_local[MAX_PATH] = {0}; - GlobalGetAtomNameW(plugin_name_atom, - plugin_name_local, - ARRAYSIZE(plugin_name_local)); - *plugin_name = plugin_name_local; - return true; - } - return false; -} - -bool WebPluginDelegateImpl::IsDummyActivationWindow(HWND window) { - if (!IsWindow(window)) - return false; - - wchar_t window_title[MAX_PATH + 1] = {0}; - if (GetWindowText(window, window_title, arraysize(window_title))) { - return (0 == lstrcmpiW(window_title, kDummyActivationWindowName)); - } - return false; -} - -LRESULT CALLBACK WebPluginDelegateImpl::HandleEventMessageFilterHook( - int code, WPARAM wParam, LPARAM lParam) { - if (g_current_plugin_instance) { - g_current_plugin_instance->OnModalLoopEntered(); - } else { - NOTREACHED(); - } - return CallNextHookEx(NULL, code, wParam, lParam); -} - -WebPluginDelegateImpl::WebPluginDelegateImpl( - gfx::PluginWindowHandle containing_view, - NPAPI::PluginInstance *instance) - : parent_(containing_view), - instance_(instance), - quirks_(0), - plugin_(NULL), - windowless_(false), - windowed_handle_(NULL), - windowed_did_set_window_(false), - windowless_needs_set_window_(true), - plugin_wnd_proc_(NULL), - last_message_(0), - is_calling_wndproc(false), - dummy_window_for_activation_(NULL), - handle_event_message_filter_hook_(NULL), - handle_event_pump_messages_event_(NULL), - handle_event_depth_(0), - user_gesture_message_posted_(false), -#pragma warning(suppress: 4355) // can use this - user_gesture_msg_factory_(this) { - memset(&window_, 0, sizeof(window_)); - - const WebPluginInfo& plugin_info = instance_->plugin_lib()->plugin_info(); - std::string filename = - WideToUTF8(StringToLowerASCII(plugin_info.path.BaseName().value())); - - if (instance_->mime_type() == "application/x-shockwave-flash" || - filename == "npswf32.dll") { - // Flash only requests windowless plugins if we return a Mozilla user - // agent. - instance_->set_use_mozilla_user_agent(); - quirks_ |= PLUGIN_QUIRK_THROTTLE_WM_USER_PLUS_ONE; - quirks_ |= PLUGIN_QUIRK_PATCH_SETCURSOR; - } else if (filename == "nppdf32.dll") { - // Check for the version number above or equal 9. - std::vector<std::wstring> version; - SplitString(plugin_info.version, L'.', &version); - if (version.size() > 0) { - int major = static_cast<int>(StringToInt64(version[0])); - if (major >= 9) { - quirks_ |= PLUGIN_QUIRK_DIE_AFTER_UNLOAD; - } - } - quirks_ |= PLUGIN_QUIRK_BLOCK_NONSTANDARD_GETURL_REQUESTS; - } else if (plugin_info.name.find(L"Windows Media Player") != - std::wstring::npos) { - // Windows Media Player needs two NPP_SetWindow calls. - quirks_ |= PLUGIN_QUIRK_SETWINDOW_TWICE; - } else if (instance_->mime_type() == "audio/x-pn-realaudio-plugin" || - filename == "nppl3260.dll") { - quirks_ |= PLUGIN_QUIRK_DONT_CALL_WND_PROC_RECURSIVELY; - } else if (plugin_info.name.find(L"VLC Multimedia Plugin") != - std::wstring::npos || - plugin_info.name.find(L"VLC Multimedia Plug-in") != - std::wstring::npos) { - // VLC hangs on NPP_Destroy if we call NPP_SetWindow with a null window - // handle - quirks_ |= PLUGIN_QUIRK_DONT_SET_NULL_WINDOW_HANDLE_ON_DESTROY; - // VLC 0.8.6d and 0.8.6e crash if multiple instances are created. - quirks_ |= PLUGIN_QUIRK_DONT_ALLOW_MULTIPLE_INSTANCES; - } else if (filename == "npctrl.dll") { - // Explanation for this quirk can be found in - // WebPluginDelegateImpl::Initialize. - quirks_ |= PLUGIN_QUIRK_PATCH_SETCURSOR; - } -} - -WebPluginDelegateImpl::~WebPluginDelegateImpl() { - if (::IsWindow(dummy_window_for_activation_)) { - ::DestroyWindow(dummy_window_for_activation_); - } - - DestroyInstance(); - - if (!windowless_) - WindowedDestroyWindow(); - - if (handle_event_pump_messages_event_) { - CloseHandle(handle_event_pump_messages_event_); - } -} - -void WebPluginDelegateImpl::PluginDestroyed() { - if (handle_event_depth_) { - MessageLoop::current()->DeleteSoon(FROM_HERE, this); - } else { - delete this; - } -} - bool WebPluginDelegateImpl::Initialize(const GURL& url, char** argn, char** argv, @@ -296,50 +77,19 @@ bool WebPluginDelegateImpl::Initialize(const GURL& url, if (!windowless_) { if (!WindowedCreatePlugin()) return false; - } - - plugin->SetWindow(windowed_handle_); - if (windowless_) { + } else { // For windowless plugins we should set the containing window handle // as the instance window handle. This is what Safari does. Not having // a valid window handle causes subtle bugs with plugins which retreive // the window handle and validate the same. The window handle can be // retreived via NPN_GetValue of NPNVnetscapeWindow. instance_->set_window_handle(parent_); -#if defined(OS_WIN) - CreateDummyWindowForActivation(); - handle_event_pump_messages_event_ = CreateEvent(NULL, TRUE, FALSE, NULL); - plugin->SetWindowlessPumpEvent(handle_event_pump_messages_event_); -#endif } - plugin_url_ = url.spec(); - // The windowless version of the Silverlight plugin calls the - // WindowFromPoint API and passes the result of that to the - // TrackPopupMenu API call as the owner window. This causes the API - // to fail as the API expects the window handle to live on the same - // thread as the caller. It works in the other browsers as the plugin - // lives on the browser thread. Our workaround is to intercept the - // TrackPopupMenu API for Silverlight and replace the window handle - // with the dummy activation window. - if (windowless_ && !g_iat_patch_track_popup_menu.Pointer()->is_patched()) { - g_iat_patch_track_popup_menu.Pointer()->Patch( - GetPluginPath().value().c_str(), "user32.dll", "TrackPopupMenu", - WebPluginDelegateImpl::TrackPopupMenuPatch); - } + PlatformInitialize(plugin); + + plugin_url_ = url.spec(); - // Windowless plugins can set cursors by calling the SetCursor API. This - // works because the thread inputs of the browser UI thread and the plugin - // thread are attached. We intercept the SetCursor API for windowless plugins - // and remember the cursor being set. This is shipped over to the browser - // in the HandleEvent call, which ensures that the cursor does not change - // when a windowless plugin instance changes the cursor in a background tab. - if (windowless_ && !g_iat_patch_set_cursor.Pointer()->is_patched() && - (quirks_ & PLUGIN_QUIRK_PATCH_SETCURSOR)) { - g_iat_patch_set_cursor.Pointer()->Patch( - GetPluginPath().value().c_str(), "user32.dll", "SetCursor", - WebPluginDelegateImpl::SetCursorPatch); - } return true; } @@ -360,18 +110,7 @@ void WebPluginDelegateImpl::DestroyInstance() { instance_->set_web_plugin(NULL); - if (instance_->plugin_lib()) { - // Unpatch if this is the last plugin instance. - if (instance_->plugin_lib()->instance_count() == 1) { - if (g_iat_patch_set_cursor.Pointer()->is_patched()) { - g_iat_patch_set_cursor.Pointer()->Unpatch(); - } - - if (g_iat_patch_track_popup_menu.Pointer()->is_patched()) { - g_iat_patch_track_popup_menu.Pointer()->Unpatch(); - } - } - } + PlatformDestroyInstance(); instance_ = 0; } @@ -387,26 +126,6 @@ void WebPluginDelegateImpl::UpdateGeometry( } } -void WebPluginDelegateImpl::Paint(HDC hdc, const gfx::Rect& rect) { - if (windowless_) - WindowlessPaint(hdc, rect); -} - -void WebPluginDelegateImpl::Print(HDC hdc) { - // Disabling the call to NPP_Print as it causes a crash in - // flash in some cases. In any case this does not work as expected - // as the EMF meta file dc passed in needs to be created with the - // the plugin window dc as its sibling dc and the window rect - // in .01 mm units. -#if 0 - NPPrint npprint; - npprint.mode = NP_EMBED; - npprint.print.embedPrint.platformPrint = reinterpret_cast<void*>(hdc); - npprint.print.embedPrint.window = window_; - instance()->NPP_Print(&npprint); -#endif -} - NPObject* WebPluginDelegateImpl::GetPluginScriptableObject() { return instance_->GetPluginScriptableObject(); } @@ -417,7 +136,7 @@ void WebPluginDelegateImpl::DidFinishLoadWithReason(NPReason reason) { int WebPluginDelegateImpl::GetProcessId() { // We are in process, so the plugin pid is this current process pid. - return ::GetCurrentProcessId(); + return base::GetCurrentProcId(); } void WebPluginDelegateImpl::SendJavaScriptStream(const std::string& url, @@ -459,14 +178,6 @@ FilePath WebPluginDelegateImpl::GetPluginPath() { return instance()->plugin_lib()->plugin_info().path; } -void WebPluginDelegateImpl::InstallMissingPlugin() { - NPEvent evt; - evt.event = PluginInstallerImpl::kInstallMissingPluginMessage; - evt.lParam = 0; - evt.wParam = 0; - instance()->NPP_HandleEvent(&evt); -} - void WebPluginDelegateImpl::WindowedUpdateGeometry( const gfx::Rect& window_rect, const gfx::Rect& clip_rect) { @@ -477,720 +188,6 @@ void WebPluginDelegateImpl::WindowedUpdateGeometry( } } -bool WebPluginDelegateImpl::WindowedCreatePlugin() { - DCHECK(!windowed_handle_); - - RegisterNativeWindowClass(); - - // The window will be sized and shown later. - windowed_handle_ = CreateWindowEx( - WS_EX_LEFT | WS_EX_LTRREADING | WS_EX_RIGHTSCROLLBAR, - kNativeWindowClassName, - 0, - WS_POPUP | WS_CLIPCHILDREN | WS_CLIPSIBLINGS, - 0, - 0, - 0, - 0, - parent_, - 0, - GetModuleHandle(NULL), - 0); - if (windowed_handle_ == 0) - return false; - - if (IsWindow(parent_)) { - // This is a tricky workaround for Issue 2673 in chromium "Flash: IME not - // available". To use IMEs in this window, we have to make Windows attach - // IMEs to this window (i.e. load IME DLLs, attach them to this process, - // and add their message hooks to this window). Windows attaches IMEs while - // this process creates a top-level window. On the other hand, to layout - // this window correctly in the given parent window (RenderWidgetHostHWND), - // this window should be a child window of the parent window. - // To satisfy both of the above conditions, this code once creates a - // top-level window and change it to a child window of the parent window. - SetWindowLongPtr(windowed_handle_, GWL_STYLE, - WS_CHILD | WS_CLIPCHILDREN | WS_CLIPSIBLINGS); - SetParent(windowed_handle_, parent_); - } - - BOOL result = SetProp(windowed_handle_, kWebPluginDelegateProperty, this); - DCHECK(result == TRUE) << "SetProp failed, last error = " << GetLastError(); - // Get the name of the plugin, create an atom and set that in a window - // property. Use an atom so that other processes can access the name of - // the plugin that this window is hosting - if (instance_ != NULL) { - NPAPI::PluginLib* plugin_lib = instance()->plugin_lib(); - if (plugin_lib != NULL) { - std::wstring plugin_name = plugin_lib->plugin_info().name; - if (!plugin_name.empty()) { - ATOM plugin_name_atom = GlobalAddAtomW(plugin_name.c_str()); - DCHECK(0 != plugin_name_atom); - result = SetProp(windowed_handle_, - kPluginNameAtomProperty, - reinterpret_cast<HANDLE>(plugin_name_atom)); - DCHECK(result == TRUE) << "SetProp failed, last error = " << - GetLastError(); - } - } - } - - // Calling SetWindowLongPtrA here makes the window proc ASCII, which is - // required by at least the Shockwave Director plug-in. - SetWindowLongPtrA( - windowed_handle_, GWL_WNDPROC, reinterpret_cast<LONG>(DefWindowProcA)); - - return true; -} - -void WebPluginDelegateImpl::WindowedDestroyWindow() { - if (windowed_handle_ != NULL) { - // Unsubclass the window. - WNDPROC current_wnd_proc = reinterpret_cast<WNDPROC>( - GetWindowLongPtr(windowed_handle_, GWLP_WNDPROC)); - if (current_wnd_proc == NativeWndProc) { - SetWindowLongPtr(windowed_handle_, - GWLP_WNDPROC, - reinterpret_cast<LONG>(plugin_wnd_proc_)); - } - - plugin_->WillDestroyWindow(windowed_handle_); - - DestroyWindow(windowed_handle_); - windowed_handle_ = 0; - } -} - -// Erase all messages in the queue destined for a particular window. -// When windows are closing, callers should use this function to clear -// the queue. -// static -void WebPluginDelegateImpl::ClearThrottleQueueForWindow(HWND window) { - std::list<MSG>* throttle_queue = g_throttle_queue.Pointer(); - - std::list<MSG>::iterator it; - for (it = throttle_queue->begin(); it != throttle_queue->end(); ) { - if (it->hwnd == window) { - it = throttle_queue->erase(it); - } else { - it++; - } - } -} - -// Delayed callback for processing throttled messages. -// Throttled messages are aggregated globally across all plugins. -// static -void WebPluginDelegateImpl::OnThrottleMessage() { - // The current algorithm walks the list and processes the first - // message it finds for each plugin. It is important to service - // all active plugins with each pass through the throttle, otherwise - // we see video jankiness. - std::list<MSG>* throttle_queue = g_throttle_queue.Pointer(); - std::map<HWND, int> processed; - - std::list<MSG>::iterator it = throttle_queue->begin(); - while (it != throttle_queue->end()) { - const MSG& msg = *it; - if (processed.find(msg.hwnd) == processed.end()) { - WNDPROC proc = reinterpret_cast<WNDPROC>(msg.time); - // It is possible that the window was closed after we queued - // this message. This is a rare event; just verify the window - // is alive. (see also bug 1259488) - if (IsWindow(msg.hwnd)) - CallWindowProc(proc, msg.hwnd, msg.message, msg.wParam, msg.lParam); - processed[msg.hwnd] = 1; - it = throttle_queue->erase(it); - } else { - it++; - } - } - - if (throttle_queue->size() > 0) - MessageLoop::current()->PostDelayedTask(FROM_HERE, - NewRunnableFunction(&WebPluginDelegateImpl::OnThrottleMessage), - kFlashWMUSERMessageThrottleDelayMs); -} - -// Schedule a windows message for delivery later. -// static -void WebPluginDelegateImpl::ThrottleMessage(WNDPROC proc, HWND hwnd, - UINT message, WPARAM wParam, - LPARAM lParam) { - MSG msg; - msg.time = reinterpret_cast<DWORD>(proc); - msg.hwnd = hwnd; - msg.message = message; - msg.wParam = wParam; - msg.lParam = lParam; - - std::list<MSG>* throttle_queue = g_throttle_queue.Pointer(); - - throttle_queue->push_back(msg); - - if (throttle_queue->size() == 1) { - MessageLoop::current()->PostDelayedTask(FROM_HERE, - NewRunnableFunction(&WebPluginDelegateImpl::OnThrottleMessage), - kFlashWMUSERMessageThrottleDelayMs); - } -} - -// We go out of our way to find the hidden windows created by Flash for -// windowless plugins. We throttle the rate at which they deliver messages -// so that they will not consume outrageous amounts of CPU. -// static -LRESULT CALLBACK WebPluginDelegateImpl::FlashWindowlessWndProc(HWND hwnd, - UINT message, WPARAM wparam, LPARAM lparam) { - WNDPROC old_proc = reinterpret_cast<WNDPROC>(GetProp(hwnd, kPluginOrigProc)); - DCHECK(old_proc); - - switch (message) { - case WM_NCDESTROY: { - WebPluginDelegateImpl::ClearThrottleQueueForWindow(hwnd); - break; - } - // Flash may flood the message queue with WM_USER+1 message causing 100% CPU - // usage. See https://bugzilla.mozilla.org/show_bug.cgi?id=132759. We - // prevent this by throttling the messages. - case WM_USER + 1: { - WebPluginDelegateImpl::ThrottleMessage(old_proc, hwnd, message, wparam, - lparam); - return TRUE; - } - default: { - break; - } - } - return CallWindowProc(old_proc, hwnd, message, wparam, lparam); -} - -// Callback for enumerating the Flash windows. -BOOL CALLBACK EnumFlashWindows(HWND window, LPARAM arg) { - WNDPROC wnd_proc = reinterpret_cast<WNDPROC>(arg); - TCHAR class_name[1024]; - if (!RealGetWindowClass(window, class_name, - sizeof(class_name)/sizeof(TCHAR))) { - LOG(ERROR) << "RealGetWindowClass failure: " << GetLastError(); - return FALSE; - } - - if (wcscmp(class_name, L"SWFlash_PlaceholderX")) - return TRUE; - - WNDPROC current_wnd_proc = reinterpret_cast<WNDPROC>( - GetWindowLongPtr(window, GWLP_WNDPROC)); - if (current_wnd_proc != wnd_proc) { - WNDPROC old_flash_proc = reinterpret_cast<WNDPROC>(SetWindowLongPtr( - window, GWLP_WNDPROC, - reinterpret_cast<LONG>(wnd_proc))); - DCHECK(old_flash_proc); - BOOL result = SetProp(window, kPluginOrigProc, old_flash_proc); - if (!result) { - LOG(ERROR) << "SetProp failed, last error = " << GetLastError(); - return FALSE; - } - } - - return TRUE; -} - -bool WebPluginDelegateImpl::CreateDummyWindowForActivation() { - DCHECK(!dummy_window_for_activation_); - dummy_window_for_activation_ = CreateWindowEx( - 0, - L"Static", - kDummyActivationWindowName, - WS_CHILD, - 0, - 0, - 0, - 0, - parent_, - 0, - GetModuleHandle(NULL), - 0); - - if (dummy_window_for_activation_ == 0) - return false; - - // Flash creates background windows which use excessive CPU in our - // environment; we wrap these windows and throttle them so that they don't - // get out of hand. - if (!EnumThreadWindows(::GetCurrentThreadId(), EnumFlashWindows, - reinterpret_cast<LPARAM>( - &WebPluginDelegateImpl::FlashWindowlessWndProc))) { - // Log that this happened. Flash will still work; it just means the - // throttle isn't installed (and Flash will use more CPU). - NOTREACHED(); - LOG(ERROR) << "Failed to wrap all windowless Flash windows"; - } - return true; -} - -bool WebPluginDelegateImpl::WindowedReposition( - const gfx::Rect& window_rect, - const gfx::Rect& clip_rect) { - if (!windowed_handle_) { - NOTREACHED(); - return false; - } - - if (window_rect_ == window_rect && clip_rect_ == clip_rect) - return false; - - // We only set the plugin's size here. Its position is moved elsewhere, which - // allows the window moves/scrolling/clipping to be synchronized with the page - // and other windows. - if (window_rect.size() != window_rect_.size()) { - ::SetWindowPos(windowed_handle_, - NULL, - 0, - 0, - window_rect.width(), - window_rect.height(), - 0); - } - - window_rect_ = window_rect; - clip_rect_ = clip_rect; - - // Ensure that the entire window gets repainted. - ::InvalidateRect(windowed_handle_, NULL, FALSE); - - return true; -} - -void WebPluginDelegateImpl::WindowedSetWindow() { - if (!instance_) - return; - - if (!windowed_handle_) { - NOTREACHED(); - return; - } - - instance()->set_window_handle(windowed_handle_); - - DCHECK(!instance()->windowless()); - - window_.clipRect.top = std::max(0, clip_rect_.y()); - window_.clipRect.left = std::max(0, clip_rect_.x()); - window_.clipRect.bottom = std::max(0, clip_rect_.y() + clip_rect_.height()); - window_.clipRect.right = std::max(0, clip_rect_.x() + clip_rect_.width()); - window_.height = window_rect_.height(); - window_.width = window_rect_.width(); - window_.x = 0; - window_.y = 0; - - window_.window = windowed_handle_; - window_.type = NPWindowTypeWindow; - - // Reset this flag before entering the instance in case of side-effects. - windowed_did_set_window_ = true; - - NPError err = instance()->NPP_SetWindow(&window_); - if (quirks_ & PLUGIN_QUIRK_SETWINDOW_TWICE) - instance()->NPP_SetWindow(&window_); - - WNDPROC current_wnd_proc = reinterpret_cast<WNDPROC>( - GetWindowLongPtr(windowed_handle_, GWLP_WNDPROC)); - if (current_wnd_proc != NativeWndProc) { - plugin_wnd_proc_ = reinterpret_cast<WNDPROC>(SetWindowLongPtr( - windowed_handle_, GWLP_WNDPROC, reinterpret_cast<LONG>(NativeWndProc))); - } -} - -ATOM WebPluginDelegateImpl::RegisterNativeWindowClass() { - static bool have_registered_window_class = false; - if (have_registered_window_class == true) - return true; - - have_registered_window_class = true; - - WNDCLASSEX wcex; - wcex.cbSize = sizeof(WNDCLASSEX); - wcex.style = CS_DBLCLKS; - wcex.lpfnWndProc = DummyWindowProc; - wcex.cbClsExtra = 0; - wcex.cbWndExtra = 0; - wcex.hInstance = GetModuleHandle(NULL); - wcex.hIcon = 0; - wcex.hCursor = 0; - // Some plugins like windows media player 11 create child windows parented - // by our plugin window, where the media content is rendered. These plugins - // dont implement WM_ERASEBKGND, which causes painting issues, when the - // window where the media is rendered is moved around. DefWindowProc does - // implement WM_ERASEBKGND correctly if we have a valid background brush. - wcex.hbrBackground = reinterpret_cast<HBRUSH>(COLOR_WINDOW+1); - wcex.lpszMenuName = 0; - wcex.lpszClassName = kNativeWindowClassName; - wcex.hIconSm = 0; - - return RegisterClassEx(&wcex); -} - -LRESULT CALLBACK WebPluginDelegateImpl::DummyWindowProc( - HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) { - // This is another workaround for Issue 2673 in chromium "Flash: IME not - // available". Somehow, the CallWindowProc() function does not dispatch - // window messages when its first parameter is a handle representing the - // DefWindowProc() function. To avoid this problem, this code creates a - // wrapper function which just encapsulates the DefWindowProc() function - // and set it as the window procedure of a windowed plug-in. - return DefWindowProc(hWnd, message, wParam, lParam); -} - -LRESULT CALLBACK WebPluginDelegateImpl::NativeWndProc( - HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam) { - WebPluginDelegateImpl* delegate = reinterpret_cast<WebPluginDelegateImpl*>( - GetProp(hwnd, kWebPluginDelegateProperty)); - if (!delegate) { - NOTREACHED(); - return 0; - } - - if (message == delegate->last_message_ && - delegate->GetQuirks() & PLUGIN_QUIRK_DONT_CALL_WND_PROC_RECURSIVELY && - delegate->is_calling_wndproc) { - // Real may go into a state where it recursively dispatches the same event - // when subclassed. See https://bugzilla.mozilla.org/show_bug.cgi?id=192914 - // We only do the recursive check for Real because it's possible and valid - // for a plugin to synchronously dispatch a message to itself such that it - // looks like it's in recursion. - return TRUE; - } - - static UINT custom_msg = RegisterWindowMessage(kPaintMessageName); - if (message == custom_msg) { - // Get the invalid rect which is in screen coordinates and convert to - // window coordinates. - gfx::Rect invalid_rect; - invalid_rect.set_x(wparam >> 16); - invalid_rect.set_y(wparam & 0xFFFF); - invalid_rect.set_width(lparam >> 16); - invalid_rect.set_height(lparam & 0xFFFF); - - RECT window_rect; - GetWindowRect(hwnd, &window_rect); - invalid_rect.Offset(-window_rect.left, -window_rect.top); - - // The plugin window might have non-client area. If we don't pass in - // RDW_FRAME then the children don't receive WM_NCPAINT messages while - // scrolling, which causes painting problems (http://b/issue?id=923945). - RedrawWindow(hwnd, &invalid_rect.ToRECT(), NULL, - RDW_UPDATENOW | RDW_INVALIDATE | RDW_ALLCHILDREN | RDW_FRAME); - return FALSE; - } - - // Maintain a local/global stack for the g_current_plugin_instance variable - // as this may be a nested invocation. - WebPluginDelegateImpl* last_plugin_instance = g_current_plugin_instance; - - g_current_plugin_instance = delegate; - - // Flash may flood the message queue with WM_USER+1 message causing 100% CPU - // usage. See https://bugzilla.mozilla.org/show_bug.cgi?id=132759. We - // prevent this by throttling the messages. - if (message == WM_USER + 1 && - delegate->GetQuirks() & PLUGIN_QUIRK_THROTTLE_WM_USER_PLUS_ONE) { - WebPluginDelegateImpl::ThrottleMessage(delegate->plugin_wnd_proc_, hwnd, - message, wparam, lparam); - g_current_plugin_instance = last_plugin_instance; - return FALSE; - } - - delegate->last_message_ = message; - delegate->is_calling_wndproc = true; - - if (!delegate->user_gesture_message_posted_ && - IsUserGestureMessage(message)) { - delegate->user_gesture_message_posted_ = true; - - delegate->instance()->PushPopupsEnabledState(true); - - MessageLoop::current()->PostDelayedTask(FROM_HERE, - delegate->user_gesture_msg_factory_.NewRunnableMethod( - &WebPluginDelegateImpl::OnUserGestureEnd), - kWindowedPluginPopupTimerMs); - } - - LRESULT result = CallWindowProc(delegate->plugin_wnd_proc_, hwnd, message, - wparam, lparam); - delegate->is_calling_wndproc = false; - g_current_plugin_instance = last_plugin_instance; - - if (message == WM_NCDESTROY) { - RemoveProp(hwnd, kWebPluginDelegateProperty); - ATOM plugin_name_atom = reinterpret_cast <ATOM>( - RemoveProp(hwnd, kPluginNameAtomProperty)); - if (plugin_name_atom != 0) - GlobalDeleteAtom(plugin_name_atom); - ClearThrottleQueueForWindow(hwnd); - } - - return result; -} - -void WebPluginDelegateImpl::WindowlessUpdateGeometry( - const gfx::Rect& window_rect, - const gfx::Rect& clip_rect) { - // Only resend to the instance if the geometry has changed. - if (window_rect == window_rect_ && clip_rect == clip_rect_) - return; - - // We will inform the instance of this change when we call NPP_SetWindow. - clip_rect_ = clip_rect; - cutout_rects_.clear(); - - if (window_rect_ != window_rect) { - window_rect_ = window_rect; - - WindowlessSetWindow(true); - - WINDOWPOS win_pos = {0}; - win_pos.x = window_rect_.x(); - win_pos.y = window_rect_.y(); - win_pos.cx = window_rect_.width(); - win_pos.cy = window_rect_.height(); - - NPEvent pos_changed_event; - pos_changed_event.event = WM_WINDOWPOSCHANGED; - pos_changed_event.wParam = 0; - pos_changed_event.lParam = PtrToUlong(&win_pos); - - instance()->NPP_HandleEvent(&pos_changed_event); - } -} - -void WebPluginDelegateImpl::WindowlessPaint(HDC hdc, - const gfx::Rect& damage_rect) { - DCHECK(hdc); - - RECT damage_rect_win; - damage_rect_win.left = damage_rect.x(); // + window_rect_.x(); - damage_rect_win.top = damage_rect.y(); // + window_rect_.y(); - damage_rect_win.right = damage_rect_win.left + damage_rect.width(); - damage_rect_win.bottom = damage_rect_win.top + damage_rect.height(); - - window_.window = hdc; - - NPEvent paint_event; - paint_event.event = WM_PAINT; - // NOTE: NPAPI is not 64bit safe. It puts pointers into 32bit values. - paint_event.wParam = PtrToUlong(hdc); - paint_event.lParam = PtrToUlong(&damage_rect_win); - static StatsRate plugin_paint("Plugin.Paint"); - StatsScope<StatsRate> scope(plugin_paint); - instance()->NPP_HandleEvent(&paint_event); -} - -void WebPluginDelegateImpl::WindowlessSetWindow(bool force_set_window) { - if (!instance()) - return; - - if (window_rect_.IsEmpty()) // wait for geometry to be set. - return; - - DCHECK(instance()->windowless()); - - window_.clipRect.top = clip_rect_.y(); - window_.clipRect.left = clip_rect_.x(); - window_.clipRect.bottom = clip_rect_.y() + clip_rect_.height(); - window_.clipRect.right = clip_rect_.x() + clip_rect_.width(); - window_.height = window_rect_.height(); - window_.width = window_rect_.width(); - window_.x = window_rect_.x(); - window_.y = window_rect_.y(); - window_.type = NPWindowTypeDrawable; - DrawableContextEnforcer enforcer(&window_); - - NPError err = instance()->NPP_SetWindow(&window_); - DCHECK(err == NPERR_NO_ERROR); -} - -void WebPluginDelegateImpl::SetFocus() { - DCHECK(instance()->windowless()); - - NPEvent focus_event; - focus_event.event = WM_SETFOCUS; - focus_event.wParam = 0; - focus_event.lParam = 0; - - instance()->NPP_HandleEvent(&focus_event); -} - -static bool NPEventFromWebMouseEvent(const WebMouseEvent& event, - NPEvent *np_event) { - np_event->lParam = static_cast<uint32>(MAKELPARAM(event.windowX, - event.windowY)); - np_event->wParam = 0; - - if (event.modifiers & WebInputEvent::ControlKey) - np_event->wParam |= MK_CONTROL; - if (event.modifiers & WebInputEvent::ShiftKey) - np_event->wParam |= MK_SHIFT; - if (event.modifiers & WebInputEvent::LeftButtonDown) - np_event->wParam |= MK_LBUTTON; - if (event.modifiers & WebInputEvent::MiddleButtonDown) - np_event->wParam |= MK_MBUTTON; - if (event.modifiers & WebInputEvent::RightButtonDown) - np_event->wParam |= MK_RBUTTON; - - switch (event.type) { - case WebInputEvent::MouseMove: - case WebInputEvent::MouseLeave: - case WebInputEvent::MouseEnter: - np_event->event = WM_MOUSEMOVE; - return true; - case WebInputEvent::MouseDown: - switch (event.button) { - case WebMouseEvent::ButtonLeft: - np_event->event = WM_LBUTTONDOWN; - break; - case WebMouseEvent::ButtonMiddle: - np_event->event = WM_MBUTTONDOWN; - break; - case WebMouseEvent::ButtonRight: - np_event->event = WM_RBUTTONDOWN; - break; - } - return true; - case WebInputEvent::MouseUp: - switch (event.button) { - case WebMouseEvent::ButtonLeft: - np_event->event = WM_LBUTTONUP; - break; - case WebMouseEvent::ButtonMiddle: - np_event->event = WM_MBUTTONUP; - break; - case WebMouseEvent::ButtonRight: - np_event->event = WM_RBUTTONUP; - break; - } - return true; - default: - NOTREACHED(); - return false; - } -} - -static bool NPEventFromWebKeyboardEvent(const WebKeyboardEvent& event, - NPEvent *np_event) { - np_event->wParam = event.windowsKeyCode; - - switch (event.type) { - case WebInputEvent::KeyDown: - np_event->event = WM_KEYDOWN; - np_event->lParam = 0; - return true; - case WebInputEvent::KeyUp: - np_event->event = WM_KEYUP; - np_event->lParam = 0x8000; - return true; - default: - NOTREACHED(); - return false; - } -} - -static bool NPEventFromWebInputEvent(const WebInputEvent& event, - NPEvent* np_event) { - switch (event.type) { - case WebInputEvent::MouseMove: - case WebInputEvent::MouseLeave: - case WebInputEvent::MouseEnter: - case WebInputEvent::MouseDown: - case WebInputEvent::MouseUp: - if (event.size < sizeof(WebMouseEvent)) { - NOTREACHED(); - return false; - } - return NPEventFromWebMouseEvent( - *static_cast<const WebMouseEvent*>(&event), np_event); - case WebInputEvent::KeyDown: - case WebInputEvent::KeyUp: - if (event.size < sizeof(WebKeyboardEvent)) { - NOTREACHED(); - return false; - } - return NPEventFromWebKeyboardEvent( - *static_cast<const WebKeyboardEvent*>(&event), np_event); - default: - return false; - } -} - -bool WebPluginDelegateImpl::HandleInputEvent(const WebInputEvent& event, - WebCursorInfo* cursor_info) { - DCHECK(windowless_) << "events should only be received in windowless mode"; - DCHECK(cursor_info != NULL); - - NPEvent np_event; - if (!NPEventFromWebInputEvent(event, &np_event)) { - return false; - } - - if (ShouldTrackEventForModalLoops(&np_event)) { - // A windowless plugin can enter a modal loop in a NPP_HandleEvent call. - // For e.g. Flash puts up a context menu when we right click on the - // windowless plugin area. We detect this by setting up a message filter - // hook pror to calling NPP_HandleEvent on the plugin and unhook on - // return from NPP_HandleEvent. If the plugin does enter a modal loop - // in that context we unhook on receiving the first notification in - // the message filter hook. - handle_event_message_filter_hook_ = - SetWindowsHookEx(WH_MSGFILTER, HandleEventMessageFilterHook, NULL, - GetCurrentThreadId()); - } - - bool old_task_reentrancy_state = - MessageLoop::current()->NestableTasksAllowed(); - - - // Maintain a local/global stack for the g_current_plugin_instance variable - // as this may be a nested invocation. - WebPluginDelegateImpl* last_plugin_instance = g_current_plugin_instance; - - g_current_plugin_instance = this; - - handle_event_depth_++; - - bool pop_user_gesture = false; - - if (IsUserGestureMessage(np_event.event)) { - pop_user_gesture = true; - instance()->PushPopupsEnabledState(true); - } - - bool ret = instance()->NPP_HandleEvent(&np_event) != 0; - - if (np_event.event == WM_MOUSEMOVE) { - // Snag a reference to the current cursor ASAP in case the plugin modified - // it. There is a nasty race condition here with the multiprocess browser - // as someone might be setting the cursor in the main process as well. - current_windowless_cursor_.GetCursorInfo(cursor_info); - } - - if (pop_user_gesture) { - instance()->PopPopupsEnabledState(); - } - - handle_event_depth_--; - - g_current_plugin_instance = last_plugin_instance; - - MessageLoop::current()->SetNestableTasksAllowed(old_task_reentrancy_state); - - // We could have multiple NPP_HandleEvent calls nested together in case - // the plugin enters a modal loop. Reset the pump messages event when - // the outermost NPP_HandleEvent call unwinds. - if (handle_event_depth_ == 0) { - ResetEvent(handle_event_pump_messages_event_); - } - - return ret; -} - WebPluginResourceClient* WebPluginDelegateImpl::CreateResourceClient( int resource_id, const GURL& url, bool notify_needed, intptr_t notify_data, intptr_t existing_stream) { @@ -1220,118 +217,3 @@ void WebPluginDelegateImpl::URLRequestRouted(const std::string&url, instance()->SetURLLoadData(GURL(url.c_str()), notify_data); } } - -void WebPluginDelegateImpl::OnModalLoopEntered() { - DCHECK(handle_event_pump_messages_event_ != NULL); - SetEvent(handle_event_pump_messages_event_); - - MessageLoop::current()->SetNestableTasksAllowed(true); - - UnhookWindowsHookEx(handle_event_message_filter_hook_); - handle_event_message_filter_hook_ = NULL; -} - -bool WebPluginDelegateImpl::ShouldTrackEventForModalLoops(NPEvent* event) { - if (event->event == WM_RBUTTONDOWN) - return true; - return false; -} - -bool WebPluginDelegateImpl::IsUserGestureMessage(unsigned int message) { - switch (message) { - case WM_LBUTTONUP: - case WM_RBUTTONUP: - case WM_MBUTTONUP: - case WM_KEYUP: - return true; - - default: - break; - } - - return false; -} - -void WebPluginDelegateImpl::OnUserGestureEnd() { - user_gesture_message_posted_ = false; - instance()->PopPopupsEnabledState(); -} - -BOOL WINAPI WebPluginDelegateImpl::TrackPopupMenuPatch( - HMENU menu, unsigned int flags, int x, int y, int reserved, - HWND window, const RECT* rect) { - - HWND last_focus_window = NULL; - - if (g_current_plugin_instance) { - unsigned long window_process_id = 0; - unsigned long window_thread_id = - GetWindowThreadProcessId(window, &window_process_id); - // TrackPopupMenu fails if the window passed in belongs to a different - // thread. - if (::GetCurrentThreadId() != window_thread_id) { - window = g_current_plugin_instance->dummy_window_for_activation_; - } - - // To ensure that the plugin receives keyboard events we set focus to the - // dummy window. - // TODO(iyengar) We need a framework in the renderer to identify which - // windowless plugin is under the mouse and to handle this. This would - // also require some changes in RenderWidgetHost to detect this in the - // WM_MOUSEACTIVATE handler and inform the renderer accordingly. - if (g_current_plugin_instance->dummy_window_for_activation_) { - last_focus_window = - ::SetFocus(g_current_plugin_instance->dummy_window_for_activation_); - } - } - - BOOL result = TrackPopupMenu(menu, flags, x, y, reserved, window, rect); - - if (IsWindow(last_focus_window)) { - // The Flash plugin at times sets focus to its hidden top level window - // with class name SWFlash_PlaceholderX. This causes the chrome browser - // window to receive a WM_ACTIVATEAPP message as a top level window from - // another thread is now active. We end up in a state where the chrome - // browser window is not active even though the user clicked on it. - // Our workaround for this is to send over a raw - // WM_LBUTTONDOWN/WM_LBUTTONUP combination to the last focus window, which - // does the trick. - if (g_current_plugin_instance->dummy_window_for_activation_ != - ::GetFocus()) { - INPUT input_info = {0}; - input_info.type = INPUT_MOUSE; - input_info.mi.dwFlags = MOUSEEVENTF_LEFTDOWN; - ::SendInput(1, &input_info, sizeof(INPUT)); - - input_info.type = INPUT_MOUSE; - input_info.mi.dwFlags = MOUSEEVENTF_LEFTUP; - ::SendInput(1, &input_info, sizeof(INPUT)); - } else { - ::SetFocus(last_focus_window); - } - } - - return result; -} - -HCURSOR WINAPI WebPluginDelegateImpl::SetCursorPatch(HCURSOR cursor) { - // The windowless flash plugin periodically calls SetCursor in a wndproc - // instantiated on the plugin thread. This causes annoying cursor flicker - // when the mouse is moved on a foreground tab, with a windowless plugin - // instance in a background tab. We just ignore the call here. - if (!g_current_plugin_instance) - return GetCursor(); - - if (!g_current_plugin_instance->IsWindowless()) { - return SetCursor(cursor); - } - - // It is ok to pass NULL here to GetCursor as we are not looking for cursor - // types defined by Webkit. - HCURSOR previous_cursor = - g_current_plugin_instance->current_windowless_cursor_.GetCursor(NULL); - - g_current_plugin_instance->current_windowless_cursor_.InitFromExternalCursor( - cursor); - return previous_cursor; -} diff --git a/webkit/glue/plugins/webplugin_delegate_impl.h b/webkit/glue/plugins/webplugin_delegate_impl.h index 90d8203..6563003 100644 --- a/webkit/glue/plugins/webplugin_delegate_impl.h +++ b/webkit/glue/plugins/webplugin_delegate_impl.h @@ -101,6 +101,13 @@ class WebPluginDelegateImpl : public WebPluginDelegate { NPAPI::PluginInstance *instance); ~WebPluginDelegateImpl(); + // Called by Initialize(), used for platform-specific initialization + // code. + void PlatformInitialize(WebPlugin* plugin); + + // Called by DestroyInstance(), used for platform-specific destruction. + void PlatformDestroyInstance(); + #if !defined(OS_MACOSX) //-------------------------- // used for windowed plugins diff --git a/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc b/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc index 83d348b..d0afce8 100644 --- a/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc +++ b/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc @@ -19,7 +19,6 @@ #include "base/string_util.h" #include "webkit/api/public/WebCursorInfo.h" #include "webkit/api/public/WebInputEvent.h" -// #include "webkit/default_plugin/plugin_impl.h" #include "webkit/glue/glue_util.h" #include "webkit/glue/webplugin.h" #include "webkit/glue/plugins/gtk_plugin_container.h" @@ -29,33 +28,14 @@ #include "webkit/glue/plugins/plugin_list.h" #include "webkit/glue/plugins/plugin_stream_url.h" #include "webkit/glue/webkit_glue.h" -#if defined(OS_LINUX) + #include "third_party/npapi/bindings/npapi_x11.h" -#endif using WebKit::WebCursorInfo; using WebKit::WebKeyboardEvent; using WebKit::WebInputEvent; using WebKit::WebMouseEvent; -WebPluginDelegate* WebPluginDelegate::Create( - const FilePath& filename, - const std::string& mime_type, - gfx::PluginWindowHandle containing_view) { - scoped_refptr<NPAPI::PluginLib> plugin = - NPAPI::PluginLib::CreatePluginLib(filename); - if (plugin.get() == NULL) - return NULL; - - NPError err = plugin->NP_Initialize(); - if (err != NPERR_NO_ERROR) - return NULL; - - scoped_refptr<NPAPI::PluginInstance> instance = - plugin->CreateInstance(mime_type); - return new WebPluginDelegateImpl(containing_view, instance.get()); -} - WebPluginDelegateImpl::WebPluginDelegateImpl( gfx::PluginWindowHandle containing_view, NPAPI::PluginInstance *instance) @@ -79,6 +59,13 @@ WebPluginDelegateImpl::WebPluginDelegateImpl( quirks_ |= PLUGIN_QUIRK_WINDOWLESS_OFFSET_WINDOW_TO_DRAW | PLUGIN_QUIRK_WINDOWLESS_INVALIDATE_AFTER_SET_WINDOW; } + + // TODO(evanm): I played with this for quite a while but couldn't + // figure out a way to make Flash not crash unless I didn't call + // NPP_SetWindow. + // However, after piman's grand refactor of windowed plugins, maybe + // this is no longer necessary. + quirks_ |= PLUGIN_QUIRK_DONT_SET_NULL_WINDOW_HANDLE_ON_DESTROY; } WebPluginDelegateImpl::~WebPluginDelegateImpl() { @@ -99,85 +86,18 @@ WebPluginDelegateImpl::~WebPluginDelegateImpl() { } } -void WebPluginDelegateImpl::PluginDestroyed() { - delete this; -} - -bool WebPluginDelegateImpl::Initialize(const GURL& url, - char** argn, - char** argv, - int argc, - WebPlugin* plugin, - bool load_manually) { - plugin_ = plugin; - - instance_->set_web_plugin(plugin); - NPAPI::PluginInstance* old_instance = - NPAPI::PluginInstance::SetInitializingInstance(instance_); - - bool start_result = instance_->Start(url, argn, argv, argc, load_manually); - - NPAPI::PluginInstance::SetInitializingInstance(old_instance); - - if (!start_result) - return false; - - windowless_ = instance_->windowless(); - if (windowless_) { - // For windowless plugins we should set the containing window handle - // as the instance window handle. This is what Safari does. Not having - // a valid window handle causes subtle bugs with plugins which retreive - // the window handle and validate the same. The window handle can be - // retreived via NPN_GetValue of NPNVnetscapeWindow. - instance_->set_window_handle(parent_); - // CreateDummyWindowForActivation(); - // handle_event_pump_messages_event_ = CreateEvent(NULL, TRUE, FALSE, NULL); - } else { - if (!WindowedCreatePlugin()) - return false; - } +void WebPluginDelegateImpl::PlatformInitialize(WebPlugin* plugin) { gfx::PluginWindowHandle handle = windowless_ ? 0 : gtk_plug_get_id(GTK_PLUG(plug_)); plugin->SetWindow(handle); - - plugin_url_ = url.spec(); - - return true; } -void WebPluginDelegateImpl::DestroyInstance() { - if (instance_ && (instance_->npp()->ndata != NULL)) { - // Shutdown all streams before destroying so that - // no streams are left "in progress". Need to do - // this before calling set_web_plugin(NULL) because the - // instance uses the helper to do the download. - instance_->CloseStreams(); - - // TODO(evanm): I played with this for quite a while but couldn't - // figure out a way to make Flash not crash unless I didn't call - // NPP_SetWindow. Perhaps it just should be marked with the quirk - // that wraps the NPP_SetWindow call. - // window_.window = NULL; - // if (!(quirks_ & PLUGIN_QUIRK_DONT_SET_NULL_WINDOW_HANDLE_ON_DESTROY)) { - // instance_->NPP_SetWindow(&window_); - // } - - instance_->NPP_Destroy(); - - instance_->set_web_plugin(NULL); - - instance_ = 0; - } +void WebPluginDelegateImpl::PlatformDestroyInstance() { + // Nothing to do here. } -void WebPluginDelegateImpl::UpdateGeometry( - const gfx::Rect& window_rect, - const gfx::Rect& clip_rect) { - if (windowless_) { - WindowlessUpdateGeometry(window_rect, clip_rect); - } else { - WindowedUpdateGeometry(window_rect, clip_rect); - } +void WebPluginDelegateImpl::PluginDestroyed() { + delete this; } void WebPluginDelegateImpl::Paint(cairo_t* context, @@ -190,74 +110,8 @@ void WebPluginDelegateImpl::Print(cairo_t* context) { NOTIMPLEMENTED(); } -NPObject* WebPluginDelegateImpl::GetPluginScriptableObject() { - return instance_->GetPluginScriptableObject(); -} - -void WebPluginDelegateImpl::DidFinishLoadWithReason(NPReason reason) { - instance()->DidFinishLoadWithReason(reason); -} - -int WebPluginDelegateImpl::GetProcessId() { - // We are in process, so the plugin pid is this current process pid. - return base::GetCurrentProcId(); -} - -void WebPluginDelegateImpl::SendJavaScriptStream(const std::string& url, - const std::wstring& result, - bool success, - bool notify_needed, - intptr_t notify_data) { - instance()->SendJavaScriptStream(url, result, success, notify_needed, - notify_data); -} - -void WebPluginDelegateImpl::DidReceiveManualResponse( - const GURL& url, const std::string& mime_type, - const std::string& headers, uint32 expected_length, uint32 last_modified) { - if (!windowless_) { - // Calling NPP_WriteReady before NPP_SetWindow causes movies to not load in - // Flash. See http://b/issue?id=892174. - DCHECK(windowed_did_set_window_); - } - - instance()->DidReceiveManualResponse(url, mime_type, headers, - expected_length, last_modified); -} - -void WebPluginDelegateImpl::DidReceiveManualData(const char* buffer, - int length) { - instance()->DidReceiveManualData(buffer, length); -} - -void WebPluginDelegateImpl::DidFinishManualLoading() { - instance()->DidFinishManualLoading(); -} - -void WebPluginDelegateImpl::DidManualLoadFail() { - instance()->DidManualLoadFail(); -} - -FilePath WebPluginDelegateImpl::GetPluginPath() { - return instance()->plugin_lib()->plugin_info().path; -} - void WebPluginDelegateImpl::InstallMissingPlugin() { - /* XXX NPEvent evt; - evt.event = PluginInstallerImpl::kInstallMissingPluginMessage; - evt.lParam = 0; - evt.wParam = 0; - instance()->NPP_HandleEvent(&evt); */ -} - -void WebPluginDelegateImpl::WindowedUpdateGeometry( - const gfx::Rect& window_rect, - const gfx::Rect& clip_rect) { - if (WindowedReposition(window_rect, clip_rect) || - !windowed_did_set_window_) { - // Let the plugin know that it has been moved - WindowedSetWindow(); - } + NOTIMPLEMENTED(); } bool WebPluginDelegateImpl::WindowedCreatePlugin() { @@ -855,34 +709,3 @@ bool WebPluginDelegateImpl::HandleInputEvent(const WebInputEvent& event, return ret; } -WebPluginResourceClient* WebPluginDelegateImpl::CreateResourceClient( - int resource_id, const GURL& url, bool notify_needed, - intptr_t notify_data, intptr_t existing_stream) { - // Stream already exists. This typically happens for range requests - // initiated via NPN_RequestRead. - if (existing_stream) { - NPAPI::PluginStream* plugin_stream = - reinterpret_cast<NPAPI::PluginStream*>(existing_stream); - - plugin_stream->CancelRequest(); - - return plugin_stream->AsResourceClient(); - } - - if (notify_needed) { - instance()->SetURLLoadData(url, notify_data); - } - std::string mime_type; - NPAPI::PluginStreamUrl *stream = instance()->CreateStream( - resource_id, url, mime_type, notify_needed, - reinterpret_cast<void*>(notify_data)); - return stream; -} - -void WebPluginDelegateImpl::URLRequestRouted(const std::string&url, - bool notify_needed, - intptr_t notify_data) { - if (notify_needed) { - instance()->SetURLLoadData(GURL(url.c_str()), notify_data); - } -} diff --git a/webkit/glue/plugins/webplugin_delegate_impl_mac.mm b/webkit/glue/plugins/webplugin_delegate_impl_mac.mm index f52ed34..62ea2de 100644 --- a/webkit/glue/plugins/webplugin_delegate_impl_mac.mm +++ b/webkit/glue/plugins/webplugin_delegate_impl_mac.mm @@ -160,6 +160,13 @@ void WebPluginDelegateImpl::DestroyInstance() { } } +void WebPluginDelegateImpl::PlatformInitialize(WebPlugin* plugin) { + // TODO(port): implement these after unforking. +} +void WebPluginDelegateImpl::PlatformDestroyInstance() { + // TODO(port): implement these after unforking. +} + void WebPluginDelegateImpl::UpdateGeometry( const gfx::Rect& window_rect, const gfx::Rect& clip_rect) { diff --git a/webkit/glue/plugins/webplugin_delegate_impl_win.cc b/webkit/glue/plugins/webplugin_delegate_impl_win.cc index 37efc33..1a3c091 100644 --- a/webkit/glue/plugins/webplugin_delegate_impl_win.cc +++ b/webkit/glue/plugins/webplugin_delegate_impl_win.cc @@ -101,24 +101,6 @@ class DrawableContextEnforcer { } // namespace -WebPluginDelegate* WebPluginDelegate::Create( - const FilePath& filename, - const std::string& mime_type, - gfx::PluginWindowHandle containing_view) { - scoped_refptr<NPAPI::PluginLib> plugin = - NPAPI::PluginLib::CreatePluginLib(filename); - if (plugin.get() == NULL) - return NULL; - - NPError err = plugin->NP_Initialize(); - if (err != NPERR_NO_ERROR) - return NULL; - - scoped_refptr<NPAPI::PluginInstance> instance = - plugin->CreateInstance(mime_type); - return new WebPluginDelegateImpl(containing_view, instance.get()); -} - bool WebPluginDelegateImpl::IsPluginDelegateWindow(HWND window) { // We use a buffer that is one char longer than we need to detect cases where // kNativeWindowClassName is a prefix of the given window's class name. It @@ -263,56 +245,13 @@ void WebPluginDelegateImpl::PluginDestroyed() { } } -bool WebPluginDelegateImpl::Initialize(const GURL& url, - char** argn, - char** argv, - int argc, - WebPlugin* plugin, - bool load_manually) { - plugin_ = plugin; - - instance_->set_web_plugin(plugin); - NPAPI::PluginInstance* old_instance = - NPAPI::PluginInstance::SetInitializingInstance(instance_); - - if (quirks_ & PLUGIN_QUIRK_DONT_ALLOW_MULTIPLE_INSTANCES) { - NPAPI::PluginLib* plugin_lib = instance()->plugin_lib(); - if (plugin_lib->instance_count() > 1) { - return false; - } - } - - if (quirks_ & PLUGIN_QUIRK_DIE_AFTER_UNLOAD) - webkit_glue::SetForcefullyTerminatePluginProcess(true); - - bool start_result = instance_->Start(url, argn, argv, argc, load_manually); - - NPAPI::PluginInstance::SetInitializingInstance(old_instance); - - if (!start_result) - return false; - - windowless_ = instance_->windowless(); - if (!windowless_) { - if (!WindowedCreatePlugin()) - return false; - } - +void WebPluginDelegateImpl::PlatformInitialize(WebPlugin* plugin) { plugin->SetWindow(windowed_handle_); if (windowless_) { - // For windowless plugins we should set the containing window handle - // as the instance window handle. This is what Safari does. Not having - // a valid window handle causes subtle bugs with plugins which retreive - // the window handle and validate the same. The window handle can be - // retreived via NPN_GetValue of NPNVnetscapeWindow. - instance_->set_window_handle(parent_); -#if defined(OS_WIN) CreateDummyWindowForActivation(); handle_event_pump_messages_event_ = CreateEvent(NULL, TRUE, FALSE, NULL); plugin->SetWindowlessPumpEvent(handle_event_pump_messages_event_); -#endif } - plugin_url_ = url.spec(); // The windowless version of the Silverlight plugin calls the // WindowFromPoint API and passes the result of that to the @@ -340,50 +279,20 @@ bool WebPluginDelegateImpl::Initialize(const GURL& url, GetPluginPath().value().c_str(), "user32.dll", "SetCursor", WebPluginDelegateImpl::SetCursorPatch); } - return true; } -void WebPluginDelegateImpl::DestroyInstance() { - if (instance_ && (instance_->npp()->ndata != NULL)) { - // Shutdown all streams before destroying so that - // no streams are left "in progress". Need to do - // this before calling set_web_plugin(NULL) because the - // instance uses the helper to do the download. - instance_->CloseStreams(); - - window_.window = NULL; - if (!(quirks_ & PLUGIN_QUIRK_DONT_SET_NULL_WINDOW_HANDLE_ON_DESTROY)) { - instance_->NPP_SetWindow(&window_); - } - - instance_->NPP_Destroy(); - - instance_->set_web_plugin(NULL); - - if (instance_->plugin_lib()) { - // Unpatch if this is the last plugin instance. - if (instance_->plugin_lib()->instance_count() == 1) { - if (g_iat_patch_set_cursor.Pointer()->is_patched()) { - g_iat_patch_set_cursor.Pointer()->Unpatch(); - } +void WebPluginDelegateImpl::PlatformDestroyInstance() { + if (instance_->plugin_lib()) { + // Unpatch if this is the last plugin instance. + if (instance_->plugin_lib()->instance_count() == 1) { + if (g_iat_patch_set_cursor.Pointer()->is_patched()) { + g_iat_patch_set_cursor.Pointer()->Unpatch(); + } - if (g_iat_patch_track_popup_menu.Pointer()->is_patched()) { - g_iat_patch_track_popup_menu.Pointer()->Unpatch(); - } + if (g_iat_patch_track_popup_menu.Pointer()->is_patched()) { + g_iat_patch_track_popup_menu.Pointer()->Unpatch(); } } - - instance_ = 0; - } -} - -void WebPluginDelegateImpl::UpdateGeometry( - const gfx::Rect& window_rect, - const gfx::Rect& clip_rect) { - if (windowless_) { - WindowlessUpdateGeometry(window_rect, clip_rect); - } else { - WindowedUpdateGeometry(window_rect, clip_rect); } } @@ -407,58 +316,6 @@ void WebPluginDelegateImpl::Print(HDC hdc) { #endif } -NPObject* WebPluginDelegateImpl::GetPluginScriptableObject() { - return instance_->GetPluginScriptableObject(); -} - -void WebPluginDelegateImpl::DidFinishLoadWithReason(NPReason reason) { - instance()->DidFinishLoadWithReason(reason); -} - -int WebPluginDelegateImpl::GetProcessId() { - // We are in process, so the plugin pid is this current process pid. - return ::GetCurrentProcessId(); -} - -void WebPluginDelegateImpl::SendJavaScriptStream(const std::string& url, - const std::wstring& result, - bool success, - bool notify_needed, - intptr_t notify_data) { - instance()->SendJavaScriptStream(url, result, success, notify_needed, - notify_data); -} - -void WebPluginDelegateImpl::DidReceiveManualResponse( - const GURL& url, const std::string& mime_type, - const std::string& headers, uint32 expected_length, uint32 last_modified) { - if (!windowless_) { - // Calling NPP_WriteReady before NPP_SetWindow causes movies to not load in - // Flash. See http://b/issue?id=892174. - DCHECK(windowed_did_set_window_); - } - - instance()->DidReceiveManualResponse(url, mime_type, headers, - expected_length, last_modified); -} - -void WebPluginDelegateImpl::DidReceiveManualData(const char* buffer, - int length) { - instance()->DidReceiveManualData(buffer, length); -} - -void WebPluginDelegateImpl::DidFinishManualLoading() { - instance()->DidFinishManualLoading(); -} - -void WebPluginDelegateImpl::DidManualLoadFail() { - instance()->DidManualLoadFail(); -} - -FilePath WebPluginDelegateImpl::GetPluginPath() { - return instance()->plugin_lib()->plugin_info().path; -} - void WebPluginDelegateImpl::InstallMissingPlugin() { NPEvent evt; evt.event = PluginInstallerImpl::kInstallMissingPluginMessage; @@ -467,16 +324,6 @@ void WebPluginDelegateImpl::InstallMissingPlugin() { instance()->NPP_HandleEvent(&evt); } -void WebPluginDelegateImpl::WindowedUpdateGeometry( - const gfx::Rect& window_rect, - const gfx::Rect& clip_rect) { - if (WindowedReposition(window_rect, clip_rect) || - !windowed_did_set_window_) { - // Let the plugin know that it has been moved - WindowedSetWindow(); - } -} - bool WebPluginDelegateImpl::WindowedCreatePlugin() { DCHECK(!windowed_handle_); @@ -1191,35 +1038,6 @@ bool WebPluginDelegateImpl::HandleInputEvent(const WebInputEvent& event, return ret; } -WebPluginResourceClient* WebPluginDelegateImpl::CreateResourceClient( - int resource_id, const GURL& url, bool notify_needed, - intptr_t notify_data, intptr_t existing_stream) { - // Stream already exists. This typically happens for range requests - // initiated via NPN_RequestRead. - if (existing_stream) { - NPAPI::PluginStream* plugin_stream = - reinterpret_cast<NPAPI::PluginStream*>(existing_stream); - - return plugin_stream->AsResourceClient(); - } - - if (notify_needed) { - instance()->SetURLLoadData(url, notify_data); - } - std::string mime_type; - NPAPI::PluginStreamUrl *stream = instance()->CreateStream( - resource_id, url, mime_type, notify_needed, - reinterpret_cast<void*>(notify_data)); - return stream; -} - -void WebPluginDelegateImpl::URLRequestRouted(const std::string&url, - bool notify_needed, - intptr_t notify_data) { - if (notify_needed) { - instance()->SetURLLoadData(GURL(url.c_str()), notify_data); - } -} void WebPluginDelegateImpl::OnModalLoopEntered() { DCHECK(handle_event_pump_messages_event_ != NULL); diff --git a/webkit/webkit.gyp b/webkit/webkit.gyp index e27c8c7..bf03e1d 100644 --- a/webkit/webkit.gyp +++ b/webkit/webkit.gyp @@ -1339,6 +1339,7 @@ 'glue/plugins/webplugin_delegate_impl.h', 'glue/plugins/webplugin_delegate_impl_gtk.cc', 'glue/plugins/webplugin_delegate_impl_mac.mm', + 'glue/plugins/webplugin_delegate_impl_win.cc', 'glue/alt_error_page_resource_fetcher.cc', 'glue/alt_error_page_resource_fetcher.h', 'glue/autofill_form.cc', @@ -1492,22 +1493,20 @@ }], ['OS!="mac"', { 'sources/': [['exclude', '_mac\\.(cc|mm)$']] + }, { # else: OS=="mac" + 'sources!': [ + # TODO(port): Unfork webplugin_delegate_impl_mac and this file. + 'glue/plugins/webplugin_delegate_impl.cc', + ], }], ['OS!="win"', { 'sources/': [['exclude', '_win\\.cc$']], 'sources!': [ - # TODO(port): Mac uses webplugin_delegate_impl_mac.cc and GTK uses - # webplugin_delegate_impl_gtk.cc. Seems like this should be - # renamed webplugin_delegate_impl_win.cc, then we could get rid - # of the explicit exclude. - 'glue/plugins/webplugin_delegate_impl.cc', - # These files are Windows-only now but may be ported to other # platforms. 'glue/glue_accessibility_object.cc', 'glue/glue_accessibility_object.h', 'glue/plugins/mozilla_extensions.cc', - 'glue/plugins/webplugin_delegate_impl.cc', 'glue/webaccessibility.h', 'glue/webaccessibilitymanager.h', 'glue/webaccessibilitymanager_impl.cc', |