FBTF: Move more ctors/dtors from headers to implementation.

- Adding/Moving dtors of objects that have CancelableRequestConsumers shaves
  three megs off browser.a.
- Adding/Moving dtors of objects that have ScopedRunnableMethodFactories only
  shaved 100k off browser.a/renderer.a.
- Adding/Moving dtors of objects that used some form of base::*Timer<> was
  negligible; there were only a few classes that had a Timer but had a
  ctor/dtor in the header after the previous cleanups.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/3278006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58192 0039d316-1c4b-4281-b951-d872f2087c98

8 files changed, 20 insertions, 2 deletions

diff --git a/webkit/glue/resource_fetcher.cc b/webkit/glue/resource_fetcher.cc
index 186092b..84688a7 100644
--- a/webkit/glue/resource_fetcher.cc
+++ b/webkit/glue/resource_fetcher.cc
@@ -119,6 +119,9 @@ ResourceFetcherWithTimeout::ResourceFetcherWithTimeout(
                        &ResourceFetcherWithTimeout::TimeoutFired);
 }
 
+ResourceFetcherWithTimeout::~ResourceFetcherWithTimeout() {
+}
+
 void ResourceFetcherWithTimeout::TimeoutFired() {
   if (!completed_) {
     loader_->cancel();
diff --git a/webkit/glue/resource_fetcher.h b/webkit/glue/resource_fetcher.h
index 7910fc1..a510d7c 100644
--- a/webkit/glue/resource_fetcher.h
+++ b/webkit/glue/resource_fetcher.h
@@ -100,7 +100,7 @@ class ResourceFetcherWithTimeout : public ResourceFetcher {
  public:
   ResourceFetcherWithTimeout(const GURL& url, WebKit::WebFrame* frame,
                              int timeout_secs, Callback* c);
-  virtual ~ResourceFetcherWithTimeout() {}
+  virtual ~ResourceFetcherWithTimeout();
 
  private:
   // Callback for timer that limits how long we wait for the alternate error
diff --git a/webkit/tools/test_shell/event_sending_controller.cc b/webkit/tools/test_shell/event_sending_controller.cc
index 02d8078..29e7295 100644
--- a/webkit/tools/test_shell/event_sending_controller.cc
+++ b/webkit/tools/test_shell/event_sending_controller.cc
@@ -305,6 +305,9 @@ EventSendingController::EventSendingController(TestShell* shell)
 #endif
 }
 
+EventSendingController::~EventSendingController() {
+}
+
 void EventSendingController::Reset() {
   // The test should have finished a drag and the mouse button state.
   DCHECK(current_drag_data.isNull());
diff --git a/webkit/tools/test_shell/event_sending_controller.h b/webkit/tools/test_shell/event_sending_controller.h
index e7db529..95ddc05 100644
--- a/webkit/tools/test_shell/event_sending_controller.h
+++ b/webkit/tools/test_shell/event_sending_controller.h
@@ -36,6 +36,7 @@ class EventSendingController : public CppBoundClass {
   // Builds the property and method lists needed to bind this class to a JS
   // object.
   EventSendingController(TestShell* shell);
+  ~EventSendingController();
 
   // Resets some static variable state.
   void Reset();
diff --git a/webkit/tools/test_shell/layout_test_controller.cc b/webkit/tools/test_shell/layout_test_controller.cc
index 32f5188..e250886 100644
--- a/webkit/tools/test_shell/layout_test_controller.cc
+++ b/webkit/tools/test_shell/layout_test_controller.cc
@@ -199,6 +199,12 @@ LayoutTestController::LayoutTestController(TestShell* shell) :
   BindProperty("webHistoryItemCount", &webHistoryItemCount_);
 }
 
+LayoutTestController::~LayoutTestController() {
+}
+
+LayoutTestController::WorkQueue::WorkQueue() {
+}
+
 LayoutTestController::WorkQueue::~WorkQueue() {
   Reset();
 }
diff --git a/webkit/tools/test_shell/layout_test_controller.h b/webkit/tools/test_shell/layout_test_controller.h
index 28ae5ea..d048d0f 100644
--- a/webkit/tools/test_shell/layout_test_controller.h
+++ b/webkit/tools/test_shell/layout_test_controller.h
@@ -26,6 +26,7 @@ class LayoutTestController : public CppBoundClass {
   // Builds the property and method lists needed to bind this class to a JS
   // object.
   LayoutTestController(TestShell* shell);
+  ~LayoutTestController();
 
   // This function sets a flag that tells the test_shell to dump pages as
   // plain text, rather than as a text representation of the renderer's state.
@@ -352,6 +353,7 @@ class LayoutTestController : public CppBoundClass {
   // queueScript.
   class WorkQueue {
    public:
+    WorkQueue();
     virtual ~WorkQueue();
     void ProcessWorkSoon();
 
diff --git a/webkit/tools/test_shell/test_shell_devtools_agent.cc b/webkit/tools/test_shell/test_shell_devtools_agent.cc
index 356f59c..d13cb9f 100644
--- a/webkit/tools/test_shell/test_shell_devtools_agent.cc
+++ b/webkit/tools/test_shell/test_shell_devtools_agent.cc
@@ -61,6 +61,9 @@ TestShellDevToolsAgent::TestShellDevToolsAgent()
         &TestShellDevToolsAgent::DispatchMessageLoop);
 }
 
+TestShellDevToolsAgent::~TestShellDevToolsAgent() {
+}
+
 void TestShellDevToolsAgent::SetWebView(WebKit::WebView* web_view) {
   web_view_ = web_view;
 }
diff --git a/webkit/tools/test_shell/test_shell_devtools_agent.h b/webkit/tools/test_shell/test_shell_devtools_agent.h
index 8ea16de..e0f5276 100644
--- a/webkit/tools/test_shell/test_shell_devtools_agent.h
+++ b/webkit/tools/test_shell/test_shell_devtools_agent.h
@@ -24,7 +24,7 @@ class TestShellDevToolsAgent : public WebKit::WebDevToolsAgentClient {
 
  public:
   TestShellDevToolsAgent();
-  virtual ~TestShellDevToolsAgent() {}
+  virtual ~TestShellDevToolsAgent();
 
   void SetWebView(WebKit::WebView* web_view);