diff options
| author | dpranke@google.com <dpranke@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-23 01:40:26 +0000 |
|---|---|---|
| committer | dpranke@google.com <dpranke@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-23 01:40:26 +0000 |
| commit | 75a4493827db00698cd91b2422338f023137579a (patch) | |
| tree | 1c614da3c5d00856600b96b063caf1f3811ae9c2 /webkit | |
| parent | e64edf70b0a1ae80dd327965d9ea804fce9a09d5 (diff) | |
| download | chromium_src-75a4493827db00698cd91b2422338f023137579a.zip chromium_src-75a4493827db00698cd91b2422338f023137579a.tar.gz chromium_src-75a4493827db00698cd91b2422338f023137579a.tar.bz2 | |
python 2.4's implementation of sys.popen() has a race condition
python 2.4's implementation of sys.popen() keeps a list of subprocesses
around to handle cleanup, but the list isn't safe against concurrent access,
leading it to sometimes through a ValueError exception. The list is kind
of pointless, and the exception can be ignored (which it is in 2.5).
BUG=none
R=maruel
TEST=none
Review URL: http://codereview.chromium.org/155782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21367 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
| -rw-r--r-- | webkit/tools/layout_tests/test_types/image_diff.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/webkit/tools/layout_tests/test_types/image_diff.py b/webkit/tools/layout_tests/test_types/image_diff.py index 684c582..7e32a78 100644 --- a/webkit/tools/layout_tests/test_types/image_diff.py +++ b/webkit/tools/layout_tests/test_types/image_diff.py @@ -93,6 +93,10 @@ class ImageDiff(test_type_base.TestTypeBase): _compare_available = False else: raise e + except ValueError: + # work around a race condition in Python 2.4's implementation of + # subprocess.Popen + pass global _compare_msg_printed |