summaryrefslogtreecommitdiffstats
path: root/webkit
diff options
context:
space:
mode:
authorevanm@google.com <evanm@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-08-20 22:11:47 +0000
committerevanm@google.com <evanm@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-08-20 22:11:47 +0000
commitfa87a2527ca8c0bcef92d8e44791332782936911 (patch)
tree04dc5d1e6881f8356f91203a386648057b20d924 /webkit
parent4f64d0af5908e36d356c834005d08cca98d579fe (diff)
downloadchromium_src-fa87a2527ca8c0bcef92d8e44791332782936911.zip
chromium_src-fa87a2527ca8c0bcef92d8e44791332782936911.tar.gz
chromium_src-fa87a2527ca8c0bcef92d8e44791332782936911.tar.bz2
Revert. Failing unit tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1118 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r--webkit/glue/plugins/plugin_instance.cc15
-rw-r--r--webkit/glue/plugins/plugin_instance.h3
2 files changed, 8 insertions, 10 deletions
diff --git a/webkit/glue/plugins/plugin_instance.cc b/webkit/glue/plugins/plugin_instance.cc
index 405acb5..62e1357 100644
--- a/webkit/glue/plugins/plugin_instance.cc
+++ b/webkit/glue/plugins/plugin_instance.cc
@@ -45,9 +45,7 @@
namespace NPAPI
{
-
-// TODO(evanm): don't rely on static initialization.
-ThreadLocalStorage::Slot PluginInstance::plugin_instance_tls_index_;
+int PluginInstance::plugin_instance_tls_index_ = ThreadLocalStorage::Alloc();
PluginInstance::PluginInstance(PluginLib *plugin, const std::string &mime_type)
: plugin_(plugin),
@@ -431,16 +429,17 @@ void PluginInstance::OnPluginThreadAsyncCall(void (*func)(void *),
PluginInstance* PluginInstance::SetInitializingInstance(
PluginInstance* instance) {
PluginInstance* old_instance =
- static_cast<PluginInstance*>(plugin_instance_tls_index_.Get());
- plugin_instance_tls_index_.Set(instance);
+ static_cast<PluginInstance*>(
+ ThreadLocalStorage::Get(plugin_instance_tls_index_));
+ ThreadLocalStorage::Set(plugin_instance_tls_index_, instance);
return old_instance;
}
PluginInstance* PluginInstance::GetInitializingInstance() {
PluginInstance* instance =
- static_cast<PluginInstance*>(plugin_instance_tls_index_.Get());
- return instance;
-}
+ static_cast<PluginInstance*>(
+ ThreadLocalStorage::Get(plugin_instance_tls_index_));
+ return instance;}
NPError PluginInstance::GetServiceManager(void** service_manager) {
if (!mozilla_extenstions_) {
diff --git a/webkit/glue/plugins/plugin_instance.h b/webkit/glue/plugins/plugin_instance.h
index 6cbfd5a..5743c24 100644
--- a/webkit/glue/plugins/plugin_instance.h
+++ b/webkit/glue/plugins/plugin_instance.h
@@ -40,7 +40,6 @@
#include "base/basictypes.h"
#include "base/ref_counted.h"
#include "base/scoped_ptr.h"
-#include "base/thread_local_storage.h"
#include "webkit/glue/plugins/nphostapi.h"
#include "googleurl/src/gurl.h"
#include "third_party/npapi/bindings/npapi.h"
@@ -262,7 +261,7 @@ class PluginInstance : public base::RefCounted<PluginInstance> {
// We need to pass this instance to the service manager
// (MozillaExtensionApi) created as a result of NPN_GetValue
// in the context of NP_Initialize.
- static ThreadLocalStorage::Slot plugin_instance_tls_index_;
+ static int plugin_instance_tls_index_;
scoped_refptr<PluginDataStream> plugin_data_stream_;
GURL instance_url_;