Upgrade the windows specific version of LaunchProcess to avoid raw handles.

This change implies that extensions::LaunchNativeProcess also changes to
return base::Process, and that requires base::EnsureProcessTerminated to
deal with base:Process (as it basically claims ownership of the process).

This CL fixes some leaks all around.

BUG=417532

Committed: https://crrev.com/6b687a5e232c80539772dc3dbe35b98095064c38
Cr-Commit-Position: refs/heads/master@{#306687}

Review URL: https://codereview.chromium.org/759903002

Cr-Commit-Position: refs/heads/master@{#306963}

1 files changed, 5 insertions, 5 deletions

diff --git a/win8/test/metro_registration_helper.cc b/win8/test/metro_registration_helper.cc
index c5d6735..59b2235 100644
--- a/win8/test/metro_registration_helper.cc
+++ b/win8/test/metro_registration_helper.cc
@@ -53,13 +53,13 @@ bool RegisterTestDefaultBrowser() {
   CommandLine register_command(registrar);
   register_command.AppendArg("/RegServer");
 
-  base::win::ScopedHandle register_handle;
-  if (base::LaunchProcess(register_command.GetCommandLineString(),
-                          base::LaunchOptions(),
-                          &register_handle)) {
+  base::Process register_process =
+      base::LaunchProcess(register_command.GetCommandLineString(),
+                          base::LaunchOptions());
+  if (register_process.IsValid()) {
     int ret = 0;
     if (base::WaitForExitCodeWithTimeout(
-            register_handle.Get(), &ret,
+            register_process.Handle(), &ret,
             base::TimeDelta::FromSeconds(kRegistrationTimeoutSeconds))) {
       if (ret == 0) {
         return true;