diff options
author | rvargas <rvargas@chromium.org> | 2014-12-03 14:24:06 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-03 22:24:46 +0000 |
commit | 6b687a5e232c80539772dc3dbe35b98095064c38 (patch) | |
tree | 152e59d10d89943e7ec0363b8f686b483c9d31be /win8 | |
parent | e77e1c6d3ecf6398fdbd32fd262e6d6d5e00c4bd (diff) | |
download | chromium_src-6b687a5e232c80539772dc3dbe35b98095064c38.zip chromium_src-6b687a5e232c80539772dc3dbe35b98095064c38.tar.gz chromium_src-6b687a5e232c80539772dc3dbe35b98095064c38.tar.bz2 |
Upgrade the windows specific version of LaunchProcess to avoid raw handles.
This change implies that extensions::LaunchNativeProcess also changes to
return base::Process, and that requires base::EnsureProcessTerminated to
deal with base:Process (as it basically claims ownership of the process).
This CL fixes some leaks all around.
BUG=417532
Review URL: https://codereview.chromium.org/759903002
Cr-Commit-Position: refs/heads/master@{#306687}
Diffstat (limited to 'win8')
-rw-r--r-- | win8/test/metro_registration_helper.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/win8/test/metro_registration_helper.cc b/win8/test/metro_registration_helper.cc index c5d6735..59b2235 100644 --- a/win8/test/metro_registration_helper.cc +++ b/win8/test/metro_registration_helper.cc @@ -53,13 +53,13 @@ bool RegisterTestDefaultBrowser() { CommandLine register_command(registrar); register_command.AppendArg("/RegServer"); - base::win::ScopedHandle register_handle; - if (base::LaunchProcess(register_command.GetCommandLineString(), - base::LaunchOptions(), - ®ister_handle)) { + base::Process register_process = + base::LaunchProcess(register_command.GetCommandLineString(), + base::LaunchOptions()); + if (register_process.IsValid()) { int ret = 0; if (base::WaitForExitCodeWithTimeout( - register_handle.Get(), &ret, + register_process.Handle(), &ret, base::TimeDelta::FromSeconds(kRegistrationTimeoutSeconds))) { if (ret == 0) { return true; |