diff options
| author | Peter Kasting <pkasting@google.com> | 2014-11-20 15:14:08 -0800 |
|---|---|---|
| committer | Peter Kasting <pkasting@google.com> | 2014-11-20 23:16:57 +0000 |
| commit | be940e9e152e528fc567c4eeeeb5930710873f98 (patch) | |
| tree | 8496f9708b39b9ed106be20043e2e37d6ab58eb0 /win8 | |
| parent | ce6760690b52af662b5684f24dca6edc20832edf (diff) | |
| download | chromium_src-be940e9e152e528fc567c4eeeeb5930710873f98.zip chromium_src-be940e9e152e528fc567c4eeeeb5930710873f98.tar.gz chromium_src-be940e9e152e528fc567c4eeeeb5930710873f98.tar.bz2 | |
Enable MSVC warning for unused locals.
There is seemingly a bug in the compiler where it occasionally claims a local is
unused when it isn't. This forces a few places to either inline such locals or
mark them ALLOW_UNUSED_LOCAL.
BUG=81439
TEST=none
R=brettw@chromium.org, cpu@chromium.org, jamesr@chromium.org, rvargas@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, wolenetz@chromium.org
Review URL: https://codereview.chromium.org/731373002
Cr-Commit-Position: refs/heads/master@{#305108}
Diffstat (limited to 'win8')
| -rw-r--r-- | win8/delegate_execute/crash_server_init.cc | 2 | ||||
| -rw-r--r-- | win8/metro_driver/chrome_app_view_ash.cc | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/win8/delegate_execute/crash_server_init.cc b/win8/delegate_execute/crash_server_init.cc index 646c57b..1272652 100644 --- a/win8/delegate_execute/crash_server_init.cc +++ b/win8/delegate_execute/crash_server_init.cc @@ -68,7 +68,7 @@ namespace delegate_execute { scoped_ptr<google_breakpad::ExceptionHandler> InitializeCrashReporting() { wchar_t temp_path[MAX_PATH + 1] = {0}; - DWORD path_len = ::GetTempPath(MAX_PATH, temp_path); + ::GetTempPath(MAX_PATH, temp_path); base::string16 pipe_name; pipe_name = kGoogleUpdatePipeName; diff --git a/win8/metro_driver/chrome_app_view_ash.cc b/win8/metro_driver/chrome_app_view_ash.cc index d0530bd..2e8b1cb 100644 --- a/win8/metro_driver/chrome_app_view_ash.cc +++ b/win8/metro_driver/chrome_app_view_ash.cc @@ -284,7 +284,7 @@ void RunMessageLoop(winui::Core::ICoreDispatcher* dispatcher) { // 1 - User action like ALT-F4. // 2 - Calling ICoreApplicationExit::Exit(). // 3- Posting WM_CLOSE to the core window. - HRESULT hr = dispatcher->ProcessEvents( + dispatcher->ProcessEvents( winui::Core::CoreProcessEventsOption ::CoreProcessEventsOption_ProcessUntilQuit); @@ -775,7 +775,7 @@ void ChromeAppViewAsh::OnOpenURLOnDesktop(const base::FilePath& shortcut, sei.lpFile = file.c_str(); sei.lpDirectory = L""; sei.lpParameters = url.c_str(); - BOOL result = ShellExecuteEx(&sei); + ShellExecuteEx(&sei); } void ChromeAppViewAsh::OnSetCursor(HCURSOR cursor) { |