summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--base/thread_unittest.cc3
-rw-r--r--tools/valgrind/tsan/suppressions.txt8
2 files changed, 3 insertions, 8 deletions
diff --git a/base/thread_unittest.cc b/base/thread_unittest.cc
index a7407e2..90aec51 100644
--- a/base/thread_unittest.cc
+++ b/base/thread_unittest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/dynamic_annotations.h"
#include "base/lock.h"
#include "base/message_loop.h"
#include "base/string_util.h"
@@ -18,6 +19,8 @@ namespace {
class ToggleValue : public Task {
public:
explicit ToggleValue(bool* value) : value_(value) {
+ ANNOTATE_BENIGN_RACE(value, "Test-only data race on boolean "
+ "in base/thread_unittest");
}
virtual void Run() {
*value_ = !*value_;
diff --git a/tools/valgrind/tsan/suppressions.txt b/tools/valgrind/tsan/suppressions.txt
index def64d1..e94fc15 100644
--- a/tools/valgrind/tsan/suppressions.txt
+++ b/tools/valgrind/tsan/suppressions.txt
@@ -133,14 +133,6 @@
# TODO(timurrrr): bug item
{
- Data race on bool in base/thread_unittest
- ThreadSanitizer:Race
- ...
- fun:*ToggleValue*Run*
-}
-
-# TODO(timurrrr): bug item
-{
Data race on bool in AssertReporter [test-only]
ThreadSanitizer:Race
...