diff options
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete.h | 4 | ||||
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete_popup.cc | 4 | ||||
| -rw-r--r-- | chrome/browser/metrics_log.cc | 7 |
3 files changed, 13 insertions, 2 deletions
diff --git a/chrome/browser/autocomplete/autocomplete.h b/chrome/browser/autocomplete/autocomplete.h index 2e26102..79095ad 100644 --- a/chrome/browser/autocomplete/autocomplete.h +++ b/chrome/browser/autocomplete/autocomplete.h @@ -788,16 +788,20 @@ class AutocompleteController : public ACProviderListener { // from the omnibox popup. struct AutocompleteLog { AutocompleteLog(std::wstring text, + AutocompleteInput::Type input_type, size_t selected_index, size_t inline_autocompleted_length, const AutocompleteResult& result) : text(text), + input_type(input_type), selected_index(selected_index), inline_autocompleted_length(inline_autocompleted_length), result(result) { } // The user's input text in the omnibox. std::wstring text; + // The detected type of the user's input. + AutocompleteInput::Type input_type; // Selected index (if selected) or -1 (AutocompletePopupModel::kNoMatch). size_t selected_index; // Inline autocompleted length (if displayed). diff --git a/chrome/browser/autocomplete/autocomplete_popup.cc b/chrome/browser/autocomplete/autocomplete_popup.cc index d9ca65a..23535c3 100644 --- a/chrome/browser/autocomplete/autocomplete_popup.cc +++ b/chrome/browser/autocomplete/autocomplete_popup.cc @@ -869,8 +869,8 @@ bool AutocompletePopupModel::GetKeywordForMatch(const AutocompleteMatch& match, } AutocompleteLog* AutocompletePopupModel::GetAutocompleteLog() { - return new AutocompleteLog(controller_->input().text(), selected_line_, 0, - controller_->result()); + return new AutocompleteLog(controller_->input().text(), + controller_->input().type(), selected_line_, 0, controller_->result()); } void AutocompletePopupModel::Move(int count) { diff --git a/chrome/browser/metrics_log.cc b/chrome/browser/metrics_log.cc index 01de449..6d8397a 100644 --- a/chrome/browser/metrics_log.cc +++ b/chrome/browser/metrics_log.cc @@ -593,12 +593,19 @@ void MetricsLog::RecordOmniboxOpenedURL(const AutocompleteLog& log) { WriteIntAttribute("selectedindex", static_cast<int>(log.selected_index)); WriteIntAttribute("completedlength", static_cast<int>(log.inline_autocompleted_length)); + const std::string input_type( + AutocompleteInput::TypeToString(log.input_type)); + if (!input_type.empty()) + WriteAttribute("inputtype", input_type); for (AutocompleteResult::const_iterator i(log.result.begin()); i != log.result.end(); ++i) { OPEN_ELEMENT_FOR_SCOPE("autocompleteitem"); if (i->provider) WriteAttribute("provider", i->provider->name()); + const std::string result_type(AutocompleteMatch::TypeToString(i->type)); + if (!result_type.empty()) + WriteAttribute("resulttype", result_type); WriteIntAttribute("relevance", i->relevance); WriteIntAttribute("isstarred", i->starred ? 1 : 0); } |