diff options
| -rw-r--r-- | chrome/browser/renderer_host/resource_dispatcher_host.cc | 10 | ||||
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 16 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 64 |
3 files changed, 5 insertions, 85 deletions
diff --git a/chrome/browser/renderer_host/resource_dispatcher_host.cc b/chrome/browser/renderer_host/resource_dispatcher_host.cc index 93749f3..3a649ca6 100644 --- a/chrome/browser/renderer_host/resource_dispatcher_host.cc +++ b/chrome/browser/renderer_host/resource_dispatcher_host.cc @@ -1618,11 +1618,11 @@ void ResourceDispatcherHost::NotifyOnUI(NotificationType type, T* detail) { RenderViewHost* rvh = RenderViewHost::FromID(render_process_id, render_view_id); - if (!rvh) - return; - RenderViewHostDelegate* rvhd = rvh->delegate(); - NotificationService::current()->Notify( - type, Source<RenderViewHostDelegate>(rvhd), Details<T>(detail)); + if (rvh) { + RenderViewHostDelegate* rvhd = rvh->delegate(); + NotificationService::current()->Notify( + type, Source<RenderViewHostDelegate>(rvhd), Details<T>(detail)); + } delete detail; } diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index c1d24e4..eb6077d 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1174,22 +1174,6 @@ fun:_ZN3net22HttpNetworkTransaction5StartEPKNS_15HttpRequestInfoEP14CallbackRunnerI6Tuple1IiEERKNS_11BoundNetLogE fun:_ZN3net9HttpCache11Transaction13DoSendRequestEv } -# URLRequest*Job stands for {URLRequestJob,URLRequestChromeJob,URLRequestHttpJob} -{ - bug_68290 - Heapcheck:Leak - fun:ResourceDispatcherHost::NotifyResponseStarted - fun:ResourceDispatcherHost::CompleteResponseStarted - fun:ResourceDispatcherHost::OnResponseStarted - fun:net::URLRequest::ResponseStarted - fun:net::URLRequest*Job::NotifyHeadersComplete - fun:net::URLRequestTestJob::StartAsync - fun:void DispatchToMethod - fun:RunnableMethod::Run - fun:MessageLoop::RunTask - fun:MessageLoop::DeferOrRunPendingTask - fun:MessageLoop::DoWork -} { bug_68304 Heapcheck:Leak diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index b330625..379e7295 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -3524,70 +3524,6 @@ fun:main } { - bug_68290_a - Memcheck:Leak - fun:_Znw* - fun:_ZN22ResourceDispatcherHost21NotifyResponseStartedEPN3net10URLRequestEi - fun:_ZN22ResourceDispatcherHost23CompleteResponseStartedEPN3net10URLRequestE - fun:_ZN22ResourceDispatcherHost17OnResponseStartedEPN3net10URLRequestE - fun:_ZN3net10URLRequest15ResponseStartedEv - fun:_ZN3net13URLRequestJob21NotifyHeadersCompleteEv - fun:_ZN3net17URLRequestTestJob10StartAsyncEv - fun:_Z16DispatchToMethodIN3net17URLRequestTestJobEMS1_FvvEEvPT_T0_RK6Tuple0 - fun:_ZN14RunnableMethodIN3net17URLRequestTestJobEMS1_FvvE6Tuple0E3RunEv - fun:_ZN11MessageLoop7RunTaskEP4Task - fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE - fun:_ZN11MessageLoop6DoWorkEv - fun:_ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE - fun:_ZN11MessageLoop11RunInternalEv - fun:_ZN11MessageLoop10RunHandlerEv -} -{ - bug_68290_b - Memcheck:Leak - fun:_Znw* - fun:_ZN22ResourceDispatcherHost21NotifyResponseStartedEPN3net10URLRequestEi - fun:_ZN22ResourceDispatcherHost23CompleteResponseStartedEPN3net10URLRequestE - fun:_ZN22ResourceDispatcherHost17OnResponseStartedEPN3net10URLRequestE - fun:_ZN3net10URLRequest15ResponseStartedEv - fun:_ZN3net13URLRequestJob21NotifyHeadersCompleteEv - fun:_ZN19URLRequestChromeJob10StartAsyncEv - fun:_Z16DispatchToMethodI19URLRequestChromeJobMS0_FvvEEvPT_T0_RK6Tuple0 - fun:_ZN14RunnableMethodI19URLRequestChromeJobMS0_FvvE6Tuple0E3RunEv - fun:_ZN11MessageLoop7RunTaskEP4Task - fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE - fun:_ZN11MessageLoop6DoWorkEv - fun:_ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE - fun:_ZN11MessageLoop11RunInternalEv - fun:_ZN11MessageLoop10RunHandlerEv -} -{ - bug_68290_c - Memcheck:Leak - fun:_Znw* - fun:_ZN22ResourceDispatcherHost21NotifyResponseStartedEPN3net10URLRequestEi - fun:_ZN22ResourceDispatcherHost23CompleteResponseStartedEPN3net10URLRequestE - fun:_ZN22ResourceDispatcherHost17OnResponseStartedEPN3net10URLRequestE - fun:_ZN3net10URLRequest15ResponseStartedEv - fun:_ZN3net13URLRequestJob21NotifyHeadersCompleteEv - fun:_ZN3net17URLRequestHttpJob21NotifyHeadersCompleteEv - fun:_ZN3net17URLRequestHttpJob14SaveNextCookieEv - fun:_ZN3net17URLRequestHttpJob35SaveCookiesAndNotifyHeadersCompleteEv - fun:_ZN3net17URLRequestHttpJob16OnStartCompletedEi - fun:_Z16DispatchToMethodIN3net17URLRequestHttpJobEMS1_FviEiEvPT_T0_RK6Tuple1IT1_E - fun:_ZN12CallbackImplIN3net17URLRequestHttpJobEMS1_FviE6Tuple1IiEE13RunWithParamsERKS5_ - fun:_ZN14CallbackRunnerI6Tuple1IiEE3RunIiEEvRKT_ - fun:_ZN3net9HttpCache11Transaction10DoCallbackEi - fun:_ZN3net9HttpCache11Transaction12HandleResultEi - fun:_ZN3net9HttpCache11Transaction6DoLoopEi - fun:_ZN3net9HttpCache11Transaction12OnIOCompleteEi - fun:_Z16DispatchToMethodIN3net9HttpCache11TransactionEMS2_FviEiEvPT_T0_RK6Tuple1IT1_E - fun:_ZN12CallbackImplIN3net9HttpCache11TransactionEMS2_FviE6Tuple1IiEE13RunWithParamsERKS6_ - fun:_ZN3net28CancelableCompletionCallbackINS_9HttpCache11TransactionEE13RunWithParamsERK6Tuple1IiE - fun:_ZN14CallbackRunnerI6Tuple1IiEE3RunIiEEvRKT_ - fun:_ZN10disk_cache17InFlightBackendIO19OnOperationCompleteEPNS_12BackgroundIOEb -} -{ bug_68292 Memcheck:Leak fun:_Znw* |