diff options
| -rw-r--r-- | net/base/escape_unittest.cc | 6 | ||||
| -rw-r--r-- | net/http/http_transaction.h | 2 | ||||
| -rw-r--r-- | net/net.xcodeproj/project.pbxproj | 8 |
3 files changed, 13 insertions, 3 deletions
diff --git a/net/base/escape_unittest.cc b/net/base/escape_unittest.cc index 6a201d4..1d48874 100644 --- a/net/base/escape_unittest.cc +++ b/net/base/escape_unittest.cc @@ -76,7 +76,7 @@ TEST(Escape, EscapeTextForFormSubmission) { {L"foo bar", L"foo+bar"}, {L"foo++", L"foo%2B%2B"} }; - for (int i = 0; i < arraysize(escape_cases); ++i) { + for (size_t i = 0; i < arraysize(escape_cases); ++i) { EscapeCase value = escape_cases[i]; EXPECT_EQ(value.output, EscapeQueryParamValueUTF8(value.input)); } @@ -156,7 +156,7 @@ TEST(Escape, UnescapeURLComponent) { {"Hello%20%13%10%02", UnescapeRule::CONTROL_CHARS, "Hello%20\x13\x10\x02"}, }; - for (int i = 0; i < arraysize(unescape_cases); i++) { + for (size_t i = 0; i < arraysize(unescape_cases); i++) { std::string str(unescape_cases[i].input); EXPECT_EQ(std::string(unescape_cases[i].output), UnescapeURLComponent(str, unescape_cases[i].rules)); @@ -217,7 +217,7 @@ TEST(Escape, UnescapeAndDecodeURLComponent) { L"%ED%ED"}, // Invalid UTF-8 -> kept unescaped. }; - for (int i = 0; i < arraysize(unescape_cases); i++) { + for (size_t i = 0; i < arraysize(unescape_cases); i++) { std::string unescaped = UnescapeURLComponent(unescape_cases[i].input, UnescapeRule::NORMAL); EXPECT_EQ(std::string(unescape_cases[i].url_unescaped), unescaped); diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h index 4a13f7c..12b2ba8 100644 --- a/net/http/http_transaction.h +++ b/net/http/http_transaction.h @@ -43,6 +43,8 @@ class HttpResponseInfo; // answered. Cookies are assumed to be managed by the caller. class HttpTransaction { public: + virtual ~HttpTransaction() {} + // Stops any pending IO and destroys the transaction object. virtual void Destroy() = 0; diff --git a/net/net.xcodeproj/project.pbxproj b/net/net.xcodeproj/project.pbxproj index 8449b30..089be25 100644 --- a/net/net.xcodeproj/project.pbxproj +++ b/net/net.xcodeproj/project.pbxproj @@ -26,6 +26,10 @@ 048268080E5B3B3200A30786 /* http_chunked_decoder_unittest.cc in Sources */ = {isa = PBXBuildFile; fileRef = 7BED33570E5A194700A747DB /* http_chunked_decoder_unittest.cc */; }; 048268090E5B3B4800A30786 /* mime_util_unittest.cc in Sources */ = {isa = PBXBuildFile; fileRef = 7BED325E0E5A181C00A747DB /* mime_util_unittest.cc */; }; 0482692A0E5B624D00A30786 /* http_cache.cc in Sources */ = {isa = PBXBuildFile; fileRef = 7BED334C0E5A194700A747DB /* http_cache.cc */; }; + 7B4DF64A0E5B98DF004D7619 /* client_socket_pool_unittest.cc in Sources */ = {isa = PBXBuildFile; fileRef = 7BED326A0E5A181C00A747DB /* client_socket_pool_unittest.cc */; }; + 7B4DF6A90E5B98E7004D7619 /* data_url_unittest.cc in Sources */ = {isa = PBXBuildFile; fileRef = 7BED325F0E5A181C00A747DB /* data_url_unittest.cc */; }; + 7B4DF6B10E5B98ED004D7619 /* escape_unittest.cc in Sources */ = {isa = PBXBuildFile; fileRef = 7BED32BF0E5A181C00A747DB /* escape_unittest.cc */; }; + 7B4DF6BD0E5B98F7004D7619 /* addr_unittest.cc in Sources */ = {isa = PBXBuildFile; fileRef = 7BED32EE0E5A190600A747DB /* addr_unittest.cc */; }; 7B8502040E5A376900730B43 /* libgoogleurl.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 7B8501FE0E5A372500730B43 /* libgoogleurl.a */; }; 7B8502050E5A377100730B43 /* auth_cache_unittest.cc in Sources */ = {isa = PBXBuildFile; fileRef = 7BED32790E5A181C00A747DB /* auth_cache_unittest.cc */; }; 7B8502120E5A37A800730B43 /* base64_unittest.cc in Sources */ = {isa = PBXBuildFile; fileRef = 7BED32760E5A181C00A747DB /* base64_unittest.cc */; }; @@ -1196,9 +1200,13 @@ isa = PBXSourcesBuildPhase; buildActionMask = 2147483647; files = ( + 7B4DF6BD0E5B98F7004D7619 /* addr_unittest.cc in Sources */, 7B8502050E5A377100730B43 /* auth_cache_unittest.cc in Sources */, 7B8502120E5A37A800730B43 /* base64_unittest.cc in Sources */, 7BA015210E5A1B9800044150 /* bzip2_filter_unittest.cc in Sources */, + 7B4DF64A0E5B98DF004D7619 /* client_socket_pool_unittest.cc in Sources */, + 7B4DF6A90E5B98E7004D7619 /* data_url_unittest.cc in Sources */, + 7B4DF6B10E5B98ED004D7619 /* escape_unittest.cc in Sources */, 7BA0151F0E5A1B9200044150 /* gzip_filter_unittest.cc in Sources */, 048268080E5B3B3200A30786 /* http_chunked_decoder_unittest.cc in Sources */, 048268090E5B3B4800A30786 /* mime_util_unittest.cc in Sources */, |