diff options
| -rw-r--r-- | chrome/browser/gtk/browser_window_gtk.cc | 4 | ||||
| -rw-r--r-- | chrome/browser/renderer_host/render_widget_host_view_gtk.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/tab_contents/web_contents_view_gtk.cc | 14 | ||||
| -rw-r--r-- | chrome/common/chrome_plugin_lib.cc | 4 | ||||
| -rw-r--r-- | chrome/common/temp_scaffolding_stubs.cc | 6 |
5 files changed, 20 insertions, 10 deletions
diff --git a/chrome/browser/gtk/browser_window_gtk.cc b/chrome/browser/gtk/browser_window_gtk.cc index 7bf8a69..52436c3 100644 --- a/chrome/browser/gtk/browser_window_gtk.cc +++ b/chrome/browser/gtk/browser_window_gtk.cc @@ -390,7 +390,9 @@ void BrowserWindowGtk::UpdateLoadingAnimations(bool should_animate) { } void BrowserWindowGtk::SetStarredState(bool is_starred) { - NOTIMPLEMENTED(); + // Hide our current lack of starring support from NOTIMPLEMENTED spew. + if (is_starred) + NOTIMPLEMENTED(); } gfx::Rect BrowserWindowGtk::GetNormalBounds() const { diff --git a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc index a550258..56ae00b 100644 --- a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc +++ b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc @@ -196,7 +196,7 @@ void RenderWidgetHostViewGtk::WasHidden() { } void RenderWidgetHostViewGtk::SetSize(const gfx::Size& size) { - NOTIMPLEMENTED(); + // We rely on our parent GTK container to size us. } gfx::NativeView RenderWidgetHostViewGtk::GetPluginNativeView() { diff --git a/chrome/browser/tab_contents/web_contents_view_gtk.cc b/chrome/browser/tab_contents/web_contents_view_gtk.cc index 12c7b1c..f0e6734 100644 --- a/chrome/browser/tab_contents/web_contents_view_gtk.cc +++ b/chrome/browser/tab_contents/web_contents_view_gtk.cc @@ -110,7 +110,12 @@ gfx::NativeWindow WebContentsViewGtk::GetTopLevelNativeWindow() const { } void WebContentsViewGtk::GetContainerBounds(gfx::Rect* out) const { - NOTIMPLEMENTED(); + // This is used for positioning the download shelf arrow animation, + // as well as sizing some other widgets in Windows. In GTK the size is + // managed for us, so it appears to be only used for the download shelf + // animation. + out->SetRect(vbox_.get()->allocation.x, vbox_.get()->allocation.y, + vbox_.get()->allocation.width, vbox_.get()->allocation.height); } void WebContentsViewGtk::OnContentsDestroy() { @@ -119,7 +124,10 @@ void WebContentsViewGtk::OnContentsDestroy() { } void WebContentsViewGtk::SetPageTitle(const std::wstring& title) { - NOTIMPLEMENTED(); + // Set the window name to include the page title so it's easier to spot + // when debugging (e.g. via xwininfo -tree). + if (content_view_ && content_view_->window) + gdk_window_set_title(content_view_->window, WideToUTF8(title).c_str()); } void WebContentsViewGtk::Invalidate() { @@ -164,7 +172,7 @@ void WebContentsViewGtk::RestoreFocus() { // TODO(estade): implement this function. // For now just assume we are viewing the tab for the first time. SetInitialFocus(); - NOTIMPLEMENTED(); + NOTIMPLEMENTED() << " -- need to restore the focus position on this page."; } void WebContentsViewGtk::UpdateDragCursor(bool is_drop_target) { diff --git a/chrome/common/chrome_plugin_lib.cc b/chrome/common/chrome_plugin_lib.cc index 7fbca70..40a0c76 100644 --- a/chrome/common/chrome_plugin_lib.cc +++ b/chrome/common/chrome_plugin_lib.cc @@ -122,7 +122,7 @@ void ChromePluginLib::RegisterPluginsWithNPAPI() { return; // Note: we can only access the NPAPI list because the PluginService has done // the locking for us. We should not touch it anywhere else. -#if defined(OS_WIN) +#if defined(OS_WIN) || defined(OS_LINUX) NPAPI::PluginList::AddExtraPluginPath(path); #else // TODO(port): plugins not yet implemented @@ -255,7 +255,7 @@ int ChromePluginLib::CP_Test(void* param) { bool ChromePluginLib::Load() { #if !defined(OS_WIN) // TODO(port): plugins not yet implemented - NOTIMPLEMENTED(); + NOTIMPLEMENTED() << " -- gears loading code."; return false; #else DCHECK(module_ == 0); diff --git a/chrome/common/temp_scaffolding_stubs.cc b/chrome/common/temp_scaffolding_stubs.cc index 4690499..181d4b1 100644 --- a/chrome/common/temp_scaffolding_stubs.cc +++ b/chrome/common/temp_scaffolding_stubs.cc @@ -211,19 +211,19 @@ int FirstRun::ImportNow(Profile* profile, const CommandLine& cmdline) { // static bool Upgrade::IsBrowserAlreadyRunning() { - NOTIMPLEMENTED(); + // http://code.google.com/p/chromium/issues/detail?id=9295 return false; } // static bool Upgrade::RelaunchChromeBrowser(const CommandLine& command_line) { - NOTIMPLEMENTED(); + // http://code.google.com/p/chromium/issues/detail?id=9295 return true; } // static bool Upgrade::SwapNewChromeExeIfPresent() { - NOTIMPLEMENTED(); + // http://code.google.com/p/chromium/issues/detail?id=9295 return true; } |