summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--base/message_loop_proxy.h3
-rw-r--r--net/base/transport_security_state.h3
-rw-r--r--net/url_request/https_prober.h4
-rw-r--r--net/url_request/url_request_http_job.cc2
4 files changed, 10 insertions, 2 deletions
diff --git a/base/message_loop_proxy.h b/base/message_loop_proxy.h
index 26fd368..10d5368 100644
--- a/base/message_loop_proxy.h
+++ b/base/message_loop_proxy.h
@@ -55,6 +55,9 @@ class MessageLoopProxy
protected:
friend struct MessageLoopProxyTraits;
+
+ virtual ~MessageLoopProxy() { }
+
// Called when the proxy is about to be deleted. Subclasses can override this
// to provide deletion on specific threads.
virtual void OnDestruct() {
diff --git a/net/base/transport_security_state.h b/net/base/transport_security_state.h
index 934db78..6d03776 100644
--- a/net/base/transport_security_state.h
+++ b/net/base/transport_security_state.h
@@ -80,6 +80,9 @@ class TransportSecurityState :
// This function may not block and may be called with internal locks held.
// Thus it must not reenter the TransportSecurityState object.
virtual void StateIsDirty(TransportSecurityState* state) = 0;
+
+ protected:
+ virtual ~Delegate() {}
};
void SetDelegate(Delegate*);
diff --git a/net/url_request/https_prober.h b/net/url_request/https_prober.h
index 2ab1f86..c1c9941 100644
--- a/net/url_request/https_prober.h
+++ b/net/url_request/https_prober.h
@@ -23,6 +23,8 @@ namespace net {
class HTTPSProberDelegate {
public:
virtual void ProbeComplete(bool result) = 0;
+ protected:
+ virtual ~HTTPSProberDelegate() {}
};
// HTTPSProber is a singleton object that manages HTTPS probes. A HTTPS probe
@@ -30,7 +32,7 @@ class HTTPSProberDelegate {
// transparently upgrading from HTTP to HTTPS (for example, for SPDY).
class HTTPSProber : public URLRequest::Delegate {
public:
- HTTPSProber() { }
+ HTTPSProber() {}
// HaveProbed returns true if the given host is known to have been probed
// since the browser was last started.
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 420100f..7041b8d 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -902,7 +902,7 @@ void URLRequestHttpJob::ProcessStrictTransportSecurityHeader() {
continue;
}
- net::HTTPSProberDelegate* delegate =
+ HTTPSProberDelegate* delegate =
new HTTPSProberDelegate(request_info_.url.host(), max_age,
include_subdomains,
ctx->transport_security_state());