summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--chrome/browser/download/download_request_infobar_delegate.cc3
-rw-r--r--tools/heapcheck/suppressions.txt6
-rw-r--r--tools/valgrind/memcheck/suppressions.txt11
3 files changed, 2 insertions, 18 deletions
diff --git a/chrome/browser/download/download_request_infobar_delegate.cc b/chrome/browser/download/download_request_infobar_delegate.cc
index 4d39ad3..34f0f02 100644
--- a/chrome/browser/download/download_request_infobar_delegate.cc
+++ b/chrome/browser/download/download_request_infobar_delegate.cc
@@ -23,8 +23,7 @@ DownloadRequestInfoBarDelegate::~DownloadRequestInfoBarDelegate() {
void DownloadRequestInfoBarDelegate::InfoBarClosed() {
if (host_)
host_->Cancel();
- // This will delete us.
- ConfirmInfoBarDelegate::InfoBarClosed();
+ delete this;
}
SkBitmap* DownloadRequestInfoBarDelegate::GetIcon() const {
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt
index 1e53b47..9c1821f 100644
--- a/tools/heapcheck/suppressions.txt
+++ b/tools/heapcheck/suppressions.txt
@@ -1242,9 +1242,3 @@
...
fun:ExtensionUpdaterTest*
}
-{
- bug_72288
- Heapcheck:Leak
- fun:MockTabDownloadState
- fun:DownloadRequestInfobarDelegate_*_Test::TestBody
-}
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt
index 73937e2..3605438 100644
--- a/tools/valgrind/memcheck/suppressions.txt
+++ b/tools/valgrind/memcheck/suppressions.txt
@@ -3668,16 +3668,7 @@
fun:*DownloadFileTest5SetUpEv
}
{
- bug_72288_a
- Memcheck:Leak
- fun:_Znw*
- ...
- fun:_ZN20MockTabDownloadStateC1Ev
- fun:*DownloadRequestInfobarDelegate_*
- fun:_ZN7testing*35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS3_FS2_vEPKc
-}
-{
- bug_72288_b
+ bug_72547
Memcheck:Leak
fun:_Znw*
fun:_ZN4base22PosixDynamicThreadPool8PostTaskEP4Task