diff options
-rw-r--r-- | chrome/browser/extensions/app_notification_storage.cc | 4 | ||||
-rw-r--r-- | chrome/browser/extensions/apps_promo.cc | 4 | ||||
-rw-r--r-- | chrome/browser/extensions/apps_promo.h | 6 | ||||
-rw-r--r-- | chrome/browser/extensions/bundle_installer.cc | 2 | ||||
-rw-r--r-- | chrome/browser/extensions/extension_install_ui.cc | 2 | ||||
-rw-r--r-- | chrome/browser/extensions/extension_install_ui.h | 2 | ||||
-rw-r--r-- | chrome/browser/extensions/image_loading_tracker.cc | 2 | ||||
-rw-r--r-- | chrome/browser/extensions/image_loading_tracker.h | 2 |
8 files changed, 12 insertions, 12 deletions
diff --git a/chrome/browser/extensions/app_notification_storage.cc b/chrome/browser/extensions/app_notification_storage.cc index 2c8f594..b00f908 100644 --- a/chrome/browser/extensions/app_notification_storage.cc +++ b/chrome/browser/extensions/app_notification_storage.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -101,7 +101,7 @@ bool JSONToAppNotificationList(const std::string& json, return true; } -void LogLevelDbError(tracked_objects::Location location, +void LogLevelDbError(const tracked_objects::Location& location, const leveldb::Status& status) { LOG(ERROR) << "AppNotificationStorage database error at " << location.ToString() << " status:" << status.ToString(); diff --git a/chrome/browser/extensions/apps_promo.cc b/chrome/browser/extensions/apps_promo.cc index f67999a..e034c19 100644 --- a/chrome/browser/extensions/apps_promo.cc +++ b/chrome/browser/extensions/apps_promo.cc @@ -170,7 +170,7 @@ AppsPromo::PromoData AppsPromo::GetPromo() { } // static -void AppsPromo::SetPromo(AppsPromo::PromoData data) { +void AppsPromo::SetPromo(const AppsPromo::PromoData& data) { PrefService* local_state = g_browser_process->local_state(); local_state->SetString(prefs::kNtpWebStorePromoId, data.id); local_state->SetString(prefs::kNtpWebStorePromoButton, data.button); @@ -187,7 +187,7 @@ GURL AppsPromo::GetSourcePromoLogoURL() { } // static -void AppsPromo::SetSourcePromoLogoURL(GURL logo_source) { +void AppsPromo::SetSourcePromoLogoURL(const GURL& logo_source) { PrefService* local_state = g_browser_process->local_state(); local_state->SetString(prefs::kNtpWebStorePromoLogoSource, logo_source.spec()); diff --git a/chrome/browser/extensions/apps_promo.h b/chrome/browser/extensions/apps_promo.h index 78fa96f..37501c7 100644 --- a/chrome/browser/extensions/apps_promo.h +++ b/chrome/browser/extensions/apps_promo.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -76,12 +76,12 @@ class AppsPromo { // |promo_data.logo| is empty or not a valid 'data' URL. static void ClearPromo(); static PromoData GetPromo(); - static void SetPromo(PromoData promo_data); + static void SetPromo(const PromoData& promo_data); // Gets the original URL of the logo. This should only be set when the logo // was served over HTTPS. static GURL GetSourcePromoLogoURL(); - static void SetSourcePromoLogoURL(GURL original_url); + static void SetSourcePromoLogoURL(const GURL& original_url); explicit AppsPromo(PrefService* prefs); ~AppsPromo(); diff --git a/chrome/browser/extensions/bundle_installer.cc b/chrome/browser/extensions/bundle_installer.cc index 1347462..5670ea6d 100644 --- a/chrome/browser/extensions/bundle_installer.cc +++ b/chrome/browser/extensions/bundle_installer.cc @@ -40,7 +40,7 @@ AutoApproveForTest g_auto_approve_for_test = DO_NOT_SKIP; // Creates a dummy extension and sets the manifest's name to the item's // localized name. -scoped_refptr<Extension> CreateDummyExtension(BundleInstaller::Item item, +scoped_refptr<Extension> CreateDummyExtension(const BundleInstaller::Item& item, DictionaryValue* manifest) { // We require localized names so we can have nice error messages when we can't // parse an extension manifest. diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc index 8052ecb..be8335a 100644 --- a/chrome/browser/extensions/extension_install_ui.cc +++ b/chrome/browser/extensions/extension_install_ui.cc @@ -99,7 +99,7 @@ ExtensionInstallUI::Prompt::~Prompt() { } void ExtensionInstallUI::Prompt::SetPermissions( - std::vector<string16> permissions) { + const std::vector<string16>& permissions) { permissions_ = permissions; } diff --git a/chrome/browser/extensions/extension_install_ui.h b/chrome/browser/extensions/extension_install_ui.h index 9a35da0..3b3fa48 100644 --- a/chrome/browser/extensions/extension_install_ui.h +++ b/chrome/browser/extensions/extension_install_ui.h @@ -51,7 +51,7 @@ class ExtensionInstallUI : public ImageLoadingTracker::Observer { explicit Prompt(PromptType type); ~Prompt(); - void SetPermissions(std::vector<string16> permissions); + void SetPermissions(const std::vector<string16>& permissions); void SetInlineInstallWebstoreData(const std::string& localized_user_count, double average_rating, int rating_count); diff --git a/chrome/browser/extensions/image_loading_tracker.cc b/chrome/browser/extensions/image_loading_tracker.cc index edf1f4b..7a34abc 100644 --- a/chrome/browser/extensions/image_loading_tracker.cc +++ b/chrome/browser/extensions/image_loading_tracker.cc @@ -27,7 +27,7 @@ ImageLoadingTracker::Observer::~Observer() {} // ImageLoadingTracker::ImageInfo ImageLoadingTracker::ImageInfo::ImageInfo( - const ExtensionResource resource, gfx::Size max_size) + const ExtensionResource& resource, gfx::Size max_size) : resource(resource), max_size(max_size) { } diff --git a/chrome/browser/extensions/image_loading_tracker.h b/chrome/browser/extensions/image_loading_tracker.h index 6363877..96e6513 100644 --- a/chrome/browser/extensions/image_loading_tracker.h +++ b/chrome/browser/extensions/image_loading_tracker.h @@ -61,7 +61,7 @@ class ImageLoadingTracker : public content::NotificationObserver { // Information about a single image to load from a extension resource. struct ImageInfo { - ImageInfo(const ExtensionResource resource, gfx::Size max_size); + ImageInfo(const ExtensionResource& resource, gfx::Size max_size); ~ImageInfo(); ExtensionResource resource; // If the loaded image is larger than |max_size| it will be resized to those |