summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--chrome/browser/autofill/form_structure.cc8
-rw-r--r--tools/heapcheck/suppressions.txt49
2 files changed, 4 insertions, 53 deletions
diff --git a/chrome/browser/autofill/form_structure.cc b/chrome/browser/autofill/form_structure.cc
index 1d24e3e..0eab86b 100644
--- a/chrome/browser/autofill/form_structure.cc
+++ b/chrome/browser/autofill/form_structure.cc
@@ -167,16 +167,16 @@ bool FormStructure::EncodeQueryRequest(const ScopedVector<FormStructure>& forms,
if (processed_forms.find(signature) != processed_forms.end())
continue;
processed_forms.insert(signature);
- buzz::XmlElement* encompassing_xml_element =
- new buzz::XmlElement(buzz::QName("form"));
+ scoped_ptr<buzz::XmlElement> encompassing_xml_element(
+ new buzz::XmlElement(buzz::QName("form")));
encompassing_xml_element->SetAttr(buzz::QName(kAttributeSignature),
signature);
if (!(*it)->EncodeFormRequest(FormStructure::QUERY,
- encompassing_xml_element))
+ encompassing_xml_element.get()))
continue; // Malformed form, skip it.
- autofil_request_xml.AddElement(encompassing_xml_element);
+ autofil_request_xml.AddElement(encompassing_xml_element.release());
encoded_signatures->push_back(signature);
}
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt
index 318cea0..6e727ea 100644
--- a/tools/heapcheck/suppressions.txt
+++ b/tools/heapcheck/suppressions.txt
@@ -1053,52 +1053,3 @@
fun:testing::HandleExceptionsInMethodIfSupported
fun:testing::Test::Run
}
-{
- bug_61424_a
- Heapcheck:Leak
- fun:FormStructure::EncodeQueryRequest
- fun:::FormStructureTest_EncodeQueryRequest_Test::TestBody
- fun:testing::HandleExceptionsInMethodIfSupported
- fun:testing::Test::Run
-}
-{
- bug_61424_b
- Heapcheck:Leak
- fun:__gnu_cxx::new_allocator::allocate
- fun:std::string::_Rep::_S_create
- fun:std::string::_S_construct
- fun:std::string::_S_construct_aux
- fun:std::string::_S_construct
- fun:basic_string
- fun:base::::IntToStringT::IntToString
- fun:base::Uint64ToString
- fun:::Hash64Bit
- fun:FormStructure::FormSignature
- fun:FormStructure::EncodeQueryRequest
- fun:::FormStructureTest_EncodeQueryRequest_Test::TestBody
- fun:testing::HandleExceptionsInMethodIfSupported
- fun:testing::Test::Run
-}
-{
- bug_61424_c
- Heapcheck:Leak
- fun:__gnu_cxx::new_allocator::allocate
- fun:std::string::_Rep::_S_create
- fun:std::string::_S_construct
- fun:std::string::_S_construct_aux
- fun:std::string::_S_construct
- fun:basic_string
- fun:FormStructure::EncodeQueryRequest
- fun:::FormStructureTest_EncodeQueryRequest_Test::TestBody
- fun:testing::HandleExceptionsInMethodIfSupported
- fun:testing::Test::Run
-}
-{
- bug_61424_d
- Heapcheck:Leak
- fun:buzz::XmlElement::SetAttr
- fun:FormStructure::EncodeQueryRequest
- fun:::FormStructureTest_EncodeQueryRequest_Test::TestBody
- fun:testing::HandleExceptionsInMethodIfSupported
- fun:testing::Test::Run
-}