summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
Diffstat
-rw-r--r--chrome/browser/importer/nss_decryptor.cc4
-rw-r--r--chrome/browser/password_manager/login_database.cc2
-rw-r--r--chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc4
-rw-r--r--chrome/common/chrome_plugin_util.cc6
-rw-r--r--chrome/common/common_glue.cc2
-rw-r--r--chrome/common/extensions/extension.cc8
-rwxr-xr-xchrome/common/extensions/extension_action.cc4
-rw-r--r--chrome/common/extensions/extension_error_reporter.cc2
-rw-r--r--chrome/common/extensions/extension_file_util.cc5
-rw-r--r--chrome/common/extensions/extension_message_bundle.cc2
-rw-r--r--chrome/common/platform_util_linux.cc2
-rw-r--r--chrome/common/sqlite_utils.h2
-rw-r--r--chrome/common/time_format.cc2
13 files changed, 32 insertions, 13 deletions
diff --git a/chrome/browser/importer/nss_decryptor.cc b/chrome/browser/importer/nss_decryptor.cc
index b5893e1..393732f 100644
--- a/chrome/browser/importer/nss_decryptor.cc
+++ b/chrome/browser/importer/nss_decryptor.cc
@@ -4,6 +4,9 @@
#include "chrome/browser/importer/nss_decryptor.h"
+#include <string>
+#include <vector>
+
#include "base/scoped_ptr.h"
#include "build/build_config.h"
#include "chrome/common/sqlite_utils.h"
@@ -14,6 +17,7 @@
#endif // defined(USE_NSS)
#include "base/base64.h"
+#include "base/string_util.h"
#include "base/utf_string_conversions.h"
#include "webkit/glue/password_form.h"
diff --git a/chrome/browser/password_manager/login_database.cc b/chrome/browser/password_manager/login_database.cc
index ac6540c..7f31372e 100644
--- a/chrome/browser/password_manager/login_database.cc
+++ b/chrome/browser/password_manager/login_database.cc
@@ -8,7 +8,9 @@
#include <limits>
#include "base/file_path.h"
+#include "base/logging.h"
#include "base/time.h"
+#include "base/utf_string_conversions.h"
#include "chrome/common/sqlite_utils.h"
using webkit_glue::PasswordForm;
diff --git a/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc b/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
index 98fc2d0..37f5237 100644
--- a/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_store_sqlite.cc
@@ -4,8 +4,12 @@
#include "chrome/browser/safe_browsing/safe_browsing_store_sqlite.h"
+#include <string>
+
#include "base/callback.h"
#include "base/file_util.h"
+#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
#include "chrome/common/sqlite_compiled_statement.h"
#include "chrome/common/sqlite_utils.h"
diff --git a/chrome/common/chrome_plugin_util.cc b/chrome/common/chrome_plugin_util.cc
index 128fe1b..e65b77b 100644
--- a/chrome/common/chrome_plugin_util.cc
+++ b/chrome/common/chrome_plugin_util.cc
@@ -4,10 +4,12 @@
#include "chrome/common/chrome_plugin_util.h"
+#include <algorithm>
+
#include "base/command_line.h"
#include "base/file_util.h"
#include "base/message_loop.h"
-#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
#include "chrome/common/chrome_plugin_lib.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/notification_service.h"
@@ -103,7 +105,7 @@ int PluginResponseUtils::GetResponseInfo(
case CPRESPONSEINFO_HTTP_STATUS:
if (buf && buf_size) {
int status = response_headers->response_code();
- memcpy(buf, &status, std::min(buf_size, sizeof(int)));
+ memcpy(buf, &status, std::min(buf_size, sizeof(status)));
}
break;
case CPRESPONSEINFO_HTTP_RAW_HEADERS: {
diff --git a/chrome/common/common_glue.cc b/chrome/common/common_glue.cc
index 0d3d554..95417ab 100644
--- a/chrome/common/common_glue.cc
+++ b/chrome/common/common_glue.cc
@@ -7,7 +7,7 @@
#include "base/command_line.h"
#include "base/path_service.h"
#include "base/string16.h"
-#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 4436b72..642150e 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -4,6 +4,8 @@
#include "chrome/common/extensions/extension.h"
+#include <algorithm>
+
#include "app/l10n_util.h"
#include "app/resource_bundle.h"
#include "base/base64.h"
@@ -13,10 +15,10 @@
#include "base/file_util.h"
#include "base/file_version_info.h"
#include "base/logging.h"
-#include "base/string_util.h"
#include "base/stl_util-inl.h"
#include "base/third_party/nss/blapi.h"
#include "base/third_party/nss/sha256.h"
+#include "base/utf_string_conversions.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
@@ -150,7 +152,7 @@ bool Extension::IdIsValid(const std::string& id) {
GURL Extension::GetResourceURL(const GURL& extension_url,
const std::string& relative_path) {
DCHECK(extension_url.SchemeIs(chrome::kExtensionScheme));
- DCHECK(extension_url.path() == "/");
+ DCHECK_EQ("/", extension_url.path());
GURL ret_val = GURL(extension_url.spec() + relative_path);
DCHECK(StartsWithASCII(ret_val.spec(), extension_url.spec(), false));
@@ -865,7 +867,7 @@ bool Extension::InitFromValue(const DictionaryValue& source, bool require_key,
l10n_util::GetStringUTF8(IDS_PRODUCT_NAME),
minimum_version_string);
return false;
- }
+ }
}
// Initialize converted_from_user_script (if present)
diff --git a/chrome/common/extensions/extension_action.cc b/chrome/common/extensions/extension_action.cc
index a9718a8..963c4b96 100755
--- a/chrome/common/extensions/extension_action.cc
+++ b/chrome/common/extensions/extension_action.cc
@@ -4,11 +4,13 @@
#include "chrome/common/extensions/extension_action.h"
+#include <algorithm>
+
#include "app/gfx/canvas.h"
#include "app/gfx/font.h"
#include "app/resource_bundle.h"
#include "base/gfx/rect.h"
-#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
#include "chrome/app/chrome_dll_resource.h"
#include "grit/app_resources.h"
#include "third_party/skia/include/core/SkBitmap.h"
diff --git a/chrome/common/extensions/extension_error_reporter.cc b/chrome/common/extensions/extension_error_reporter.cc
index 6913c1e..3d45867 100644
--- a/chrome/common/extensions/extension_error_reporter.cc
+++ b/chrome/common/extensions/extension_error_reporter.cc
@@ -8,7 +8,7 @@
#include "base/logging.h"
#include "base/message_loop.h"
-#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
#include "chrome/common/platform_util.h"
// No AddRef required when using ExtensionErrorReporter with RunnableMethod.
diff --git a/chrome/common/extensions/extension_file_util.cc b/chrome/common/extensions/extension_file_util.cc
index 5edfff5..dce512b 100644
--- a/chrome/common/extensions/extension_file_util.cc
+++ b/chrome/common/extensions/extension_file_util.cc
@@ -4,11 +4,14 @@
#include "chrome/common/extensions/extension_file_util.h"
+#include <map>
+#include <vector>
+
#include "app/l10n_util.h"
#include "base/file_util.h"
#include "base/logging.h"
#include "base/scoped_temp_dir.h"
-#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_l10n_util.h"
#include "chrome/common/extensions/extension_constants.h"
diff --git a/chrome/common/extensions/extension_message_bundle.cc b/chrome/common/extensions/extension_message_bundle.cc
index 04301f9..b069c9b 100644
--- a/chrome/common/extensions/extension_message_bundle.cc
+++ b/chrome/common/extensions/extension_message_bundle.cc
@@ -13,7 +13,7 @@
#include "base/scoped_ptr.h"
#include "base/singleton.h"
#include "base/stl_util-inl.h"
-#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/extension_error_utils.h"
diff --git a/chrome/common/platform_util_linux.cc b/chrome/common/platform_util_linux.cc
index 34cc70f..c4bf536 100644
--- a/chrome/common/platform_util_linux.cc
+++ b/chrome/common/platform_util_linux.cc
@@ -8,7 +8,7 @@
#include "base/file_util.h"
#include "base/process_util.h"
-#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
#include "chrome/browser/gtk/gtk_util.h"
#include "chrome/common/process_watcher.h"
#include "googleurl/src/gurl.h"
diff --git a/chrome/common/sqlite_utils.h b/chrome/common/sqlite_utils.h
index d5e8df3..05e4f5f 100644
--- a/chrome/common/sqlite_utils.h
+++ b/chrome/common/sqlite_utils.h
@@ -17,7 +17,7 @@
#include "base/basictypes.h"
#include "base/scoped_ptr.h"
#include "base/string16.h"
-#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
// forward declarations of classes defined here
class FilePath;
diff --git a/chrome/common/time_format.cc b/chrome/common/time_format.cc
index e6dd6ac..4ca5187 100644
--- a/chrome/common/time_format.cc
+++ b/chrome/common/time_format.cc
@@ -12,8 +12,8 @@
#include "base/scoped_ptr.h"
#include "base/singleton.h"
#include "base/stl_util-inl.h"
-#include "base/string_util.h"
#include "base/time.h"
+#include "base/utf_string_conversions.h"
#include "grit/generated_resources.h"
#include "unicode/datefmt.h"
#include "unicode/locid.h"
generated by cgit v1.1 at 2025-01-30 14:24:46 +0000