diff options
| -rw-r--r-- | AUTHORS | 1 | ||||
| -rw-r--r-- | chrome/test/chromedriver/chrome/javascript_dialog_manager.cc | 2 | ||||
| -rw-r--r-- | chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc | 4 |
3 files changed, 4 insertions, 3 deletions
@@ -103,6 +103,7 @@ Craig Schlenter <craig.schlenter@gmail.com> Daegyu Lee <na7jun8gi@gmail.com> Dai Chunyang <chunyang.dai@intel.com> Daniel Bomar <dbdaniel42@gmail.com> +Daniel Carvalho Liedke <dliedke@gmail.com> Daniel Imms <daniimms@amazon.com> Daniel Johnson <danielj41@gmail.com> Daniel Nishi <dhnishi@gmail.com> diff --git a/chrome/test/chromedriver/chrome/javascript_dialog_manager.cc b/chrome/test/chromedriver/chrome/javascript_dialog_manager.cc index a0fcd93..a1b1631 100644 --- a/chrome/test/chromedriver/chrome/javascript_dialog_manager.cc +++ b/chrome/test/chromedriver/chrome/javascript_dialog_manager.cc @@ -63,7 +63,7 @@ Status JavaScriptDialogManager::OnEvent(DevToolsClient* client, return Status(kUnknownError, "dialog event missing or invalid 'message'"); unhandled_dialog_queue_.push_back(message); - } else if (method == "Page.javascriptDialogClosing") { + } else if (method == "Page.javascriptDialogClosed") { // Inspector only sends this event when all dialogs have been closed. // Clear the unhandled queue in case the user closed a dialog manually. unhandled_dialog_queue_.clear(); diff --git a/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc b/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc index 69ca375..a016511 100644 --- a/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc +++ b/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc @@ -113,7 +113,7 @@ class FakeDevToolsClient : public StubDevToolsClient { while (closing_count_ > 0) { base::DictionaryValue empty; Status status = - listener_->OnEvent(this, "Page.javascriptDialogClosing", empty); + listener_->OnEvent(this, "Page.javascriptDialogClosed", empty); if (status.IsError()) return status; closing_count_--; @@ -202,7 +202,7 @@ TEST(JavaScriptDialogManager, OneDialogManualClose) { ASSERT_EQ( kOk, - manager.OnEvent(&client, "Page.javascriptDialogClosing", params).code()); + manager.OnEvent(&client, "Page.javascriptDialogClosed", params).code()); ASSERT_FALSE(manager.IsDialogOpen()); ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code()); ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, NULL).code()); |