diff options
| -rw-r--r-- | gin/converter.cc | 4 | ||||
| -rw-r--r-- | gin/converter_unittest.cc | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/gin/converter.cc b/gin/converter.cc index 07437b7..29da322 100644 --- a/gin/converter.cc +++ b/gin/converter.cc @@ -35,7 +35,7 @@ Handle<Value> Converter<int32_t>::ToV8(Isolate* isolate, int32_t val) { bool Converter<int32_t>::FromV8(Isolate* isolate, Handle<Value> val, int32_t* out) { - if (!val->IsInt32()) + if (!val->IsNumber()) return false; *out = val->Int32Value(); return true; @@ -47,7 +47,7 @@ Handle<Value> Converter<uint32_t>::ToV8(Isolate* isolate, uint32_t val) { bool Converter<uint32_t>::FromV8(Isolate* isolate, Handle<Value> val, uint32_t* out) { - if (!val->IsUint32()) + if (!val->IsNumber()) return false; *out = val->Uint32Value(); return true; diff --git a/gin/converter_unittest.cc b/gin/converter_unittest.cc index 791d7e6..cf1affc 100644 --- a/gin/converter_unittest.cc +++ b/gin/converter_unittest.cc @@ -89,7 +89,7 @@ TEST_F(ConverterTest, Int32) { { Integer::New(instance_->isolate(), 0).As<Value>(), true, 0 }, { Integer::New(instance_->isolate(), 1).As<Value>(), true, 1 }, { Number::New(instance_->isolate(), -1).As<Value>(), true, -1 }, - { Number::New(instance_->isolate(), 1.1).As<Value>(), false, 0 }, + { Number::New(instance_->isolate(), 1.1).As<Value>(), true, 1 }, { String::NewFromUtf8(instance_->isolate(), "42").As<Value>(), false, 0 }, { String::NewFromUtf8(instance_->isolate(), "foo").As<Value>(), false, 0 }, { Object::New(instance_->isolate()).As<Value>(), false, 0 }, |