diff options
92 files changed, 183 insertions, 211 deletions
diff --git a/base/win/scoped_variant.h b/base/win/scoped_variant.h index 11ffa3e..16a52ec 100644 --- a/base/win/scoped_variant.h +++ b/base/win/scoped_variant.h @@ -38,7 +38,7 @@ class BASE_API ScopedVariant { explicit ScopedVariant(const wchar_t* str); // Creates a new VT_BSTR variant of a specified length. - explicit ScopedVariant(const wchar_t* str, UINT length); + ScopedVariant(const wchar_t* str, UINT length); // Creates a new integral type variant and assigns the value to // VARIANT.lVal (32 bit sized field). diff --git a/chrome/browser/automation/automation_provider_observers.h b/chrome/browser/automation/automation_provider_observers.h index 947518a..15bccd0 100644 --- a/chrome/browser/automation/automation_provider_observers.h +++ b/chrome/browser/automation/automation_provider_observers.h @@ -599,9 +599,9 @@ class DomOperationObserver : public NotificationObserver { // operation. class DomOperationMessageSender : public DomOperationObserver { public: - explicit DomOperationMessageSender(AutomationProvider* automation, - IPC::Message* relpy_message, - bool use_json_interface); + DomOperationMessageSender(AutomationProvider* automation, + IPC::Message* relpy_message, + bool use_json_interface); virtual ~DomOperationMessageSender(); virtual void OnDomOperationCompleted(const std::string& json) OVERRIDE; diff --git a/chrome/browser/browser_main.cc b/chrome/browser/browser_main.cc index ddc7f30..1e2a2bc 100644 --- a/chrome/browser/browser_main.cc +++ b/chrome/browser/browser_main.cc @@ -1093,7 +1093,7 @@ void InitializeToolkit(const MainFunctionParams& parameters) { class StubLogin : public chromeos::LoginStatusConsumer, public chromeos::LoginUtils::Delegate { public: - explicit StubLogin(std::string username, std::string password) { + StubLogin(std::string username, std::string password) { authenticator_ = chromeos::LoginUtils::Get()->CreateAuthenticator(this); authenticator_.get()->AuthenticateToLogin( g_browser_process->profile_manager()->GetDefaultProfile(), diff --git a/chrome/browser/chromeos/cros/burn_library.h b/chrome/browser/chromeos/cros/burn_library.h index b444037..8130f84 100644 --- a/chrome/browser/chromeos/cros/burn_library.h +++ b/chrome/browser/chromeos/cros/burn_library.h @@ -24,16 +24,15 @@ struct ImageBurnStatus { } explicit ImageBurnStatus(const chromeos::BurnStatus& status) - : amount_burnt(status.amount_burnt), - total_size(status.total_size) { + : amount_burnt(status.amount_burnt), total_size(status.total_size) { if (status.target_path) target_path = status.target_path; if (status.error) error = status.error; } - explicit ImageBurnStatus(const char* path, int64 burnt, int64 total, - const char* err) : total_size(total) { + ImageBurnStatus(const char* path, int64 burnt, int64 total, const char* err) + : total_size(total) { if (path) target_path = path; if (err) diff --git a/chrome/browser/chromeos/cros/network_library.cc b/chrome/browser/chromeos/cros/network_library.cc index d74e91c..f3f1d2d 100644 --- a/chrome/browser/chromeos/cros/network_library.cc +++ b/chrome/browser/chromeos/cros/network_library.cc @@ -430,7 +430,7 @@ class StringToEnum { const Type value; }; - explicit StringToEnum(const Pair* list, size_t num_entries, Type unknown) + StringToEnum(const Pair* list, size_t num_entries, Type unknown) : unknown_value_(unknown) { for (size_t i = 0; i < num_entries; ++i, ++list) enum_map_[list->key] = list->value; @@ -2695,7 +2695,7 @@ class NetworkLibraryImplBase : public NetworkLibrary { typedef std::map<std::string, CellularDataPlanVector*> CellularDataPlanMap; struct NetworkProfile { - explicit NetworkProfile(const std::string& p, NetworkProfileType t) + NetworkProfile(const std::string& p, NetworkProfileType t) : path(p), type(t) {} std::string path; NetworkProfileType type; diff --git a/chrome/browser/chromeos/login/login_utils.cc b/chrome/browser/chromeos/login/login_utils.cc index f42706a..ce93999 100644 --- a/chrome/browser/chromeos/login/login_utils.cc +++ b/chrome/browser/chromeos/login/login_utils.cc @@ -180,9 +180,9 @@ class TransferDefaultCookiesOnIOThreadTask : public Task { // Fetches an OAuth token and initializes user policy with it. class PolicyOAuthFetcher : public GaiaOAuthConsumer { public: - explicit PolicyOAuthFetcher(Profile* profile, - const std::string& oauth1_token, - const std::string& oauth1_secret) + PolicyOAuthFetcher(Profile* profile, + const std::string& oauth1_token, + const std::string& oauth1_secret) : oauth_fetcher_(this, profile->GetRequestContext(), profile, diff --git a/chrome/browser/chromeos/login/mock_authenticator.h b/chrome/browser/chromeos/login/mock_authenticator.h index e3982c2..ae6c26e 100644 --- a/chrome/browser/chromeos/login/mock_authenticator.h +++ b/chrome/browser/chromeos/login/mock_authenticator.h @@ -76,8 +76,8 @@ class MockAuthenticator : public Authenticator { class MockLoginUtils : public LoginUtils { public: - explicit MockLoginUtils(const std::string& expected_username, - const std::string& expected_password); + MockLoginUtils(const std::string& expected_username, + const std::string& expected_password); virtual ~MockLoginUtils(); virtual bool ShouldWaitForWifi(); diff --git a/chrome/browser/chromeos/login/rounded_rect_painter.cc b/chrome/browser/chromeos/login/rounded_rect_painter.cc index a5532c8..883f1a7 100644 --- a/chrome/browser/chromeos/login/rounded_rect_painter.cc +++ b/chrome/browser/chromeos/login/rounded_rect_painter.cc @@ -185,10 +185,10 @@ void RoundedRectBorder::GetInsets(gfx::Insets* insets) const { // Simple solid round background. class RoundedBackground : public views::Background { public: - explicit RoundedBackground(int corner_radius, - int stroke_width, - const SkColor& background_color, - const SkColor& stroke_color) + RoundedBackground(int corner_radius, + int stroke_width, + const SkColor& background_color, + const SkColor& stroke_color) : corner_radius_(corner_radius), stroke_width_(stroke_width), stroke_color_(stroke_color) { diff --git a/chrome/browser/chromeos/options/network_config_view.h b/chrome/browser/chromeos/options/network_config_view.h index 2485ff3..a07107a 100644 --- a/chrome/browser/chromeos/options/network_config_view.h +++ b/chrome/browser/chromeos/options/network_config_view.h @@ -102,7 +102,7 @@ class NetworkConfigView : public views::DialogDelegateView, // methods, which are called by NetworkConfigView. class ChildNetworkConfigView : public views::View { public: - explicit ChildNetworkConfigView(NetworkConfigView* parent, Network* network) + ChildNetworkConfigView(NetworkConfigView* parent, Network* network) : service_path_(network->service_path()), parent_(parent) {} explicit ChildNetworkConfigView(NetworkConfigView* parent) diff --git a/chrome/browser/chromeos/setting_level_bubble.h b/chrome/browser/chromeos/setting_level_bubble.h index 454ad85..765aaa2 100644 --- a/chrome/browser/chromeos/setting_level_bubble.h +++ b/chrome/browser/chromeos/setting_level_bubble.h @@ -44,9 +44,9 @@ class SettingLevelBubble : public BubbleDelegate, void UpdateWithoutShowingBubble(int percent); protected: - explicit SettingLevelBubble(SkBitmap* increase_icon, - SkBitmap* decrease_icon, - SkBitmap* zero_icon); + SettingLevelBubble(SkBitmap* increase_icon, + SkBitmap* decrease_icon, + SkBitmap* zero_icon); virtual ~SettingLevelBubble(); private: diff --git a/chrome/browser/chromeos/status/status_area_button.h b/chrome/browser/chromeos/status/status_area_button.h index e8be9cd..2d5c9fb 100644 --- a/chrome/browser/chromeos/status/status_area_button.h +++ b/chrome/browser/chromeos/status/status_area_button.h @@ -16,8 +16,8 @@ namespace chromeos { // Shows current button state by drawing a border around the current icon. class StatusAreaButton : public views::MenuButton { public: - explicit StatusAreaButton(StatusAreaHost* host, - views::ViewMenuDelegate* menu_delegate); + StatusAreaButton(StatusAreaHost* host, + views::ViewMenuDelegate* menu_delegate); virtual ~StatusAreaButton() {} virtual void PaintButton(gfx::Canvas* canvas, PaintButtonMode mode); diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc index 2f5ca58..9141cb8 100644 --- a/chrome/browser/download/download_browsertest.cc +++ b/chrome/browser/download/download_browsertest.cc @@ -334,7 +334,7 @@ class DownloadsFlushObserver public: explicit DownloadsFlushObserver(DownloadManager* download_manager) : download_manager_(download_manager), - waiting_for_zero_inprogress_(true) { } + waiting_for_zero_inprogress_(true) {} void WaitForFlush() { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); @@ -826,8 +826,8 @@ class DownloadTest : public InProcessBrowserTest { // Get History Information. class DownloadsHistoryDataCollector { public: - explicit DownloadsHistoryDataCollector(int64 download_db_handle, - DownloadManager* manager) + DownloadsHistoryDataCollector(int64 download_db_handle, + DownloadManager* manager) : result_valid_(false), download_db_handle_(download_db_handle) { HistoryService* hs = @@ -893,8 +893,8 @@ class MockAbortExtensionInstallUI : public ExtensionInstallUI { // installation. class MockAutoConfirmExtensionInstallUI : public ExtensionInstallUI { public: - explicit MockAutoConfirmExtensionInstallUI(Profile* profile) : - ExtensionInstallUI(profile) {} + explicit MockAutoConfirmExtensionInstallUI(Profile* profile) + : ExtensionInstallUI(profile) {} // Proceed without confirmation prompt. virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) { diff --git a/chrome/browser/extensions/extension_event_router.cc b/chrome/browser/extensions/extension_event_router.cc index 76a0c32..44561ce 100644 --- a/chrome/browser/extensions/extension_event_router.cc +++ b/chrome/browser/extensions/extension_event_router.cc @@ -36,8 +36,7 @@ struct ExtensionEventRouter::EventListener { RenderProcessHost* process; std::string extension_id; - explicit EventListener(RenderProcessHost* process, - const std::string& extension_id) + EventListener(RenderProcessHost* process, const std::string& extension_id) : process(process), extension_id(extension_id) {} bool operator<(const EventListener& that) const { diff --git a/chrome/browser/extensions/extension_message_service.cc b/chrome/browser/extensions/extension_message_service.cc index 756ec4e..0dd960d 100644 --- a/chrome/browser/extensions/extension_message_service.cc +++ b/chrome/browser/extensions/extension_message_service.cc @@ -37,7 +37,7 @@ struct ExtensionMessageService::MessagePort { IPC::Message::Sender* sender; int routing_id; explicit MessagePort(IPC::Message::Sender* sender = NULL, - int routing_id = MSG_ROUTING_CONTROL) + int routing_id = MSG_ROUTING_CONTROL) : sender(sender), routing_id(routing_id) {} }; diff --git a/chrome/browser/extensions/extension_pref_store.h b/chrome/browser/extensions/extension_pref_store.h index 80b82e3..289cdc5 100644 --- a/chrome/browser/extensions/extension_pref_store.h +++ b/chrome/browser/extensions/extension_pref_store.h @@ -19,8 +19,8 @@ class ExtensionPrefStore : public ValueMapPrefStore, public ExtensionPrefValueMap::Observer { public: // Constructs an ExtensionPrefStore for a regular or an incognito profile. - explicit ExtensionPrefStore(ExtensionPrefValueMap* extension_pref_value_map, - bool incognito_pref_store); + ExtensionPrefStore(ExtensionPrefValueMap* extension_pref_value_map, + bool incognito_pref_store); virtual ~ExtensionPrefStore(); private: diff --git a/chrome/browser/extensions/extension_prefs.h b/chrome/browser/extensions/extension_prefs.h index 6e25c5b..86f2d66 100644 --- a/chrome/browser/extensions/extension_prefs.h +++ b/chrome/browser/extensions/extension_prefs.h @@ -68,9 +68,9 @@ class ExtensionPrefs : public ExtensionContentSettingsStore::Observer { }; // Does not assume ownership of |prefs| and |incognito_prefs|. - explicit ExtensionPrefs(PrefService* prefs, - const FilePath& root_dir, - ExtensionPrefValueMap* extension_pref_value_map); + ExtensionPrefs(PrefService* prefs, + const FilePath& root_dir, + ExtensionPrefValueMap* extension_pref_value_map); virtual ~ExtensionPrefs(); // Returns a copy of the Extensions prefs. diff --git a/chrome/browser/extensions/extension_web_ui.h b/chrome/browser/extensions/extension_web_ui.h index 6eeb830..a793fe5 100644 --- a/chrome/browser/extensions/extension_web_ui.h +++ b/chrome/browser/extensions/extension_web_ui.h @@ -33,7 +33,7 @@ class ExtensionWebUI : public ChromeWebUI { public: static const char kExtensionURLOverrides[]; - explicit ExtensionWebUI(TabContents* tab_contents, const GURL& url); + ExtensionWebUI(TabContents* tab_contents, const GURL& url); virtual ~ExtensionWebUI(); diff --git a/chrome/browser/extensions/extensions_quota_service.h b/chrome/browser/extensions/extensions_quota_service.h index 525729e..a0329b2a 100644 --- a/chrome/browser/extensions/extensions_quota_service.h +++ b/chrome/browser/extensions/extensions_quota_service.h @@ -142,7 +142,7 @@ class QuotaLimitHeuristic { }; // Ownership of |mapper| is given to the new QuotaLimitHeuristic. - explicit QuotaLimitHeuristic(const Config& config, BucketMapper* map); + QuotaLimitHeuristic(const Config& config, BucketMapper* map); virtual ~QuotaLimitHeuristic(); // Determines if sufficient quota exists (according to the Apply @@ -173,7 +173,7 @@ class QuotaLimitHeuristic { // a given period of time; e.g "no more than 100 events in an hour". class ExtensionsQuotaService::TimedLimit : public QuotaLimitHeuristic { public: - explicit TimedLimit(const Config& config, BucketMapper* map) + TimedLimit(const Config& config, BucketMapper* map) : QuotaLimitHeuristic(config, map) {} virtual bool Apply(Bucket* bucket, const base::TimeTicks& event_time); }; diff --git a/chrome/browser/history/text_database_manager.h b/chrome/browser/history/text_database_manager.h index 0bf541f..120f4b1 100644 --- a/chrome/browser/history/text_database_manager.h +++ b/chrome/browser/history/text_database_manager.h @@ -74,9 +74,9 @@ class TextDatabaseManager { // The visit database is a pointer owned by the caller for the main database // (of recent visits). The visit database will be updated to refer to the // added text database entries. - explicit TextDatabaseManager(const FilePath& dir, - URLDatabase* url_database, - VisitDatabase* visit_database); + TextDatabaseManager(const FilePath& dir, + URLDatabase* url_database, + VisitDatabase* visit_database); ~TextDatabaseManager(); // Must call before using other functions. If it returns false, no other diff --git a/chrome/browser/plugin_data_remover_helper.cc b/chrome/browser/plugin_data_remover_helper.cc index 599ece9..4636b73 100644 --- a/chrome/browser/plugin_data_remover_helper.cc +++ b/chrome/browser/plugin_data_remover_helper.cc @@ -17,7 +17,7 @@ class PluginDataRemoverHelper::Internal : public base::RefCountedThreadSafe<PluginDataRemoverHelper::Internal> { public: - explicit Internal(const char* pref_name, PrefService* prefs) + Internal(const char* pref_name, PrefService* prefs) : pref_name_(pref_name), prefs_(prefs) {} void StartUpdate() { diff --git a/chrome/browser/policy/device_policy_cache.h b/chrome/browser/policy/device_policy_cache.h index 248824c..d777c03 100644 --- a/chrome/browser/policy/device_policy_cache.h +++ b/chrome/browser/policy/device_policy_cache.h @@ -25,8 +25,8 @@ namespace em = enterprise_management; class DevicePolicyCache : public CloudPolicyCacheBase, public chromeos::SignedSettingsHelper::Callback { public: - explicit DevicePolicyCache(CloudPolicyDataStore* data_store, - EnterpriseInstallAttributes* install_attributes); + DevicePolicyCache(CloudPolicyDataStore* data_store, + EnterpriseInstallAttributes* install_attributes); virtual ~DevicePolicyCache(); // CloudPolicyCacheBase implementation: diff --git a/chrome/browser/printing/print_dialog_cloud_internal.h b/chrome/browser/printing/print_dialog_cloud_internal.h index bfb8060..6e0e935 100644 --- a/chrome/browser/printing/print_dialog_cloud_internal.h +++ b/chrome/browser/printing/print_dialog_cloud_internal.h @@ -97,9 +97,9 @@ class CloudPrintHtmlDialogDelegate; class CloudPrintFlowHandler : public WebUIMessageHandler, public NotificationObserver { public: - explicit CloudPrintFlowHandler(const FilePath& path_to_file, - const string16& print_job_title, - const std::string& file_type); + CloudPrintFlowHandler(const FilePath& path_to_file, + const string16& print_job_title, + const std::string& file_type); virtual ~CloudPrintFlowHandler(); // WebUIMessageHandler implementation. diff --git a/chrome/browser/printing/print_dialog_cloud_unittest.cc b/chrome/browser/printing/print_dialog_cloud_unittest.cc index 86a832c..78f81d0 100644 --- a/chrome/browser/printing/print_dialog_cloud_unittest.cc +++ b/chrome/browser/printing/print_dialog_cloud_unittest.cc @@ -81,9 +81,9 @@ class MockCloudPrintFlowHandler : public CloudPrintFlowHandler, public base::SupportsWeakPtr<MockCloudPrintFlowHandler> { public: - explicit MockCloudPrintFlowHandler(const FilePath& path, - const string16& title, - const std::string& file_type) + MockCloudPrintFlowHandler(const FilePath& path, + const string16& title, + const std::string& file_type) : CloudPrintFlowHandler(path, title, file_type) {} MOCK_METHOD0(DestructorCalled, void()); MOCK_METHOD0(RegisterMessages, void()); diff --git a/chrome/browser/process_singleton_uitest.cc b/chrome/browser/process_singleton_uitest.cc index 386d748..8589e37 100644 --- a/chrome/browser/process_singleton_uitest.cc +++ b/chrome/browser/process_singleton_uitest.cc @@ -36,7 +36,7 @@ namespace { // NewRunnableMethod class to run the StartChrome methods in many threads. class ChromeStarter : public base::RefCountedThreadSafe<ChromeStarter> { public: - explicit ChromeStarter(int timeout_ms, const FilePath& user_data_dir) + ChromeStarter(int timeout_ms, const FilePath& user_data_dir) : ready_event_(false /* manual */, false /* signaled */), done_event_(false /* manual */, false /* signaled */), process_handle_(base::kNullProcessHandle), diff --git a/chrome/browser/rlz/rlz.cc b/chrome/browser/rlz/rlz.cc index 7fd78b3..4b75bd4 100644 --- a/chrome/browser/rlz/rlz.cc +++ b/chrome/browser/rlz/rlz.cc @@ -176,7 +176,7 @@ class DailyPingTask : public Task { // This task needs to run on the UI thread. class DelayedInitTask : public Task { public: - explicit DelayedInitTask(bool first_run, bool google_default_search) + DelayedInitTask(bool first_run, bool google_default_search) : first_run_(first_run), google_default_search_(google_default_search) { } diff --git a/chrome/browser/sessions/tab_restore_service.h b/chrome/browser/sessions/tab_restore_service.h index 8fc50dc..714e83e 100644 --- a/chrome/browser/sessions/tab_restore_service.h +++ b/chrome/browser/sessions/tab_restore_service.h @@ -117,8 +117,7 @@ class TabRestoreService : public BaseSessionService { // Creates a new TabRestoreService and provides an object that provides the // current time. The TabRestoreService does not take ownership of the // |time_factory_|. - explicit TabRestoreService(Profile* profile, - TimeFactory* time_factory_ = NULL); + TabRestoreService(Profile* profile, TimeFactory* time_factory_ = NULL); virtual ~TabRestoreService(); diff --git a/chrome/browser/sync/engine/syncapi.h b/chrome/browser/sync/engine/syncapi.h index ffe369d..139c8c4 100644 --- a/chrome/browser/sync/engine/syncapi.h +++ b/chrome/browser/sync/engine/syncapi.h @@ -594,8 +594,8 @@ class ReadTransaction : public BaseTransaction { class WriteTransaction : public BaseTransaction { public: // Start a new read/write transaction. - explicit WriteTransaction(const tracked_objects::Location& from_here, - UserShare* share); + WriteTransaction(const tracked_objects::Location& from_here, + UserShare* share); virtual ~WriteTransaction(); // Provide access to the syncable.h transaction from the API WriteNode. diff --git a/chrome/browser/sync/glue/syncable_service_adapter.h b/chrome/browser/sync/glue/syncable_service_adapter.h index f6401d4..b19a867 100644 --- a/chrome/browser/sync/glue/syncable_service_adapter.h +++ b/chrome/browser/sync/glue/syncable_service_adapter.h @@ -23,9 +23,9 @@ class GenericChangeProcessor; // provided SyncableService as necessary. class SyncableServiceAdapter : public AssociatorInterface { public: - explicit SyncableServiceAdapter(syncable::ModelType type, - SyncableService* service, - GenericChangeProcessor* sync_processor); + SyncableServiceAdapter(syncable::ModelType type, + SyncableService* service, + GenericChangeProcessor* sync_processor); virtual ~SyncableServiceAdapter(); // AssociatorInterface implementation. diff --git a/chrome/browser/ui/browser_init.cc b/chrome/browser/ui/browser_init.cc index bd70c32..f85c9aa 100644 --- a/chrome/browser/ui/browser_init.cc +++ b/chrome/browser/ui/browser_init.cc @@ -1086,9 +1086,9 @@ void BrowserInit::LaunchWithProfile::AddBadFlagsInfoBarIfNecessary( class LearnMoreInfoBar : public LinkInfoBarDelegate { public: - explicit LearnMoreInfoBar(TabContents* tab_contents, - const string16& message, - const GURL& url); + LearnMoreInfoBar(TabContents* tab_contents, + const string16& message, + const GURL& url); virtual ~LearnMoreInfoBar(); virtual string16 GetMessageTextWithOffset(size_t* link_offset) const OVERRIDE; diff --git a/chrome/browser/ui/cocoa/download/download_shelf_mac.h b/chrome/browser/ui/cocoa/download/download_shelf_mac.h index 1320c3d..e2b626c 100644 --- a/chrome/browser/ui/cocoa/download/download_shelf_mac.h +++ b/chrome/browser/ui/cocoa/download/download_shelf_mac.h @@ -22,8 +22,7 @@ class DownloadItemMac; class DownloadShelfMac : public DownloadShelf { public: - explicit DownloadShelfMac(Browser* browser, - DownloadShelfController* controller); + DownloadShelfMac(Browser* browser, DownloadShelfController* controller); // DownloadShelf implementation. virtual void AddDownload(BaseDownloadItemModel* download_model); diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_instructions_gtk.h b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_instructions_gtk.h index 3e075a8..07cddc8 100644 --- a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_instructions_gtk.h +++ b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_instructions_gtk.h @@ -27,7 +27,7 @@ class BookmarkBarInstructionsGtk : public NotificationObserver { virtual ~Delegate() {} }; - explicit BookmarkBarInstructionsGtk(Delegate* delegate, Profile* profile); + BookmarkBarInstructionsGtk(Delegate* delegate, Profile* profile); // Get the native widget. GtkWidget* widget() const { return instructions_hbox_; } diff --git a/chrome/browser/ui/gtk/browser_titlebar.cc b/chrome/browser/ui/gtk/browser_titlebar.cc index 77331de..61f7988 100644 --- a/chrome/browser/ui/gtk/browser_titlebar.cc +++ b/chrome/browser/ui/gtk/browser_titlebar.cc @@ -150,8 +150,7 @@ GdkColor PickLuminosityContrastingColor(const GdkColor* base, // user clicks on the favicon) and all of its submenus. class PopupPageMenuModel : public ui::SimpleMenuModel { public: - explicit PopupPageMenuModel(ui::SimpleMenuModel::Delegate* delegate, - Browser* browser); + PopupPageMenuModel(ui::SimpleMenuModel::Delegate* delegate, Browser* browser); virtual ~PopupPageMenuModel() { } private: diff --git a/chrome/browser/ui/gtk/browser_toolbar_gtk.h b/chrome/browser/ui/gtk/browser_toolbar_gtk.h index 090ef6a..cd5d864 100644 --- a/chrome/browser/ui/gtk/browser_toolbar_gtk.h +++ b/chrome/browser/ui/gtk/browser_toolbar_gtk.h @@ -43,7 +43,7 @@ class BrowserToolbarGtk : public CommandUpdater::CommandObserver, public MenuGtk::Delegate, public NotificationObserver { public: - explicit BrowserToolbarGtk(Browser* browser, BrowserWindowGtk* window); + BrowserToolbarGtk(Browser* browser, BrowserWindowGtk* window); virtual ~BrowserToolbarGtk(); // Create the contents of the toolbar. |top_level_window| is the GtkWindow diff --git a/chrome/browser/ui/gtk/bubble/bubble_gtk.h b/chrome/browser/ui/gtk/bubble/bubble_gtk.h index b11b45f..d5d5958 100644 --- a/chrome/browser/ui/gtk/bubble/bubble_gtk.h +++ b/chrome/browser/ui/gtk/bubble/bubble_gtk.h @@ -97,7 +97,7 @@ class BubbleGtk : public NotificationObserver { FRAME_STROKE, }; - explicit BubbleGtk(GtkThemeService* provider, bool match_system_theme); + BubbleGtk(GtkThemeService* provider, bool match_system_theme); virtual ~BubbleGtk(); // Creates the Bubble. diff --git a/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h b/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h index 5a7a15a..f10dfaa 100644 --- a/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h +++ b/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h @@ -100,8 +100,8 @@ class CreateChromeApplicationShortcutsDialogGtk // Displays the dialog box to create application shortcuts for |app|. static void Show(GtkWindow* parent, const Extension* app); - explicit CreateChromeApplicationShortcutsDialogGtk(GtkWindow* parent, - const Extension* app); + CreateChromeApplicationShortcutsDialogGtk(GtkWindow* parent, + const Extension* app); virtual ~CreateChromeApplicationShortcutsDialogGtk() {} // Implement ImageLoadingTracker::Observer. |tracker_| is used to diff --git a/chrome/browser/ui/gtk/custom_drag.h b/chrome/browser/ui/gtk/custom_drag.h index 8ec9936..6703def 100644 --- a/chrome/browser/ui/gtk/custom_drag.h +++ b/chrome/browser/ui/gtk/custom_drag.h @@ -23,7 +23,7 @@ class Image; // Base class for programatically generated drags. class CustomDrag { protected: - explicit CustomDrag(gfx::Image* icon, int code_mask, GdkDragAction action); + CustomDrag(gfx::Image* icon, int code_mask, GdkDragAction action); virtual ~CustomDrag(); virtual void OnDragDataGet(GtkWidget* widget, GdkDragContext* context, diff --git a/chrome/browser/ui/gtk/download/download_shelf_gtk.h b/chrome/browser/ui/gtk/download/download_shelf_gtk.h index fd777a9..8088cca 100644 --- a/chrome/browser/ui/gtk/download/download_shelf_gtk.h +++ b/chrome/browser/ui/gtk/download/download_shelf_gtk.h @@ -36,7 +36,7 @@ class DownloadShelfGtk : public DownloadShelf, public SlideAnimatorGtk::Delegate, public MessageLoopForUI::Observer { public: - explicit DownloadShelfGtk(Browser* browser, gfx::NativeView view); + DownloadShelfGtk(Browser* browser, gfx::NativeView view); virtual ~DownloadShelfGtk(); diff --git a/chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h b/chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h index d1591a9..c28997a 100644 --- a/chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h +++ b/chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h @@ -13,8 +13,8 @@ class TranslateInfoBarDelegate; class AfterTranslateInfoBar : public TranslateInfoBarBase { public: - explicit AfterTranslateInfoBar(TabContentsWrapper* owner, - TranslateInfoBarDelegate* delegate); + AfterTranslateInfoBar(TabContentsWrapper* owner, + TranslateInfoBarDelegate* delegate); virtual ~AfterTranslateInfoBar(); // Overridden from TranslateInfoBarBase: diff --git a/chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.h b/chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.h index 3b693ec..f412c81 100644 --- a/chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.h +++ b/chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.h @@ -12,8 +12,8 @@ class TranslateInfoBarDelegate; class BeforeTranslateInfoBar : public TranslateInfoBarBase { public: - explicit BeforeTranslateInfoBar(TabContentsWrapper* owner, - TranslateInfoBarDelegate* delegate); + BeforeTranslateInfoBar(TabContentsWrapper* owner, + TranslateInfoBarDelegate* delegate); virtual ~BeforeTranslateInfoBar(); // Overridden from TranslateInfoBarBase: diff --git a/chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h b/chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h index e37754f..35dc89c 100644 --- a/chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h +++ b/chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h @@ -19,8 +19,8 @@ typedef struct _GtkWidget GtkWidget; // "Would you like to do X? [Yes] [No] _Learn More_ [x]" class ConfirmInfoBarGtk : public InfoBarGtk { public: - explicit ConfirmInfoBarGtk(TabContentsWrapper* owner, - ConfirmInfoBarDelegate* delegate); + ConfirmInfoBarGtk(TabContentsWrapper* owner, + ConfirmInfoBarDelegate* delegate); private: virtual ~ConfirmInfoBarGtk(); diff --git a/chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h b/chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h index 428f25f..80b3f9b 100644 --- a/chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h +++ b/chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h @@ -20,8 +20,8 @@ class ExtensionInfoBarGtk : public InfoBarGtk, public ImageLoadingTracker::Observer, public ExtensionViewGtk::Container { public: - explicit ExtensionInfoBarGtk(TabContentsWrapper* owner, - ExtensionInfoBarDelegate* delegate); + ExtensionInfoBarGtk(TabContentsWrapper* owner, + ExtensionInfoBarDelegate* delegate); virtual ~ExtensionInfoBarGtk(); // Overridden from ImageLoadingTracker::Observer: diff --git a/chrome/browser/ui/gtk/infobars/infobar_container_gtk.h b/chrome/browser/ui/gtk/infobars/infobar_container_gtk.h index 73e821c..2252493 100644 --- a/chrome/browser/ui/gtk/infobars/infobar_container_gtk.h +++ b/chrome/browser/ui/gtk/infobars/infobar_container_gtk.h @@ -38,8 +38,7 @@ typedef struct _GtkWidget GtkWidget; // we can't just overlap the widgets. class InfoBarContainerGtk : public InfoBarContainer { public: - explicit InfoBarContainerGtk(InfoBarContainer::Delegate* delegate, - Profile* profile); + InfoBarContainerGtk(InfoBarContainer::Delegate* delegate, Profile* profile); virtual ~InfoBarContainerGtk(); // Get the native widget. diff --git a/chrome/browser/ui/gtk/infobars/infobar_gtk.h b/chrome/browser/ui/gtk/infobars/infobar_gtk.h index a757a3a..a84a962 100644 --- a/chrome/browser/ui/gtk/infobars/infobar_gtk.h +++ b/chrome/browser/ui/gtk/infobars/infobar_gtk.h @@ -25,7 +25,7 @@ class InfoBarDelegate; class InfoBarGtk : public InfoBar, public NotificationObserver { public: - explicit InfoBarGtk(TabContentsWrapper* owner, InfoBarDelegate* delegate); + InfoBarGtk(TabContentsWrapper* owner, InfoBarDelegate* delegate); virtual ~InfoBarGtk(); // Get the top level native GTK widget for this infobar. diff --git a/chrome/browser/ui/gtk/infobars/link_infobar_gtk.h b/chrome/browser/ui/gtk/infobars/link_infobar_gtk.h index 37de260..c6f5168 100644 --- a/chrome/browser/ui/gtk/infobars/link_infobar_gtk.h +++ b/chrome/browser/ui/gtk/infobars/link_infobar_gtk.h @@ -15,8 +15,7 @@ class LinkInfoBarDelegate; // An infobar that shows a string with an embedded link. class LinkInfoBarGtk : public InfoBarGtk { public: - explicit LinkInfoBarGtk(TabContentsWrapper* owner, - LinkInfoBarDelegate* delegate); + LinkInfoBarGtk(TabContentsWrapper* owner, LinkInfoBarDelegate* delegate); private: virtual ~LinkInfoBarGtk(); diff --git a/chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h b/chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h index f55997c..bb09172 100644 --- a/chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h +++ b/chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h @@ -17,8 +17,8 @@ class TranslateInfoBarDelegate; // use. class TranslateInfoBarBase : public InfoBarGtk { public: - explicit TranslateInfoBarBase(TabContentsWrapper* owner, - TranslateInfoBarDelegate* delegate); + TranslateInfoBarBase(TabContentsWrapper* owner, + TranslateInfoBarDelegate* delegate); virtual ~TranslateInfoBarBase(); // Initializes the infobar widgets. Should be called after the object has been diff --git a/chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.h b/chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.h index d05ba45..2635546 100644 --- a/chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.h +++ b/chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.h @@ -12,8 +12,8 @@ class TranslateInfoBarDelegate; class TranslateMessageInfoBar : public TranslateInfoBarBase { public: - explicit TranslateMessageInfoBar(TabContentsWrapper* owner, - TranslateInfoBarDelegate* delegate); + TranslateMessageInfoBar(TabContentsWrapper* owner, + TranslateInfoBarDelegate* delegate); virtual ~TranslateMessageInfoBar(); // Overridden from TranslateInfoBarBase: diff --git a/chrome/browser/ui/gtk/sad_tab_gtk.h b/chrome/browser/ui/gtk/sad_tab_gtk.h index 03ab37f..a3547e6 100644 --- a/chrome/browser/ui/gtk/sad_tab_gtk.h +++ b/chrome/browser/ui/gtk/sad_tab_gtk.h @@ -20,7 +20,7 @@ class SadTabGtk { KILLED // The tab was killed. Display the killed tab page. }; - explicit SadTabGtk(TabContents* tab_contents, Kind kind); + SadTabGtk(TabContents* tab_contents, Kind kind); virtual ~SadTabGtk(); GtkWidget* widget() const { return event_box_.get(); } diff --git a/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc b/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc index 22185f2..142e4cb 100644 --- a/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc +++ b/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc @@ -263,7 +263,7 @@ class TabStripGtk::TabAnimation : public ui::AnimationDelegate { // Handles insertion of a Tab at |index|. class InsertTabAnimation : public TabStripGtk::TabAnimation { public: - explicit InsertTabAnimation(TabStripGtk* tabstrip, int index) + InsertTabAnimation(TabStripGtk* tabstrip, int index) : TabAnimation(tabstrip, INSERT), index_(index) { int tab_count = tabstrip->GetTabCount(); @@ -526,7 +526,7 @@ class ResizeLayoutAnimation : public TabStripGtk::TabAnimation { // in the model. class MiniTabAnimation : public TabStripGtk::TabAnimation { public: - explicit MiniTabAnimation(TabStripGtk* tabstrip, int index) + MiniTabAnimation(TabStripGtk* tabstrip, int index) : TabAnimation(tabstrip, MINI), index_(index) { int tab_count = tabstrip->GetTabCount(); @@ -586,10 +586,10 @@ class MiniTabAnimation : public TabStripGtk::TabAnimation { // result. class MiniMoveAnimation : public TabStripGtk::TabAnimation { public: - explicit MiniMoveAnimation(TabStripGtk* tabstrip, - int from_index, - int to_index, - const gfx::Rect& start_bounds) + MiniMoveAnimation(TabStripGtk* tabstrip, + int from_index, + int to_index, + const gfx::Rect& start_bounds) : TabAnimation(tabstrip, MINI_MOVE), tab_(tabstrip->GetTabAt(to_index)), start_bounds_(start_bounds), diff --git a/chrome/browser/ui/search_engines/template_url_fetcher_ui_callbacks.h b/chrome/browser/ui/search_engines/template_url_fetcher_ui_callbacks.h index 2ed407f..7c6a014 100644 --- a/chrome/browser/ui/search_engines/template_url_fetcher_ui_callbacks.h +++ b/chrome/browser/ui/search_engines/template_url_fetcher_ui_callbacks.h @@ -18,8 +18,8 @@ class TabContents; class TemplateURLFetcherUICallbacks : public TemplateURLFetcherCallbacks, public NotificationObserver { public: - explicit TemplateURLFetcherUICallbacks(SearchEngineTabHelper* tab_helper, - TabContents* tab_contents); + TemplateURLFetcherUICallbacks(SearchEngineTabHelper* tab_helper, + TabContents* tab_contents); virtual ~TemplateURLFetcherUICallbacks(); // TemplateURLFetcherCallback implementation. diff --git a/chrome/browser/ui/search_engines/template_url_table_model.cc b/chrome/browser/ui/search_engines/template_url_table_model.cc index 6690a16..df098cd 100644 --- a/chrome/browser/ui/search_engines/template_url_table_model.cc +++ b/chrome/browser/ui/search_engines/template_url_table_model.cc @@ -34,8 +34,7 @@ static SkBitmap* default_icon = NULL; class ModelEntry { public: - explicit ModelEntry(TemplateURLTableModel* model, - const TemplateURL& template_url) + ModelEntry(TemplateURLTableModel* model, const TemplateURL& template_url) : template_url_(template_url), load_state_(NOT_LOADED), model_(model) { diff --git a/chrome/browser/ui/views/create_application_shortcut_view.h b/chrome/browser/ui/views/create_application_shortcut_view.h index c325330..9c56810 100644 --- a/chrome/browser/ui/views/create_application_shortcut_view.h +++ b/chrome/browser/ui/views/create_application_shortcut_view.h @@ -114,8 +114,7 @@ class CreateChromeApplicationShortcutView : public CreateApplicationShortcutView, public ImageLoadingTracker::Observer { public: - explicit CreateChromeApplicationShortcutView(Profile* profile, - const Extension* app); + CreateChromeApplicationShortcutView(Profile* profile, const Extension* app); virtual ~CreateChromeApplicationShortcutView(); // Implement ImageLoadingTracker::Observer. |tracker_| is used to diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc index a6cf6fa..41cf512 100644 --- a/chrome/browser/ui/views/frame/browser_view.cc +++ b/chrome/browser/ui/views/frame/browser_view.cc @@ -181,9 +181,9 @@ static gfx::NativeWindow GetNormalBrowserWindowForBrowser(Browser* browser, // and paint the bookmark bar. class BookmarkExtensionBackground : public views::Background { public: - explicit BookmarkExtensionBackground(BrowserView* browser_view, - DetachableToolbarView* host_view, - Browser* browser); + BookmarkExtensionBackground(BrowserView* browser_view, + DetachableToolbarView* host_view, + Browser* browser); // View methods overridden from views:Background. virtual void Paint(gfx::Canvas* canvas, views::View* view) const; diff --git a/chrome/browser/ui/views/sad_tab_view.h b/chrome/browser/ui/views/sad_tab_view.h index 5580013..7d571c0 100644 --- a/chrome/browser/ui/views/sad_tab_view.h +++ b/chrome/browser/ui/views/sad_tab_view.h @@ -30,7 +30,7 @@ class SadTabView : public views::View, KILLED // The tab was killed. Display the killed tab page. }; - explicit SadTabView(TabContents* tab_contents, Kind kind); + SadTabView(TabContents* tab_contents, Kind kind); virtual ~SadTabView(); // Overridden from views::View: diff --git a/chrome/browser/ui/views/tabs/side_tab_strip.cc b/chrome/browser/ui/views/tabs/side_tab_strip.cc index 5e099e3..f7edbfa 100644 --- a/chrome/browser/ui/views/tabs/side_tab_strip.cc +++ b/chrome/browser/ui/views/tabs/side_tab_strip.cc @@ -78,7 +78,7 @@ class ScrollButton : public views::TextButton { DOWN }; - explicit ScrollButton(views::ButtonListener* listener, Type type); + ScrollButton(views::ButtonListener* listener, Type type); protected: // views::View overrides. diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc index e8cbc05..3b2d4c3 100644 --- a/chrome/browser/ui/views/tabs/tab_strip.cc +++ b/chrome/browser/ui/views/tabs/tab_strip.cc @@ -67,7 +67,7 @@ namespace { class NewTabButton : public views::ImageButton { public: - explicit NewTabButton(TabStrip* tab_strip, views::ButtonListener* listener) + NewTabButton(TabStrip* tab_strip, views::ButtonListener* listener) : views::ImageButton(listener), tab_strip_(tab_strip) { } diff --git a/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc b/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc index 10a0123..cf646ac 100644 --- a/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc +++ b/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc @@ -68,8 +68,8 @@ void URLToRequest(const GURL& url, std::string* source_name, // calls back once the data is available. class URLRequestChromeJob : public net::URLRequestJob { public: - explicit URLRequestChromeJob(net::URLRequest* request, - ChromeURLDataManagerBackend* backend); + URLRequestChromeJob(net::URLRequest* request, + ChromeURLDataManagerBackend* backend); // net::URLRequestJob implementation. virtual void Start() OVERRIDE; diff --git a/chrome/browser/ui/window_sizer.cc b/chrome/browser/ui/window_sizer.cc index 24a19cb..bcd321c 100644 --- a/chrome/browser/ui/window_sizer.cc +++ b/chrome/browser/ui/window_sizer.cc @@ -17,9 +17,8 @@ // and persistent state from the browser window and the user's profile. class DefaultStateProvider : public WindowSizer::StateProvider { public: - explicit DefaultStateProvider(const std::string& app_name, - const Browser* browser) : app_name_(app_name), - browser_(browser) { + DefaultStateProvider(const std::string& app_name, const Browser* browser) + : app_name_(app_name), browser_(browser) { } // Overridden from WindowSizer::StateProvider: diff --git a/chrome/browser/upgrade_detector_impl.cc b/chrome/browser/upgrade_detector_impl.cc index 1619e0a..d6fa033 100644 --- a/chrome/browser/upgrade_detector_impl.cc +++ b/chrome/browser/upgrade_detector_impl.cc @@ -63,8 +63,7 @@ int GetCheckForUpgradeEveryMs() { // callback task. Otherwise it just deletes the task. class DetectUpgradeTask : public Task { public: - explicit DetectUpgradeTask(Task* upgrade_detected_task, - bool* is_unstable_channel) + DetectUpgradeTask(Task* upgrade_detected_task, bool* is_unstable_channel) : upgrade_detected_task_(upgrade_detected_task), is_unstable_channel_(is_unstable_channel) { } diff --git a/chrome/browser/webdata/web_database_table.h b/chrome/browser/webdata/web_database_table.h index feb60fd..bfcaaf32 100644 --- a/chrome/browser/webdata/web_database_table.h +++ b/chrome/browser/webdata/web_database_table.h @@ -14,7 +14,7 @@ // Each table should subclass this, adding type-specific methods as needed. class WebDatabaseTable { protected: - explicit WebDatabaseTable(sql::Connection* db, sql::MetaTable* meta_table) + WebDatabaseTable(sql::Connection* db, sql::MetaTable* meta_table) : db_(db), meta_table_(meta_table) {} virtual ~WebDatabaseTable(); diff --git a/chrome/common/json_pref_store.cc b/chrome/common/json_pref_store.cc index 5dd3cf2..ede2eed 100644 --- a/chrome/common/json_pref_store.cc +++ b/chrome/common/json_pref_store.cc @@ -24,8 +24,8 @@ const FilePath::CharType* kBadExtension = FILE_PATH_LITERAL("bad"); class FileThreadDeserializer : public base::RefCountedThreadSafe<FileThreadDeserializer> { public: - explicit FileThreadDeserializer(JsonPrefStore* delegate, - base::MessageLoopProxy* file_loop_proxy) + FileThreadDeserializer(JsonPrefStore* delegate, + base::MessageLoopProxy* file_loop_proxy) : no_dir_(false), error_(PersistentPrefStore::PREF_READ_ERROR_NONE), delegate_(delegate), diff --git a/chrome/service/cloud_print/cloud_print_proxy_backend.cc b/chrome/service/cloud_print/cloud_print_proxy_backend.cc index 7e6b3b1..f76c2ce 100644 --- a/chrome/service/cloud_print/cloud_print_proxy_backend.cc +++ b/chrome/service/cloud_print/cloud_print_proxy_backend.cc @@ -44,11 +44,11 @@ class CloudPrintProxyBackend::Core public: // It is OK for print_server_url to be empty. In this case system should // use system default (local) print server. - explicit Core(CloudPrintProxyBackend* backend, - const GURL& cloud_print_server_url, - const DictionaryValue* print_system_settings, - const gaia::OAuthClientInfo& oauth_client_info, - bool enable_job_poll); + Core(CloudPrintProxyBackend* backend, + const GURL& cloud_print_server_url, + const DictionaryValue* print_system_settings, + const gaia::OAuthClientInfo& oauth_client_info, + bool enable_job_poll); // Note: // diff --git a/chrome/service/cloud_print/print_system_cups.cc b/chrome/service/cloud_print/print_system_cups.cc index 3387334..54ee38f 100644 --- a/chrome/service/cloud_print/print_system_cups.cc +++ b/chrome/service/cloud_print/print_system_cups.cc @@ -236,8 +236,8 @@ class PrintServerWatcherCUPS class PrinterWatcherCUPS : public PrintSystem::PrinterWatcher { public: - explicit PrinterWatcherCUPS(PrintSystemCUPS* print_system, - const std::string& printer_name) + PrinterWatcherCUPS(PrintSystemCUPS* print_system, + const std::string& printer_name) : printer_name_(printer_name), delegate_(NULL), print_system_(print_system) { diff --git a/chrome_frame/custom_sync_call_context.h b/chrome_frame/custom_sync_call_context.h index 87eb075..9bdce87 100644 --- a/chrome_frame/custom_sync_call_context.h +++ b/chrome_frame/custom_sync_call_context.h @@ -65,7 +65,7 @@ class UnloadContext : public SyncMessageReplyDispatcher::SyncMessageCallContext { public: typedef Tuple1<bool> output_type; - explicit UnloadContext(base::WaitableEvent* unload_done, bool* should_unload) + UnloadContext(base::WaitableEvent* unload_done, bool* should_unload) : should_unload_(should_unload), unload_done_(unload_done) { } diff --git a/chrome_frame/test/net/test_automation_provider.h b/chrome_frame/test/net/test_automation_provider.h index 209a069..0c00d63 100644 --- a/chrome_frame/test/net/test_automation_provider.h +++ b/chrome_frame/test/net/test_automation_provider.h @@ -30,8 +30,8 @@ class TestAutomationProviderDelegate { class TestAutomationProvider : public AutomationProvider { public: - explicit TestAutomationProvider(Profile* profile, - TestAutomationProviderDelegate* delegate); + TestAutomationProvider(Profile* profile, + TestAutomationProviderDelegate* delegate); virtual ~TestAutomationProvider(); diff --git a/chrome_frame/test/test_server.h b/chrome_frame/test/test_server.h index 50ba5da..1b60645 100644 --- a/chrome_frame/test/test_server.h +++ b/chrome_frame/test/test_server.h @@ -374,8 +374,7 @@ class ConfigurableConnection : public base::RefCounted<ConfigurableConnection> { // instance to send the response. class HTTPTestServer : public net::ListenSocket::ListenSocketDelegate { public: - explicit HTTPTestServer(int port, const std::wstring& address, - FilePath root_dir); + HTTPTestServer(int port, const std::wstring& address, FilePath root_dir); virtual ~HTTPTestServer(); // HTTP GET request is received. Override in derived classes. diff --git a/content/browser/renderer_host/gpu_message_filter.cc b/content/browser/renderer_host/gpu_message_filter.cc index 600de33..22b4c7a 100644 --- a/content/browser/renderer_host/gpu_message_filter.cc +++ b/content/browser/renderer_host/gpu_message_filter.cc @@ -52,10 +52,9 @@ class EstablishChannelCallback base::ProcessHandle, const GPUInfo&> > { public: - explicit EstablishChannelCallback(GpuMessageFilter* filter, - IPC::Message* reply) : - filter_(filter->AsWeakPtr()), - reply_(reply) { + EstablishChannelCallback(GpuMessageFilter* filter, IPC::Message* reply) + : filter_(filter->AsWeakPtr()), + reply_(reply) { } virtual void RunWithParams(const TupleType& params) { diff --git a/content/browser/zygote_main_linux.cc b/content/browser/zygote_main_linux.cc index bf72711..40f238c 100644 --- a/content/browser/zygote_main_linux.cc +++ b/content/browser/zygote_main_linux.cc @@ -99,9 +99,8 @@ static void SELinuxTransitionToTypeOrDie(const char* type) { // runs it. class Zygote { public: - explicit Zygote(int sandbox_flags, ZygoteForkDelegate* helper) - : sandbox_flags_(sandbox_flags), - helper_(helper) { + Zygote(int sandbox_flags, ZygoteForkDelegate* helper) + : sandbox_flags_(sandbox_flags), helper_(helper) { } bool ProcessRequests() { diff --git a/content/common/process_watcher_posix.cc b/content/common/process_watcher_posix.cc index 85f8ace..ebad678 100644 --- a/content/common/process_watcher_posix.cc +++ b/content/common/process_watcher_posix.cc @@ -32,7 +32,7 @@ static bool IsChildDead(pid_t child) { // If the child doesn't exit within a couple of seconds, kill it. class BackgroundReaper : public base::PlatformThread::Delegate { public: - explicit BackgroundReaper(pid_t child, unsigned timeout) + BackgroundReaper(pid_t child, unsigned timeout) : child_(child), timeout_(timeout) { } diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc index c67c78f..ed6e000 100644 --- a/gpu/command_buffer/service/gles2_cmd_decoder.cc +++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc @@ -222,8 +222,8 @@ class ScopedFrameBufferBinder { // if it is bound or enforce_internal_framebuffer is true. class ScopedResolvedFrameBufferBinder { public: - explicit ScopedResolvedFrameBufferBinder(GLES2DecoderImpl* decoder, - bool enforce_internal_framebuffer); + ScopedResolvedFrameBufferBinder(GLES2DecoderImpl* decoder, + bool enforce_internal_framebuffer); ~ScopedResolvedFrameBufferBinder(); private: @@ -447,8 +447,7 @@ GLES2Decoder::~GLES2Decoder() { class GLES2DecoderImpl : public base::SupportsWeakPtr<GLES2DecoderImpl>, public GLES2Decoder { public: - explicit GLES2DecoderImpl(SurfaceManager* surface_manager, - ContextGroup* group); + GLES2DecoderImpl(SurfaceManager* surface_manager, ContextGroup* group); // Overridden from AsyncAPIInterface. virtual Error DoCommand(unsigned int command, diff --git a/ipc/ipc_sync_channel_unittest.cc b/ipc/ipc_sync_channel_unittest.cc index 5256de8b..bdd83eb 100644 --- a/ipc/ipc_sync_channel_unittest.cc +++ b/ipc/ipc_sync_channel_unittest.cc @@ -340,7 +340,7 @@ namespace { class NoHangServer : public Worker { public: - explicit NoHangServer(WaitableEvent* got_first_reply, bool pump_during_send) + NoHangServer(WaitableEvent* got_first_reply, bool pump_during_send) : Worker(Channel::MODE_SERVER, "no_hang_server"), got_first_reply_(got_first_reply), pump_during_send_(pump_during_send) { } @@ -475,11 +475,10 @@ namespace { class RecursiveServer : public Worker { public: - explicit RecursiveServer( - bool expected_send_result, bool pump_first, bool pump_second) - : Worker(Channel::MODE_SERVER, "recursive_server"), - expected_send_result_(expected_send_result), - pump_first_(pump_first), pump_second_(pump_second) { } + RecursiveServer(bool expected_send_result, bool pump_first, bool pump_second) + : Worker(Channel::MODE_SERVER, "recursive_server"), + expected_send_result_(expected_send_result), + pump_first_(pump_first), pump_second_(pump_second) {} void Run() { SendDouble(pump_first_, expected_send_result_); Done(); @@ -495,9 +494,9 @@ class RecursiveServer : public Worker { class RecursiveClient : public Worker { public: - explicit RecursiveClient(bool pump_during_send, bool close_channel) - : Worker(Channel::MODE_CLIENT, "recursive_client"), - pump_during_send_(pump_during_send), close_channel_(close_channel) { } + RecursiveClient(bool pump_during_send, bool close_channel) + : Worker(Channel::MODE_CLIENT, "recursive_client"), + pump_during_send_(pump_during_send), close_channel_(close_channel) {} void OnDoubleDelay(int in, Message* reply_msg) { SendDouble(pump_during_send_, !close_channel_); @@ -959,7 +958,7 @@ namespace { class NestedTask : public Task { public: - explicit NestedTask(Worker* server) : server_(server) { } + explicit NestedTask(Worker* server) : server_(server) {} void Run() { // Sleep a bit so that we wake up after the reply has been received. base::PlatformThread::Sleep(250); diff --git a/jingle/notifier/listener/push_notifications_listen_task.h b/jingle/notifier/listener/push_notifications_listen_task.h index 8eb764e..3cc4c3d 100644 --- a/jingle/notifier/listener/push_notifications_listen_task.h +++ b/jingle/notifier/listener/push_notifications_listen_task.h @@ -32,7 +32,7 @@ class PushNotificationsListenTask : public buzz::XmppTask { const Notification& notification) = 0; }; - explicit PushNotificationsListenTask(Task* parent, Delegate* delegate); + PushNotificationsListenTask(Task* parent, Delegate* delegate); virtual ~PushNotificationsListenTask(); // Overriden from buzz::XmppTask. diff --git a/net/base/file_stream_unittest.cc b/net/base/file_stream_unittest.cc index 82aaa24..a8cdfcc 100644 --- a/net/base/file_stream_unittest.cc +++ b/net/base/file_stream_unittest.cc @@ -646,7 +646,7 @@ TEST_F(FileStreamTest, BasicAsyncWriteRead) { class TestWriteReadCompletionCallback : public Callback1<int>::Type { public: - explicit TestWriteReadCompletionCallback( + TestWriteReadCompletionCallback( FileStream* stream, int* total_bytes_written, int* total_bytes_read, @@ -776,8 +776,7 @@ TEST_F(FileStreamTest, AsyncWriteRead) { class TestWriteCloseCompletionCallback : public Callback1<int>::Type { public: - explicit TestWriteCloseCompletionCallback(FileStream* stream, - int* total_bytes_written) + TestWriteCloseCompletionCallback(FileStream* stream, int* total_bytes_written) : result_(0), have_result_(false), waiting_for_result_(false), diff --git a/net/disk_cache/mapped_file_unittest.cc b/net/disk_cache/mapped_file_unittest.cc index fefc383..1ab80b1 100644 --- a/net/disk_cache/mapped_file_unittest.cc +++ b/net/disk_cache/mapped_file_unittest.cc @@ -15,9 +15,7 @@ namespace { // Implementation of FileIOCallback for the tests. class FileCallbackTest: public disk_cache::FileIOCallback { public: - explicit FileCallbackTest(int id, - MessageLoopHelper* helper, - int* max_id) + FileCallbackTest(int id, MessageLoopHelper* helper, int* max_id) : id_(id), helper_(helper), max_id_(max_id) { diff --git a/net/disk_cache/stats_histogram.h b/net/disk_cache/stats_histogram.h index f41c384..318a8bc 100644 --- a/net/disk_cache/stats_histogram.h +++ b/net/disk_cache/stats_histogram.h @@ -30,8 +30,8 @@ class StatsHistogram : public base::Histogram { } }; - explicit StatsHistogram(const std::string& name, Sample minimum, - Sample maximum, size_t bucket_count) + StatsHistogram(const std::string& name, Sample minimum, + Sample maximum, size_t bucket_count) : Histogram(name, minimum, maximum, bucket_count), init_(false) {} virtual ~StatsHistogram(); diff --git a/net/ftp/ftp_network_transaction_unittest.cc b/net/ftp/ftp_network_transaction_unittest.cc index 4b929ba..d8bf377 100644 --- a/net/ftp/ftp_network_transaction_unittest.cc +++ b/net/ftp/ftp_network_transaction_unittest.cc @@ -628,8 +628,7 @@ class FtpSocketDataProviderEvilEpsv : public FtpSocketDataProviderFileDownload { class FtpSocketDataProviderEvilPasv : public FtpSocketDataProviderFileDownloadWithPasvFallback { public: - explicit FtpSocketDataProviderEvilPasv(const char* pasv_response, - State expected_state) + FtpSocketDataProviderEvilPasv(const char* pasv_response, State expected_state) : pasv_response_(pasv_response), expected_state_(expected_state) { } diff --git a/net/server/http_server.h b/net/server/http_server.h index 09a2f8a..78f6e42 100644 --- a/net/server/http_server.h +++ b/net/server/http_server.h @@ -58,7 +58,7 @@ private: static int lastId_; friend class HttpServer; - explicit Connection(HttpServer* server, ListenSocket* sock); + Connection(HttpServer* server, ListenSocket* sock); ~Connection(); void DetachSocket(); diff --git a/net/spdy/spdy_session_pool.h b/net/spdy/spdy_session_pool.h index ba02eed..b31e4e9 100644 --- a/net/spdy/spdy_session_pool.h +++ b/net/spdy/spdy_session_pool.h @@ -40,8 +40,8 @@ class NET_API SpdySessionPool public SSLConfigService::Observer, public CertDatabase::Observer { public: - explicit SpdySessionPool(HostResolver* host_resolver, - SSLConfigService* ssl_config_service); + SpdySessionPool(HostResolver* host_resolver, + SSLConfigService* ssl_config_service); virtual ~SpdySessionPool(); // Either returns an existing SpdySession or creates a new SpdySession for diff --git a/net/url_request/url_request_test_job.h b/net/url_request/url_request_test_job.h index 19210b1..80d51ce 100644 --- a/net/url_request/url_request_test_job.h +++ b/net/url_request/url_request_test_job.h @@ -44,15 +44,15 @@ class NET_TEST URLRequestTestJob : public URLRequestJob { // Constructs a job to return one of the canned responses depending on the // request url, optionally with auto advance enabled. - explicit URLRequestTestJob(URLRequest* request, bool auto_advance); + URLRequestTestJob(URLRequest* request, bool auto_advance); // Constructs a job to return the given response regardless of the request // url. The headers should include the HTTP status line and be formatted as // expected by HttpResponseHeaders. - explicit URLRequestTestJob(URLRequest* request, - const std::string& response_headers, - const std::string& response_data, - bool auto_advance); + URLRequestTestJob(URLRequest* request, + const std::string& response_headers, + const std::string& response_data, + bool auto_advance); // The three canned URLs this handler will respond to without having been // explicitly initialized with response headers and data. diff --git a/net/url_request/url_request_throttler_entry.h b/net/url_request/url_request_throttler_entry.h index 75e6aa0..10f1adc 100644 --- a/net/url_request/url_request_throttler_entry.h +++ b/net/url_request/url_request_throttler_entry.h @@ -71,8 +71,8 @@ class NET_API URLRequestThrottlerEntry static const char kExponentialThrottlingDisableValue[]; // The manager object's lifetime must enclose the lifetime of this object. - explicit URLRequestThrottlerEntry(URLRequestThrottlerManager* manager, - const std::string& url_id); + URLRequestThrottlerEntry(URLRequestThrottlerManager* manager, + const std::string& url_id); // The life span of instances created with this constructor is set to // infinite, and the number of initial errors to ignore is set to 0. diff --git a/ppapi/cpp/dev/font_dev.h b/ppapi/cpp/dev/font_dev.h index 7fc5c41..1ffb08b 100644 --- a/ppapi/cpp/dev/font_dev.h +++ b/ppapi/cpp/dev/font_dev.h @@ -104,7 +104,7 @@ class Font_Dev : public Resource { Font_Dev(); explicit Font_Dev(PP_Resource resource); - explicit Font_Dev(Instance* instance, const FontDescription_Dev& description); + Font_Dev(Instance* instance, const FontDescription_Dev& description); Font_Dev(const Font_Dev& other); Font_Dev& operator=(const Font_Dev& other); diff --git a/ppapi/tests/test_transport.cc b/ppapi/tests/test_transport.cc index d45112a..1295f75 100644 --- a/ppapi/tests/test_transport.cc +++ b/ppapi/tests/test_transport.cc @@ -34,9 +34,9 @@ const int kReadBufferSize = 65536; class StreamReader { public: - explicit StreamReader(pp::Transport_Dev* transport, - int expected_size, - pp::CompletionCallback done_callback) + StreamReader(pp::Transport_Dev* transport, + int expected_size, + pp::CompletionCallback done_callback) : expected_size_(expected_size), done_callback_(done_callback), ALLOW_THIS_IN_INITIALIZER_LIST(callback_factory_(this)), diff --git a/remoting/client/plugin/chromoting_scriptable_object.h b/remoting/client/plugin/chromoting_scriptable_object.h index e6894f2..5a5127a 100644 --- a/remoting/client/plugin/chromoting_scriptable_object.h +++ b/remoting/client/plugin/chromoting_scriptable_object.h @@ -182,11 +182,11 @@ class ChromotingScriptableObject typedef pp::Var (ChromotingScriptableObject::*MethodHandler)( const std::vector<pp::Var>& args, pp::Var* exception); struct PropertyDescriptor { - explicit PropertyDescriptor(const std::string& n, pp::Var a) + PropertyDescriptor(const std::string& n, pp::Var a) : type(NONE), name(n), attribute(a), method(NULL) { } - explicit PropertyDescriptor(const std::string& n, MethodHandler m) + PropertyDescriptor(const std::string& n, MethodHandler m) : type(NONE), name(n), method(m) { } diff --git a/remoting/protocol/content_description.h b/remoting/protocol/content_description.h index f4cb97b..678da31 100644 --- a/remoting/protocol/content_description.h +++ b/remoting/protocol/content_description.h @@ -26,10 +26,10 @@ namespace protocol { // interface does not need to depend on libjingle. class ContentDescription : public cricket::ContentDescription { public: - explicit ContentDescription(const CandidateSessionConfig* config, - const std::string& auth_token, - const std::string& master_key, - const std::string& certificate); + ContentDescription(const CandidateSessionConfig* config, + const std::string& auth_token, + const std::string& master_key, + const std::string& certificate); virtual ~ContentDescription(); const CandidateSessionConfig* config() const { diff --git a/sandbox/src/crosscall_params.h b/sandbox/src/crosscall_params.h index 4c1e4fe..800c8e9 100644 --- a/sandbox/src/crosscall_params.h +++ b/sandbox/src/crosscall_params.h @@ -144,7 +144,7 @@ class CrossCallParams { protected: // constructs the IPC call params. Called only from the derived classes - explicit CrossCallParams(uint32 tag, size_t params_count) + CrossCallParams(uint32 tag, size_t params_count) : tag_(tag), params_count_(params_count), is_in_out_(0) { diff --git a/skia/ext/vector_platform_device_cairo_linux.h b/skia/ext/vector_platform_device_cairo_linux.h index ff6a2df..72a90f6 100644 --- a/skia/ext/vector_platform_device_cairo_linux.h +++ b/skia/ext/vector_platform_device_cairo_linux.h @@ -73,8 +73,7 @@ class SK_API VectorPlatformDeviceCairo : public PlatformDevice { virtual PlatformSurface BeginPlatformPaint(); protected: - explicit VectorPlatformDeviceCairo(PlatformSurface context, - const SkBitmap& bitmap); + VectorPlatformDeviceCairo(PlatformSurface context, const SkBitmap& bitmap); virtual SkDevice* onCreateCompatibleDevice(SkBitmap::Config, int width, int height, bool isOpaque, diff --git a/tools/traceline/traceline/assembler.h b/tools/traceline/traceline/assembler.h index 232fb36..6ae6958 100644 --- a/tools/traceline/traceline/assembler.h +++ b/tools/traceline/traceline/assembler.h @@ -175,22 +175,17 @@ class Operand { } // [base + disp/r] - explicit Operand(Register base, int disp) { + Operand(Register base, int disp) { Init(base, disp); } // [base + index*scale + disp/r] - explicit Operand(Register base, - Register index, - ScaleFactor scale, - int disp) { + Operand(Register base, Register index, ScaleFactor scale, int disp) { Init(base, index, scale, disp); } // [index*scale + disp/r] - explicit Operand(Register index, - ScaleFactor scale, - int disp) { + Operand(Register index, ScaleFactor scale, int disp) { Init(index, scale, disp); } diff --git a/ui/gfx/gl/gl_surface_egl.h b/ui/gfx/gl/gl_surface_egl.h index 19e7f4f..1b03a75 100644 --- a/ui/gfx/gl/gl_surface_egl.h +++ b/ui/gfx/gl/gl_surface_egl.h @@ -49,8 +49,7 @@ protected: // Encapsulates an EGL surface bound to a view. class NativeViewGLSurfaceEGL : public GLSurfaceEGL { public: - explicit NativeViewGLSurfaceEGL(bool software, - gfx::PluginWindowHandle window); + NativeViewGLSurfaceEGL(bool software, gfx::PluginWindowHandle window); virtual ~NativeViewGLSurfaceEGL(); // Implement GLSurface. @@ -71,7 +70,7 @@ class NativeViewGLSurfaceEGL : public GLSurfaceEGL { // Encapsulates a pbuffer EGL surface. class PbufferGLSurfaceEGL : public GLSurfaceEGL { public: - explicit PbufferGLSurfaceEGL(bool software, const gfx::Size& size); + PbufferGLSurfaceEGL(bool software, const gfx::Size& size); virtual ~PbufferGLSurfaceEGL(); // Implement GLSurface. diff --git a/ui/gfx/gl/gl_surface_osmesa.h b/ui/gfx/gl/gl_surface_osmesa.h index 2ea9c88..974c322 100644 --- a/ui/gfx/gl/gl_surface_osmesa.h +++ b/ui/gfx/gl/gl_surface_osmesa.h @@ -17,7 +17,7 @@ namespace gfx { // surfaces can be resized and resizing preserves the contents. class GLSurfaceOSMesa : public GLSurface { public: - explicit GLSurfaceOSMesa(unsigned format, const gfx::Size& size); + GLSurfaceOSMesa(unsigned format, const gfx::Size& size); virtual ~GLSurfaceOSMesa(); // Resize the back buffer, preserving the old content. Does nothing if the diff --git a/views/controls/menu/menu_scroll_view_container.cc b/views/controls/menu/menu_scroll_view_container.cc index 5f1b94e..1d3fcdd 100644 --- a/views/controls/menu/menu_scroll_view_container.cc +++ b/views/controls/menu/menu_scroll_view_container.cc @@ -42,7 +42,7 @@ namespace { class MenuScrollButton : public View { public: - explicit MenuScrollButton(SubmenuView* host, bool is_up) + MenuScrollButton(SubmenuView* host, bool is_up) : host_(host), is_up_(is_up), // Make our height the same as that of other MenuItemViews. diff --git a/views/widget/drop_target_gtk.h b/views/widget/drop_target_gtk.h index bc2c3ca..daa08f2 100644 --- a/views/widget/drop_target_gtk.h +++ b/views/widget/drop_target_gtk.h @@ -39,8 +39,7 @@ class RootView; // which results in deleting the DropTargetGtk. class DropTargetGtk { public: - explicit DropTargetGtk(internal::RootView* root_view, - GdkDragContext* context); + DropTargetGtk(internal::RootView* root_view, GdkDragContext* context); ~DropTargetGtk(); // If a drag and drop is underway and |view| is the current drop target, the diff --git a/webkit/appcache/appcache_update_job_unittest.cc b/webkit/appcache/appcache_update_job_unittest.cc index 44f347d..9dd1848 100644 --- a/webkit/appcache/appcache_update_job_unittest.cc +++ b/webkit/appcache/appcache_update_job_unittest.cc @@ -411,9 +411,9 @@ class RetryRequestTestJob : public net::URLRequestTestJob { "http://retry\r"); // must be same as kRetryUrl } - explicit RetryRequestTestJob(net::URLRequest* request, - const std::string& headers, - int response_code) + RetryRequestTestJob(net::URLRequest* request, + const std::string& headers, + int response_code) : net::URLRequestTestJob(request, headers, data(), true), response_code_(response_code) { } diff --git a/webkit/tools/test_shell/simple_file_writer.cc b/webkit/tools/test_shell/simple_file_writer.cc index 657d247..83bc59f 100644 --- a/webkit/tools/test_shell/simple_file_writer.cc +++ b/webkit/tools/test_shell/simple_file_writer.cc @@ -31,8 +31,8 @@ net::URLRequestContext* SimpleFileWriter::request_context_ = NULL; class SimpleFileWriter::IOThreadProxy : public base::RefCountedThreadSafe<SimpleFileWriter::IOThreadProxy> { public: - explicit IOThreadProxy(const base::WeakPtr<SimpleFileWriter>& simple_writer, - FileSystemContext* file_system_context) + IOThreadProxy(const base::WeakPtr<SimpleFileWriter>& simple_writer, + FileSystemContext* file_system_context) : simple_writer_(simple_writer), operation_(NULL), file_system_context_(file_system_context) { |