summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp6
-rw-r--r--third_party/WebKit/Source/core/editing/commands/EditingState.cpp2
-rw-r--r--third_party/WebKit/Source/wtf/Assertions.h7
3 files changed, 6 insertions, 9 deletions
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp b/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp
index 9ea0dc5..c510a12 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp
@@ -41,17 +41,17 @@ NoExceptionStateAssertionChecker::NoExceptionStateAssertionChecker(const char* f
void NoExceptionStateAssertionChecker::throwDOMException(const ExceptionCode&, const String&)
{
- ASSERT_AT(false, m_file, m_line, "");
+ DCHECK_AT(false, m_file, m_line) << "DOMExeption should not be thrown.";
}
void NoExceptionStateAssertionChecker::throwTypeError(const String&)
{
- ASSERT_AT(false, m_file, m_line, "");
+ DCHECK_AT(false, m_file, m_line) << "TypeError should not be thrown.";
}
void NoExceptionStateAssertionChecker::throwSecurityError(const String&, const String&)
{
- ASSERT_AT(false, m_file, m_line, "");
+ DCHECK_AT(false, m_file, m_line) << "SecurityError should not be thrown.";
}
#endif
diff --git a/third_party/WebKit/Source/core/editing/commands/EditingState.cpp b/third_party/WebKit/Source/core/editing/commands/EditingState.cpp
index 03da028..f734bee 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditingState.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditingState.cpp
@@ -38,7 +38,7 @@ NoEditingAbortChecker::NoEditingAbortChecker(const char* file, int line)
NoEditingAbortChecker::~NoEditingAbortChecker()
{
- ASSERT_AT(!m_editingState.isAborted(), m_file, m_line, "");
+ DCHECK_AT(!m_editingState.isAborted(), m_file, m_line) << "The operation should not have been aborted.";
}
#endif
diff --git a/third_party/WebKit/Source/wtf/Assertions.h b/third_party/WebKit/Source/wtf/Assertions.h
index 7446b57..fa5dcaf 100644
--- a/third_party/WebKit/Source/wtf/Assertions.h
+++ b/third_party/WebKit/Source/wtf/Assertions.h
@@ -146,10 +146,7 @@ WTF_EXPORT void WTFPrintBacktrace(void** stack, int size);
CRASH()) : \
(void)0)
-#define ASSERT_AT(assertion, file, line, function) \
- (!(assertion) ? \
- (WTFReportAssertionFailure(file, line, function, #assertion), CRASH()) : \
- (void)0)
+#define DCHECK_AT(assertion, file, line) LAZY_STREAM(logging::LogMessage(file, line, #assertion).stream(), !(assertion))
#define ASSERT_NOT_REACHED() do { \
WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, 0); \
@@ -163,7 +160,7 @@ WTF_EXPORT void WTFPrintBacktrace(void** stack, int size);
#else
#define ASSERT(assertion) ((void)0)
-#define ASSERT_AT(assertion, file, line, function) ((void)0)
+#define DCHECK_AT(assertion, file, line) EAT_STREAM_PARAMETERS
#define ASSERT_NOT_REACHED() ((void)0)
#define NO_RETURN_DUE_TO_ASSERT