diff options
| -rw-r--r-- | base/sys_info_android.cc | 6 | ||||
| -rw-r--r-- | base/sys_info_chromeos.cc | 5 | ||||
| -rw-r--r-- | base/sys_info_freebsd.cc | 4 | ||||
| -rw-r--r-- | base/sys_info_ios.mm | 6 | ||||
| -rw-r--r-- | base/sys_info_linux.cc | 7 | ||||
| -rw-r--r-- | base/sys_info_mac.cc | 5 | ||||
| -rw-r--r-- | base/sys_info_openbsd.cc | 4 | ||||
| -rw-r--r-- | base/sys_info_posix.cc | 4 | ||||
| -rw-r--r-- | components/metrics/proto/system_profile.proto | 2 |
9 files changed, 38 insertions, 5 deletions
diff --git a/base/sys_info_android.cc b/base/sys_info_android.cc index 245097f..0f2abc5 100644 --- a/base/sys_info_android.cc +++ b/base/sys_info_android.cc @@ -155,6 +155,12 @@ int GetDalvikHeapGrowthLimitMB() { namespace base { +bool SysInfo::HasSeekPenalty(const FilePath& path, bool* has_seek_penalty) { + // Find a case where this is incorrect and dbeam@ will buy you a beer. + *has_seek_penalty = false; + return true; +} + std::string SysInfo::OperatingSystemName() { return "Android"; } diff --git a/base/sys_info_chromeos.cc b/base/sys_info_chromeos.cc index ef5f1fe..2a5f5d7 100644 --- a/base/sys_info_chromeos.cc +++ b/base/sys_info_chromeos.cc @@ -169,6 +169,11 @@ ChromeOSVersionInfo& GetChromeOSVersionInfo() { } // namespace +bool SysInfo::HasSeekPenalty(const FilePath& path, bool* has_seek_penalty) { + // TODO(dbeam): implement. Can we just use boards/models? + return false; +} + // static void SysInfo::OperatingSystemVersionNumbers(int32* major_version, int32* minor_version, diff --git a/base/sys_info_freebsd.cc b/base/sys_info_freebsd.cc index 832b3598..338f1cd 100644 --- a/base/sys_info_freebsd.cc +++ b/base/sys_info_freebsd.cc @@ -22,6 +22,10 @@ int64 SysInfo::AmountOfPhysicalMemory() { return static_cast<int64>(pages) * page_size; } +bool SysInfo::HasSeekPenalty(const FilePath& path, bool* has_seek_penalty) { + return false; +} + // static size_t SysInfo::MaxSharedMemorySize() { size_t limit; diff --git a/base/sys_info_ios.mm b/base/sys_info_ios.mm index 49d618c..324bef6 100644 --- a/base/sys_info_ios.mm +++ b/base/sys_info_ios.mm @@ -16,6 +16,12 @@ namespace base { +bool SysInfo::HasSeekPenalty(const FilePath& path, bool* has_seek_penalty) { + // Find a case where this is incorrect and dbeam@ will buy you a beer. + *has_seek_penalty = false; + return true; +} + // static std::string SysInfo::OperatingSystemName() { static dispatch_once_t get_system_name_once; diff --git a/base/sys_info_linux.cc b/base/sys_info_linux.cc index c698f91..401d55c 100644 --- a/base/sys_info_linux.cc +++ b/base/sys_info_linux.cc @@ -68,6 +68,13 @@ int64 SysInfo::AmountOfPhysicalMemory() { return g_lazy_physical_memory.Get().value(); } +#if !defined(OS_CHROMEOS) && !defined(OS_ANDROID) +bool SysInfo::HasSeekPenalty(const FilePath& path, bool* has_seek_penalty) { + // TODO(dbeam): implement. + return false; +} +#endif + // static size_t SysInfo::MaxSharedMemorySize() { return g_lazy_max_shared_memory.Get().value(); diff --git a/base/sys_info_mac.cc b/base/sys_info_mac.cc index 18df624..8635088 100644 --- a/base/sys_info_mac.cc +++ b/base/sys_info_mac.cc @@ -76,6 +76,11 @@ int64 SysInfo::AmountOfAvailablePhysicalMemory() { vm_info.free_count - vm_info.speculative_count) * PAGE_SIZE; } +bool SysInfo::HasSeekPenalty(const FilePath& path, bool* has_seek_penalty) { + // TODO(dbeam): implement. + return false; +} + // static std::string SysInfo::CPUModelName() { char name[256]; diff --git a/base/sys_info_openbsd.cc b/base/sys_info_openbsd.cc index edbb2c9..68d2ea14 100644 --- a/base/sys_info_openbsd.cc +++ b/base/sys_info_openbsd.cc @@ -48,6 +48,10 @@ int64 SysInfo::AmountOfAvailablePhysicalMemory() { return AmountOfMemory(_SC_AVPHYS_PAGES); } +bool SysInfo::HasSeekPenalty(const FilePath& path, bool* has_seek_penalty) { + return false; +} + // static size_t SysInfo::MaxSharedMemorySize() { int mib[] = { CTL_KERN, KERN_SHMINFO, KERN_SHMINFO_SHMMAX }; diff --git a/base/sys_info_posix.cc b/base/sys_info_posix.cc index cdb95d7..3d49bf9 100644 --- a/base/sys_info_posix.cc +++ b/base/sys_info_posix.cc @@ -96,10 +96,6 @@ int64 SysInfo::AmountOfFreeDiskSpace(const FilePath& path) { return static_cast<int64>(stats.f_bavail) * stats.f_frsize; } -bool SysInfo::HasSeekPenalty(const FilePath& path, bool* has_seek_penalty) { - return false; -} - #if !defined(OS_MACOSX) && !defined(OS_ANDROID) // static std::string SysInfo::OperatingSystemName() { diff --git a/components/metrics/proto/system_profile.proto b/components/metrics/proto/system_profile.proto index a9bdc1d..e76989c 100644 --- a/components/metrics/proto/system_profile.proto +++ b/components/metrics/proto/system_profile.proto @@ -255,7 +255,7 @@ message SystemProfileProto { // Logged on ChromeOS only. repeated TouchScreen external_touchscreen = 15; - // Drive messages are logged on Windows 7+ only for now. + // Drive messages are currently logged on Windows 7+, iOS, and Android. message Drive { // Whether this drive incurs a time penalty when randomly accessed. This // should be true for spinning disks but false for SSDs or other |