summaryrefslogtreecommitdiffstats
path: root/base
diff options
context:
space:
mode:
Diffstat (limited to 'base')
-rw-r--r--base/values.cc15
-rw-r--r--base/values.h9
2 files changed, 20 insertions, 4 deletions
diff --git a/base/values.cc b/base/values.cc
index 3b5bd38..716fdf3 100644
--- a/base/values.cc
+++ b/base/values.cc
@@ -610,13 +610,15 @@ bool ListValue::Remove(size_t index, Value** out_value) {
return true;
}
-void ListValue::Remove(const Value& value) {
+int ListValue::Remove(const Value& value) {
for (ValueVector::iterator i(list_.begin()); i != list_.end(); ++i) {
if ((*i)->Equals(&value)) {
+ size_t index = i - list_.begin();
list_.erase(i);
- break;
+ return index;
}
}
+ return -1;
}
void ListValue::Append(Value* in_value) {
@@ -624,6 +626,15 @@ void ListValue::Append(Value* in_value) {
list_.push_back(in_value);
}
+bool ListValue::Insert(size_t index, Value* in_value) {
+ DCHECK(in_value);
+ if (index < 0 || index > list_.size())
+ return false;
+
+ list_.insert(list_.begin() + index, in_value);
+ return true;
+}
+
Value* ListValue::DeepCopy() const {
ListValue* result = new ListValue;
diff --git a/base/values.h b/base/values.h
index cd68b10..482ffa0 100644
--- a/base/values.h
+++ b/base/values.h
@@ -334,12 +334,17 @@ class ListValue : public Value {
// it will return false and the ListValue object will be unchanged.
bool Remove(size_t index, Value** out_value);
- // Removes the first instance of |value| found in the list, if any.
- void Remove(const Value& value);
+ // Removes the first instance of |value| found in the list, if any, returning
+ // the index that it was located at (-1 for not present).
+ int Remove(const Value& value);
// Appends a Value to the end of the list.
void Append(Value* in_value);
+ // Insert a Value at index.
+ // Returns true if successful, or false if the index was out of range.
+ bool Insert(size_t index, Value* in_value);
+
// Iteration
typedef ValueVector::iterator iterator;
typedef ValueVector::const_iterator const_iterator;