diff options
Diffstat (limited to 'chrome/browser/automation')
4 files changed, 11 insertions, 4 deletions
diff --git a/chrome/browser/automation/automation_provider_observers.cc b/chrome/browser/automation/automation_provider_observers.cc index d836bee..b98d78c 100644 --- a/chrome/browser/automation/automation_provider_observers.cc +++ b/chrome/browser/automation/automation_provider_observers.cc @@ -973,6 +973,8 @@ MetricEventDurationObserver::MetricEventDurationObserver() { NotificationService::AllSources()); } +MetricEventDurationObserver::~MetricEventDurationObserver() {} + int MetricEventDurationObserver::GetEventDurationMs( const std::string& event_name) { EventDurationMap::const_iterator it = durations_.find(event_name); @@ -1002,6 +1004,8 @@ PageTranslatedObserver::PageTranslatedObserver(AutomationProvider* automation, Source<TabContents>(tab_contents)); } +PageTranslatedObserver::~PageTranslatedObserver() {} + void PageTranslatedObserver::Observe(NotificationType type, const NotificationSource& source, const NotificationDetails& details) { diff --git a/chrome/browser/automation/automation_provider_observers.h b/chrome/browser/automation/automation_provider_observers.h index 8706d85..5c7b77b 100644 --- a/chrome/browser/automation/automation_provider_observers.h +++ b/chrome/browser/automation/automation_provider_observers.h @@ -508,6 +508,7 @@ class DocumentPrintedNotificationObserver : public NotificationObserver { class MetricEventDurationObserver : public NotificationObserver { public: MetricEventDurationObserver(); + virtual ~MetricEventDurationObserver(); // Get the duration of an event. Returns -1 if we haven't seen the event. int GetEventDurationMs(const std::string& event_name); @@ -530,6 +531,7 @@ class PageTranslatedObserver : public NotificationObserver { PageTranslatedObserver(AutomationProvider* automation, IPC::Message* reply_message, TabContents* tab_contents); + virtual ~PageTranslatedObserver(); // NotificationObserver interface. virtual void Observe(NotificationType type, diff --git a/chrome/browser/automation/automation_resource_message_filter.cc b/chrome/browser/automation/automation_resource_message_filter.cc index abdf099..9cb0ecd3 100644 --- a/chrome/browser/automation/automation_resource_message_filter.cc +++ b/chrome/browser/automation/automation_resource_message_filter.cc @@ -82,6 +82,10 @@ class AutomationCookieStore : public net::CookieStore { DISALLOW_COPY_AND_ASSIGN(AutomationCookieStore); }; +struct AutomationResourceMessageFilter::CookieCompletionInfo { + net::CompletionCallback* completion_callback; + scoped_refptr<net::CookieStore> cookie_store; +}; AutomationResourceMessageFilter::AutomationResourceMessageFilter() : channel_(NULL) { diff --git a/chrome/browser/automation/automation_resource_message_filter.h b/chrome/browser/automation/automation_resource_message_filter.h index c245f280..a30825f 100644 --- a/chrome/browser/automation/automation_resource_message_filter.h +++ b/chrome/browser/automation/automation_resource_message_filter.h @@ -203,10 +203,7 @@ class AutomationResourceMessageFilter // Contains information used for completing the request to read cookies from // the host coming in from the renderer. - struct CookieCompletionInfo { - net::CompletionCallback* completion_callback; - scoped_refptr<net::CookieStore> cookie_store; - }; + struct CookieCompletionInfo; // Map of completion callback id to CookieCompletionInfo, which contains the // actual callback which is invoked on successful retrieval of cookies from |