summaryrefslogtreecommitdiffstats
path: root/chrome/browser/enumerate_modules_model_win.cc
diff options
context:
space:
mode:
Diffstat (limited to 'chrome/browser/enumerate_modules_model_win.cc')
-rw-r--r--chrome/browser/enumerate_modules_model_win.cc31
1 files changed, 20 insertions, 11 deletions
diff --git a/chrome/browser/enumerate_modules_model_win.cc b/chrome/browser/enumerate_modules_model_win.cc
index ead91ea..f7f7f99 100644
--- a/chrome/browser/enumerate_modules_model_win.cc
+++ b/chrome/browser/enumerate_modules_model_win.cc
@@ -842,19 +842,28 @@ void EnumerateModulesModel::DoneScanning() {
HISTOGRAM_COUNTS_100("Conflicts.ConfirmedBadModules",
confirmed_bad_modules_detected_);
- if (!limited_mode_) {
+ // Notifications are not available in limited mode.
+ if (limited_mode_)
+ return;
+
+ NotificationService::current()->Notify(
+ NotificationType::MODULE_LIST_ENUMERATED,
+ Source<EnumerateModulesModel>(this),
+ NotificationService::NoDetails());
+
+ // Command line flag must be enabled for the notification to get sent out.
+ // Otherwise we'd get the badge (while the feature is disabled) when we
+ // navigate to about:conflicts and find confirmed matches.
+ const CommandLine& cmd_line = *CommandLine::ForCurrentProcess();
+ if (!cmd_line.HasSwitch(switches::kConflictingModulesCheck))
+ return;
+
+ if (suspected_bad_modules_detected_ || confirmed_bad_modules_detected_) {
+ bool found_confirmed_bad_modules = confirmed_bad_modules_detected_ > 0;
NotificationService::current()->Notify(
- NotificationType::MODULE_LIST_ENUMERATED,
+ NotificationType::MODULE_INCOMPATIBILITY_DETECTED,
Source<EnumerateModulesModel>(this),
- NotificationService::NoDetails());
-
- if (suspected_bad_modules_detected_ || confirmed_bad_modules_detected_) {
- bool found_confirmed_bad_modules = confirmed_bad_modules_detected_ > 0;
- NotificationService::current()->Notify(
- NotificationType::MODULE_INCOMPATIBILITY_DETECTED,
- Source<EnumerateModulesModel>(this),
- Details<bool>(&found_confirmed_bad_modules));
- }
+ Details<bool>(&found_confirmed_bad_modules));
}
}