diff options
Diffstat (limited to 'chrome/browser/extensions/image_loading_tracker.cc')
-rw-r--r-- | chrome/browser/extensions/image_loading_tracker.cc | 30 |
1 files changed, 12 insertions, 18 deletions
diff --git a/chrome/browser/extensions/image_loading_tracker.cc b/chrome/browser/extensions/image_loading_tracker.cc index 5be22d8..ea174ff 100644 --- a/chrome/browser/extensions/image_loading_tracker.cc +++ b/chrome/browser/extensions/image_loading_tracker.cc @@ -14,8 +14,6 @@ #include "third_party/skia/include/core/SkBitmap.h" #include "webkit/glue/image_decoder.h" -ImageLoadingTracker::Observer::~Observer() {} - //////////////////////////////////////////////////////////////////////////////// // ImageLoadingTracker::ImageLoader @@ -56,7 +54,7 @@ class ImageLoadingTracker::ImageLoader std::string file_contents; FilePath path = resource.GetFilePath(); if (path.empty() || !file_util::ReadFileToString(path, &file_contents)) { - ReportBack(NULL, resource, gfx::Size(), id); + ReportBack(NULL, resource, id); return; } @@ -67,12 +65,10 @@ class ImageLoadingTracker::ImageLoader scoped_ptr<SkBitmap> decoded(new SkBitmap()); *decoded = decoder.Decode(data, file_contents.length()); if (decoded->empty()) { - ReportBack(NULL, resource, gfx::Size(), id); + ReportBack(NULL, resource, id); return; // Unable to decode. } - gfx::Size original_size(decoded->width(), decoded->height()); - if (decoded->width() > max_size.width() || decoded->height() > max_size.height()) { // The bitmap is too big, re-sample. @@ -81,25 +77,25 @@ class ImageLoadingTracker::ImageLoader max_size.width(), max_size.height()); } - ReportBack(decoded.release(), resource, original_size, id); + ReportBack(decoded.release(), resource, id); } void ReportBack(SkBitmap* image, const ExtensionResource& resource, - const gfx::Size& original_size, int id) { + int id) { DCHECK(ChromeThread::CurrentlyOn(ChromeThread::FILE)); ChromeThread::PostTask( callback_thread_id_, FROM_HERE, NewRunnableMethod(this, &ImageLoader::ReportOnUIThread, - image, resource, original_size, id)); + image, resource, id)); } void ReportOnUIThread(SkBitmap* image, ExtensionResource resource, - const gfx::Size& original_size, int id) { + int id) { DCHECK(!ChromeThread::CurrentlyOn(ChromeThread::FILE)); if (tracker_) - tracker_->OnImageLoaded(image, resource, original_size, id); + tracker_->OnImageLoaded(image, resource, id); delete image; } @@ -142,16 +138,16 @@ void ImageLoadingTracker::LoadImage(Extension* extension, // back. int id = next_id_++; if (resource.relative_path().empty()) { - OnImageLoaded(NULL, resource, max_size, id); + OnImageLoaded(NULL, resource, id); return; } DCHECK(extension->path() == resource.extension_root()); // See if the extension has the image already. - if (extension->HasCachedImage(resource, max_size)) { - SkBitmap image = extension->GetCachedImage(resource, max_size); - OnImageLoaded(&image, resource, max_size, id); + if (extension->HasCachedImage(resource)) { + SkBitmap image = extension->GetCachedImage(resource); + OnImageLoaded(&image, resource, id); return; } @@ -169,12 +165,10 @@ void ImageLoadingTracker::LoadImage(Extension* extension, void ImageLoadingTracker::OnImageLoaded( SkBitmap* image, const ExtensionResource& resource, - const gfx::Size& original_size, int id) { LoadMap::iterator i = load_map_.find(id); if (i != load_map_.end()) { - i->second->SetCachedImage(resource, image ? *image : SkBitmap(), - original_size); + i->second->SetCachedImage(resource, image ? *image : SkBitmap()); load_map_.erase(i); } |