summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
diff options
context:
space:
mode:
Diffstat (limited to 'chrome/browser/extensions')
-rw-r--r--chrome/browser/extensions/extensions_service.cc1
-rw-r--r--chrome/browser/extensions/extensions_service.h4
-rw-r--r--chrome/browser/extensions/extensions_service_unittest.cc6
3 files changed, 8 insertions, 3 deletions
diff --git a/chrome/browser/extensions/extensions_service.cc b/chrome/browser/extensions/extensions_service.cc
index 37685e8..79810c0 100644
--- a/chrome/browser/extensions/extensions_service.cc
+++ b/chrome/browser/extensions/extensions_service.cc
@@ -805,7 +805,6 @@ void ExtensionsService::ClearExtensionData(const GURL& extension_url) {
void ExtensionsService::EnableExtension(const std::string& extension_id) {
Extension* extension = GetExtensionByIdInternal(extension_id, false, true);
if (!extension) {
- NOTREACHED() << "Trying to enable an extension that isn't disabled.";
return;
}
diff --git a/chrome/browser/extensions/extensions_service.h b/chrome/browser/extensions/extensions_service.h
index 4efa84a..211bc8de 100644
--- a/chrome/browser/extensions/extensions_service.h
+++ b/chrome/browser/extensions/extensions_service.h
@@ -242,8 +242,8 @@ class ExtensionsService
void UninstallExtension(const std::string& extension_id,
bool external_uninstall);
- // Enable or disable an extension. The extension must be in the opposite state
- // before calling.
+ // Enable or disable an extension. No action if the extension is already
+ // enabled/disabled.
void EnableExtension(const std::string& extension_id);
void DisableExtension(const std::string& extension_id);
diff --git a/chrome/browser/extensions/extensions_service_unittest.cc b/chrome/browser/extensions/extensions_service_unittest.cc
index ee4d7a9..281e9cb 100644
--- a/chrome/browser/extensions/extensions_service_unittest.cc
+++ b/chrome/browser/extensions/extensions_service_unittest.cc
@@ -302,6 +302,12 @@ void ExtensionsServiceTestBase::InitializeExtensionsService(
browser::RegisterUserPrefs(prefs_.get());
profile_.reset(profile);
+ // TODO(scherkus): Remove this when we no longer need to have Talk
+ // component extension state as a preference http://crbug.com/56429
+ DictionaryValue* dict =
+ prefs_->GetMutableDictionary("extensions.settings");
+ dict->Remove("ggnioahjipcehijkhpdjekioddnjoben", NULL);
+
service_ = new ExtensionsService(profile_.get(),
CommandLine::ForCurrentProcess(),
prefs_.get(),