summaryrefslogtreecommitdiffstats
path: root/chrome/browser/prefs
diff options
context:
space:
mode:
Diffstat (limited to 'chrome/browser/prefs')
-rw-r--r--chrome/browser/prefs/command_line_pref_store.cc4
-rw-r--r--chrome/browser/prefs/command_line_pref_store.h4
-rw-r--r--chrome/browser/prefs/pref_set_observer.cc2
-rw-r--r--chrome/browser/prefs/pref_set_observer.h2
4 files changed, 9 insertions, 3 deletions
diff --git a/chrome/browser/prefs/command_line_pref_store.cc b/chrome/browser/prefs/command_line_pref_store.cc
index 3331ed5b..8d398b6 100644
--- a/chrome/browser/prefs/command_line_pref_store.cc
+++ b/chrome/browser/prefs/command_line_pref_store.cc
@@ -28,12 +28,16 @@ CommandLinePrefStore::CommandLinePrefStore(const CommandLine* command_line)
: command_line_(command_line),
prefs_(new DictionaryValue()) {}
+CommandLinePrefStore::~CommandLinePrefStore() {}
+
PrefStore::PrefReadError CommandLinePrefStore::ReadPrefs() {
ApplySimpleSwitches();
ValidateProxySwitches();
return PrefStore::PREF_READ_ERROR_NONE;
}
+DictionaryValue* CommandLinePrefStore::prefs() { return prefs_.get(); }
+
void CommandLinePrefStore::ApplySimpleSwitches() {
// Look for each switch we know about and set its preference accordingly.
for (size_t i = 0; i < arraysize(string_switch_map_); ++i) {
diff --git a/chrome/browser/prefs/command_line_pref_store.h b/chrome/browser/prefs/command_line_pref_store.h
index 89e49ce..8dd7cd5 100644
--- a/chrome/browser/prefs/command_line_pref_store.h
+++ b/chrome/browser/prefs/command_line_pref_store.h
@@ -18,11 +18,11 @@ class DictionaryValue;
class CommandLinePrefStore : public PrefStore {
public:
explicit CommandLinePrefStore(const CommandLine* command_line);
- virtual ~CommandLinePrefStore() {}
+ virtual ~CommandLinePrefStore();
// PrefStore methods:
virtual PrefReadError ReadPrefs();
- virtual DictionaryValue* prefs() { return prefs_.get(); }
+ virtual DictionaryValue* prefs();
protected:
// Logs a message and returns false if the proxy switches are
diff --git a/chrome/browser/prefs/pref_set_observer.cc b/chrome/browser/prefs/pref_set_observer.cc
index 70810c6..a073eb2 100644
--- a/chrome/browser/prefs/pref_set_observer.cc
+++ b/chrome/browser/prefs/pref_set_observer.cc
@@ -14,6 +14,8 @@ PrefSetObserver::PrefSetObserver(PrefService* pref_service,
registrar_.Init(pref_service);
}
+PrefSetObserver::~PrefSetObserver() {}
+
void PrefSetObserver::AddPref(const std::string& pref) {
if (!prefs_.count(pref) && pref_service_->FindPreference(pref.c_str())) {
prefs_.insert(pref);
diff --git a/chrome/browser/prefs/pref_set_observer.h b/chrome/browser/prefs/pref_set_observer.h
index ff350df..568265c 100644
--- a/chrome/browser/prefs/pref_set_observer.h
+++ b/chrome/browser/prefs/pref_set_observer.h
@@ -20,7 +20,7 @@ class PrefSetObserver : public NotificationObserver {
// Initialize with an empty set of preferences.
PrefSetObserver(PrefService* pref_service,
NotificationObserver* observer);
- virtual ~PrefSetObserver() {}
+ virtual ~PrefSetObserver();
// Add a |pref| to the set of preferences to observe.
void AddPref(const std::string& pref);