diff options
Diffstat (limited to 'chrome/browser/sync/internal_api/syncapi_unittest.cc')
| -rw-r--r-- | chrome/browser/sync/internal_api/syncapi_unittest.cc | 2519 |
1 files changed, 0 insertions, 2519 deletions
diff --git a/chrome/browser/sync/internal_api/syncapi_unittest.cc b/chrome/browser/sync/internal_api/syncapi_unittest.cc deleted file mode 100644 index 2464dcb..0000000 --- a/chrome/browser/sync/internal_api/syncapi_unittest.cc +++ /dev/null @@ -1,2519 +0,0 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -// Unit tests for the SyncApi. Note that a lot of the underlying -// functionality is provided by the Syncable layer, which has its own -// unit tests. We'll test SyncApi specific things in this harness. - -#include <cstddef> -#include <map> - -#include "base/basictypes.h" -#include "base/callback.h" -#include "base/compiler_specific.h" -#include "base/format_macros.h" -#include "base/location.h" -#include "base/memory/scoped_ptr.h" -#include "base/message_loop.h" -#include "base/message_loop_proxy.h" -#include "base/scoped_temp_dir.h" -#include "base/string_number_conversions.h" -#include "base/stringprintf.h" -#include "base/test/values_test_util.h" -#include "base/utf_string_conversions.h" -#include "base/values.h" -#include "chrome/browser/sync/internal_api/change_record.h" -#include "chrome/browser/sync/internal_api/http_post_provider_factory.h" -#include "chrome/browser/sync/internal_api/http_post_provider_interface.h" -#include "chrome/browser/sync/internal_api/read_node.h" -#include "chrome/browser/sync/internal_api/read_transaction.h" -#include "chrome/browser/sync/internal_api/sync_manager.h" -#include "chrome/browser/sync/internal_api/syncapi_internal.h" -#include "chrome/browser/sync/internal_api/write_node.h" -#include "chrome/browser/sync/internal_api/write_transaction.h" -#include "chrome/browser/sync/test/engine/test_user_share.h" -#include "sync/engine/model_safe_worker.h" -#include "sync/engine/nigori_util.h" -#include "sync/engine/polling_constants.h" -#include "sync/js/js_arg_list.h" -#include "sync/js/js_backend.h" -#include "sync/js/js_event_handler.h" -#include "sync/js/js_reply_handler.h" -#include "sync/js/js_test_util.h" -#include "sync/notifier/sync_notifier.h" -#include "sync/notifier/sync_notifier_observer.h" -#include "sync/protocol/bookmark_specifics.pb.h" -#include "sync/protocol/encryption.pb.h" -#include "sync/protocol/extension_specifics.pb.h" -#include "sync/protocol/password_specifics.pb.h" -#include "sync/protocol/preference_specifics.pb.h" -#include "sync/protocol/proto_value_conversions.h" -#include "sync/protocol/sync.pb.h" -#include "sync/sessions/sync_session.h" -#include "sync/syncable/model_type_test_util.h" -#include "sync/syncable/syncable.h" -#include "sync/syncable/syncable_id.h" -#include "sync/test/fake_encryptor.h" -#include "sync/test/fake_extensions_activity_monitor.h" -#include "sync/util/cryptographer.h" -#include "sync/util/extensions_activity_monitor.h" -#include "sync/util/test_unrecoverable_error_handler.h" -#include "sync/util/time.h" -#include "testing/gmock/include/gmock/gmock.h" -#include "testing/gtest/include/gtest/gtest.h" - -using base::ExpectDictStringValue; -using browser_sync::Cryptographer; -using browser_sync::FakeEncryptor; -using browser_sync::FakeExtensionsActivityMonitor; -using browser_sync::HasArgsAsList; -using browser_sync::HasDetailsAsDictionary; -using browser_sync::KeyParams; -using browser_sync::kNigoriTag; -using browser_sync::JsArgList; -using browser_sync::JsBackend; -using browser_sync::JsEventHandler; -using browser_sync::JsReplyHandler; -using browser_sync::MockJsEventHandler; -using browser_sync::MockJsReplyHandler; -using browser_sync::ModelSafeRoutingInfo; -using browser_sync::ModelSafeWorker; -using browser_sync::ModelSafeWorkerRegistrar; -using browser_sync::sessions::SyncSessionSnapshot; -using browser_sync::TestUnrecoverableErrorHandler; -using browser_sync::WeakHandle; -using syncable::IS_DEL; -using syncable::IS_UNSYNCED; -using syncable::kEncryptedString; -using syncable::ModelTypeSet; -using syncable::ModelType; -using syncable::NON_UNIQUE_NAME; -using syncable::SPECIFICS; -using testing::_; -using testing::AnyNumber; -using testing::AtLeast; -using testing::InSequence; -using testing::Invoke; -using testing::SaveArg; -using testing::StrictMock; - -namespace sync_api { - -namespace { - -const char kTestChromeVersion[] = "test chrome version"; - -void DoNothing() {} - -void ExpectInt64Value(int64 expected_value, - const DictionaryValue& value, const std::string& key) { - std::string int64_str; - EXPECT_TRUE(value.GetString(key, &int64_str)); - int64 val = 0; - EXPECT_TRUE(base::StringToInt64(int64_str, &val)); - EXPECT_EQ(expected_value, val); -} - -void ExpectTimeValue(const base::Time& expected_value, - const DictionaryValue& value, const std::string& key) { - std::string time_str; - EXPECT_TRUE(value.GetString(key, &time_str)); - EXPECT_EQ(browser_sync::GetTimeDebugString(expected_value), time_str); -} - -// Makes a non-folder child of the root node. Returns the id of the -// newly-created node. -int64 MakeNode(UserShare* share, - ModelType model_type, - const std::string& client_tag) { - WriteTransaction trans(FROM_HERE, share); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - WriteNode node(&trans); - EXPECT_TRUE(node.InitUniqueByCreation(model_type, root_node, client_tag)); - node.SetIsFolder(false); - return node.GetId(); -} - -// Makes a non-folder child of a non-root node. Returns the id of the -// newly-created node. -int64 MakeNodeWithParent(UserShare* share, - ModelType model_type, - const std::string& client_tag, - int64 parent_id) { - WriteTransaction trans(FROM_HERE, share); - ReadNode parent_node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, parent_node.InitByIdLookup(parent_id)); - WriteNode node(&trans); - EXPECT_TRUE(node.InitUniqueByCreation(model_type, parent_node, client_tag)); - node.SetIsFolder(false); - return node.GetId(); -} - -// Makes a folder child of a non-root node. Returns the id of the -// newly-created node. -int64 MakeFolderWithParent(UserShare* share, - ModelType model_type, - int64 parent_id, - BaseNode* predecessor) { - WriteTransaction trans(FROM_HERE, share); - ReadNode parent_node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, parent_node.InitByIdLookup(parent_id)); - WriteNode node(&trans); - EXPECT_TRUE(node.InitByCreation(model_type, parent_node, predecessor)); - node.SetIsFolder(true); - return node.GetId(); -} - -// Creates the "synced" root node for a particular datatype. We use the syncable -// methods here so that the syncer treats these nodes as if they were already -// received from the server. -int64 MakeServerNodeForType(UserShare* share, - ModelType model_type) { - sync_pb::EntitySpecifics specifics; - syncable::AddDefaultFieldValue(model_type, &specifics); - syncable::WriteTransaction trans( - FROM_HERE, syncable::UNITTEST, share->directory.get()); - // Attempt to lookup by nigori tag. - std::string type_tag = syncable::ModelTypeToRootTag(model_type); - syncable::Id node_id = syncable::Id::CreateFromServerId(type_tag); - syncable::MutableEntry entry(&trans, syncable::CREATE_NEW_UPDATE_ITEM, - node_id); - EXPECT_TRUE(entry.good()); - entry.Put(syncable::BASE_VERSION, 1); - entry.Put(syncable::SERVER_VERSION, 1); - entry.Put(syncable::IS_UNAPPLIED_UPDATE, false); - entry.Put(syncable::SERVER_PARENT_ID, syncable::GetNullId()); - entry.Put(syncable::SERVER_IS_DIR, true); - entry.Put(syncable::IS_DIR, true); - entry.Put(syncable::SERVER_SPECIFICS, specifics); - entry.Put(syncable::UNIQUE_SERVER_TAG, type_tag); - entry.Put(syncable::NON_UNIQUE_NAME, type_tag); - entry.Put(syncable::IS_DEL, false); - entry.Put(syncable::SPECIFICS, specifics); - return entry.Get(syncable::META_HANDLE); -} - -// Simulates creating a "synced" node as a child of the root datatype node. -int64 MakeServerNode(UserShare* share, ModelType model_type, - const std::string& client_tag, - const std::string& hashed_tag, - const sync_pb::EntitySpecifics& specifics) { - syncable::WriteTransaction trans( - FROM_HERE, syncable::UNITTEST, share->directory.get()); - syncable::Entry root_entry(&trans, syncable::GET_BY_SERVER_TAG, - syncable::ModelTypeToRootTag(model_type)); - EXPECT_TRUE(root_entry.good()); - syncable::Id root_id = root_entry.Get(syncable::ID); - syncable::Id node_id = syncable::Id::CreateFromServerId(client_tag); - syncable::MutableEntry entry(&trans, syncable::CREATE_NEW_UPDATE_ITEM, - node_id); - EXPECT_TRUE(entry.good()); - entry.Put(syncable::BASE_VERSION, 1); - entry.Put(syncable::SERVER_VERSION, 1); - entry.Put(syncable::IS_UNAPPLIED_UPDATE, false); - entry.Put(syncable::SERVER_PARENT_ID, root_id); - entry.Put(syncable::PARENT_ID, root_id); - entry.Put(syncable::SERVER_IS_DIR, false); - entry.Put(syncable::IS_DIR, false); - entry.Put(syncable::SERVER_SPECIFICS, specifics); - entry.Put(syncable::NON_UNIQUE_NAME, client_tag); - entry.Put(syncable::UNIQUE_CLIENT_TAG, hashed_tag); - entry.Put(syncable::IS_DEL, false); - entry.Put(syncable::SPECIFICS, specifics); - return entry.Get(syncable::META_HANDLE); -} - -} // namespace - -class SyncApiTest : public testing::Test { - public: - virtual void SetUp() { - test_user_share_.SetUp(); - } - - virtual void TearDown() { - test_user_share_.TearDown(); - } - - protected: - MessageLoop message_loop_; - browser_sync::TestUserShare test_user_share_; -}; - -TEST_F(SyncApiTest, SanityCheckTest) { - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - EXPECT_TRUE(trans.GetWrappedTrans() != NULL); - } - { - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - EXPECT_TRUE(trans.GetWrappedTrans() != NULL); - } - { - // No entries but root should exist - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode node(&trans); - // Metahandle 1 can be root, sanity check 2 - EXPECT_EQ(BaseNode::INIT_FAILED_ENTRY_NOT_GOOD, node.InitByIdLookup(2)); - } -} - -TEST_F(SyncApiTest, BasicTagWrite) { - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - EXPECT_EQ(root_node.GetFirstChildId(), 0); - } - - ignore_result(MakeNode(test_user_share_.user_share(), - syncable::BOOKMARKS, "testtag")); - - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, "testtag")); - - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - EXPECT_NE(node.GetId(), 0); - EXPECT_EQ(node.GetId(), root_node.GetFirstChildId()); - } -} - -TEST_F(SyncApiTest, GenerateSyncableHash) { - EXPECT_EQ("OyaXV5mEzrPS4wbogmtKvRfekAI=", - BaseNode::GenerateSyncableHash(syncable::BOOKMARKS, "tag1")); - EXPECT_EQ("iNFQtRFQb+IZcn1kKUJEZDDkLs4=", - BaseNode::GenerateSyncableHash(syncable::PREFERENCES, "tag1")); - EXPECT_EQ("gO1cPZQXaM73sHOvSA+tKCKFs58=", - BaseNode::GenerateSyncableHash(syncable::AUTOFILL, "tag1")); - - EXPECT_EQ("A0eYIHXM1/jVwKDDp12Up20IkKY=", - BaseNode::GenerateSyncableHash(syncable::BOOKMARKS, "tag2")); - EXPECT_EQ("XYxkF7bhS4eItStFgiOIAU23swI=", - BaseNode::GenerateSyncableHash(syncable::PREFERENCES, "tag2")); - EXPECT_EQ("GFiWzo5NGhjLlN+OyCfhy28DJTQ=", - BaseNode::GenerateSyncableHash(syncable::AUTOFILL, "tag2")); -} - -TEST_F(SyncApiTest, ModelTypesSiloed) { - { - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - EXPECT_EQ(root_node.GetFirstChildId(), 0); - } - - ignore_result(MakeNode(test_user_share_.user_share(), - syncable::BOOKMARKS, "collideme")); - ignore_result(MakeNode(test_user_share_.user_share(), - syncable::PREFERENCES, "collideme")); - ignore_result(MakeNode(test_user_share_.user_share(), - syncable::AUTOFILL, "collideme")); - - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - - ReadNode bookmarknode(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - bookmarknode.InitByClientTagLookup(syncable::BOOKMARKS, - "collideme")); - - ReadNode prefnode(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - prefnode.InitByClientTagLookup(syncable::PREFERENCES, - "collideme")); - - ReadNode autofillnode(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - autofillnode.InitByClientTagLookup(syncable::AUTOFILL, - "collideme")); - - EXPECT_NE(bookmarknode.GetId(), prefnode.GetId()); - EXPECT_NE(autofillnode.GetId(), prefnode.GetId()); - EXPECT_NE(bookmarknode.GetId(), autofillnode.GetId()); - } -} - -TEST_F(SyncApiTest, ReadMissingTagsFails) { - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_FAILED_ENTRY_NOT_GOOD, - node.InitByClientTagLookup(syncable::BOOKMARKS, - "testtag")); - } - { - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_FAILED_ENTRY_NOT_GOOD, - node.InitByClientTagLookup(syncable::BOOKMARKS, - "testtag")); - } -} - -// TODO(chron): Hook this all up to the server and write full integration tests -// for update->undelete behavior. -TEST_F(SyncApiTest, TestDeleteBehavior) { - int64 node_id; - int64 folder_id; - std::string test_title("test1"); - - { - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - - // we'll use this spare folder later - WriteNode folder_node(&trans); - EXPECT_TRUE(folder_node.InitByCreation(syncable::BOOKMARKS, - root_node, NULL)); - folder_id = folder_node.GetId(); - - WriteNode wnode(&trans); - EXPECT_TRUE(wnode.InitUniqueByCreation(syncable::BOOKMARKS, - root_node, "testtag")); - wnode.SetIsFolder(false); - wnode.SetTitle(UTF8ToWide(test_title)); - - node_id = wnode.GetId(); - } - - // Ensure we can delete something with a tag. - { - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - WriteNode wnode(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - wnode.InitByClientTagLookup(syncable::BOOKMARKS, - "testtag")); - EXPECT_FALSE(wnode.GetIsFolder()); - EXPECT_EQ(wnode.GetTitle(), test_title); - - wnode.Remove(); - } - - // Lookup of a node which was deleted should return failure, - // but have found some data about the node. - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_FAILED_ENTRY_IS_DEL, - node.InitByClientTagLookup(syncable::BOOKMARKS, - "testtag")); - // Note that for proper function of this API this doesn't need to be - // filled, we're checking just to make sure the DB worked in this test. - EXPECT_EQ(node.GetTitle(), test_title); - } - - { - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode folder_node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, folder_node.InitByIdLookup(folder_id)); - - WriteNode wnode(&trans); - // This will undelete the tag. - EXPECT_TRUE(wnode.InitUniqueByCreation(syncable::BOOKMARKS, - folder_node, "testtag")); - EXPECT_EQ(wnode.GetIsFolder(), false); - EXPECT_EQ(wnode.GetParentId(), folder_node.GetId()); - EXPECT_EQ(wnode.GetId(), node_id); - EXPECT_NE(wnode.GetTitle(), test_title); // Title should be cleared - wnode.SetTitle(UTF8ToWide(test_title)); - } - - // Now look up should work. - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, - "testtag")); - EXPECT_EQ(node.GetTitle(), test_title); - EXPECT_EQ(node.GetModelType(), syncable::BOOKMARKS); - } -} - -TEST_F(SyncApiTest, WriteAndReadPassword) { - KeyParams params = {"localhost", "username", "passphrase"}; - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - trans.GetCryptographer()->AddKey(params); - } - { - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - - WriteNode password_node(&trans); - EXPECT_TRUE(password_node.InitUniqueByCreation(syncable::PASSWORDS, - root_node, "foo")); - sync_pb::PasswordSpecificsData data; - data.set_password_value("secret"); - password_node.SetPasswordSpecifics(data); - } - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - - ReadNode password_node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - password_node.InitByClientTagLookup(syncable::PASSWORDS, - "foo")); - const sync_pb::PasswordSpecificsData& data = - password_node.GetPasswordSpecifics(); - EXPECT_EQ("secret", data.password_value()); - } -} - -TEST_F(SyncApiTest, WriteEncryptedTitle) { - KeyParams params = {"localhost", "username", "passphrase"}; - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - trans.GetCryptographer()->AddKey(params); - trans.GetCryptographer()->set_encrypt_everything(); - } - { - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - - WriteNode bookmark_node(&trans); - EXPECT_TRUE(bookmark_node.InitUniqueByCreation(syncable::BOOKMARKS, - root_node, "foo")); - bookmark_node.SetTitle(UTF8ToWide("foo")); - - WriteNode pref_node(&trans); - EXPECT_TRUE(pref_node.InitUniqueByCreation(syncable::PREFERENCES, - root_node, "bar")); - pref_node.SetTitle(UTF8ToWide("bar")); - } - { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - - ReadNode bookmark_node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - bookmark_node.InitByClientTagLookup(syncable::BOOKMARKS, - "foo")); - EXPECT_EQ("foo", bookmark_node.GetTitle()); - EXPECT_EQ(kEncryptedString, - bookmark_node.GetEntry()->Get(syncable::NON_UNIQUE_NAME)); - - ReadNode pref_node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - pref_node.InitByClientTagLookup(syncable::PREFERENCES, - "bar")); - EXPECT_EQ(kEncryptedString, pref_node.GetTitle()); - } -} - -TEST_F(SyncApiTest, BaseNodeSetSpecifics) { - int64 child_id = MakeNode(test_user_share_.user_share(), - syncable::BOOKMARKS, "testtag"); - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByIdLookup(child_id)); - - sync_pb::EntitySpecifics entity_specifics; - entity_specifics.mutable_bookmark()->set_url("http://www.google.com"); - - EXPECT_NE(entity_specifics.SerializeAsString(), - node.GetEntitySpecifics().SerializeAsString()); - node.SetEntitySpecifics(entity_specifics); - EXPECT_EQ(entity_specifics.SerializeAsString(), - node.GetEntitySpecifics().SerializeAsString()); -} - -TEST_F(SyncApiTest, BaseNodeSetSpecificsPreservesUnknownFields) { - int64 child_id = MakeNode(test_user_share_.user_share(), - syncable::BOOKMARKS, "testtag"); - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByIdLookup(child_id)); - EXPECT_TRUE(node.GetEntitySpecifics().unknown_fields().empty()); - - sync_pb::EntitySpecifics entity_specifics; - entity_specifics.mutable_bookmark()->set_url("http://www.google.com"); - entity_specifics.mutable_unknown_fields()->AddFixed32(5, 100); - node.SetEntitySpecifics(entity_specifics); - EXPECT_FALSE(node.GetEntitySpecifics().unknown_fields().empty()); - - entity_specifics.mutable_unknown_fields()->Clear(); - node.SetEntitySpecifics(entity_specifics); - EXPECT_FALSE(node.GetEntitySpecifics().unknown_fields().empty()); -} - -namespace { - -void CheckNodeValue(const BaseNode& node, const DictionaryValue& value, - bool is_detailed) { - ExpectInt64Value(node.GetId(), value, "id"); - { - bool is_folder = false; - EXPECT_TRUE(value.GetBoolean("isFolder", &is_folder)); - EXPECT_EQ(node.GetIsFolder(), is_folder); - } - ExpectDictStringValue(node.GetTitle(), value, "title"); - { - ModelType expected_model_type = node.GetModelType(); - std::string type_str; - EXPECT_TRUE(value.GetString("type", &type_str)); - if (expected_model_type >= syncable::FIRST_REAL_MODEL_TYPE) { - ModelType model_type = - syncable::ModelTypeFromString(type_str); - EXPECT_EQ(expected_model_type, model_type); - } else if (expected_model_type == syncable::TOP_LEVEL_FOLDER) { - EXPECT_EQ("Top-level folder", type_str); - } else if (expected_model_type == syncable::UNSPECIFIED) { - EXPECT_EQ("Unspecified", type_str); - } else { - ADD_FAILURE(); - } - } - if (is_detailed) { - ExpectInt64Value(node.GetParentId(), value, "parentId"); - ExpectTimeValue(node.GetModificationTime(), value, "modificationTime"); - ExpectInt64Value(node.GetExternalId(), value, "externalId"); - ExpectInt64Value(node.GetPredecessorId(), value, "predecessorId"); - ExpectInt64Value(node.GetSuccessorId(), value, "successorId"); - ExpectInt64Value(node.GetFirstChildId(), value, "firstChildId"); - { - scoped_ptr<DictionaryValue> expected_entry(node.GetEntry()->ToValue()); - Value* entry = NULL; - EXPECT_TRUE(value.Get("entry", &entry)); - EXPECT_TRUE(Value::Equals(entry, expected_entry.get())); - } - EXPECT_EQ(11u, value.size()); - } else { - EXPECT_EQ(4u, value.size()); - } -} - -} // namespace - -TEST_F(SyncApiTest, BaseNodeGetSummaryAsValue) { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode node(&trans); - node.InitByRootLookup(); - scoped_ptr<DictionaryValue> details(node.GetSummaryAsValue()); - if (details.get()) { - CheckNodeValue(node, *details, false); - } else { - ADD_FAILURE(); - } -} - -TEST_F(SyncApiTest, BaseNodeGetDetailsAsValue) { - ReadTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode node(&trans); - node.InitByRootLookup(); - scoped_ptr<DictionaryValue> details(node.GetDetailsAsValue()); - if (details.get()) { - CheckNodeValue(node, *details, true); - } else { - ADD_FAILURE(); - } -} - -TEST_F(SyncApiTest, EmptyTags) { - WriteTransaction trans(FROM_HERE, test_user_share_.user_share()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - WriteNode node(&trans); - std::string empty_tag; - EXPECT_FALSE(node.InitUniqueByCreation( - syncable::TYPED_URLS, root_node, empty_tag)); - EXPECT_EQ(BaseNode::INIT_FAILED_PRECONDITION, - node.InitByTagLookup(empty_tag)); -} - -namespace { - -class TestHttpPostProviderInterface : public HttpPostProviderInterface { - public: - virtual ~TestHttpPostProviderInterface() {} - - virtual void SetUserAgent(const char* user_agent) OVERRIDE {} - virtual void SetExtraRequestHeaders(const char* headers) OVERRIDE {} - virtual void SetURL(const char* url, int port) OVERRIDE {} - virtual void SetPostPayload(const char* content_type, - int content_length, - const char* content) OVERRIDE {} - virtual bool MakeSynchronousPost(int* error_code, int* response_code) - OVERRIDE { - return false; - } - virtual int GetResponseContentLength() const OVERRIDE { - return 0; - } - virtual const char* GetResponseContent() const OVERRIDE { - return ""; - } - virtual const std::string GetResponseHeaderValue( - const std::string& name) const OVERRIDE { - return ""; - } - virtual void Abort() OVERRIDE {} -}; - -class TestHttpPostProviderFactory : public HttpPostProviderFactory { - public: - virtual ~TestHttpPostProviderFactory() {} - virtual HttpPostProviderInterface* Create() OVERRIDE { - return new TestHttpPostProviderInterface(); - } - virtual void Destroy(HttpPostProviderInterface* http) OVERRIDE { - delete http; - } -}; - -class SyncManagerObserverMock : public SyncManager::Observer { - public: - MOCK_METHOD1(OnSyncCycleCompleted, - void(const SyncSessionSnapshot*)); // NOLINT - MOCK_METHOD2(OnInitializationComplete, - void(const WeakHandle<JsBackend>&, bool)); // NOLINT - MOCK_METHOD1(OnConnectionStatusChange, void(ConnectionStatus)); // NOLINT - MOCK_METHOD2(OnPassphraseRequired, - void(sync_api::PassphraseRequiredReason, - const sync_pb::EncryptedData&)); // NOLINT - MOCK_METHOD0(OnPassphraseAccepted, void()); // NOLINT - MOCK_METHOD1(OnBootstrapTokenUpdated, void(const std::string&)); // NOLINT - MOCK_METHOD0(OnStopSyncingPermanently, void()); // NOLINT - MOCK_METHOD1(OnUpdatedToken, void(const std::string&)); // NOLINT - MOCK_METHOD0(OnClearServerDataFailed, void()); // NOLINT - MOCK_METHOD0(OnClearServerDataSucceeded, void()); // NOLINT - MOCK_METHOD2(OnEncryptedTypesChanged, - void(ModelTypeSet, bool)); // NOLINT - MOCK_METHOD0(OnEncryptionComplete, void()); // NOLINT - MOCK_METHOD1(OnActionableError, - void(const browser_sync::SyncProtocolError&)); // NOLINT -}; - -class SyncNotifierMock : public sync_notifier::SyncNotifier { - public: - MOCK_METHOD1(AddObserver, void(sync_notifier::SyncNotifierObserver*)); - MOCK_METHOD1(RemoveObserver, void(sync_notifier::SyncNotifierObserver*)); - MOCK_METHOD1(SetUniqueId, void(const std::string&)); - MOCK_METHOD1(SetState, void(const std::string&)); - MOCK_METHOD2(UpdateCredentials, - void(const std::string&, const std::string&)); - MOCK_METHOD1(UpdateEnabledTypes, - void(syncable::ModelTypeSet)); - MOCK_METHOD1(SendNotification, void(syncable::ModelTypeSet)); -}; - -} // namespace - -class SyncManagerTest : public testing::Test, - public ModelSafeWorkerRegistrar, - public SyncManager::ChangeDelegate { - protected: - enum NigoriStatus { - DONT_WRITE_NIGORI, - WRITE_TO_NIGORI - }; - - enum EncryptionStatus { - UNINITIALIZED, - DEFAULT_ENCRYPTION, - FULL_ENCRYPTION - }; - - SyncManagerTest() - : sync_notifier_mock_(NULL), - sync_manager_("Test sync manager"), - sync_notifier_observer_(NULL), - update_enabled_types_call_count_(0) {} - - virtual ~SyncManagerTest() { - EXPECT_FALSE(sync_notifier_mock_); - } - - // Test implementation. - void SetUp() { - ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); - - SyncCredentials credentials; - credentials.email = "foo@bar.com"; - credentials.sync_token = "sometoken"; - - sync_notifier_mock_ = new StrictMock<SyncNotifierMock>(); - EXPECT_CALL(*sync_notifier_mock_, AddObserver(_)). - WillOnce(Invoke(this, &SyncManagerTest::SyncNotifierAddObserver)); - EXPECT_CALL(*sync_notifier_mock_, SetUniqueId(_)); - EXPECT_CALL(*sync_notifier_mock_, SetState("")); - EXPECT_CALL(*sync_notifier_mock_, - UpdateCredentials(credentials.email, credentials.sync_token)); - EXPECT_CALL(*sync_notifier_mock_, UpdateEnabledTypes(_)). - Times(AtLeast(1)). - WillRepeatedly( - Invoke(this, &SyncManagerTest::SyncNotifierUpdateEnabledTypes)); - EXPECT_CALL(*sync_notifier_mock_, RemoveObserver(_)). - WillOnce(Invoke(this, &SyncManagerTest::SyncNotifierRemoveObserver)); - - sync_manager_.AddObserver(&observer_); - EXPECT_CALL(observer_, OnInitializationComplete(_, _)). - WillOnce(SaveArg<0>(&js_backend_)); - - EXPECT_FALSE(sync_notifier_observer_); - EXPECT_FALSE(js_backend_.IsInitialized()); - - // Takes ownership of |sync_notifier_mock_|. - sync_manager_.Init(temp_dir_.path(), - WeakHandle<JsEventHandler>(), - "bogus", 0, false, - base::MessageLoopProxy::current(), - new TestHttpPostProviderFactory(), this, - &extensions_activity_monitor_, this, "bogus", - credentials, - false /* enable_sync_tabs_for_other_clients */, - sync_notifier_mock_, "", - sync_api::SyncManager::TEST_IN_MEMORY, - &encryptor_, - &handler_, - NULL); - - EXPECT_TRUE(sync_notifier_observer_); - EXPECT_TRUE(js_backend_.IsInitialized()); - - EXPECT_EQ(1, update_enabled_types_call_count_); - - ModelSafeRoutingInfo routes; - GetModelSafeRoutingInfo(&routes); - for (ModelSafeRoutingInfo::iterator i = routes.begin(); i != routes.end(); - ++i) { - type_roots_[i->first] = MakeServerNodeForType( - sync_manager_.GetUserShare(), i->first); - } - PumpLoop(); - } - - void TearDown() { - sync_manager_.RemoveObserver(&observer_); - sync_manager_.ShutdownOnSyncThread(); - sync_notifier_mock_ = NULL; - EXPECT_FALSE(sync_notifier_observer_); - PumpLoop(); - } - - // ModelSafeWorkerRegistrar implementation. - virtual void GetWorkers(std::vector<ModelSafeWorker*>* out) OVERRIDE { - NOTIMPLEMENTED(); - out->clear(); - } - virtual void GetModelSafeRoutingInfo(ModelSafeRoutingInfo* out) OVERRIDE { - (*out)[syncable::NIGORI] = browser_sync::GROUP_PASSIVE; - (*out)[syncable::BOOKMARKS] = browser_sync::GROUP_PASSIVE; - (*out)[syncable::THEMES] = browser_sync::GROUP_PASSIVE; - (*out)[syncable::SESSIONS] = browser_sync::GROUP_PASSIVE; - (*out)[syncable::PASSWORDS] = browser_sync::GROUP_PASSIVE; - (*out)[syncable::PREFERENCES] = browser_sync::GROUP_PASSIVE; - } - - virtual void OnChangesApplied( - syncable::ModelType model_type, - const BaseTransaction* trans, - const ImmutableChangeRecordList& changes) OVERRIDE {} - - virtual void OnChangesComplete(syncable::ModelType model_type) OVERRIDE {} - - // Helper methods. - bool SetUpEncryption(NigoriStatus nigori_status, - EncryptionStatus encryption_status) { - UserShare* share = sync_manager_.GetUserShare(); - share->directory->set_initial_sync_ended_for_type(syncable::NIGORI, true); - - // We need to create the nigori node as if it were an applied server update. - int64 nigori_id = GetIdForDataType(syncable::NIGORI); - if (nigori_id == kInvalidId) - return false; - - // Set the nigori cryptographer information. - WriteTransaction trans(FROM_HERE, share); - Cryptographer* cryptographer = trans.GetCryptographer(); - if (!cryptographer) - return false; - if (encryption_status != UNINITIALIZED) { - KeyParams params = {"localhost", "dummy", "foobar"}; - cryptographer->AddKey(params); - } else { - DCHECK_NE(nigori_status, WRITE_TO_NIGORI); - } - if (encryption_status == FULL_ENCRYPTION) - cryptographer->set_encrypt_everything(); - if (nigori_status == WRITE_TO_NIGORI) { - sync_pb::NigoriSpecifics nigori; - cryptographer->GetKeys(nigori.mutable_encrypted()); - cryptographer->UpdateNigoriFromEncryptedTypes(&nigori); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByIdLookup(nigori_id)); - node.SetNigoriSpecifics(nigori); - } - return cryptographer->is_ready(); - } - - int64 GetIdForDataType(ModelType type) { - if (type_roots_.count(type) == 0) - return 0; - return type_roots_[type]; - } - - void SyncNotifierAddObserver( - sync_notifier::SyncNotifierObserver* sync_notifier_observer) { - EXPECT_EQ(NULL, sync_notifier_observer_); - sync_notifier_observer_ = sync_notifier_observer; - } - - void SyncNotifierRemoveObserver( - sync_notifier::SyncNotifierObserver* sync_notifier_observer) { - EXPECT_EQ(sync_notifier_observer_, sync_notifier_observer); - sync_notifier_observer_ = NULL; - } - - void SyncNotifierUpdateEnabledTypes(syncable::ModelTypeSet types) { - ModelSafeRoutingInfo routes; - GetModelSafeRoutingInfo(&routes); - const syncable::ModelTypeSet expected_types = - GetRoutingInfoTypes(routes); - EXPECT_TRUE(types.Equals(expected_types)); - ++update_enabled_types_call_count_; - } - - void PumpLoop() { - message_loop_.RunAllPending(); - } - - void SendJsMessage(const std::string& name, const JsArgList& args, - const WeakHandle<JsReplyHandler>& reply_handler) { - js_backend_.Call(FROM_HERE, &JsBackend::ProcessJsMessage, - name, args, reply_handler); - PumpLoop(); - } - - void SetJsEventHandler(const WeakHandle<JsEventHandler>& event_handler) { - js_backend_.Call(FROM_HERE, &JsBackend::SetJsEventHandler, - event_handler); - PumpLoop(); - } - - // Looks up an entry by client tag and resets IS_UNSYNCED value to false. - // Returns true if entry was previously unsynced, false if IS_UNSYNCED was - // already false. - bool ResetUnsyncedEntry(syncable::ModelType type, - const std::string& client_tag) { - UserShare* share = sync_manager_.GetUserShare(); - syncable::WriteTransaction trans( - FROM_HERE, syncable::UNITTEST, share->directory.get()); - const std::string hash = BaseNode::GenerateSyncableHash(type, client_tag); - syncable::MutableEntry entry(&trans, syncable::GET_BY_CLIENT_TAG, - hash); - EXPECT_TRUE(entry.good()); - if (!entry.Get(IS_UNSYNCED)) - return false; - entry.Put(IS_UNSYNCED, false); - return true; - } - - private: - // Needed by |sync_manager_|. - MessageLoop message_loop_; - // Needed by |sync_manager_|. - ScopedTempDir temp_dir_; - // Sync Id's for the roots of the enabled datatypes. - std::map<ModelType, int64> type_roots_; - FakeExtensionsActivityMonitor extensions_activity_monitor_; - StrictMock<SyncNotifierMock>* sync_notifier_mock_; - - protected: - FakeEncryptor encryptor_; - TestUnrecoverableErrorHandler handler_; - SyncManager sync_manager_; - WeakHandle<JsBackend> js_backend_; - StrictMock<SyncManagerObserverMock> observer_; - sync_notifier::SyncNotifierObserver* sync_notifier_observer_; - int update_enabled_types_call_count_; -}; - -TEST_F(SyncManagerTest, UpdateEnabledTypes) { - EXPECT_EQ(1, update_enabled_types_call_count_); - // Triggers SyncNotifierUpdateEnabledTypes. - sync_manager_.UpdateEnabledTypes(); - EXPECT_EQ(2, update_enabled_types_call_count_); -} - -TEST_F(SyncManagerTest, DoNotSyncTabsInNigoriNode) { - const syncable::ModelTypeSet encrypted_types(syncable::TYPED_URLS); - sync_manager_.MaybeSetSyncTabsInNigoriNode(encrypted_types); - - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - ASSERT_EQ(BaseNode::INIT_OK, - node.InitByIdLookup(GetIdForDataType(syncable::NIGORI))); - EXPECT_FALSE(node.GetNigoriSpecifics().sync_tabs()); -} - -TEST_F(SyncManagerTest, SyncTabsInNigoriNode) { - const syncable::ModelTypeSet encrypted_types(syncable::SESSIONS); - sync_manager_.MaybeSetSyncTabsInNigoriNode(encrypted_types); - - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - ASSERT_EQ(BaseNode::INIT_OK, - node.InitByIdLookup(GetIdForDataType(syncable::NIGORI))); - EXPECT_TRUE(node.GetNigoriSpecifics().sync_tabs()); -} - -TEST_F(SyncManagerTest, ProcessJsMessage) { - const JsArgList kNoArgs; - - StrictMock<MockJsReplyHandler> reply_handler; - - ListValue false_args; - false_args.Append(Value::CreateBooleanValue(false)); - - EXPECT_CALL(reply_handler, - HandleJsReply("getNotificationState", - HasArgsAsList(false_args))); - - // This message should be dropped. - SendJsMessage("unknownMessage", kNoArgs, reply_handler.AsWeakHandle()); - - SendJsMessage("getNotificationState", kNoArgs, reply_handler.AsWeakHandle()); -} - -TEST_F(SyncManagerTest, ProcessJsMessageGetRootNodeDetails) { - const JsArgList kNoArgs; - - StrictMock<MockJsReplyHandler> reply_handler; - - JsArgList return_args; - - EXPECT_CALL(reply_handler, - HandleJsReply("getRootNodeDetails", _)) - .WillOnce(SaveArg<1>(&return_args)); - - SendJsMessage("getRootNodeDetails", kNoArgs, reply_handler.AsWeakHandle()); - - EXPECT_EQ(1u, return_args.Get().GetSize()); - DictionaryValue* node_info = NULL; - EXPECT_TRUE(return_args.Get().GetDictionary(0, &node_info)); - if (node_info) { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - node.InitByRootLookup(); - CheckNodeValue(node, *node_info, true); - } else { - ADD_FAILURE(); - } -} - -void CheckGetNodesByIdReturnArgs(const SyncManager& sync_manager, - const JsArgList& return_args, - int64 id, - bool is_detailed) { - EXPECT_EQ(1u, return_args.Get().GetSize()); - ListValue* nodes = NULL; - ASSERT_TRUE(return_args.Get().GetList(0, &nodes)); - ASSERT_TRUE(nodes); - EXPECT_EQ(1u, nodes->GetSize()); - DictionaryValue* node_info = NULL; - EXPECT_TRUE(nodes->GetDictionary(0, &node_info)); - ASSERT_TRUE(node_info); - ReadTransaction trans(FROM_HERE, sync_manager.GetUserShare()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByIdLookup(id)); - CheckNodeValue(node, *node_info, is_detailed); -} - -class SyncManagerGetNodesByIdTest : public SyncManagerTest { - protected: - virtual ~SyncManagerGetNodesByIdTest() {} - - void RunGetNodesByIdTest(const char* message_name, bool is_detailed) { - int64 root_id = kInvalidId; - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - root_id = root_node.GetId(); - } - - int64 child_id = - MakeNode(sync_manager_.GetUserShare(), - syncable::BOOKMARKS, "testtag"); - - StrictMock<MockJsReplyHandler> reply_handler; - - JsArgList return_args; - - const int64 ids[] = { root_id, child_id }; - - EXPECT_CALL(reply_handler, - HandleJsReply(message_name, _)) - .Times(arraysize(ids)).WillRepeatedly(SaveArg<1>(&return_args)); - - for (size_t i = 0; i < arraysize(ids); ++i) { - ListValue args; - ListValue* id_values = new ListValue(); - args.Append(id_values); - id_values->Append(Value::CreateStringValue(base::Int64ToString(ids[i]))); - SendJsMessage(message_name, - JsArgList(&args), reply_handler.AsWeakHandle()); - - CheckGetNodesByIdReturnArgs(sync_manager_, return_args, - ids[i], is_detailed); - } - } - - void RunGetNodesByIdFailureTest(const char* message_name) { - StrictMock<MockJsReplyHandler> reply_handler; - - ListValue empty_list_args; - empty_list_args.Append(new ListValue()); - - EXPECT_CALL(reply_handler, - HandleJsReply(message_name, - HasArgsAsList(empty_list_args))) - .Times(6); - - { - ListValue args; - SendJsMessage(message_name, - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - { - ListValue args; - args.Append(new ListValue()); - SendJsMessage(message_name, - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - { - ListValue args; - ListValue* ids = new ListValue(); - args.Append(ids); - ids->Append(Value::CreateStringValue("")); - SendJsMessage(message_name, - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - { - ListValue args; - ListValue* ids = new ListValue(); - args.Append(ids); - ids->Append(Value::CreateStringValue("nonsense")); - SendJsMessage(message_name, - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - { - ListValue args; - ListValue* ids = new ListValue(); - args.Append(ids); - ids->Append(Value::CreateStringValue("0")); - SendJsMessage(message_name, - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - { - ListValue args; - ListValue* ids = new ListValue(); - args.Append(ids); - ids->Append(Value::CreateStringValue("9999")); - SendJsMessage(message_name, - JsArgList(&args), reply_handler.AsWeakHandle()); - } - } -}; - -TEST_F(SyncManagerGetNodesByIdTest, GetNodeSummariesById) { - RunGetNodesByIdTest("getNodeSummariesById", false); -} - -TEST_F(SyncManagerGetNodesByIdTest, GetNodeDetailsById) { - RunGetNodesByIdTest("getNodeDetailsById", true); -} - -TEST_F(SyncManagerGetNodesByIdTest, GetNodeSummariesByIdFailure) { - RunGetNodesByIdFailureTest("getNodeSummariesById"); -} - -TEST_F(SyncManagerGetNodesByIdTest, GetNodeDetailsByIdFailure) { - RunGetNodesByIdFailureTest("getNodeDetailsById"); -} - -TEST_F(SyncManagerTest, GetChildNodeIds) { - StrictMock<MockJsReplyHandler> reply_handler; - - JsArgList return_args; - - EXPECT_CALL(reply_handler, - HandleJsReply("getChildNodeIds", _)) - .Times(1).WillRepeatedly(SaveArg<1>(&return_args)); - - { - ListValue args; - args.Append(Value::CreateStringValue("1")); - SendJsMessage("getChildNodeIds", - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - EXPECT_EQ(1u, return_args.Get().GetSize()); - ListValue* nodes = NULL; - ASSERT_TRUE(return_args.Get().GetList(0, &nodes)); - ASSERT_TRUE(nodes); - EXPECT_EQ(6u, nodes->GetSize()); -} - -TEST_F(SyncManagerTest, GetChildNodeIdsFailure) { - StrictMock<MockJsReplyHandler> reply_handler; - - ListValue empty_list_args; - empty_list_args.Append(new ListValue()); - - EXPECT_CALL(reply_handler, - HandleJsReply("getChildNodeIds", - HasArgsAsList(empty_list_args))) - .Times(5); - - { - ListValue args; - SendJsMessage("getChildNodeIds", - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - { - ListValue args; - args.Append(Value::CreateStringValue("")); - SendJsMessage("getChildNodeIds", - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - { - ListValue args; - args.Append(Value::CreateStringValue("nonsense")); - SendJsMessage("getChildNodeIds", - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - { - ListValue args; - args.Append(Value::CreateStringValue("0")); - SendJsMessage("getChildNodeIds", - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - { - ListValue args; - args.Append(Value::CreateStringValue("9999")); - SendJsMessage("getChildNodeIds", - JsArgList(&args), reply_handler.AsWeakHandle()); - } -} - -TEST_F(SyncManagerTest, GetAllNodesTest) { - StrictMock<MockJsReplyHandler> reply_handler; - JsArgList return_args; - - EXPECT_CALL(reply_handler, - HandleJsReply("getAllNodes", _)) - .Times(1).WillRepeatedly(SaveArg<1>(&return_args)); - - { - ListValue args; - SendJsMessage("getAllNodes", - JsArgList(&args), reply_handler.AsWeakHandle()); - } - - // There's not much value in verifying every attribute on every node here. - // Most of the value of this test has already been achieved: we've verified we - // can call the above function without crashing or leaking memory. - // - // Let's just check the list size and a few of its elements. Anything more - // would make this test brittle without greatly increasing our chances of - // catching real bugs. - - ListValue* node_list; - DictionaryValue* first_result; - - // The resulting argument list should have one argument, a list of nodes. - ASSERT_EQ(1U, return_args.Get().GetSize()); - ASSERT_TRUE(return_args.Get().GetList(0, &node_list)); - - // The database creation logic depends on the routing info. - // Refer to setup methods for more information. - ModelSafeRoutingInfo routes; - GetModelSafeRoutingInfo(&routes); - size_t directory_size = routes.size() + 1; - - ASSERT_EQ(directory_size, node_list->GetSize()); - ASSERT_TRUE(node_list->GetDictionary(0, &first_result)); - EXPECT_TRUE(first_result->HasKey("ID")); - EXPECT_TRUE(first_result->HasKey("NON_UNIQUE_NAME")); -} - -TEST_F(SyncManagerTest, OnNotificationStateChange) { - InSequence dummy; - StrictMock<MockJsEventHandler> event_handler; - - DictionaryValue true_details; - true_details.SetBoolean("enabled", true); - DictionaryValue false_details; - false_details.SetBoolean("enabled", false); - - EXPECT_CALL(event_handler, - HandleJsEvent("onNotificationStateChange", - HasDetailsAsDictionary(true_details))); - EXPECT_CALL(event_handler, - HandleJsEvent("onNotificationStateChange", - HasDetailsAsDictionary(false_details))); - - sync_manager_.TriggerOnNotificationStateChangeForTest(true); - sync_manager_.TriggerOnNotificationStateChangeForTest(false); - - SetJsEventHandler(event_handler.AsWeakHandle()); - sync_manager_.TriggerOnNotificationStateChangeForTest(true); - sync_manager_.TriggerOnNotificationStateChangeForTest(false); - SetJsEventHandler(WeakHandle<JsEventHandler>()); - - sync_manager_.TriggerOnNotificationStateChangeForTest(true); - sync_manager_.TriggerOnNotificationStateChangeForTest(false); - - // Should trigger the replies. - PumpLoop(); -} - -TEST_F(SyncManagerTest, OnIncomingNotification) { - StrictMock<MockJsEventHandler> event_handler; - - const syncable::ModelTypeSet empty_model_types; - const syncable::ModelTypeSet model_types( - syncable::BOOKMARKS, syncable::THEMES); - - // Build expected_args to have a single argument with the string - // equivalents of model_types. - DictionaryValue expected_details; - { - ListValue* model_type_list = new ListValue(); - expected_details.SetString("source", "REMOTE_NOTIFICATION"); - expected_details.Set("changedTypes", model_type_list); - for (syncable::ModelTypeSet::Iterator it = model_types.First(); - it.Good(); it.Inc()) { - model_type_list->Append( - Value::CreateStringValue( - syncable::ModelTypeToString(it.Get()))); - } - } - - EXPECT_CALL(event_handler, - HandleJsEvent("onIncomingNotification", - HasDetailsAsDictionary(expected_details))); - - sync_manager_.TriggerOnIncomingNotificationForTest(empty_model_types); - sync_manager_.TriggerOnIncomingNotificationForTest(model_types); - - SetJsEventHandler(event_handler.AsWeakHandle()); - sync_manager_.TriggerOnIncomingNotificationForTest(model_types); - SetJsEventHandler(WeakHandle<JsEventHandler>()); - - sync_manager_.TriggerOnIncomingNotificationForTest(empty_model_types); - sync_manager_.TriggerOnIncomingNotificationForTest(model_types); - - // Should trigger the replies. - PumpLoop(); -} - -TEST_F(SyncManagerTest, RefreshEncryptionReady) { - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - EXPECT_CALL(observer_, OnEncryptionComplete()); - - sync_manager_.RefreshNigori(kTestChromeVersion, base::Bind(&DoNothing)); - PumpLoop(); - - const syncable::ModelTypeSet encrypted_types = - sync_manager_.GetEncryptedDataTypesForTest(); - EXPECT_TRUE(encrypted_types.Has(syncable::PASSWORDS)); - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByIdLookup(GetIdForDataType(syncable::NIGORI))); - sync_pb::NigoriSpecifics nigori = node.GetNigoriSpecifics(); - EXPECT_TRUE(nigori.has_encrypted()); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - EXPECT_TRUE(cryptographer->CanDecrypt(nigori.encrypted())); - } -} - -// Attempt to refresh encryption when nigori not downloaded. -TEST_F(SyncManagerTest, RefreshEncryptionNotReady) { - // Don't set up encryption (no nigori node created). - - // Should fail. - sync_manager_.RefreshNigori(kTestChromeVersion, base::Bind(&DoNothing)); - PumpLoop(); - - const syncable::ModelTypeSet encrypted_types = - sync_manager_.GetEncryptedDataTypesForTest(); - EXPECT_TRUE(encrypted_types.Has(syncable::PASSWORDS)); // Hardcoded. - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); -} - -// Attempt to refresh encryption when nigori is empty. -TEST_F(SyncManagerTest, RefreshEncryptionEmptyNigori) { - EXPECT_TRUE(SetUpEncryption(DONT_WRITE_NIGORI, DEFAULT_ENCRYPTION)); - EXPECT_CALL(observer_, OnEncryptionComplete()); - - // Should write to nigori. - sync_manager_.RefreshNigori(kTestChromeVersion, base::Bind(&DoNothing)); - PumpLoop(); - - const syncable::ModelTypeSet encrypted_types = - sync_manager_.GetEncryptedDataTypesForTest(); - EXPECT_TRUE(encrypted_types.Has(syncable::PASSWORDS)); // Hardcoded. - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByIdLookup(GetIdForDataType(syncable::NIGORI))); - sync_pb::NigoriSpecifics nigori = node.GetNigoriSpecifics(); - EXPECT_TRUE(nigori.has_encrypted()); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - EXPECT_TRUE(cryptographer->CanDecrypt(nigori.encrypted())); - } -} - -TEST_F(SyncManagerTest, EncryptDataTypesWithNoData) { - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - EXPECT_CALL(observer_, - OnEncryptedTypesChanged( - HasModelTypes(syncable::ModelTypeSet::All()), true)); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.EnableEncryptEverything(); - EXPECT_TRUE(sync_manager_.EncryptEverythingEnabledForTest()); -} - -TEST_F(SyncManagerTest, EncryptDataTypesWithData) { - size_t batch_size = 5; - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - - // Create some unencrypted unsynced data. - int64 folder = MakeFolderWithParent(sync_manager_.GetUserShare(), - syncable::BOOKMARKS, - GetIdForDataType(syncable::BOOKMARKS), - NULL); - // First batch_size nodes are children of folder. - size_t i; - for (i = 0; i < batch_size; ++i) { - MakeNodeWithParent(sync_manager_.GetUserShare(), syncable::BOOKMARKS, - base::StringPrintf("%"PRIuS"", i), folder); - } - // Next batch_size nodes are a different type and on their own. - for (; i < 2*batch_size; ++i) { - MakeNodeWithParent(sync_manager_.GetUserShare(), syncable::SESSIONS, - base::StringPrintf("%"PRIuS"", i), - GetIdForDataType(syncable::SESSIONS)); - } - // Last batch_size nodes are a third type that will not need encryption. - for (; i < 3*batch_size; ++i) { - MakeNodeWithParent(sync_manager_.GetUserShare(), syncable::THEMES, - base::StringPrintf("%"PRIuS"", i), - GetIdForDataType(syncable::THEMES)); - } - - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - EXPECT_TRUE(GetEncryptedTypes(&trans).Equals( - Cryptographer::SensitiveTypes())); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::BOOKMARKS, - false /* not encrypted */)); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::SESSIONS, - false /* not encrypted */)); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::THEMES, - false /* not encrypted */)); - } - - EXPECT_CALL(observer_, - OnEncryptedTypesChanged( - HasModelTypes(syncable::ModelTypeSet::All()), true)); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.EnableEncryptEverything(); - EXPECT_TRUE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - EXPECT_TRUE(GetEncryptedTypes(&trans).Equals( - syncable::ModelTypeSet::All())); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::BOOKMARKS, - true /* is encrypted */)); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::SESSIONS, - true /* is encrypted */)); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::THEMES, - true /* is encrypted */)); - } - - // Trigger's a ReEncryptEverything with new passphrase. - testing::Mock::VerifyAndClearExpectations(&observer_); - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetEncryptionPassphrase("new_passphrase", true); - EXPECT_TRUE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - EXPECT_TRUE(GetEncryptedTypes(&trans).Equals( - syncable::ModelTypeSet::All())); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::BOOKMARKS, - true /* is encrypted */)); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::SESSIONS, - true /* is encrypted */)); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::THEMES, - true /* is encrypted */)); - } - // Calling EncryptDataTypes with an empty encrypted types should not trigger - // a reencryption and should just notify immediately. - // TODO(zea): add logic to ensure nothing was written. - testing::Mock::VerifyAndClearExpectations(&observer_); - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)).Times(0); - EXPECT_CALL(observer_, OnPassphraseAccepted()).Times(0); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.EnableEncryptEverything(); -} - -// Test that when there are no pending keys and the cryptographer is not -// initialized, we add a key based on the current GAIA password. -// (case 1 in SyncManager::SyncInternal::SetEncryptionPassphrase) -TEST_F(SyncManagerTest, SetInitialGaiaPass) { - EXPECT_FALSE(SetUpEncryption(DONT_WRITE_NIGORI, UNINITIALIZED)); - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetEncryptionPassphrase("new_passphrase", false); - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByTagLookup(kNigoriTag)); - sync_pb::NigoriSpecifics nigori = node.GetNigoriSpecifics(); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - EXPECT_TRUE(cryptographer->CanDecrypt(nigori.encrypted())); - } -} - -// Test that when there are no pending keys and we have on the old GAIA -// password, we update and re-encrypt everything with the new GAIA password. -// (case 1 in SyncManager::SyncInternal::SetEncryptionPassphrase) -TEST_F(SyncManagerTest, UpdateGaiaPass) { - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - Cryptographer verifier(&encryptor_); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - std::string bootstrap_token; - cryptographer->GetBootstrapToken(&bootstrap_token); - verifier.Bootstrap(bootstrap_token); - } - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetEncryptionPassphrase("new_passphrase", false); - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - // Verify the default key has changed. - sync_pb::EncryptedData encrypted; - cryptographer->GetKeys(&encrypted); - EXPECT_FALSE(verifier.CanDecrypt(encrypted)); - } -} - -// Sets a new explicit passphrase. This should update the bootstrap token -// and re-encrypt everything. -// (case 2 in SyncManager::SyncInternal::SetEncryptionPassphrase) -TEST_F(SyncManagerTest, SetPassphraseWithPassword) { - Cryptographer verifier(&encryptor_); - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - // Store the default (soon to be old) key. - Cryptographer* cryptographer = trans.GetCryptographer(); - std::string bootstrap_token; - cryptographer->GetBootstrapToken(&bootstrap_token); - verifier.Bootstrap(bootstrap_token); - - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - - WriteNode password_node(&trans); - EXPECT_TRUE(password_node.InitUniqueByCreation(syncable::PASSWORDS, - root_node, "foo")); - sync_pb::PasswordSpecificsData data; - data.set_password_value("secret"); - password_node.SetPasswordSpecifics(data); - } - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetEncryptionPassphrase("new_passphrase", true); - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - // Verify the default key has changed. - sync_pb::EncryptedData encrypted; - cryptographer->GetKeys(&encrypted); - EXPECT_FALSE(verifier.CanDecrypt(encrypted)); - - ReadNode password_node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - password_node.InitByClientTagLookup(syncable::PASSWORDS, - "foo")); - const sync_pb::PasswordSpecificsData& data = - password_node.GetPasswordSpecifics(); - EXPECT_EQ("secret", data.password_value()); - } -} - -// Manually set the pending keys in the cryptographer/nigori to reflect the data -// being encrypted with a new (unprovided) GAIA password, then supply the -// password. -// (case 7 in SyncManager::SyncInternal::SetDecryptionPassphrase) -TEST_F(SyncManagerTest, SupplyPendingGAIAPass) { - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - Cryptographer other_cryptographer(&encryptor_); - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - std::string bootstrap_token; - cryptographer->GetBootstrapToken(&bootstrap_token); - other_cryptographer.Bootstrap(bootstrap_token); - - // Now update the nigori to reflect the new keys, and update the - // cryptographer to have pending keys. - KeyParams params = {"localhost", "dummy", "passphrase2"}; - other_cryptographer.AddKey(params); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByTagLookup(kNigoriTag)); - sync_pb::NigoriSpecifics nigori; - other_cryptographer.GetKeys(nigori.mutable_encrypted()); - cryptographer->Update(nigori); - EXPECT_TRUE(cryptographer->has_pending_keys()); - node.SetNigoriSpecifics(nigori); - } - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetDecryptionPassphrase("passphrase2"); - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - // Verify we're encrypting with the new key. - sync_pb::EncryptedData encrypted; - cryptographer->GetKeys(&encrypted); - EXPECT_TRUE(other_cryptographer.CanDecrypt(encrypted)); - } -} - -// Manually set the pending keys in the cryptographer/nigori to reflect the data -// being encrypted with an old (unprovided) GAIA password. Attempt to supply -// the current GAIA password and verify the bootstrap token is updated. Then -// supply the old GAIA password, and verify we re-encrypt all data with the -// new GAIA password. -// (cases 4 and 5 in SyncManager::SyncInternal::SetEncryptionPassphrase) -TEST_F(SyncManagerTest, SupplyPendingOldGAIAPass) { - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - Cryptographer other_cryptographer(&encryptor_); - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - std::string bootstrap_token; - cryptographer->GetBootstrapToken(&bootstrap_token); - other_cryptographer.Bootstrap(bootstrap_token); - - // Now update the nigori to reflect the new keys, and update the - // cryptographer to have pending keys. - KeyParams params = {"localhost", "dummy", "old_gaia"}; - other_cryptographer.AddKey(params); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByTagLookup(kNigoriTag)); - sync_pb::NigoriSpecifics nigori; - other_cryptographer.GetKeys(nigori.mutable_encrypted()); - node.SetNigoriSpecifics(nigori); - cryptographer->Update(nigori); - - // other_cryptographer now contains all encryption keys, and is encrypting - // with the newest gaia. - KeyParams new_params = {"localhost", "dummy", "new_gaia"}; - other_cryptographer.AddKey(new_params); - } - // The bootstrap token should have been updated. Save it to ensure it's based - // on the new GAIA password. - std::string bootstrap_token; - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)) - .WillOnce(SaveArg<0>(&bootstrap_token)); - EXPECT_CALL(observer_, OnPassphraseRequired(_,_)); - sync_manager_.SetEncryptionPassphrase("new_gaia", false); - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); - testing::Mock::VerifyAndClearExpectations(&observer_); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_initialized()); - EXPECT_FALSE(cryptographer->is_ready()); - // Verify we're encrypting with the new key, even though we have pending - // keys. - sync_pb::EncryptedData encrypted; - other_cryptographer.GetKeys(&encrypted); - EXPECT_TRUE(cryptographer->CanDecrypt(encrypted)); - } - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetEncryptionPassphrase("old_gaia", false); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - - // Verify we're encrypting with the new key. - sync_pb::EncryptedData encrypted; - other_cryptographer.GetKeys(&encrypted); - EXPECT_TRUE(cryptographer->CanDecrypt(encrypted)); - - // Verify the saved bootstrap token is based on the new gaia password. - Cryptographer temp_cryptographer(&encryptor_); - temp_cryptographer.Bootstrap(bootstrap_token); - EXPECT_TRUE(temp_cryptographer.CanDecrypt(encrypted)); - } -} - -// Manually set the pending keys in the cryptographer/nigori to reflect the data -// being encrypted with an explicit (unprovided) passphrase, then supply the -// passphrase. -// (case 9 in SyncManager::SyncInternal::SetDecryptionPassphrase) -TEST_F(SyncManagerTest, SupplyPendingExplicitPass) { - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - Cryptographer other_cryptographer(&encryptor_); - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - std::string bootstrap_token; - cryptographer->GetBootstrapToken(&bootstrap_token); - other_cryptographer.Bootstrap(bootstrap_token); - - // Now update the nigori to reflect the new keys, and update the - // cryptographer to have pending keys. - KeyParams params = {"localhost", "dummy", "explicit"}; - other_cryptographer.AddKey(params); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByTagLookup(kNigoriTag)); - sync_pb::NigoriSpecifics nigori; - other_cryptographer.GetKeys(nigori.mutable_encrypted()); - cryptographer->Update(nigori); - EXPECT_TRUE(cryptographer->has_pending_keys()); - nigori.set_using_explicit_passphrase(true); - node.SetNigoriSpecifics(nigori); - } - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetDecryptionPassphrase("explicit"); - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - // Verify we're encrypting with the new key. - sync_pb::EncryptedData encrypted; - cryptographer->GetKeys(&encrypted); - EXPECT_TRUE(other_cryptographer.CanDecrypt(encrypted)); - } -} - -// Manually set the pending keys in the cryptographer/nigori to reflect the data -// being encrypted with a new (unprovided) GAIA password, then supply the -// password as a user-provided password. -// This is the android case 7/8. -TEST_F(SyncManagerTest, SupplyPendingGAIAPassUserProvided) { - EXPECT_FALSE(SetUpEncryption(DONT_WRITE_NIGORI, UNINITIALIZED)); - Cryptographer other_cryptographer(&encryptor_); - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - // Now update the nigori to reflect the new keys, and update the - // cryptographer to have pending keys. - KeyParams params = {"localhost", "dummy", "passphrase"}; - other_cryptographer.AddKey(params); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByTagLookup(kNigoriTag)); - sync_pb::NigoriSpecifics nigori; - other_cryptographer.GetKeys(nigori.mutable_encrypted()); - node.SetNigoriSpecifics(nigori); - cryptographer->Update(nigori); - EXPECT_FALSE(cryptographer->is_ready()); - } - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetEncryptionPassphrase("passphrase", false); - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - } -} - -TEST_F(SyncManagerTest, SetPassphraseWithEmptyPasswordNode) { - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - int64 node_id = 0; - std::string tag = "foo"; - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - - WriteNode password_node(&trans); - EXPECT_TRUE(password_node.InitUniqueByCreation(syncable::PASSWORDS, - root_node, tag)); - node_id = password_node.GetId(); - } - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetEncryptionPassphrase("new_passphrase", true); - EXPECT_FALSE(sync_manager_.EncryptEverythingEnabledForTest()); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode password_node(&trans); - EXPECT_EQ(BaseNode::INIT_FAILED_DECRYPT_IF_NECESSARY, - password_node.InitByClientTagLookup(syncable::PASSWORDS, - tag)); - } - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode password_node(&trans); - EXPECT_EQ(BaseNode::INIT_FAILED_DECRYPT_IF_NECESSARY, - password_node.InitByIdLookup(node_id)); - } -} - -TEST_F(SyncManagerTest, NudgeDelayTest) { - EXPECT_EQ(sync_manager_.GetNudgeDelayTimeDelta(syncable::BOOKMARKS), - base::TimeDelta::FromMilliseconds( - SyncManager::kDefaultNudgeDelayMilliseconds)); - - EXPECT_EQ(sync_manager_.GetNudgeDelayTimeDelta(syncable::AUTOFILL), - base::TimeDelta::FromSeconds( - browser_sync::kDefaultShortPollIntervalSeconds)); - - EXPECT_EQ(sync_manager_.GetNudgeDelayTimeDelta(syncable::PREFERENCES), - base::TimeDelta::FromMilliseconds( - SyncManager::kPreferencesNudgeDelayMilliseconds)); -} - -// Friended by WriteNode, so can't be in an anonymouse namespace. -TEST_F(SyncManagerTest, EncryptBookmarksWithLegacyData) { - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - std::string title; - SyncAPINameToServerName("Google", &title); - std::string url = "http://www.google.com"; - std::string raw_title2 = ".."; // An invalid cosmo title. - std::string title2; - SyncAPINameToServerName(raw_title2, &title2); - std::string url2 = "http://www.bla.com"; - - // Create a bookmark using the legacy format. - int64 node_id1 = MakeNode(sync_manager_.GetUserShare(), - syncable::BOOKMARKS, - "testtag"); - int64 node_id2 = MakeNode(sync_manager_.GetUserShare(), - syncable::BOOKMARKS, - "testtag2"); - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByIdLookup(node_id1)); - - sync_pb::EntitySpecifics entity_specifics; - entity_specifics.mutable_bookmark()->set_url(url); - node.SetEntitySpecifics(entity_specifics); - - // Set the old style title. - syncable::MutableEntry* node_entry = node.entry_; - node_entry->Put(syncable::NON_UNIQUE_NAME, title); - - WriteNode node2(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node2.InitByIdLookup(node_id2)); - - sync_pb::EntitySpecifics entity_specifics2; - entity_specifics2.mutable_bookmark()->set_url(url2); - node2.SetEntitySpecifics(entity_specifics2); - - // Set the old style title. - syncable::MutableEntry* node_entry2 = node2.entry_; - node_entry2->Put(syncable::NON_UNIQUE_NAME, title2); - } - - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByIdLookup(node_id1)); - EXPECT_EQ(syncable::BOOKMARKS, node.GetModelType()); - EXPECT_EQ(title, node.GetTitle()); - EXPECT_EQ(title, node.GetBookmarkSpecifics().title()); - EXPECT_EQ(url, node.GetBookmarkSpecifics().url()); - - ReadNode node2(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node2.InitByIdLookup(node_id2)); - EXPECT_EQ(syncable::BOOKMARKS, node2.GetModelType()); - // We should de-canonicalize the title in GetTitle(), but the title in the - // specifics should be stored in the server legal form. - EXPECT_EQ(raw_title2, node2.GetTitle()); - EXPECT_EQ(title2, node2.GetBookmarkSpecifics().title()); - EXPECT_EQ(url2, node2.GetBookmarkSpecifics().url()); - } - - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::BOOKMARKS, - false /* not encrypted */)); - } - - EXPECT_CALL(observer_, - OnEncryptedTypesChanged( - HasModelTypes(syncable::ModelTypeSet::All()), true)); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.EnableEncryptEverything(); - EXPECT_TRUE(sync_manager_.EncryptEverythingEnabledForTest()); - - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - EXPECT_TRUE(GetEncryptedTypes(&trans).Equals( - syncable::ModelTypeSet::All())); - EXPECT_TRUE(syncable::VerifyDataTypeEncryptionForTest( - trans.GetWrappedTrans(), - trans.GetCryptographer(), - syncable::BOOKMARKS, - true /* is encrypted */)); - - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node.InitByIdLookup(node_id1)); - EXPECT_EQ(syncable::BOOKMARKS, node.GetModelType()); - EXPECT_EQ(title, node.GetTitle()); - EXPECT_EQ(title, node.GetBookmarkSpecifics().title()); - EXPECT_EQ(url, node.GetBookmarkSpecifics().url()); - - ReadNode node2(&trans); - EXPECT_EQ(BaseNode::INIT_OK, node2.InitByIdLookup(node_id2)); - EXPECT_EQ(syncable::BOOKMARKS, node2.GetModelType()); - // We should de-canonicalize the title in GetTitle(), but the title in the - // specifics should be stored in the server legal form. - EXPECT_EQ(raw_title2, node2.GetTitle()); - EXPECT_EQ(title2, node2.GetBookmarkSpecifics().title()); - EXPECT_EQ(url2, node2.GetBookmarkSpecifics().url()); - } -} - -// Create a bookmark and set the title/url, then verify the data was properly -// set. This replicates the unique way bookmarks have of creating sync nodes. -// See BookmarkChangeProcessor::PlaceSyncNode(..). -TEST_F(SyncManagerTest, CreateLocalBookmark) { - std::string title = "title"; - GURL url("url"); - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - WriteNode node(&trans); - ASSERT_TRUE(node.InitByCreation(syncable::BOOKMARKS, root_node, NULL)); - node.SetIsFolder(false); - node.SetTitle(UTF8ToWide(title)); - node.SetURL(url); - } - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode root_node(&trans); - root_node.InitByRootLookup(); - int64 child_id = root_node.GetFirstChildId(); - - ReadNode node(&trans); - ASSERT_EQ(BaseNode::INIT_OK, node.InitByIdLookup(child_id)); - EXPECT_FALSE(node.GetIsFolder()); - EXPECT_EQ(title, node.GetTitle()); - EXPECT_EQ(url, node.GetURL()); - } -} - -// Verifies WriteNode::UpdateEntryWithEncryption does not make unnecessary -// changes. -TEST_F(SyncManagerTest, UpdateEntryWithEncryption) { - std::string client_tag = "title"; - sync_pb::EntitySpecifics entity_specifics; - entity_specifics.mutable_bookmark()->set_url("url"); - entity_specifics.mutable_bookmark()->set_title("title"); - MakeServerNode(sync_manager_.GetUserShare(), syncable::BOOKMARKS, client_tag, - BaseNode::GenerateSyncableHash(syncable::BOOKMARKS, - client_tag), - entity_specifics); - // New node shouldn't start off unsynced. - EXPECT_FALSE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - // Manually change to the same data. Should not set is_unsynced. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - node.SetEntitySpecifics(entity_specifics); - } - EXPECT_FALSE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - - // Encrypt the datatatype, should set is_unsynced. - EXPECT_CALL(observer_, - OnEncryptedTypesChanged( - HasModelTypes(syncable::ModelTypeSet::All()), true)); - EXPECT_CALL(observer_, OnEncryptionComplete()); - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, FULL_ENCRYPTION)); - - sync_manager_.RefreshNigori(kTestChromeVersion, base::Bind(&DoNothing)); - PumpLoop(); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - const syncable::Entry* node_entry = node.GetEntry(); - const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS); - EXPECT_TRUE(specifics.has_encrypted()); - EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME)); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - EXPECT_TRUE(cryptographer->CanDecryptUsingDefaultKey( - specifics.encrypted())); - } - EXPECT_TRUE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - - // Set a new passphrase. Should set is_unsynced. - testing::Mock::VerifyAndClearExpectations(&observer_); - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetEncryptionPassphrase("new_passphrase", true); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - const syncable::Entry* node_entry = node.GetEntry(); - const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS); - EXPECT_TRUE(specifics.has_encrypted()); - EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME)); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->is_ready()); - EXPECT_TRUE(cryptographer->CanDecryptUsingDefaultKey( - specifics.encrypted())); - } - EXPECT_TRUE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - - // Force a re-encrypt everything. Should not set is_unsynced. - testing::Mock::VerifyAndClearExpectations(&observer_); - EXPECT_CALL(observer_, OnEncryptionComplete()); - - sync_manager_.RefreshNigori(kTestChromeVersion, base::Bind(&DoNothing)); - PumpLoop(); - - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - const syncable::Entry* node_entry = node.GetEntry(); - const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS); - EXPECT_TRUE(specifics.has_encrypted()); - EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME)); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->CanDecryptUsingDefaultKey( - specifics.encrypted())); - } - EXPECT_FALSE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - - // Manually change to the same data. Should not set is_unsynced. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - node.SetEntitySpecifics(entity_specifics); - const syncable::Entry* node_entry = node.GetEntry(); - const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS); - EXPECT_TRUE(specifics.has_encrypted()); - EXPECT_FALSE(node_entry->Get(IS_UNSYNCED)); - EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME)); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->CanDecryptUsingDefaultKey( - specifics.encrypted())); - } - EXPECT_FALSE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - - // Manually change to different data. Should set is_unsynced. - { - entity_specifics.mutable_bookmark()->set_url("url2"); - entity_specifics.mutable_bookmark()->set_title("title2"); - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - node.SetEntitySpecifics(entity_specifics); - const syncable::Entry* node_entry = node.GetEntry(); - const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS); - EXPECT_TRUE(specifics.has_encrypted()); - EXPECT_TRUE(node_entry->Get(IS_UNSYNCED)); - EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME)); - Cryptographer* cryptographer = trans.GetCryptographer(); - EXPECT_TRUE(cryptographer->CanDecryptUsingDefaultKey( - specifics.encrypted())); - } -} - -// Passwords have their own handling for encryption. Verify it does not result -// in unnecessary writes via SetEntitySpecifics. -TEST_F(SyncManagerTest, UpdatePasswordSetEntitySpecificsNoChange) { - std::string client_tag = "title"; - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - sync_pb::EntitySpecifics entity_specifics; - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - sync_pb::PasswordSpecificsData data; - data.set_password_value("secret"); - cryptographer->Encrypt( - data, - entity_specifics.mutable_password()-> - mutable_encrypted()); - } - MakeServerNode(sync_manager_.GetUserShare(), syncable::PASSWORDS, client_tag, - BaseNode::GenerateSyncableHash(syncable::PASSWORDS, - client_tag), - entity_specifics); - // New node shouldn't start off unsynced. - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PASSWORDS, client_tag)); - - // Manually change to the same data via SetEntitySpecifics. Should not set - // is_unsynced. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::PASSWORDS, client_tag)); - node.SetEntitySpecifics(entity_specifics); - } - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PASSWORDS, client_tag)); -} - -// Passwords have their own handling for encryption. Verify it does not result -// in unnecessary writes via SetPasswordSpecifics. -TEST_F(SyncManagerTest, UpdatePasswordSetPasswordSpecifics) { - std::string client_tag = "title"; - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - sync_pb::EntitySpecifics entity_specifics; - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - sync_pb::PasswordSpecificsData data; - data.set_password_value("secret"); - cryptographer->Encrypt( - data, - entity_specifics.mutable_password()-> - mutable_encrypted()); - } - MakeServerNode(sync_manager_.GetUserShare(), syncable::PASSWORDS, client_tag, - BaseNode::GenerateSyncableHash(syncable::PASSWORDS, - client_tag), - entity_specifics); - // New node shouldn't start off unsynced. - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PASSWORDS, client_tag)); - - // Manually change to the same data via SetPasswordSpecifics. Should not set - // is_unsynced. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::PASSWORDS, client_tag)); - node.SetPasswordSpecifics(node.GetPasswordSpecifics()); - } - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PASSWORDS, client_tag)); - - // Manually change to different data. Should set is_unsynced. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::PASSWORDS, client_tag)); - Cryptographer* cryptographer = trans.GetCryptographer(); - sync_pb::PasswordSpecificsData data; - data.set_password_value("secret2"); - cryptographer->Encrypt( - data, - entity_specifics.mutable_password()->mutable_encrypted()); - node.SetPasswordSpecifics(data); - const syncable::Entry* node_entry = node.GetEntry(); - EXPECT_TRUE(node_entry->Get(IS_UNSYNCED)); - } -} - -// Passwords have their own handling for encryption. Verify setting a new -// passphrase updates the data. -TEST_F(SyncManagerTest, UpdatePasswordNewPassphrase) { - std::string client_tag = "title"; - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - sync_pb::EntitySpecifics entity_specifics; - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - sync_pb::PasswordSpecificsData data; - data.set_password_value("secret"); - cryptographer->Encrypt( - data, - entity_specifics.mutable_password()->mutable_encrypted()); - } - MakeServerNode(sync_manager_.GetUserShare(), syncable::PASSWORDS, client_tag, - BaseNode::GenerateSyncableHash(syncable::PASSWORDS, - client_tag), - entity_specifics); - // New node shouldn't start off unsynced. - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PASSWORDS, client_tag)); - - // Set a new passphrase. Should set is_unsynced. - testing::Mock::VerifyAndClearExpectations(&observer_); - EXPECT_CALL(observer_, OnBootstrapTokenUpdated(_)); - EXPECT_CALL(observer_, OnPassphraseAccepted()); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.SetEncryptionPassphrase("new_passphrase", true); - EXPECT_TRUE(ResetUnsyncedEntry(syncable::PASSWORDS, client_tag)); -} - -// Passwords have their own handling for encryption. Verify it does not result -// in unnecessary writes via ReencryptEverything. -TEST_F(SyncManagerTest, UpdatePasswordReencryptEverything) { - std::string client_tag = "title"; - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - sync_pb::EntitySpecifics entity_specifics; - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - Cryptographer* cryptographer = trans.GetCryptographer(); - sync_pb::PasswordSpecificsData data; - data.set_password_value("secret"); - cryptographer->Encrypt( - data, - entity_specifics.mutable_password()->mutable_encrypted()); - } - MakeServerNode(sync_manager_.GetUserShare(), syncable::PASSWORDS, client_tag, - BaseNode::GenerateSyncableHash(syncable::PASSWORDS, - client_tag), - entity_specifics); - // New node shouldn't start off unsynced. - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PASSWORDS, client_tag)); - - // Force a re-encrypt everything. Should not set is_unsynced. - testing::Mock::VerifyAndClearExpectations(&observer_); - EXPECT_CALL(observer_, OnEncryptionComplete()); - sync_manager_.RefreshNigori(kTestChromeVersion, base::Bind(&DoNothing)); - PumpLoop(); - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PASSWORDS, client_tag)); -} - -// Verify SetTitle(..) doesn't unnecessarily set IS_UNSYNCED for bookmarks -// when we write the same data, but does set it when we write new data. -TEST_F(SyncManagerTest, SetBookmarkTitle) { - std::string client_tag = "title"; - sync_pb::EntitySpecifics entity_specifics; - entity_specifics.mutable_bookmark()->set_url("url"); - entity_specifics.mutable_bookmark()->set_title("title"); - MakeServerNode(sync_manager_.GetUserShare(), syncable::BOOKMARKS, client_tag, - BaseNode::GenerateSyncableHash(syncable::BOOKMARKS, - client_tag), - entity_specifics); - // New node shouldn't start off unsynced. - EXPECT_FALSE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - - // Manually change to the same title. Should not set is_unsynced. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - node.SetTitle(UTF8ToWide(client_tag)); - } - EXPECT_FALSE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - - // Manually change to new title. Should set is_unsynced. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - node.SetTitle(UTF8ToWide("title2")); - } - EXPECT_TRUE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); -} - -// Verify SetTitle(..) doesn't unnecessarily set IS_UNSYNCED for encrypted -// bookmarks when we write the same data, but does set it when we write new -// data. -TEST_F(SyncManagerTest, SetBookmarkTitleWithEncryption) { - std::string client_tag = "title"; - sync_pb::EntitySpecifics entity_specifics; - entity_specifics.mutable_bookmark()->set_url("url"); - entity_specifics.mutable_bookmark()->set_title("title"); - MakeServerNode(sync_manager_.GetUserShare(), syncable::BOOKMARKS, client_tag, - BaseNode::GenerateSyncableHash(syncable::BOOKMARKS, - client_tag), - entity_specifics); - // New node shouldn't start off unsynced. - EXPECT_FALSE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - - // Encrypt the datatatype, should set is_unsynced. - EXPECT_CALL(observer_, - OnEncryptedTypesChanged( - HasModelTypes(syncable::ModelTypeSet::All()), true)); - EXPECT_CALL(observer_, OnEncryptionComplete()); - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, FULL_ENCRYPTION)); - sync_manager_.RefreshNigori(kTestChromeVersion, base::Bind(&DoNothing)); - PumpLoop(); - EXPECT_TRUE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - - // Manually change to the same title. Should not set is_unsynced. - // NON_UNIQUE_NAME should be kEncryptedString. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - node.SetTitle(UTF8ToWide(client_tag)); - const syncable::Entry* node_entry = node.GetEntry(); - const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS); - EXPECT_TRUE(specifics.has_encrypted()); - EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME)); - } - EXPECT_FALSE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); - - // Manually change to new title. Should set is_unsynced. NON_UNIQUE_NAME - // should still be kEncryptedString. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - node.SetTitle(UTF8ToWide("title2")); - const syncable::Entry* node_entry = node.GetEntry(); - const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS); - EXPECT_TRUE(specifics.has_encrypted()); - EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME)); - } - EXPECT_TRUE(ResetUnsyncedEntry(syncable::BOOKMARKS, client_tag)); -} - -// Verify SetTitle(..) doesn't unnecessarily set IS_UNSYNCED for non-bookmarks -// when we write the same data, but does set it when we write new data. -TEST_F(SyncManagerTest, SetNonBookmarkTitle) { - std::string client_tag = "title"; - sync_pb::EntitySpecifics entity_specifics; - entity_specifics.mutable_preference()->set_name("name"); - entity_specifics.mutable_preference()->set_value("value"); - MakeServerNode(sync_manager_.GetUserShare(), - syncable::PREFERENCES, - client_tag, - BaseNode::GenerateSyncableHash(syncable::PREFERENCES, - client_tag), - entity_specifics); - // New node shouldn't start off unsynced. - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PREFERENCES, client_tag)); - - // Manually change to the same title. Should not set is_unsynced. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::PREFERENCES, client_tag)); - node.SetTitle(UTF8ToWide(client_tag)); - } - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PREFERENCES, client_tag)); - - // Manually change to new title. Should set is_unsynced. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::PREFERENCES, client_tag)); - node.SetTitle(UTF8ToWide("title2")); - } - EXPECT_TRUE(ResetUnsyncedEntry(syncable::PREFERENCES, client_tag)); -} - -// Verify SetTitle(..) doesn't unnecessarily set IS_UNSYNCED for encrypted -// non-bookmarks when we write the same data or when we write new data -// data (should remained kEncryptedString). -TEST_F(SyncManagerTest, SetNonBookmarkTitleWithEncryption) { - std::string client_tag = "title"; - sync_pb::EntitySpecifics entity_specifics; - entity_specifics.mutable_preference()->set_name("name"); - entity_specifics.mutable_preference()->set_value("value"); - MakeServerNode(sync_manager_.GetUserShare(), - syncable::PREFERENCES, - client_tag, - BaseNode::GenerateSyncableHash(syncable::PREFERENCES, - client_tag), - entity_specifics); - // New node shouldn't start off unsynced. - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PREFERENCES, client_tag)); - - // Encrypt the datatatype, should set is_unsynced. - EXPECT_CALL(observer_, - OnEncryptedTypesChanged( - HasModelTypes(syncable::ModelTypeSet::All()), true)); - EXPECT_CALL(observer_, OnEncryptionComplete()); - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, FULL_ENCRYPTION)); - sync_manager_.RefreshNigori(kTestChromeVersion, base::Bind(&DoNothing)); - PumpLoop(); - EXPECT_TRUE(ResetUnsyncedEntry(syncable::PREFERENCES, client_tag)); - - // Manually change to the same title. Should not set is_unsynced. - // NON_UNIQUE_NAME should be kEncryptedString. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::PREFERENCES, client_tag)); - node.SetTitle(UTF8ToWide(client_tag)); - const syncable::Entry* node_entry = node.GetEntry(); - const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS); - EXPECT_TRUE(specifics.has_encrypted()); - EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME)); - } - EXPECT_FALSE(ResetUnsyncedEntry(syncable::PREFERENCES, client_tag)); - - // Manually change to new title. Should not set is_unsynced because the - // NON_UNIQUE_NAME should still be kEncryptedString. - { - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::PREFERENCES, client_tag)); - node.SetTitle(UTF8ToWide("title2")); - const syncable::Entry* node_entry = node.GetEntry(); - const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS); - EXPECT_TRUE(specifics.has_encrypted()); - EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME)); - EXPECT_FALSE(node_entry->Get(IS_UNSYNCED)); - } -} - -// Create an encrypted entry when the cryptographer doesn't think the type is -// marked for encryption. Ensure reads/writes don't break and don't unencrypt -// the data. -TEST_F(SyncManagerTest, SetPreviouslyEncryptedSpecifics) { - std::string client_tag = "tag"; - std::string url = "url"; - std::string url2 = "new_url"; - std::string title = "title"; - sync_pb::EntitySpecifics entity_specifics; - EXPECT_TRUE(SetUpEncryption(WRITE_TO_NIGORI, DEFAULT_ENCRYPTION)); - { - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - browser_sync::Cryptographer* crypto = trans.GetCryptographer(); - sync_pb::EntitySpecifics bm_specifics; - bm_specifics.mutable_bookmark()->set_title("title"); - bm_specifics.mutable_bookmark()->set_url("url"); - sync_pb::EncryptedData encrypted; - crypto->Encrypt(bm_specifics, &encrypted); - entity_specifics.mutable_encrypted()->CopyFrom(encrypted); - syncable::AddDefaultFieldValue(syncable::BOOKMARKS, &entity_specifics); - } - MakeServerNode(sync_manager_.GetUserShare(), syncable::BOOKMARKS, client_tag, - BaseNode::GenerateSyncableHash(syncable::BOOKMARKS, - client_tag), - entity_specifics); - - { - // Verify the data. - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - EXPECT_EQ(title, node.GetTitle()); - EXPECT_EQ(GURL(url), node.GetURL()); - } - - { - // Overwrite the url (which overwrites the specifics). - WriteTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - WriteNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - node.SetURL(GURL(url2)); - } - - { - // Verify it's still encrypted and it has the most recent url. - ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare()); - ReadNode node(&trans); - EXPECT_EQ(BaseNode::INIT_OK, - node.InitByClientTagLookup(syncable::BOOKMARKS, client_tag)); - EXPECT_EQ(title, node.GetTitle()); - EXPECT_EQ(GURL(url2), node.GetURL()); - const syncable::Entry* node_entry = node.GetEntry(); - EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME)); - const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS); - EXPECT_TRUE(specifics.has_encrypted()); - } -} - -} // namespace browser_sync |