diff options
Diffstat (limited to 'chrome/common/notification_details.h')
| -rw-r--r-- | chrome/common/notification_details.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/common/notification_details.h b/chrome/common/notification_details.h index ee10111..2c914d7 100644 --- a/chrome/common/notification_details.h +++ b/chrome/common/notification_details.h @@ -33,7 +33,7 @@ class NotificationDetails { } protected: - NotificationDetails(const void* ptr) : ptr_(ptr) {} + explicit NotificationDetails(const void* ptr) : ptr_(ptr) {} // Declaring this const allows Details<T> to be used with both T = Foo and // T = const Foo. @@ -43,8 +43,9 @@ class NotificationDetails { template <class T> class Details : public NotificationDetails { public: - Details(T* ptr) : NotificationDetails(ptr) {} - Details(const NotificationDetails& other) + // TODO(erg): Our code hard relies on implicit conversion + Details(T* ptr) : NotificationDetails(ptr) {} // NOLINT + Details(const NotificationDetails& other) // NOLINT : NotificationDetails(other) {} T* operator->() const { return ptr(); } |
