diff options
Diffstat (limited to 'chrome')
| -rw-r--r-- | chrome/common/extensions/api/extension_api.cc | 2 | ||||
| -rw-r--r-- | chrome/common/extensions/api/extension_api_unittest.cc | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/chrome/common/extensions/api/extension_api.cc b/chrome/common/extensions/api/extension_api.cc index 6bbd8df..3178975 100644 --- a/chrome/common/extensions/api/extension_api.cc +++ b/chrome/common/extensions/api/extension_api.cc @@ -268,10 +268,12 @@ bool ExtensionAPI::IsPrivileged(const std::string& full_name) { std::vector<std::string> split; base::SplitString(full_name, '.', &split); std::reverse(split.begin(), split.end()); + CHECK(!split.empty()); // |full_name| was empty or only whitespace. api_name = split.back(); split.pop_back(); if (api_name == "experimental") { + CHECK(!split.empty()); // |full_name| was "experimental" alone. api_name += "." + split.back(); split.pop_back(); } diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc index bf240e1..1c5a22e3 100644 --- a/chrome/common/extensions/api/extension_api_unittest.cc +++ b/chrome/common/extensions/api/extension_api_unittest.cc @@ -26,7 +26,6 @@ TEST(ExtensionAPI, IsPrivileged) { EXPECT_TRUE(extension_api.IsPrivileged("extension.lastError")); // Default unknown names to privileged for paranoia's sake. - EXPECT_TRUE(extension_api.IsPrivileged("")); EXPECT_TRUE(extension_api.IsPrivileged("<unknown-namespace>")); EXPECT_TRUE(extension_api.IsPrivileged("extension.<unknown-member>")); |