diff options
Diffstat (limited to 'components')
-rw-r--r-- | components/variations/processed_study.cc | 4 | ||||
-rw-r--r-- | components/variations/variations_seed_processor_unittest.cc | 20 |
2 files changed, 14 insertions, 10 deletions
diff --git a/components/variations/processed_study.cc b/components/variations/processed_study.cc index a34f894..9d0e4f1 100644 --- a/components/variations/processed_study.cc +++ b/components/variations/processed_study.cc @@ -23,13 +23,13 @@ bool ValidateStudyAndComputeTotalProbability( return false; } if (study.filter().has_min_version() && - !base::Version::IsValidWildcardString(study.filter().min_version())) { + !Version::IsValidWildcardString(study.filter().min_version())) { DVLOG(1) << study.name() << " has invalid min version: " << study.filter().min_version(); return false; } if (study.filter().has_max_version() && - !base::Version::IsValidWildcardString(study.filter().max_version())) { + !Version::IsValidWildcardString(study.filter().max_version())) { DVLOG(1) << study.name() << " has invalid max version: " << study.filter().max_version(); return false; diff --git a/components/variations/variations_seed_processor_unittest.cc b/components/variations/variations_seed_processor_unittest.cc index e03fcd9..cbf0864 100644 --- a/components/variations/variations_seed_processor_unittest.cc +++ b/components/variations/variations_seed_processor_unittest.cc @@ -399,8 +399,9 @@ TEST_F(VariationsSeedProcessorTest, CheckStudyVersion) { for (size_t i = 0; i < ARRAYSIZE_UNSAFE(min_test_cases); ++i) { filter.set_min_version(min_test_cases[i].min_version); - const bool result = seed_processor.CheckStudyVersion( - filter, base::Version(min_test_cases[i].version)); + const bool result = + seed_processor.CheckStudyVersion(filter, + Version(min_test_cases[i].version)); EXPECT_EQ(min_test_cases[i].expected_result, result) << "Min. version case " << i << " failed!"; } @@ -408,8 +409,9 @@ TEST_F(VariationsSeedProcessorTest, CheckStudyVersion) { for (size_t i = 0; i < ARRAYSIZE_UNSAFE(max_test_cases); ++i) { filter.set_max_version(max_test_cases[i].max_version); - const bool result = seed_processor.CheckStudyVersion( - filter, base::Version(max_test_cases[i].version)); + const bool result = + seed_processor.CheckStudyVersion(filter, + Version(max_test_cases[i].version)); EXPECT_EQ(max_test_cases[i].expected_result, result) << "Max version case " << i << " failed!"; } @@ -421,14 +423,16 @@ TEST_F(VariationsSeedProcessorTest, CheckStudyVersion) { filter.set_max_version(max_test_cases[j].max_version); if (!min_test_cases[i].expected_result) { - const bool result = seed_processor.CheckStudyVersion( - filter, base::Version(min_test_cases[i].version)); + const bool result = + seed_processor.CheckStudyVersion( + filter, Version(min_test_cases[i].version)); EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!"; } if (!max_test_cases[j].expected_result) { - const bool result = seed_processor.CheckStudyVersion( - filter, base::Version(max_test_cases[j].version)); + const bool result = + seed_processor.CheckStudyVersion( + filter, Version(max_test_cases[j].version)); EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!"; } } |