diff options
Diffstat (limited to 'components')
6 files changed, 4 insertions, 7 deletions
diff --git a/components/autofill/core/browser/autofill_client.h b/components/autofill/core/browser/autofill_client.h index e99a28e..8cba62c 100644 --- a/components/autofill/core/browser/autofill_client.h +++ b/components/autofill/core/browser/autofill_client.h @@ -79,7 +79,6 @@ class AutofillClient { // Run |save_card_callback| if the credit card should be imported as personal // data. |metric_logger| can be used to log user actions. virtual void ConfirmSaveCreditCard( - const AutofillMetrics& metric_logger, const base::Closure& save_card_callback) = 0; // Returns true if both the platform and the device support scanning credit diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc index be7ce13..3a23c99 100644 --- a/components/autofill/core/browser/autofill_manager.cc +++ b/components/autofill/core/browser/autofill_manager.cc @@ -707,7 +707,6 @@ void AutofillManager::ImportFormData(const FormStructure& submitted_form) { // save it. if (imported_credit_card) { client_->ConfirmSaveCreditCard( - *metric_logger_, base::Bind( base::IgnoreResult(&PersonalDataManager::SaveImportedCreditCard), base::Unretained(personal_data_), diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc index c3a271a..b1ea0d9 100644 --- a/components/autofill/core/browser/autofill_metrics.cc +++ b/components/autofill/core/browser/autofill_metrics.cc @@ -265,7 +265,8 @@ AutofillMetrics::AutofillMetrics() { AutofillMetrics::~AutofillMetrics() { } -void AutofillMetrics::LogCreditCardInfoBarMetric(InfoBarMetric metric) const { +// static +void AutofillMetrics::LogCreditCardInfoBarMetric(InfoBarMetric metric) { DCHECK_LT(metric, NUM_INFO_BAR_METRICS); UMA_HISTOGRAM_ENUMERATION("Autofill.CreditCardInfoBar", metric, NUM_INFO_BAR_METRICS); diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h index 68fb824..b02d339 100644 --- a/components/autofill/core/browser/autofill_metrics.h +++ b/components/autofill/core/browser/autofill_metrics.h @@ -310,7 +310,7 @@ class AutofillMetrics { AutofillMetrics(); virtual ~AutofillMetrics(); - virtual void LogCreditCardInfoBarMetric(InfoBarMetric metric) const; + static void LogCreditCardInfoBarMetric(InfoBarMetric metric); virtual void LogDeveloperEngagementMetric( DeveloperEngagementMetric metric) const; diff --git a/components/autofill/core/browser/test_autofill_client.cc b/components/autofill/core/browser/test_autofill_client.cc index 53adfd8..dec427b 100644 --- a/components/autofill/core/browser/test_autofill_client.cc +++ b/components/autofill/core/browser/test_autofill_client.cc @@ -32,7 +32,6 @@ void TestAutofillClient::ShowAutofillSettings() { } void TestAutofillClient::ConfirmSaveCreditCard( - const AutofillMetrics& metric_logger, const base::Closure& save_card_callback) { } diff --git a/components/autofill/core/browser/test_autofill_client.h b/components/autofill/core/browser/test_autofill_client.h index 5266d8b..ed0290a 100644 --- a/components/autofill/core/browser/test_autofill_client.h +++ b/components/autofill/core/browser/test_autofill_client.h @@ -25,8 +25,7 @@ class TestAutofillClient : public AutofillClient { PrefService* GetPrefs() override; void HideRequestAutocompleteDialog() override; void ShowAutofillSettings() override; - void ConfirmSaveCreditCard(const AutofillMetrics& metric_logger, - const base::Closure& save_card_callback) override; + void ConfirmSaveCreditCard(const base::Closure& save_card_callback) override; bool HasCreditCardScanFeature() override; void ScanCreditCard(const CreditCardScanCallback& callback) override; void ShowRequestAutocompleteDialog(const FormData& form, |