1 files changed, 281 insertions, 0 deletions
diff --git a/extensions/common/manifest_handler_unittest.cc b/extensions/common/manifest_handler_unittest.cc
new file mode 100644
index 0000000..620f0d6
--- /dev/null
+++ b/extensions/common/manifest_handler_unittest.cc
@@ -0,0 +1,281 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+#include <vector>
+
+#include "base/files/file_path.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/stl_util.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/common/extensions/extension.h"
+#include "extensions/common/extension_builder.h"
+#include "extensions/common/install_warning.h"
+#include "extensions/common/manifest_handler.h"
+#include "extensions/common/value_builder.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+namespace {
+
+std::vector<std::string> SingleKey(const std::string& key) {
+  return std::vector<std::string>(1, key);
+}
+
+}  // namespace
+
+class ScopedTestingManifestHandlerRegistry {
+ public:
+  ScopedTestingManifestHandlerRegistry() {
+    old_registry_ = ManifestHandlerRegistry::SetForTesting(&registry_);
+  }
+
+  ~ScopedTestingManifestHandlerRegistry() {
+    ManifestHandlerRegistry::SetForTesting(old_registry_);
+  }
+
+  ManifestHandlerRegistry registry_;
+  ManifestHandlerRegistry* old_registry_;
+};
+
+class ManifestHandlerTest : public testing::Test {
+ public:
+  class ParsingWatcher {
+   public:
+    // Called when a manifest handler parses.
+    void Record(const std::string& name) {
+      parsed_names_.push_back(name);
+    }
+
+    const std::vector<std::string>& parsed_names() {
+      return parsed_names_;
+    }
+
+    // Returns true if |name_before| was parsed before |name_after|.
+    bool ParsedBefore(const std::string& name_before,
+                      const std::string& name_after) {
+      size_t i_before = parsed_names_.size();
+      size_t i_after = 0;
+      for (size_t i = 0; i < parsed_names_.size(); ++i) {
+        if (parsed_names_[i] == name_before)
+          i_before = i;
+        if (parsed_names_[i] == name_after)
+          i_after = i;
+      }
+      if (i_before < i_after)
+        return true;
+      return false;
+    }
+
+   private:
+    // The order of manifest handlers that we watched parsing.
+    std::vector<std::string> parsed_names_;
+  };
+
+  class TestManifestHandler : public ManifestHandler {
+   public:
+    TestManifestHandler(const std::string& name,
+                        const std::vector<std::string>& keys,
+                        const std::vector<std::string>& prereqs,
+                        ParsingWatcher* watcher)
+        : name_(name), keys_(keys), prereqs_(prereqs), watcher_(watcher) {
+    }
+
+    virtual bool Parse(Extension* extension, string16* error) OVERRIDE {
+      watcher_->Record(name_);
+      return true;
+    }
+
+    virtual const std::vector<std::string> PrerequisiteKeys() const OVERRIDE {
+      return prereqs_;
+    }
+
+   protected:
+    std::string name_;
+    std::vector<std::string> keys_;
+    std::vector<std::string> prereqs_;
+    ParsingWatcher* watcher_;
+
+    virtual const std::vector<std::string> Keys() const OVERRIDE {
+      return keys_;
+    }
+  };
+
+  class FailingTestManifestHandler : public TestManifestHandler {
+   public:
+    FailingTestManifestHandler(const std::string& name,
+                               const std::vector<std::string>& keys,
+                               const std::vector<std::string>& prereqs,
+                               ParsingWatcher* watcher)
+        : TestManifestHandler(name, keys, prereqs, watcher) {
+    }
+    virtual bool Parse(Extension* extension, string16* error) OVERRIDE {
+      *error = ASCIIToUTF16(name_);
+      return false;
+    }
+  };
+
+  class AlwaysParseTestManifestHandler : public TestManifestHandler {
+   public:
+    AlwaysParseTestManifestHandler(const std::string& name,
+                                   const std::vector<std::string>& keys,
+                                   const std::vector<std::string>& prereqs,
+                                   ParsingWatcher* watcher)
+        : TestManifestHandler(name, keys, prereqs, watcher) {
+    }
+
+    virtual bool AlwaysParseForType(Manifest::Type type) const OVERRIDE {
+      return true;
+    }
+  };
+
+  class TestManifestValidator : public ManifestHandler {
+   public:
+    TestManifestValidator(bool return_value,
+                          bool always_validate,
+                          std::vector<std::string> keys)
+        : return_value_(return_value),
+          always_validate_(always_validate),
+          keys_(keys) {
+    }
+
+    virtual bool Parse(Extension* extension, string16* error) OVERRIDE {
+      return true;
+    }
+
+    virtual bool Validate(
+        const Extension* extension,
+        std::string* error,
+        std::vector<InstallWarning>* warnings) const OVERRIDE {
+      return return_value_;
+    }
+
+    virtual bool AlwaysValidateForType(Manifest::Type type) const OVERRIDE {
+      return always_validate_;
+    }
+
+   private:
+    virtual const std::vector<std::string> Keys() const OVERRIDE {
+      return keys_;
+    }
+
+ protected:
+    bool return_value_;
+    bool always_validate_;
+    std::vector<std::string> keys_;
+  };
+};
+
+TEST_F(ManifestHandlerTest, DependentHandlers) {
+  ScopedTestingManifestHandlerRegistry registry;
+  ParsingWatcher watcher;
+  std::vector<std::string> prereqs;
+  (new TestManifestHandler("A", SingleKey("a"), prereqs, &watcher))->Register();
+  (new TestManifestHandler("B", SingleKey("b"), prereqs, &watcher))->Register();
+  (new TestManifestHandler("J", SingleKey("j"), prereqs, &watcher))->Register();
+  (new AlwaysParseTestManifestHandler("K", SingleKey("k"), prereqs, &watcher))->
+      Register();
+  prereqs.push_back("c.d");
+  std::vector<std::string> keys;
+  keys.push_back("c.e");
+  keys.push_back("c.z");
+  (new TestManifestHandler("C.EZ", keys, prereqs, &watcher))->Register();
+  prereqs.clear();
+  prereqs.push_back("b");
+  prereqs.push_back("k");
+  (new TestManifestHandler("C.D", SingleKey("c.d"), prereqs, &watcher))->
+      Register();
+  ManifestHandler::FinalizeRegistration();
+
+  scoped_refptr<Extension> extension = ExtensionBuilder()
+      .SetManifest(DictionaryBuilder()
+                   .Set("name", "no name")
+                   .Set("version", "0")
+                   .Set("manifest_version", 2)
+                   .Set("a", 1)
+                   .Set("b", 2)
+                   .Set("c", DictionaryBuilder()
+                        .Set("d", 3)
+                        .Set("e", 4)
+                        .Set("f", 5))
+                   .Set("g", 6))
+      .Build();
+
+  // A, B, C.EZ, C.D, K
+  EXPECT_EQ(5u, watcher.parsed_names().size());
+  EXPECT_TRUE(watcher.ParsedBefore("B", "C.D"));
+  EXPECT_TRUE(watcher.ParsedBefore("K", "C.D"));
+  EXPECT_TRUE(watcher.ParsedBefore("C.D", "C.EZ"));
+}
+
+TEST_F(ManifestHandlerTest, FailingHandlers) {
+  ScopedTestingManifestHandlerRegistry registry;
+  // Can't use ExtensionBuilder, because this extension will fail to
+  // be parsed.
+  scoped_ptr<base::DictionaryValue> manifest_a(
+      DictionaryBuilder()
+      .Set("name", "no name")
+      .Set("version", "0")
+      .Set("manifest_version", 2)
+      .Set("a", 1)
+      .Build());
+
+  // Succeeds when "a" is not recognized.
+  std::string error;
+  scoped_refptr<Extension> extension = Extension::Create(
+      base::FilePath(),
+      Manifest::INVALID_LOCATION,
+      *manifest_a,
+      Extension::NO_FLAGS,
+      &error);
+  EXPECT_TRUE(extension.get());
+
+  // Register a handler for "a" that fails.
+  ParsingWatcher watcher;
+  (new FailingTestManifestHandler(
+      "A", SingleKey("a"), std::vector<std::string>(), &watcher))->Register();
+  ManifestHandler::FinalizeRegistration();
+
+  extension = Extension::Create(
+      base::FilePath(),
+      Manifest::INVALID_LOCATION,
+      *manifest_a,
+      Extension::NO_FLAGS,
+      &error);
+  EXPECT_FALSE(extension.get());
+  EXPECT_EQ("A", error);
+}
+
+TEST_F(ManifestHandlerTest, Validate) {
+  ScopedTestingManifestHandlerRegistry registry;
+  scoped_refptr<Extension> extension = ExtensionBuilder()
+      .SetManifest(DictionaryBuilder()
+                   .Set("name", "no name")
+                   .Set("version", "0")
+                   .Set("manifest_version", 2)
+                   .Set("a", 1)
+                   .Set("b", 2))
+      .Build();
+  EXPECT_TRUE(extension.get());
+
+  std::string error;
+  std::vector<InstallWarning> warnings;
+  // Always validates and fails.
+  (new TestManifestValidator(false, true, SingleKey("c")))->Register();
+  EXPECT_FALSE(
+      ManifestHandler::ValidateExtension(extension.get(), &error, &warnings));
+
+  // This overrides the registered handler for "c".
+  (new TestManifestValidator(false, false, SingleKey("c")))->Register();
+  EXPECT_TRUE(
+      ManifestHandler::ValidateExtension(extension.get(), &error, &warnings));
+
+  // Validates "a" and fails.
+  (new TestManifestValidator(false, true, SingleKey("a")))->Register();
+  EXPECT_FALSE(
+      ManifestHandler::ValidateExtension(extension.get(), &error, &warnings));
+}
+
+}  // namespace extensions