summaryrefslogtreecommitdiffstats
path: root/google_apis/gaia
diff options
context:
space:
mode:
Diffstat (limited to 'google_apis/gaia')
-rw-r--r--google_apis/gaia/fake_gaia.cc20
-rw-r--r--google_apis/gaia/gaia_auth_fetcher.cc4
-rw-r--r--google_apis/gaia/gaia_auth_util.cc5
3 files changed, 17 insertions, 12 deletions
diff --git a/google_apis/gaia/fake_gaia.cc b/google_apis/gaia/fake_gaia.cc
index d24158c..6749393 100644
--- a/google_apis/gaia/fake_gaia.cc
+++ b/google_apis/gaia/fake_gaia.cc
@@ -71,13 +71,17 @@ typedef std::map<std::string, std::string> CookieMap;
// Parses cookie name-value map our of |request|.
CookieMap GetRequestCookies(const HttpRequest& request) {
CookieMap result;
- auto iter = request.headers.find("Cookie");
+ std::map<std::string, std::string>::const_iterator iter =
+ request.headers.find("Cookie");
if (iter != request.headers.end()) {
- for (const std::string& cookie_line :
- base::SplitString(iter->second, " ", base::TRIM_WHITESPACE,
- base::SPLIT_WANT_ALL)) {
- std::vector<std::string> name_value = base::SplitString(
- cookie_line, "=", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ std::vector<std::string> cookie_nv_pairs;
+ base::SplitString(iter->second, ' ', &cookie_nv_pairs);
+ for(std::vector<std::string>::const_iterator cookie_line =
+ cookie_nv_pairs.begin();
+ cookie_line != cookie_nv_pairs.end();
+ ++cookie_line) {
+ std::vector<std::string> name_value;
+ base::SplitString(*cookie_line, '=', &name_value);
if (name_value.size() != 2)
continue;
@@ -437,8 +441,8 @@ const FakeGaia::AccessTokenInfo* FakeGaia::FindAccessTokenInfo(
if (auth_token.empty() || client_id.empty())
return NULL;
- std::vector<std::string> scope_list = base::SplitString(
- scope_string, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ std::vector<std::string> scope_list;
+ base::SplitString(scope_string, ' ', &scope_list);
ScopeSet scopes(scope_list.begin(), scope_list.end());
for (AccessTokenInfoMap::const_iterator entry(
diff --git a/google_apis/gaia/gaia_auth_fetcher.cc b/google_apis/gaia/gaia_auth_fetcher.cc
index 086414f..04ebd6e 100644
--- a/google_apis/gaia/gaia_auth_fetcher.cc
+++ b/google_apis/gaia/gaia_auth_fetcher.cc
@@ -508,8 +508,8 @@ bool GaiaAuthFetcher::ParseClientLoginToOAuth2Response(
// static
bool GaiaAuthFetcher::ParseClientLoginToOAuth2Cookie(const std::string& cookie,
std::string* auth_code) {
- std::vector<std::string> parts = base::SplitString(
- cookie, ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ std::vector<std::string> parts;
+ base::SplitString(cookie, ';', &parts);
// Per documentation, the cookie should have Secure and HttpOnly.
if (!CookiePartsContains(parts, kClientLoginToOAuth2CookiePartSecure) ||
!CookiePartsContains(parts, kClientLoginToOAuth2CookiePartHttpOnly)) {
diff --git a/google_apis/gaia/gaia_auth_util.cc b/google_apis/gaia/gaia_auth_util.cc
index cc5e17c..5464da6 100644
--- a/google_apis/gaia/gaia_auth_util.cc
+++ b/google_apis/gaia/gaia_auth_util.cc
@@ -21,8 +21,9 @@ const char kGooglemailDomain[] = "googlemail.com";
std::string CanonicalizeEmailImpl(const std::string& email_address,
bool change_googlemail_to_gmail) {
- std::vector<std::string> parts = base::SplitString(
- email_address, "@", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ std::vector<std::string> parts;
+ char at = '@';
+ base::SplitString(email_address, at, &parts);
if (parts.size() != 2U) {
NOTREACHED() << "expecting exactly one @, but got "
<< (parts.empty() ? 0 : parts.size() - 1)