diff options
Diffstat (limited to 'gpu/command_buffer')
-rw-r--r-- | gpu/command_buffer/service/mailbox_manager.cc | 13 | ||||
-rw-r--r-- | gpu/command_buffer/service/mailbox_manager.h | 3 | ||||
-rw-r--r-- | gpu/command_buffer/service/texture_definition.cc | 12 | ||||
-rw-r--r-- | gpu/command_buffer/service/texture_definition.h | 4 |
4 files changed, 5 insertions, 27 deletions
diff --git a/gpu/command_buffer/service/mailbox_manager.cc b/gpu/command_buffer/service/mailbox_manager.cc index 9019393..ec7ad94 100644 --- a/gpu/command_buffer/service/mailbox_manager.cc +++ b/gpu/command_buffer/service/mailbox_manager.cc @@ -4,8 +4,6 @@ #include "gpu/command_buffer/service/mailbox_manager.h" -#include <algorithm> - #include "base/rand_util.h" #include "crypto/hmac.h" #include "gpu/command_buffer/service/gl_utils.h" @@ -14,11 +12,6 @@ namespace gpu { namespace gles2 { -MailboxName::MailboxName() { - std::fill(key, key + sizeof(key), 0); - std::fill(signature, signature + sizeof(signature), 0); -} - MailboxManager::MailboxManager() : hmac_(crypto::HMAC::SHA256), textures_(std::ptr_fun(&MailboxManager::TargetNameLess)) { @@ -26,11 +19,9 @@ MailboxManager::MailboxManager() bool success = hmac_.Init( base::StringPiece(private_key_, sizeof(private_key_))); DCHECK(success); - DCHECK(!IsMailboxNameValid(MailboxName())); } MailboxManager::~MailboxManager() { - DCHECK(!textures_.size()); } void MailboxManager::GenerateMailboxName(MailboxName* name) { @@ -45,8 +36,10 @@ TextureDefinition* MailboxManager::ConsumeTexture(unsigned target, TextureDefinitionMap::iterator it = textures_.find(TargetName(target, name)); - if (it == textures_.end()) + if (it == textures_.end()) { + NOTREACHED(); return NULL; + } TextureDefinition* definition = it->second.definition.release(); textures_.erase(it); diff --git a/gpu/command_buffer/service/mailbox_manager.h b/gpu/command_buffer/service/mailbox_manager.h index 8f97dd4..337998d 100644 --- a/gpu/command_buffer/service/mailbox_manager.h +++ b/gpu/command_buffer/service/mailbox_manager.h @@ -30,8 +30,7 @@ class TextureManager; // Identifies a mailbox where a texture definition can be stored for // transferring textures between contexts that are not in the same context // group. It is a random key signed with a hash of a private key. -struct GPU_EXPORT MailboxName { - MailboxName(); +struct MailboxName { GLbyte key[GL_MAILBOX_SIZE_CHROMIUM / 2]; GLbyte signature[GL_MAILBOX_SIZE_CHROMIUM / 2]; }; diff --git a/gpu/command_buffer/service/texture_definition.cc b/gpu/command_buffer/service/texture_definition.cc index e1c606f..aba0dfa 100644 --- a/gpu/command_buffer/service/texture_definition.cc +++ b/gpu/command_buffer/service/texture_definition.cc @@ -27,18 +27,6 @@ TextureDefinition::LevelInfo::LevelInfo(GLenum target, cleared(cleared) { } -TextureDefinition::LevelInfo::LevelInfo() - : target(0), - internal_format(0), - width(0), - height(0), - depth(0), - border(0), - format(0), - type(0), - cleared(true) { -} - TextureDefinition::TextureDefinition(GLenum target, GLuint service_id, GLenum min_filter, diff --git a/gpu/command_buffer/service/texture_definition.h b/gpu/command_buffer/service/texture_definition.h index 7f7d3cd..0a9910b 100644 --- a/gpu/command_buffer/service/texture_definition.h +++ b/gpu/command_buffer/service/texture_definition.h @@ -19,7 +19,7 @@ namespace gles2 { // context using the same GLShareGroup with the corresponding service ID. class GPU_EXPORT TextureDefinition { public: - struct GPU_EXPORT LevelInfo { + struct LevelInfo { LevelInfo(GLenum target, GLenum internal_format, GLsizei width, @@ -29,8 +29,6 @@ class GPU_EXPORT TextureDefinition { GLenum format, GLenum type, bool cleared); - LevelInfo(); - GLenum target; GLenum internal_format; GLsizei width; |