diff options
Diffstat (limited to 'ipc')
-rw-r--r-- | ipc/ipc_message_utils.cc | 11 | ||||
-rw-r--r-- | ipc/ipc_message_utils_unittest.cc | 18 |
2 files changed, 12 insertions, 17 deletions
diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc index dd310c1..432853c 100644 --- a/ipc/ipc_message_utils.cc +++ b/ipc/ipc_message_utils.cc @@ -489,20 +489,13 @@ void ParamTraits<base::FileDescriptor>::Log(const param_type& p, #endif // defined(OS_POSIX) void ParamTraits<FilePath>::Write(Message* m, const param_type& p) { - ParamTraits<FilePath::StringType>::Write(m, p.value()); + p.WriteToPickle(m); } bool ParamTraits<FilePath>::Read(const Message* m, PickleIterator* iter, param_type* r) { - FilePath::StringType value; - if (!ParamTraits<FilePath::StringType>::Read(m, iter, &value)) - return false; - // Reject embedded NULs as they can cause security checks to go awry. - if (value.find(FILE_PATH_LITERAL('\0')) != FilePath::StringType::npos) - return false; - *r = FilePath(value); - return true; + return r->ReadFromPickle(iter); } void ParamTraits<FilePath>::Log(const param_type& p, std::string* l) { diff --git a/ipc/ipc_message_utils_unittest.cc b/ipc/ipc_message_utils_unittest.cc index 2a49b9a..f9cb553 100644 --- a/ipc/ipc_message_utils_unittest.cc +++ b/ipc/ipc_message_utils_unittest.cc @@ -55,17 +55,19 @@ TEST(IPCMessageUtilsTest, NestedMessages) { // Tests that detection of various bad parameters is working correctly. TEST(IPCMessageUtilsTest, ParameterValidation) { + FilePath::StringType ok_string(FILE_PATH_LITERAL("hello"), 5); + FilePath::StringType bad_string(FILE_PATH_LITERAL("hel\0o"), 5); + + // Change this if ParamTraits<FilePath>::Write() changes. IPC::Message message; - FilePath::StringType okString(FILE_PATH_LITERAL("hello"), 5); - FilePath::StringType badString(FILE_PATH_LITERAL("hel\0o"), 5); - FilePath okPath(okString); - FilePath badPath(badString); - ParamTraits<FilePath>::Write(&message, okPath); - ParamTraits<FilePath>::Write(&message, badPath); + ParamTraits<FilePath::StringType>::Write(&message, ok_string); + ParamTraits<FilePath::StringType>::Write(&message, bad_string); PickleIterator iter(message); - ASSERT_TRUE(ParamTraits<FilePath>::Read(&message, &iter, &okPath)); - ASSERT_FALSE(ParamTraits<FilePath>::Read(&message, &iter, &badPath)); + FilePath ok_path; + FilePath bad_path; + ASSERT_TRUE(ParamTraits<FilePath>::Read(&message, &iter, &ok_path)); + ASSERT_FALSE(ParamTraits<FilePath>::Read(&message, &iter, &bad_path)); } } // namespace |