diff options
Diffstat (limited to 'net/http/http_network_transaction_unittest.cc')
-rw-r--r-- | net/http/http_network_transaction_unittest.cc | 177 |
1 files changed, 114 insertions, 63 deletions
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc index 007f0fb..c18fa4d 100644 --- a/net/http/http_network_transaction_unittest.cc +++ b/net/http/http_network_transaction_unittest.cc @@ -351,8 +351,9 @@ ProxyService* CreateFixedProxyService(const std::string& proxy) { } -HttpNetworkSession* CreateSession(ProxyService* proxy_service) { - return new HttpNetworkSession(proxy_service); +HttpNetworkSession* CreateSession(ProxyService* proxy_service, + ClientSocketFactory* client_socket_factory) { + return new HttpNetworkSession(proxy_service, client_socket_factory); } class HttpNetworkTransactionTest : public PlatformTest { @@ -384,8 +385,10 @@ SimpleGetHelperResult SimpleGetHelper(MockRead data_reads[]) { SimpleGetHelperResult out; scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -466,8 +469,10 @@ std::string MockGetHostName() { TEST_F(HttpNetworkTransactionTest, Basic) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); } TEST_F(HttpNetworkTransactionTest, SimpleGET) { @@ -577,8 +582,10 @@ TEST_F(HttpNetworkTransactionTest, StopsReading204) { // message body (since HEAD has none). TEST_F(HttpNetworkTransactionTest, Head) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "HEAD"; @@ -640,7 +647,7 @@ TEST_F(HttpNetworkTransactionTest, Head) { TEST_F(HttpNetworkTransactionTest, ReuseConnection) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); scoped_refptr<HttpNetworkSession> session = - CreateSession(proxy_service.get()); + CreateSession(proxy_service.get(), &mock_socket_factory); MockRead data_reads[] = { MockRead("HTTP/1.1 200 OK\r\nContent-Length: 5\r\n\r\n"), @@ -690,8 +697,10 @@ TEST_F(HttpNetworkTransactionTest, ReuseConnection) { TEST_F(HttpNetworkTransactionTest, Ignores100) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "POST"; @@ -736,8 +745,10 @@ TEST_F(HttpNetworkTransactionTest, Ignores100) { // HTTP/1.1. TEST_F(HttpNetworkTransactionTest, Ignores1xx) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -781,7 +792,7 @@ void HttpNetworkTransactionTest::KeepAliveConnectionResendRequestTest( const MockRead& read_failure) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); scoped_refptr<HttpNetworkSession> session = - CreateSession(proxy_service.get()); + CreateSession(proxy_service.get(), &mock_socket_factory); HttpRequestInfo request; request.method = "GET"; @@ -847,8 +858,10 @@ TEST_F(HttpNetworkTransactionTest, KeepAliveConnectionEOF) { TEST_F(HttpNetworkTransactionTest, NonKeepAliveConnectionReset) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -902,8 +915,10 @@ TEST_F(HttpNetworkTransactionTest, NonKeepAliveConnectionEOF) { // (basic auth is the easiest to mock, because it has no randomness). TEST_F(HttpNetworkTransactionTest, BasicAuth) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -993,8 +1008,10 @@ TEST_F(HttpNetworkTransactionTest, BasicAuth) { // connection. TEST_F(HttpNetworkTransactionTest, BasicAuthKeepAlive) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -1071,8 +1088,10 @@ TEST_F(HttpNetworkTransactionTest, BasicAuthKeepAlive) { // connection and with no response body to drain. TEST_F(HttpNetworkTransactionTest, BasicAuthKeepAliveNoBody) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -1152,8 +1171,10 @@ TEST_F(HttpNetworkTransactionTest, BasicAuthKeepAliveNoBody) { // connection and with a large response body to drain. TEST_F(HttpNetworkTransactionTest, BasicAuthKeepAliveLargeBody) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -1240,7 +1261,7 @@ TEST_F(HttpNetworkTransactionTest, BasicAuthProxyKeepAlive) { CreateFixedProxyService("myproxy:70")); scoped_refptr<HttpNetworkSession> session( - CreateSession(proxy_service.get())); + CreateSession(proxy_service.get(), &mock_socket_factory)); scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( session.get(), &mock_socket_factory)); @@ -1343,7 +1364,7 @@ TEST_F(HttpNetworkTransactionTest, BasicAuthProxyCancelTunnel) { CreateFixedProxyService("myproxy:70")); scoped_refptr<HttpNetworkSession> session( - CreateSession(proxy_service.get())); + CreateSession(proxy_service.get(), &mock_socket_factory)); scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( session.get(), &mock_socket_factory)); @@ -1401,7 +1422,7 @@ static void ConnectStatusHelperWithExpectedStatus( CreateFixedProxyService("myproxy:70")); scoped_refptr<HttpNetworkSession> session( - CreateSession(proxy_service.get())); + CreateSession(proxy_service.get(), &mock_socket_factory)); scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( session.get(), &mock_socket_factory)); @@ -1617,7 +1638,7 @@ TEST_F(HttpNetworkTransactionTest, BasicAuthProxyThenServer) { // Configure against proxy server "myproxy:70". scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), + CreateSession(proxy_service.get(), &mock_socket_factory), &mock_socket_factory)); HttpRequestInfo request; @@ -1756,8 +1777,10 @@ TEST_F(HttpNetworkTransactionTest, NTLMAuth1) { MockGetHostName); scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -1884,8 +1907,10 @@ TEST_F(HttpNetworkTransactionTest, NTLMAuth2) { MockGetHostName); scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -2093,8 +2118,10 @@ TEST_F(HttpNetworkTransactionTest, NTLMAuth2) { // fail with ERR_RESPONSE_HEADERS_TOO_BIG. TEST_F(HttpNetworkTransactionTest, LargeHeadersNoBody) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -2137,7 +2164,7 @@ TEST_F(HttpNetworkTransactionTest, DontRecycleTCPSocketForSSLTunnel) { CreateFixedProxyService("myproxy:70")); scoped_refptr<HttpNetworkSession> session( - CreateSession(proxy_service.get())); + CreateSession(proxy_service.get(), &mock_socket_factory)); scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( session.get(), &mock_socket_factory)); @@ -2196,7 +2223,7 @@ TEST_F(HttpNetworkTransactionTest, DontRecycleTCPSocketForSSLTunnel) { TEST_F(HttpNetworkTransactionTest, RecycleSocket) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); scoped_refptr<HttpNetworkSession> session( - CreateSession(proxy_service.get())); + CreateSession(proxy_service.get(), &mock_socket_factory)); scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( session.get(), &mock_socket_factory)); @@ -2256,7 +2283,7 @@ TEST_F(HttpNetworkTransactionTest, RecycleSocket) { TEST_F(HttpNetworkTransactionTest, RecycleSocketAfterZeroContentLength) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); scoped_refptr<HttpNetworkSession> session( - CreateSession(proxy_service.get())); + CreateSession(proxy_service.get(), &mock_socket_factory)); scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( session.get(), &mock_socket_factory)); @@ -2331,7 +2358,7 @@ TEST_F(HttpNetworkTransactionTest, ResendRequestOnWriteBodyError) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); scoped_refptr<HttpNetworkSession> session = - CreateSession(proxy_service.get()); + CreateSession(proxy_service.get(), &mock_socket_factory); // The first socket is used for transaction 1 and the first attempt of // transaction 2. @@ -2408,8 +2435,10 @@ TEST_F(HttpNetworkTransactionTest, ResendRequestOnWriteBodyError) { // it fails the identity from the URL is used to answer the challenge. TEST_F(HttpNetworkTransactionTest, AuthIdentityInUrl) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -2487,7 +2516,7 @@ TEST_F(HttpNetworkTransactionTest, AuthIdentityInUrl) { TEST_F(HttpNetworkTransactionTest, BasicAuthCacheAndPreauth) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); scoped_refptr<HttpNetworkSession> session = - CreateSession(proxy_service.get()); + CreateSession(proxy_service.get(), &mock_socket_factory); // Transaction 1: authenticate (foo, bar) on MyRealm1 { @@ -2908,8 +2937,10 @@ TEST_F(HttpNetworkTransactionTest, BasicAuthCacheAndPreauth) { TEST_F(HttpNetworkTransactionTest, ResetStateForRestart) { // Create a transaction (the dependencies aren't important). scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpNetworkTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpNetworkTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); // Setup some state (which we expect ResetStateForRestart() will clear). trans->header_buf_->Realloc(10); @@ -2966,8 +2997,10 @@ TEST_F(HttpNetworkTransactionTest, ResetStateForRestart) { // Test HTTPS connections to a site with a bad certificate TEST_F(HttpNetworkTransactionTest, HTTPSBadCertificate) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -3076,8 +3109,10 @@ TEST_F(HttpNetworkTransactionTest, HTTPSBadCertificateViaProxy) { mock_sockets_index = 0; mock_ssl_sockets_index = 0; - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); int rv = trans->Start(&request, &callback); EXPECT_EQ(ERR_IO_PENDING, rv); @@ -3100,8 +3135,10 @@ TEST_F(HttpNetworkTransactionTest, HTTPSBadCertificateViaProxy) { TEST_F(HttpNetworkTransactionTest, BuildRequest_UserAgent) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -3140,8 +3177,10 @@ TEST_F(HttpNetworkTransactionTest, BuildRequest_UserAgent) { TEST_F(HttpNetworkTransactionTest, BuildRequest_Referer) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -3181,8 +3220,10 @@ TEST_F(HttpNetworkTransactionTest, BuildRequest_Referer) { TEST_F(HttpNetworkTransactionTest, BuildRequest_PostContentLengthZero) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "POST"; @@ -3220,8 +3261,10 @@ TEST_F(HttpNetworkTransactionTest, BuildRequest_PostContentLengthZero) { TEST_F(HttpNetworkTransactionTest, BuildRequest_PutContentLengthZero) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "PUT"; @@ -3259,8 +3302,10 @@ TEST_F(HttpNetworkTransactionTest, BuildRequest_PutContentLengthZero) { TEST_F(HttpNetworkTransactionTest, BuildRequest_HeadContentLengthZero) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "HEAD"; @@ -3298,8 +3343,10 @@ TEST_F(HttpNetworkTransactionTest, BuildRequest_HeadContentLengthZero) { TEST_F(HttpNetworkTransactionTest, BuildRequest_CacheControlNoCache) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -3340,8 +3387,10 @@ TEST_F(HttpNetworkTransactionTest, BuildRequest_CacheControlNoCache) { TEST_F(HttpNetworkTransactionTest, BuildRequest_CacheControlValidateCache) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; @@ -3380,8 +3429,10 @@ TEST_F(HttpNetworkTransactionTest, TEST_F(HttpNetworkTransactionTest, BuildRequest_ExtraHeaders) { scoped_ptr<ProxyService> proxy_service(CreateNullProxyService()); - scoped_ptr<HttpTransaction> trans(new HttpNetworkTransaction( - CreateSession(proxy_service.get()), &mock_socket_factory)); + scoped_ptr<HttpTransaction> trans( + new HttpNetworkTransaction( + CreateSession(proxy_service.get(), &mock_socket_factory), + &mock_socket_factory)); HttpRequestInfo request; request.method = "GET"; |