diff options
Diffstat (limited to 'net/spdy')
-rw-r--r-- | net/spdy/spdy_framer_test.cc | 6 | ||||
-rw-r--r-- | net/spdy/spdy_http_utils.cc | 5 | ||||
-rw-r--r-- | net/spdy/spdy_session_spdy2_unittest.cc | 6 | ||||
-rw-r--r-- | net/spdy/spdy_session_spdy3_unittest.cc | 6 | ||||
-rw-r--r-- | net/spdy/spdy_stream.cc | 2 | ||||
-rw-r--r-- | net/spdy/spdy_stream_test_util.cc | 2 | ||||
-rw-r--r-- | net/spdy/spdy_write_queue_unittest.cc | 3 |
7 files changed, 16 insertions, 14 deletions
diff --git a/net/spdy/spdy_framer_test.cc b/net/spdy/spdy_framer_test.cc index 46d44c9..3ae8871a 100644 --- a/net/spdy/spdy_framer_test.cc +++ b/net/spdy/spdy_framer_test.cc @@ -1826,7 +1826,7 @@ TEST_P(SpdyFramerTest, CreateSynStreamUncompressed) { "max stream ID"; SpdyHeaderBlock headers; - headers[""] = "foo"; + headers[std::string()] = "foo"; headers["foo"] = "bar"; const unsigned char kV2FrameData[] = { @@ -2103,7 +2103,7 @@ TEST_P(SpdyFramerTest, CreateSynReplyUncompressed) { "SYN_REPLY frame with a 0-length header name, FIN, max stream ID"; SpdyHeaderBlock headers; - headers[""] = "foo"; + headers[std::string()] = "foo"; headers["foo"] = "bar"; const unsigned char kV2FrameData[] = { @@ -2619,7 +2619,7 @@ TEST_P(SpdyFramerTest, CreateHeadersUncompressed) { "HEADERS frame with a 0-length header name, FIN, max stream ID"; SpdyHeaderBlock headers; - headers[""] = "foo"; + headers[std::string()] = "foo"; headers["foo"] = "bar"; const unsigned char kV2FrameData[] = { diff --git a/net/spdy/spdy_http_utils.cc b/net/spdy/spdy_http_utils.cc index 41647c1..49fb8ca 100644 --- a/net/spdy/spdy_http_utils.cc +++ b/net/spdy/spdy_http_utils.cc @@ -188,8 +188,9 @@ GURL GetUrlFromHeaderBlock(const SpdyHeaderBlock& headers, if (it != headers.end()) path = it->second; - std::string url = (scheme.empty() || host_port.empty() || path.empty()) - ? "" : scheme + "://" + host_port + path; + std::string url = (scheme.empty() || host_port.empty() || path.empty()) + ? std::string() + : scheme + "://" + host_port + path; return GURL(url); } diff --git a/net/spdy/spdy_session_spdy2_unittest.cc b/net/spdy/spdy_session_spdy2_unittest.cc index 0b93815..1d7026f 100644 --- a/net/spdy/spdy_session_spdy2_unittest.cc +++ b/net/spdy/spdy_session_spdy2_unittest.cc @@ -678,8 +678,8 @@ void IPPoolingTest(SpdyPoolCloseSessionsType close_sessions_type) { SpdySessionDependencies session_deps; session_deps.host_resolver->set_synchronous_mode(true); for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_hosts); i++) { - session_deps.host_resolver->rules()->AddIPLiteralRule(test_hosts[i].name, - test_hosts[i].iplist, ""); + session_deps.host_resolver->rules()->AddIPLiteralRule( + test_hosts[i].name, test_hosts[i].iplist, std::string()); // This test requires that the HostResolver cache be populated. Normal // code would have done this already, but we do it manually. @@ -1139,7 +1139,7 @@ TEST_F(SpdySessionSpdy2Test, CloseSessionWithTwoCreatedStreams) { EXPECT_EQ(0u, spdy_stream2->stream_id()); // Ensure we don't crash while closing the session. - session->CloseSessionOnError(ERR_ABORTED, true, ""); + session->CloseSessionOnError(ERR_ABORTED, true, std::string()); EXPECT_TRUE(spdy_stream1->closed()); EXPECT_TRUE(spdy_stream2->closed()); diff --git a/net/spdy/spdy_session_spdy3_unittest.cc b/net/spdy/spdy_session_spdy3_unittest.cc index c790251..eaf23ffe 100644 --- a/net/spdy/spdy_session_spdy3_unittest.cc +++ b/net/spdy/spdy_session_spdy3_unittest.cc @@ -704,8 +704,8 @@ void IPPoolingTest(SpdyPoolCloseSessionsType close_sessions_type) { SpdySessionDependencies session_deps; session_deps.host_resolver->set_synchronous_mode(true); for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_hosts); i++) { - session_deps.host_resolver->rules()->AddIPLiteralRule(test_hosts[i].name, - test_hosts[i].iplist, ""); + session_deps.host_resolver->rules()->AddIPLiteralRule( + test_hosts[i].name, test_hosts[i].iplist, std::string()); // This test requires that the HostResolver cache be populated. Normal // code would have done this already, but we do it manually. @@ -1140,7 +1140,7 @@ TEST_F(SpdySessionSpdy3Test, CloseSessionWithTwoCreatedStreams) { EXPECT_EQ(0u, spdy_stream2->stream_id()); // Ensure we don't crash while closing the session. - session->CloseSessionOnError(ERR_ABORTED, true, ""); + session->CloseSessionOnError(ERR_ABORTED, true, std::string()); EXPECT_TRUE(spdy_stream1->closed()); EXPECT_TRUE(spdy_stream2->closed()); diff --git a/net/spdy/spdy_stream.cc b/net/spdy/spdy_stream.cc index 5725253..70412dd 100644 --- a/net/spdy/spdy_stream.cc +++ b/net/spdy/spdy_stream.cc @@ -534,7 +534,7 @@ void SpdyStream::Cancel() { cancelled_ = true; if (session_->IsStreamActive(stream_id_)) - session_->ResetStream(stream_id_, RST_STREAM_CANCEL, ""); + session_->ResetStream(stream_id_, RST_STREAM_CANCEL, std::string()); else if (stream_id_ == 0) session_->CloseCreatedStream(this, RST_STREAM_CANCEL); } diff --git a/net/spdy/spdy_stream_test_util.cc b/net/spdy/spdy_stream_test_util.cc index 3b2235f..00a58df 100644 --- a/net/spdy/spdy_stream_test_util.cc +++ b/net/spdy/spdy_stream_test_util.cc @@ -101,7 +101,7 @@ int StreamDelegateBase::WaitForClose() { std::string StreamDelegateBase::GetResponseHeaderValue( const std::string& name) const { SpdyHeaderBlock::const_iterator it = response_.find(name); - return (it == response_.end()) ? "" : it->second; + return (it == response_.end()) ? std::string() : it->second; } StreamDelegateSendImmediate::StreamDelegateSendImmediate( diff --git a/net/spdy/spdy_write_queue_unittest.cc b/net/spdy/spdy_write_queue_unittest.cc index c295db8..26029e4 100644 --- a/net/spdy/spdy_write_queue_unittest.cc +++ b/net/spdy/spdy_write_queue_unittest.cc @@ -60,7 +60,8 @@ int ProducerToInt(scoped_ptr<SpdyFrameProducer> producer) { // -- be careful to not call any functions that expect the session to // be there. SpdyStream* MakeTestStream(RequestPriority priority) { - return new SpdyStream(NULL, "", priority, 0, 0, false, BoundNetLog()); + return new SpdyStream( + NULL, std::string(), priority, 0, 0, false, BoundNetLog()); } // Add some frame producers of different priority. The producers |