summaryrefslogtreecommitdiffstats
path: root/net/url_request
diff options
context:
space:
mode:
Diffstat (limited to 'net/url_request')
-rw-r--r--net/url_request/url_request_job_manager.cc2
-rw-r--r--net/url_request/url_request_job_manager.h1
-rw-r--r--net/url_request/url_request_job_metrics.cc8
-rw-r--r--net/url_request/url_request_job_metrics.h7
-rw-r--r--net/url_request/view_cache_helper.cc16
-rw-r--r--net/url_request/view_cache_helper.h9
6 files changed, 30 insertions, 13 deletions
diff --git a/net/url_request/url_request_job_manager.cc b/net/url_request/url_request_job_manager.cc
index 0615280..edc9f75 100644
--- a/net/url_request/url_request_job_manager.cc
+++ b/net/url_request/url_request_job_manager.cc
@@ -43,6 +43,8 @@ URLRequestJobManager::URLRequestJobManager() {
#endif
}
+URLRequestJobManager::~URLRequestJobManager() {}
+
URLRequestJob* URLRequestJobManager::CreateJob(URLRequest* request) const {
#ifndef NDEBUG
DCHECK(IsAllowedThread());
diff --git a/net/url_request/url_request_job_manager.h b/net/url_request/url_request_job_manager.h
index 51de77a..c93df76 100644
--- a/net/url_request/url_request_job_manager.h
+++ b/net/url_request/url_request_job_manager.h
@@ -27,6 +27,7 @@
class URLRequestJobManager {
public:
URLRequestJobManager();
+ ~URLRequestJobManager();
// Instantiate an URLRequestJob implementation based on the registered
// interceptors and protocol factories. This will always succeed in
diff --git a/net/url_request/url_request_job_metrics.cc b/net/url_request/url_request_job_metrics.cc
index e0726da..8e7b70b 100644
--- a/net/url_request/url_request_job_metrics.cc
+++ b/net/url_request/url_request_job_metrics.cc
@@ -10,6 +10,14 @@
using base::TimeDelta;
+URLRequestJobMetrics::URLRequestJobMetrics()
+ : total_bytes_read_(0),
+ number_of_read_IO_(0),
+ success_(false) {
+}
+
+URLRequestJobMetrics::~URLRequestJobMetrics() {}
+
void URLRequestJobMetrics::AppendText(std::wstring* text) {
if (!text)
return;
diff --git a/net/url_request/url_request_job_metrics.h b/net/url_request/url_request_job_metrics.h
index 2f52c7f..ce0e4bf 100644
--- a/net/url_request/url_request_job_metrics.h
+++ b/net/url_request/url_request_job_metrics.h
@@ -18,11 +18,8 @@
class URLRequestJobMetrics {
public:
- URLRequestJobMetrics()
- : total_bytes_read_(0),
- number_of_read_IO_(0),
- success_(false) { }
- ~URLRequestJobMetrics() { }
+ URLRequestJobMetrics();
+ ~URLRequestJobMetrics();
// The original url the job has been created for.
scoped_ptr<GURL> original_url_;
diff --git a/net/url_request/view_cache_helper.cc b/net/url_request/view_cache_helper.cc
index 92701b7..4a3ad02 100644
--- a/net/url_request/view_cache_helper.cc
+++ b/net/url_request/view_cache_helper.cc
@@ -73,6 +73,22 @@ std::string FormatEntryInfo(disk_cache::Entry* entry,
namespace net {
+ViewCacheHelper::ViewCacheHelper()
+ : disk_cache_(NULL),
+ entry_(NULL),
+ iter_(NULL),
+ buf_len_(0),
+ index_(0),
+ data_(NULL),
+ callback_(NULL),
+ next_state_(STATE_NONE),
+ ALLOW_THIS_IN_INITIALIZER_LIST(
+ cache_callback_(this, &ViewCacheHelper::OnIOComplete)),
+ ALLOW_THIS_IN_INITIALIZER_LIST(
+ entry_callback_(new CancelableCompletionCallback<ViewCacheHelper>(
+ this, &ViewCacheHelper::OnIOComplete))) {
+}
+
ViewCacheHelper::~ViewCacheHelper() {
if (entry_)
entry_->Close();
diff --git a/net/url_request/view_cache_helper.h b/net/url_request/view_cache_helper.h
index dd960a9..03af714 100644
--- a/net/url_request/view_cache_helper.h
+++ b/net/url_request/view_cache_helper.h
@@ -22,14 +22,7 @@ namespace net {
class ViewCacheHelper {
public:
- ViewCacheHelper()
- : disk_cache_(NULL), entry_(NULL), iter_(NULL), buf_len_(0), index_(0),
- data_(NULL), callback_(NULL), next_state_(STATE_NONE),
- ALLOW_THIS_IN_INITIALIZER_LIST(
- cache_callback_(this, &ViewCacheHelper::OnIOComplete)),
- ALLOW_THIS_IN_INITIALIZER_LIST(
- entry_callback_(new CancelableCompletionCallback<ViewCacheHelper>(
- this, &ViewCacheHelper::OnIOComplete))) {}
+ ViewCacheHelper();
~ViewCacheHelper();
// Formats the cache information for |key| as HTML. Returns a net error code.