diff options
Diffstat (limited to 'views')
74 files changed, 625 insertions, 584 deletions
diff --git a/views/accessibility/accessibility_types.h b/views/accessibility/accessibility_types.h new file mode 100644 index 0000000..e55996e --- /dev/null +++ b/views/accessibility/accessibility_types.h @@ -0,0 +1,104 @@ +// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef VIEWS_ACCESSIBILITY_ACCESSIBILITY_TYPES_H_ +#define VIEWS_ACCESSIBILITY_ACCESSIBILITY_TYPES_H_ +#pragma once + +#include "base/basictypes.h" + +//////////////////////////////////////////////////////////////////////////////// +// +// AccessibilityTypes +// +// Provides enumerations used to preserve platform-independence in accessibility +// functions used in various Views, both in Browser\Views and Views. +// +//////////////////////////////////////////////////////////////////////////////// +class AccessibilityTypes { + public: + + // This defines states of the supported accessibility roles in our + // Views (e.g. used in View::GetAccessibleState). Any interface using roles + // must provide a conversion to its own roles (see e.g. + // ViewAccessibility::get_accState and ViewAccessibility::MSAAState). + typedef uint32 State; + enum StateFlag { + STATE_CHECKED = 1 << 0, + STATE_COLLAPSED = 1 << 1, + STATE_DEFAULT = 1 << 2, + STATE_EXPANDED = 1 << 3, + STATE_HASPOPUP = 1 << 4, + STATE_HOTTRACKED = 1 << 5, + STATE_INVISIBLE = 1 << 6, + STATE_LINKED = 1 << 7, + STATE_OFFSCREEN = 1 << 8, + STATE_PRESSED = 1 << 9, + STATE_PROTECTED = 1 << 10, + STATE_READONLY = 1 << 11, + STATE_SELECTED = 1 << 12, + STATE_FOCUSED = 1 << 13, + STATE_UNAVAILABLE = 1 << 14 + }; + + // This defines an enumeration of the supported accessibility roles in our + // Views (e.g. used in View::GetAccessibleRole). Any interface using roles + // must provide a conversion to its own roles (see e.g. + // ViewAccessibility::get_accRole and ViewAccessibility::MSAARole). + enum Role { + ROLE_ALERT, + ROLE_APPLICATION, + ROLE_BUTTONDROPDOWN, + ROLE_BUTTONMENU, + ROLE_CHECKBUTTON, + ROLE_CLIENT, + ROLE_COMBOBOX, + ROLE_DIALOG, + ROLE_GRAPHIC, + ROLE_GROUPING, + ROLE_LINK, + ROLE_MENUBAR, + ROLE_MENUITEM, + ROLE_MENUPOPUP, + ROLE_OUTLINE, + ROLE_OUTLINEITEM, + ROLE_PAGETAB, + ROLE_PAGETABLIST, + ROLE_PANE, + ROLE_PROGRESSBAR, + ROLE_PUSHBUTTON, + ROLE_RADIOBUTTON, + ROLE_SCROLLBAR, + ROLE_SEPARATOR, + ROLE_STATICTEXT, + ROLE_TEXT, + ROLE_TITLEBAR, + ROLE_TOOLBAR, + ROLE_WINDOW + }; + + // This defines an enumeration of the supported accessibility events in our + // Views (e.g. used in View::NotifyAccessibilityEvent). Any interface using + // events must provide a conversion to its own events (see e.g. + // ViewAccessibility::MSAAEvent). + enum Event { + EVENT_ALERT, + EVENT_FOCUS, + EVENT_MENUSTART, + EVENT_MENUEND, + EVENT_MENUPOPUPSTART, + EVENT_MENUPOPUPEND, + EVENT_NAME_CHANGED, + EVENT_TEXT_CHANGED, + EVENT_SELECTION_CHANGED, + EVENT_VALUE_CHANGED + }; + + private: + // Do not instantiate this class. + AccessibilityTypes() {} + ~AccessibilityTypes() {} +}; + +#endif // VIEWS_ACCESSIBILITY_ACCESSIBILITY_TYPES_H_ diff --git a/views/accessibility/native_view_accessibility_win.cc b/views/accessibility/view_accessibility.cc index 07a459e..ae9f889 100644 --- a/views/accessibility/native_view_accessibility_win.cc +++ b/views/accessibility/view_accessibility.cc @@ -1,36 +1,28 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "views/accessibility/native_view_accessibility_win.h" +#include "views/accessibility/view_accessibility.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/view_prop.h" #include "views/controls/button/native_button.h" #include "views/widget/widget.h" #include "views/widget/widget_win.h" -using ui::AccessibilityTypes; - -namespace views { - const char kViewsNativeHostPropForAccessibility[] = "Views_NativeViewHostHWNDForAccessibility"; // static -scoped_refptr<NativeViewAccessibilityWin> NativeViewAccessibilityWin::Create( - views::View* view) { - CComObject<NativeViewAccessibilityWin>* instance = NULL; - HRESULT hr = CComObject<NativeViewAccessibilityWin>::CreateInstance( - &instance); +scoped_refptr<ViewAccessibility> ViewAccessibility::Create(views::View* view) { + CComObject<ViewAccessibility>* instance = NULL; + HRESULT hr = CComObject<ViewAccessibility>::CreateInstance(&instance); DCHECK(SUCCEEDED(hr)); instance->set_view(view); - return scoped_refptr<NativeViewAccessibilityWin>(instance); + return scoped_refptr<ViewAccessibility>(instance); } // static -IAccessible* NativeViewAccessibilityWin::GetAccessibleForView( - views::View* view) { +IAccessible* ViewAccessibility::GetAccessibleForView(views::View* view) { IAccessible* accessible = NULL; // First, check to see if the view is a native view. @@ -51,18 +43,18 @@ IAccessible* NativeViewAccessibilityWin::GetAccessibleForView( } } - // Finally, use our NativeViewAccessibilityWin implementation. - return view->GetNativeViewAccessibilityWin(); + // Finally, use our ViewAccessibility implementation. + return view->GetViewAccessibility(); } -NativeViewAccessibilityWin::NativeViewAccessibilityWin() : view_(NULL) { +ViewAccessibility::ViewAccessibility() : view_(NULL) { } -NativeViewAccessibilityWin::~NativeViewAccessibilityWin() { +ViewAccessibility::~ViewAccessibility() { } // TODO(ctguil): Handle case where child View is not contained by parent. -STDMETHODIMP NativeViewAccessibilityWin::accHitTest( +STDMETHODIMP ViewAccessibility::accHitTest( LONG x_left, LONG y_top, VARIANT* child) { if (!child) return E_INVALIDARG; @@ -92,7 +84,7 @@ STDMETHODIMP NativeViewAccessibilityWin::accHitTest( return S_OK; } -HRESULT NativeViewAccessibilityWin::accDoDefaultAction(VARIANT var_id) { +HRESULT ViewAccessibility::accDoDefaultAction(VARIANT var_id) { if (!IsValidId(var_id)) return E_INVALIDARG; @@ -108,7 +100,7 @@ HRESULT NativeViewAccessibilityWin::accDoDefaultAction(VARIANT var_id) { return DISP_E_MEMBERNOTFOUND; } -STDMETHODIMP NativeViewAccessibilityWin::accLocation( +STDMETHODIMP ViewAccessibility::accLocation( LONG* x_left, LONG* y_top, LONG* width, LONG* height, VARIANT var_id) { if (!IsValidId(var_id) || !x_left || !y_top || !width || !height) return E_INVALIDARG; @@ -120,8 +112,8 @@ STDMETHODIMP NativeViewAccessibilityWin::accLocation( *width = view_->width(); *height = view_->height(); gfx::Point topleft(view_->bounds().origin()); - views::View::ConvertPointToScreen( - view_->parent() ? view_->parent() : view_, &topleft); + views::View::ConvertPointToScreen(view_->parent() ? view_->parent() : view_, + &topleft); *x_left = topleft.x(); *y_top = topleft.y(); } else { @@ -130,8 +122,8 @@ STDMETHODIMP NativeViewAccessibilityWin::accLocation( return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::accNavigate( - LONG nav_dir, VARIANT start, VARIANT* end) { +STDMETHODIMP ViewAccessibility::accNavigate(LONG nav_dir, VARIANT start, + VARIANT* end) { if (start.vt != VT_I4 || !end) return E_INVALIDARG; @@ -231,7 +223,7 @@ STDMETHODIMP NativeViewAccessibilityWin::accNavigate( return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accChild(VARIANT var_child, +STDMETHODIMP ViewAccessibility::get_accChild(VARIANT var_child, IDispatch** disp_child) { if (var_child.vt != VT_I4 || !disp_child) return E_INVALIDARG; @@ -274,7 +266,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accChild(VARIANT var_child, return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accChildCount(LONG* child_count) { +STDMETHODIMP ViewAccessibility::get_accChildCount(LONG* child_count) { if (!child_count || !view_) return E_INVALIDARG; @@ -285,7 +277,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accChildCount(LONG* child_count) { return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accDefaultAction( +STDMETHODIMP ViewAccessibility::get_accDefaultAction( VARIANT var_id, BSTR* def_action) { if (!IsValidId(var_id) || !def_action) return E_INVALIDARG; @@ -293,9 +285,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accDefaultAction( if (!view_) return E_FAIL; - ui::AccessibleViewState state; - view_->GetAccessibleState(&state); - string16 temp_action = state.default_action; + string16 temp_action = view_->GetAccessibleDefaultAction(); if (!temp_action.empty()) { *def_action = SysAllocString(temp_action.c_str()); @@ -306,8 +296,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accDefaultAction( return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accDescription( - VARIANT var_id, BSTR* desc) { +STDMETHODIMP ViewAccessibility::get_accDescription(VARIANT var_id, BSTR* desc) { if (!IsValidId(var_id) || !desc) return E_INVALIDARG; @@ -326,7 +315,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accDescription( return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accFocus(VARIANT* focus_child) { +STDMETHODIMP ViewAccessibility::get_accFocus(VARIANT* focus_child) { if (!focus_child) return E_INVALIDARG; @@ -353,7 +342,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accFocus(VARIANT* focus_child) { return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accKeyboardShortcut( +STDMETHODIMP ViewAccessibility::get_accKeyboardShortcut( VARIANT var_id, BSTR* acc_key) { if (!IsValidId(var_id) || !acc_key) return E_INVALIDARG; @@ -361,9 +350,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accKeyboardShortcut( if (!view_) return E_FAIL; - ui::AccessibleViewState state; - view_->GetAccessibleState(&state); - string16 temp_key = state.keyboard_shortcut; + string16 temp_key = view_->GetAccessibleKeyboardShortcut(); if (!temp_key.empty()) { *acc_key = SysAllocString(temp_key.c_str()); @@ -374,18 +361,17 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accKeyboardShortcut( return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accName( - VARIANT var_id, BSTR* name) { +STDMETHODIMP ViewAccessibility::get_accName(VARIANT var_id, BSTR* name) { if (!IsValidId(var_id) || !name) return E_INVALIDARG; if (!view_) return E_FAIL; + string16 temp_name; + // Retrieve the current view's name. - ui::AccessibleViewState state; - view_->GetAccessibleState(&state); - string16 temp_name = state.name; + view_->GetAccessibleName(&temp_name); if (!temp_name.empty()) { // Return name retrieved. *name = SysAllocString(temp_name.c_str()); @@ -397,8 +383,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accName( return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accParent( - IDispatch** disp_parent) { +STDMETHODIMP ViewAccessibility::get_accParent(IDispatch** disp_parent) { if (!disp_parent) return E_INVALIDARG; @@ -415,9 +400,9 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accParent( return S_FALSE; } - // For a View that has no parent (e.g. root), point the accessible parent - // to the default implementation, to interface with Windows' hierarchy - // and to support calls from e.g. WindowFromAccessibleObject. + // For a View that has no parent (e.g. root), point the accessible parent to + // the default implementation, to interface with Windows' hierarchy and to + // support calls from e.g. WindowFromAccessibleObject. HRESULT hr = ::AccessibleObjectFromWindow(view_->GetWidget()->GetNativeView(), OBJID_WINDOW, IID_IAccessible, @@ -436,23 +421,19 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accParent( return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accRole( - VARIANT var_id, VARIANT* role) { +STDMETHODIMP ViewAccessibility::get_accRole(VARIANT var_id, VARIANT* role) { if (!IsValidId(var_id) || !role) return E_INVALIDARG; if (!view_) return E_FAIL; - ui::AccessibleViewState state; - view_->GetAccessibleState(&state); role->vt = VT_I4; - role->lVal = MSAARole(state.role); + role->lVal = MSAARole(view_->GetAccessibleRole()); return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accState( - VARIANT var_id, VARIANT* state) { +STDMETHODIMP ViewAccessibility::get_accState(VARIANT var_id, VARIANT* state) { if (!IsValidId(var_id) || !state) return E_INVALIDARG; @@ -471,8 +452,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accState( return S_OK; } -STDMETHODIMP NativeViewAccessibilityWin::get_accValue( - VARIANT var_id, BSTR* value) { +STDMETHODIMP ViewAccessibility::get_accValue(VARIANT var_id, BSTR* value) { if (!IsValidId(var_id) || !value) return E_INVALIDARG; @@ -480,9 +460,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accValue( return E_FAIL; // Retrieve the current view's value. - ui::AccessibleViewState state; - view_->GetAccessibleState(&state); - string16 temp_value = state.value; + string16 temp_value = view_->GetAccessibleValue(); if (!temp_value.empty()) { // Return value retrieved. @@ -498,7 +476,7 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accValue( // Helper functions. -bool NativeViewAccessibilityWin::IsNavDirNext(int nav_dir) const { +bool ViewAccessibility::IsNavDirNext(int nav_dir) const { if (nav_dir == NAVDIR_RIGHT || nav_dir == NAVDIR_DOWN || nav_dir == NAVDIR_NEXT) { return true; @@ -506,8 +484,8 @@ bool NativeViewAccessibilityWin::IsNavDirNext(int nav_dir) const { return false; } -bool NativeViewAccessibilityWin::IsValidNav( - int nav_dir, int start_id, int lower_bound, int upper_bound) const { +bool ViewAccessibility::IsValidNav(int nav_dir, int start_id, int lower_bound, + int upper_bound) const { if (IsNavDirNext(nav_dir)) { if ((start_id + 1) > upper_bound) { return false; @@ -520,14 +498,13 @@ bool NativeViewAccessibilityWin::IsValidNav( return true; } -bool NativeViewAccessibilityWin::IsValidId(const VARIANT& child) const { +bool ViewAccessibility::IsValidId(const VARIANT& child) const { // View accessibility returns an IAccessible for each view so we only support // the CHILDID_SELF id. return (VT_I4 == child.vt) && (CHILDID_SELF == child.lVal); } -void NativeViewAccessibilityWin::SetState( - VARIANT* msaa_state, views::View* view) { +void ViewAccessibility::SetState(VARIANT* msaa_state, views::View* view) { // Ensure the output param is initialized to zero. msaa_state->lVal = 0; @@ -547,32 +524,28 @@ void NativeViewAccessibilityWin::SetState( msaa_state->lVal |= STATE_SYSTEM_FOCUSED; // Add on any view-specific states. - ui::AccessibleViewState view_state; - view->GetAccessibleState(&view_state); - msaa_state->lVal |= MSAAState(view_state.state); + msaa_state->lVal |= MSAAState(view->GetAccessibleState()); } // IAccessible functions not supported. -STDMETHODIMP NativeViewAccessibilityWin::get_accSelection(VARIANT* selected) { +STDMETHODIMP ViewAccessibility::get_accSelection(VARIANT* selected) { if (selected) selected->vt = VT_EMPTY; return E_NOTIMPL; } -STDMETHODIMP NativeViewAccessibilityWin::accSelect( - LONG flagsSelect, VARIANT var_id) { +STDMETHODIMP ViewAccessibility::accSelect(LONG flagsSelect, VARIANT var_id) { return E_NOTIMPL; } -STDMETHODIMP NativeViewAccessibilityWin::get_accHelp( - VARIANT var_id, BSTR* help) { +STDMETHODIMP ViewAccessibility::get_accHelp(VARIANT var_id, BSTR* help) { if (help) *help = NULL; return E_NOTIMPL; } -STDMETHODIMP NativeViewAccessibilityWin::get_accHelpTopic( +STDMETHODIMP ViewAccessibility::get_accHelpTopic( BSTR* help_file, VARIANT var_id, LONG* topic_id) { if (help_file) { *help_file = NULL; @@ -583,19 +556,17 @@ STDMETHODIMP NativeViewAccessibilityWin::get_accHelpTopic( return E_NOTIMPL; } -STDMETHODIMP NativeViewAccessibilityWin::put_accName( - VARIANT var_id, BSTR put_name) { +STDMETHODIMP ViewAccessibility::put_accName(VARIANT var_id, BSTR put_name) { // Deprecated. return E_NOTIMPL; } -STDMETHODIMP NativeViewAccessibilityWin::put_accValue( - VARIANT var_id, BSTR put_val) { +STDMETHODIMP ViewAccessibility::put_accValue(VARIANT var_id, BSTR put_val) { // Deprecated. return E_NOTIMPL; } -int32 NativeViewAccessibilityWin::MSAAEvent(AccessibilityTypes::Event event) { +int32 ViewAccessibility::MSAAEvent(AccessibilityTypes::Event event) { switch (event) { case AccessibilityTypes::EVENT_ALERT: return EVENT_SYSTEM_ALERT; @@ -624,7 +595,7 @@ int32 NativeViewAccessibilityWin::MSAAEvent(AccessibilityTypes::Event event) { } } -int32 NativeViewAccessibilityWin::MSAARole(AccessibilityTypes::Role role) { +int32 ViewAccessibility::MSAARole(AccessibilityTypes::Role role) { switch (role) { case AccessibilityTypes::ROLE_ALERT: return ROLE_SYSTEM_ALERT; @@ -689,7 +660,7 @@ return ROLE_SYSTEM_ALERT; } } -int32 NativeViewAccessibilityWin::MSAAState(AccessibilityTypes::State state) { +int32 ViewAccessibility::MSAAState(AccessibilityTypes::State state) { int32 msaa_state = 0; if (state & AccessibilityTypes::STATE_CHECKED) msaa_state |= STATE_SYSTEM_CHECKED; @@ -725,7 +696,7 @@ int32 NativeViewAccessibilityWin::MSAAState(AccessibilityTypes::State state) { } // static -HRESULT NativeViewAccessibilityWin::GetNativeIAccessibleInterface( +HRESULT ViewAccessibility::GetNativeIAccessibleInterface( views::NativeViewHost* native_host, IAccessible** accessible) { if (!native_host || !accessible) return E_INVALIDARG; @@ -741,7 +712,7 @@ HRESULT NativeViewAccessibilityWin::GetNativeIAccessibleInterface( } // static -HRESULT NativeViewAccessibilityWin::GetNativeIAccessibleInterface( +HRESULT ViewAccessibility::GetNativeIAccessibleInterface( HWND native_view_window , IAccessible** accessible) { if (IsWindow(native_view_window)) { LRESULT ret = SendMessage(native_view_window, WM_GETOBJECT, 0, @@ -752,5 +723,3 @@ HRESULT NativeViewAccessibilityWin::GetNativeIAccessibleInterface( return E_FAIL; } - -} // namespace views diff --git a/views/accessibility/native_view_accessibility_win.h b/views/accessibility/view_accessibility.h index 2e947e1..9e2d7b8 100644 --- a/views/accessibility/native_view_accessibility_win.h +++ b/views/accessibility/view_accessibility.h @@ -1,9 +1,9 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_WIN_H_ -#define VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_WIN_H_ +#ifndef VIEWS_ACCESSIBILITY_VIEW_ACCESSIBILITY_H_ +#define VIEWS_ACCESSIBILITY_VIEW_ACCESSIBILITY_H_ #pragma once #include <atlbase.h> @@ -12,37 +12,34 @@ #include <oleacc.h> #include "base/scoped_ptr.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "views/controls/native/native_view_host.h" #include "views/view.h" -namespace views { - //////////////////////////////////////////////////////////////////////////////// // -// NativeViewAccessibilityWin +// ViewAccessibility // // Class implementing the MSAA IAccessible COM interface for a generic View, // providing accessibility to be used by screen readers and other assistive // technology (AT). // //////////////////////////////////////////////////////////////////////////////// -class ATL_NO_VTABLE NativeViewAccessibilityWin +class ATL_NO_VTABLE ViewAccessibility : public CComObjectRootEx<CComMultiThreadModel>, public IDispatchImpl<IAccessible, &IID_IAccessible, &LIBID_Accessibility> { public: - BEGIN_COM_MAP(NativeViewAccessibilityWin) + BEGIN_COM_MAP(ViewAccessibility) COM_INTERFACE_ENTRY2(IDispatch, IAccessible) COM_INTERFACE_ENTRY(IAccessible) END_COM_MAP() // Create method for view accessibility. - static scoped_refptr<NativeViewAccessibilityWin> Create(views::View* view); + static scoped_refptr<ViewAccessibility> Create(views::View* view); // Returns the IAccessible interface for a view. static IAccessible* GetAccessibleForView(views::View* view); - virtual ~NativeViewAccessibilityWin(); + virtual ~ViewAccessibility(); void set_view(views::View* view) { view_ = view; } @@ -115,18 +112,18 @@ class ATL_NO_VTABLE NativeViewAccessibilityWin // Returns a conversion from the event (as defined in accessibility_types.h) // to an MSAA event. - static int32 MSAAEvent(ui::AccessibilityTypes::Event event); + static int32 MSAAEvent(AccessibilityTypes::Event event); // Returns a conversion from the Role (as defined in accessibility_types.h) // to an MSAA role. - static int32 MSAARole(ui::AccessibilityTypes::Role role); + static int32 MSAARole(AccessibilityTypes::Role role); // Returns a conversion from the State (as defined in accessibility_types.h) // to MSAA states set. - static int32 MSAAState(ui::AccessibilityTypes::State state); + static int32 MSAAState(AccessibilityTypes::State state); private: - NativeViewAccessibilityWin(); + ViewAccessibility(); // Determines navigation direction for accNavigate, based on left, up and // previous being mapped all to previous and right, down, next being mapped @@ -160,11 +157,9 @@ class ATL_NO_VTABLE NativeViewAccessibilityWin // Member View needed for view-specific calls. views::View* view_; - DISALLOW_COPY_AND_ASSIGN(NativeViewAccessibilityWin); + DISALLOW_COPY_AND_ASSIGN(ViewAccessibility); }; extern const char kViewsNativeHostPropForAccessibility[]; -} // namespace views - -#endif // VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_WIN_H_ +#endif // VIEWS_ACCESSIBILITY_VIEW_ACCESSIBILITY_H_ diff --git a/views/controls/button/button.cc b/views/controls/button/button.cc index 6d18204..7b6cc75 100644 --- a/views/controls/button/button.cc +++ b/views/controls/button/button.cc @@ -3,9 +3,7 @@ // found in the LICENSE file. #include "views/controls/button/button.h" - #include "base/utf_string_conversions.h" -#include "ui/base/accessibility/accessible_view_state.h" namespace views { @@ -20,12 +18,8 @@ void Button::SetTooltipText(const std::wstring& tooltip_text) { TooltipTextChanged(); } -void Button::SetAccessibleName(const string16& name) { - accessible_name_ = name; -} - -void Button::SetAccessibleKeyboardShortcut(const string16& shortcut) { - accessible_shortcut_ = shortcut; +void Button::SetAccessibleKeyboardShortcut(const std::wstring& shortcut) { + accessible_shortcut_ = WideToUTF16Hack(shortcut); } //////////////////////////////////////////////////////////////////////////////// @@ -39,10 +33,12 @@ bool Button::GetTooltipText(const gfx::Point& p, std::wstring* tooltip) { return true; } -void Button::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_PUSHBUTTON; - state->name = accessible_name_; - state->keyboard_shortcut = accessible_shortcut_; +string16 Button::GetAccessibleKeyboardShortcut() { + return accessible_shortcut_; +} + +AccessibilityTypes::Role Button::GetAccessibleRole() { + return AccessibilityTypes::ROLE_PUSHBUTTON; } //////////////////////////////////////////////////////////////////////////////// diff --git a/views/controls/button/button.h b/views/controls/button/button.h index 0c9c6c7..263e45f 100644 --- a/views/controls/button/button.h +++ b/views/controls/button/button.h @@ -36,13 +36,13 @@ class Button : public View { int mouse_event_flags() const { return mouse_event_flags_; } - void SetAccessibleName(const string16& name); - void SetAccessibleKeyboardShortcut(const string16& shortcut); + void SetAccessibleKeyboardShortcut(const std::wstring& shortcut); // Overridden from View: virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip) OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual string16 GetAccessibleKeyboardShortcut() OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole() OVERRIDE; protected: // Construct the Button with a Listener. The listener can be NULL. This can be @@ -61,7 +61,6 @@ class Button : public View { string16 tooltip_text_; // Accessibility data. - string16 accessible_name_; string16 accessible_shortcut_; // The id tag associated with this button. Used to disambiguate buttons in diff --git a/views/controls/button/button_dropdown.cc b/views/controls/button/button_dropdown.cc index a5f7ab1..d2f69e2 100644 --- a/views/controls/button/button_dropdown.cc +++ b/views/controls/button/button_dropdown.cc @@ -8,7 +8,6 @@ #include "base/message_loop.h" #include "base/utf_string_conversions.h" #include "grit/app_strings.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/l10n/l10n_util.h" #include "views/controls/menu/view_menu_delegate.h" #include "views/widget/widget.h" @@ -166,11 +165,16 @@ void ButtonDropDown::ShowDropDownMenu(gfx::NativeView window) { // //////////////////////////////////////////////////////////////////////////////// -void ButtonDropDown::GetAccessibleState(ui::AccessibleViewState* state) { - CustomButton::GetAccessibleState(state); - state->role = ui::AccessibilityTypes::ROLE_BUTTONDROPDOWN; - state->default_action = l10n_util::GetStringUTF16(IDS_APP_ACCACTION_PRESS); - state->state = ui::AccessibilityTypes::STATE_HASPOPUP; +string16 ButtonDropDown::GetAccessibleDefaultAction() { + return l10n_util::GetStringUTF16(IDS_APP_ACCACTION_PRESS); +} + +AccessibilityTypes::Role ButtonDropDown::GetAccessibleRole() { + return AccessibilityTypes::ROLE_BUTTONDROPDOWN; +} + +AccessibilityTypes::State ButtonDropDown::GetAccessibleState() { + return AccessibilityTypes::STATE_HASPOPUP; } } // namespace views diff --git a/views/controls/button/button_dropdown.h b/views/controls/button/button_dropdown.h index 32f2c5c..07b8276 100644 --- a/views/controls/button/button_dropdown.h +++ b/views/controls/button/button_dropdown.h @@ -26,7 +26,9 @@ class ButtonDropDown : public ImageButton { virtual ~ButtonDropDown(); // Accessibility accessors, overridden from View. - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual string16 GetAccessibleDefaultAction() OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole() OVERRIDE; + virtual AccessibilityTypes::State GetAccessibleState() OVERRIDE; private: // Overridden from CustomButton diff --git a/views/controls/button/checkbox.cc b/views/controls/button/checkbox.cc index 2a34cc5..719dfd8 100644 --- a/views/controls/button/checkbox.cc +++ b/views/controls/button/checkbox.cc @@ -5,7 +5,6 @@ #include "views/controls/button/checkbox.h" #include "base/logging.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/gfx/canvas.h" #include "views/controls/label.h" @@ -159,10 +158,12 @@ void Checkbox::OnBlur() { label_->set_paint_as_focused(false); } -void Checkbox::GetAccessibleState(ui::AccessibleViewState* state) { - Button::GetAccessibleState(state); - state->role = ui::AccessibilityTypes::ROLE_CHECKBUTTON; - state->state = checked() ? ui::AccessibilityTypes::STATE_CHECKED : 0; +AccessibilityTypes::Role Checkbox::GetAccessibleRole() { + return AccessibilityTypes::ROLE_CHECKBUTTON; +} + +AccessibilityTypes::State Checkbox::GetAccessibleState() { + return checked() ? AccessibilityTypes::STATE_CHECKED : 0; } std::string Checkbox::GetClassName() const { diff --git a/views/controls/button/checkbox.h b/views/controls/button/checkbox.h index 801b0fd..71d218d 100644 --- a/views/controls/button/checkbox.h +++ b/views/controls/button/checkbox.h @@ -57,7 +57,8 @@ class Checkbox : public NativeButton { virtual void OnBlur() OVERRIDE; // Accessibility accessors, overridden from View. - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole() OVERRIDE; + virtual AccessibilityTypes::State GetAccessibleState() OVERRIDE; // Overridden from NativeButton: virtual void SetLabel(const std::wstring& label) OVERRIDE; diff --git a/views/controls/button/custom_button.cc b/views/controls/button/custom_button.cc index fc349a2..1696d14 100644 --- a/views/controls/button/custom_button.cc +++ b/views/controls/button/custom_button.cc @@ -4,11 +4,9 @@ #include "views/controls/button/custom_button.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/animation/throb_animation.h" #include "ui/base/keycodes/keyboard_codes.h" #include "views/screen.h" -#include "views/widget/widget.h" namespace views { @@ -59,23 +57,24 @@ void CustomButton::SetAnimationDuration(int duration) { //////////////////////////////////////////////////////////////////////////////// // CustomButton, View overrides: -void CustomButton::GetAccessibleState(ui::AccessibleViewState* state) { - Button::GetAccessibleState(state); +AccessibilityTypes::State CustomButton::GetAccessibleState() { + int state = 0; switch (state_) { case BS_HOT: - state->state = ui::AccessibilityTypes::STATE_HOTTRACKED; + state = AccessibilityTypes::STATE_HOTTRACKED; break; case BS_PUSHED: - state->state = ui::AccessibilityTypes::STATE_PRESSED; + state = AccessibilityTypes::STATE_PRESSED; break; case BS_DISABLED: - state->state = ui::AccessibilityTypes::STATE_UNAVAILABLE; + state = AccessibilityTypes::STATE_UNAVAILABLE; break; case BS_NORMAL: case BS_COUNT: // No additional accessibility state set for this button state. break; } + return state; } void CustomButton::SetEnabled(bool enabled) { @@ -249,10 +248,8 @@ void CustomButton::SetHotTracked(bool flag) { if (state_ != BS_DISABLED) SetState(flag ? BS_HOT : BS_NORMAL); - if (flag) { - GetWidget()->NotifyAccessibilityEvent( - this, ui::AccessibilityTypes::EVENT_FOCUS, true); - } + if (flag) + NotifyAccessibilityEvent(AccessibilityTypes::EVENT_FOCUS); } bool CustomButton::IsHotTracked() const { diff --git a/views/controls/button/custom_button.h b/views/controls/button/custom_button.h index 1a0f75e..17dafbf 100644 --- a/views/controls/button/custom_button.h +++ b/views/controls/button/custom_button.h @@ -48,7 +48,7 @@ class CustomButton : public Button, void SetAnimationDuration(int duration); // Overridden from View: - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual AccessibilityTypes::State GetAccessibleState() OVERRIDE; virtual void SetEnabled(bool enabled) OVERRIDE; virtual bool IsEnabled() const OVERRIDE; virtual bool IsFocusable() const OVERRIDE; diff --git a/views/controls/button/menu_button.cc b/views/controls/button/menu_button.cc index db138bb..f88b106 100644 --- a/views/controls/button/menu_button.cc +++ b/views/controls/button/menu_button.cc @@ -7,7 +7,6 @@ #include "base/utf_string_conversions.h" #include "grit/app_strings.h" #include "grit/app_resources.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/dragdrop/drag_drop_types.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/resource/resource_bundle.h" @@ -261,11 +260,16 @@ void MenuButton::OnMouseExited(const MouseEvent& event) { // //////////////////////////////////////////////////////////////////////////////// -void MenuButton::GetAccessibleState(ui::AccessibleViewState* state) { - CustomButton::GetAccessibleState(state); - state->role = ui::AccessibilityTypes::ROLE_BUTTONMENU; - state->default_action = l10n_util::GetStringUTF16(IDS_APP_ACCACTION_PRESS); - state->state = ui::AccessibilityTypes::STATE_HASPOPUP; +string16 MenuButton::GetAccessibleDefaultAction() { + return l10n_util::GetStringUTF16(IDS_APP_ACCACTION_PRESS); +} + +AccessibilityTypes::Role MenuButton::GetAccessibleRole() { + return AccessibilityTypes::ROLE_BUTTONMENU; +} + +AccessibilityTypes::State MenuButton::GetAccessibleState() { + return AccessibilityTypes::STATE_HASPOPUP; } std::string MenuButton::GetClassName() const { diff --git a/views/controls/button/menu_button.h b/views/controls/button/menu_button.h index c6f3092..55f5a89 100644 --- a/views/controls/button/menu_button.h +++ b/views/controls/button/menu_button.h @@ -58,7 +58,9 @@ class MenuButton : public TextButton { virtual bool OnKeyReleased(const KeyEvent& e); // Accessibility accessors, overridden from View. - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual string16 GetAccessibleDefaultAction() OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole() OVERRIDE; + virtual AccessibilityTypes::State GetAccessibleState() OVERRIDE; // Returns views/MenuButton. virtual std::string GetClassName() const; diff --git a/views/controls/button/native_button_win.cc b/views/controls/button/native_button_win.cc index 2783c84..fbba56a 100644 --- a/views/controls/button/native_button_win.cc +++ b/views/controls/button/native_button_win.cc @@ -11,7 +11,6 @@ #include "base/win/scoped_comptr.h" #include "base/win/win_util.h" #include "base/win/windows_version.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "views/controls/button/checkbox.h" #include "views/controls/button/native_button.h" #include "views/controls/button/radio_button.h" @@ -72,19 +71,18 @@ void NativeButtonWin::UpdateDefault() { } void NativeButtonWin::UpdateAccessibleName() { - ui::AccessibleViewState state; - native_button_->GetAccessibleState(&state); - string16 name = state.name; - base::win::ScopedComPtr<IAccPropServices> pAccPropServices; - HRESULT hr = CoCreateInstance( - CLSID_AccPropServices, NULL, CLSCTX_SERVER, - IID_IAccPropServices, reinterpret_cast<void**>(&pAccPropServices)); - if (SUCCEEDED(hr)) { - VARIANT var; - var.vt = VT_BSTR; - var.bstrVal = SysAllocString(name.c_str()); - hr = pAccPropServices->SetHwndProp(native_view(), OBJID_WINDOW, - CHILDID_SELF, PROPID_ACC_NAME, var); + string16 name; + if (native_button_->GetAccessibleName(&name)) { + base::win::ScopedComPtr<IAccPropServices> pAccPropServices; + HRESULT hr = CoCreateInstance(CLSID_AccPropServices, NULL, CLSCTX_SERVER, + IID_IAccPropServices, reinterpret_cast<void**>(&pAccPropServices)); + if (SUCCEEDED(hr)) { + VARIANT var; + var.vt = VT_BSTR; + var.bstrVal = SysAllocString(name.c_str()); + hr = pAccPropServices->SetHwndProp(native_view(), OBJID_WINDOW, + CHILDID_SELF, PROPID_ACC_NAME, var); + } } } diff --git a/views/controls/button/radio_button.cc b/views/controls/button/radio_button.cc index f162f2c..4074da4 100644 --- a/views/controls/button/radio_button.cc +++ b/views/controls/button/radio_button.cc @@ -5,7 +5,6 @@ #include "views/controls/button/radio_button.h" #include "base/logging.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "views/widget/root_view.h" namespace views { @@ -61,9 +60,8 @@ void RadioButton::SetChecked(bool checked) { //////////////////////////////////////////////////////////////////////////////// // RadioButton, View overrides: -void RadioButton::GetAccessibleState(ui::AccessibleViewState* state) { - Checkbox::GetAccessibleState(state); - state->role = ui::AccessibilityTypes::ROLE_RADIOBUTTON; +AccessibilityTypes::Role RadioButton::GetAccessibleRole() { + return AccessibilityTypes::ROLE_RADIOBUTTON; } View* RadioButton::GetSelectedViewForGroup(int group_id) { diff --git a/views/controls/button/radio_button.h b/views/controls/button/radio_button.h index 5ff6f76..7ea35f5 100644 --- a/views/controls/button/radio_button.h +++ b/views/controls/button/radio_button.h @@ -22,18 +22,16 @@ class RadioButton : public Checkbox { virtual ~RadioButton(); // Overridden from Checkbox: - virtual void SetChecked(bool checked) OVERRIDE; + virtual void SetChecked(bool checked); // Overridden from View: - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; - virtual View* GetSelectedViewForGroup(int group_id) OVERRIDE; - virtual bool IsGroupFocusTraversable() const OVERRIDE; - virtual void OnMouseReleased(const MouseEvent& event, bool canceled) - OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole(); + virtual View* GetSelectedViewForGroup(int group_id); + virtual bool IsGroupFocusTraversable() const; + virtual void OnMouseReleased(const MouseEvent& event, bool canceled); protected: - // Overridden from View: - virtual std::string GetClassName() const OVERRIDE; + virtual std::string GetClassName() const; // Overridden from NativeButton: virtual NativeButtonWrapper* CreateWrapper(); diff --git a/views/controls/combobox/combobox.cc b/views/controls/combobox/combobox.cc index 2f77942..be7d719 100644 --- a/views/controls/combobox/combobox.cc +++ b/views/controls/combobox/combobox.cc @@ -6,7 +6,6 @@ #include "base/logging.h" #include "base/utf_string_conversions.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/keycodes/keyboard_codes.h" #include "ui/base/models/combobox_model.h" #include "views/controls/combobox/native_combobox_wrapper.h" @@ -53,10 +52,6 @@ void Combobox::SelectionChanged() { listener_->ItemChanged(this, prev_selected_item, selected_item_); } -void Combobox::SetAccessibleName(const string16& name) { - accessible_name_ = name; -} - //////////////////////////////////////////////////////////////////////////////// // Combobox, View overrides: @@ -94,10 +89,12 @@ void Combobox::OnPaintFocusBorder(gfx::Canvas* canvas) { View::OnPaintFocusBorder(canvas); } -void Combobox::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_COMBOBOX; - state->name = accessible_name_; - state->value = model_->GetItemAt(selected_item_); +AccessibilityTypes::Role Combobox::GetAccessibleRole() { + return AccessibilityTypes::ROLE_COMBOBOX; +} + +string16 Combobox::GetAccessibleValue() { + return model_->GetItemAt(selected_item_); } void Combobox::OnFocus() { diff --git a/views/controls/combobox/combobox.h b/views/controls/combobox/combobox.h index c50fadd..1de06d6 100644 --- a/views/controls/combobox/combobox.h +++ b/views/controls/combobox/combobox.h @@ -58,23 +58,20 @@ class Combobox : public View { // Accessor for |model_|. ComboboxModel* model() const { return model_; } - // Set the accessible name of the combo box. - void SetAccessibleName(const string16& name); - // Overridden from View: - virtual gfx::Size GetPreferredSize() OVERRIDE; - virtual void Layout() OVERRIDE; - virtual void SetEnabled(bool enabled) OVERRIDE; - virtual bool SkipDefaultKeyEventProcessing(const KeyEvent& e) OVERRIDE; - virtual void OnPaintFocusBorder(gfx::Canvas* canvas) OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual gfx::Size GetPreferredSize(); + virtual void Layout(); + virtual void SetEnabled(bool enabled); + virtual bool SkipDefaultKeyEventProcessing(const KeyEvent& e); + virtual void OnPaintFocusBorder(gfx::Canvas* canvas); + virtual AccessibilityTypes::Role GetAccessibleRole() OVERRIDE; + virtual string16 GetAccessibleValue() OVERRIDE; protected: - // Overridden from View: - virtual void OnFocus() OVERRIDE; + virtual void OnFocus(); virtual void ViewHierarchyChanged(bool is_add, View* parent, - View* child) OVERRIDE; - virtual std::string GetClassName() const OVERRIDE; + View* child); + virtual std::string GetClassName() const; // The object that actually implements the native combobox. NativeComboboxWrapper* native_wrapper_; @@ -89,9 +86,6 @@ class Combobox : public View { // The current selection. int selected_item_; - // The accessible name of the text field. - string16 accessible_name_; - DISALLOW_COPY_AND_ASSIGN(Combobox); }; diff --git a/views/controls/image_view.cc b/views/controls/image_view.cc index bc86e55..7f05e97 100644 --- a/views/controls/image_view.cc +++ b/views/controls/image_view.cc @@ -6,7 +6,6 @@ #include "base/logging.h" #include "base/utf_string_conversions.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/gfx/canvas.h" #include "ui/gfx/insets.h" @@ -127,9 +126,8 @@ void ImageView::OnPaint(gfx::Canvas* canvas) { } } -void ImageView::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_GRAPHIC; - state->name = tooltip_text_; +AccessibilityTypes::Role ImageView::GetAccessibleRole() { + return AccessibilityTypes::ROLE_GRAPHIC; } void ImageView::SetHorizontalAlignment(Alignment ha) { @@ -156,6 +154,7 @@ ImageView::Alignment ImageView::GetVerticalAlignment() { void ImageView::SetTooltipText(const std::wstring& tooltip) { tooltip_text_ = WideToUTF16Hack(tooltip); + SetAccessibleName(WideToUTF16Hack(tooltip)); } std::wstring ImageView::GetTooltipText() { diff --git a/views/controls/image_view.h b/views/controls/image_view.h index cde4bfd..b1791ac 100644 --- a/views/controls/image_view.h +++ b/views/controls/image_view.h @@ -75,11 +75,10 @@ class ImageView : public View { std::wstring GetTooltipText(); // Overriden from View - virtual gfx::Size GetPreferredSize() OVERRIDE; - virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; - virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip) - OVERRIDE; + virtual gfx::Size GetPreferredSize(); + virtual void OnPaint(gfx::Canvas* canvas); + virtual AccessibilityTypes::Role GetAccessibleRole(); + virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip); private: // Compute the image origin given the desired size and the receiver alignment diff --git a/views/controls/label.cc b/views/controls/label.cc index 6fedc80..1b105f0 100644 --- a/views/controls/label.cc +++ b/views/controls/label.cc @@ -12,7 +12,6 @@ #include "base/string_split.h" #include "base/string_util.h" #include "base/utf_string_conversions.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/resource/resource_bundle.h" #include "ui/base/text/text_elider.h" #include "ui/gfx/canvas_skia.h" @@ -107,6 +106,7 @@ void Label::SetText(const std::wstring& text) { text_ = WideToUTF16Hack(text); url_set_ = false; text_size_valid_ = false; + SetAccessibleName(WideToUTF16Hack(text)); PreferredSizeChanged(); SchedulePaint(); } @@ -250,10 +250,12 @@ void Label::SizeToFit(int max_width) { SizeToPreferredSize(); } -void Label::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_STATICTEXT; - state->state = ui::AccessibilityTypes::STATE_READONLY; - state->name = text_; +AccessibilityTypes::Role Label::GetAccessibleRole() { + return AccessibilityTypes::ROLE_STATICTEXT; +} + +AccessibilityTypes::State Label::GetAccessibleState() { + return AccessibilityTypes::STATE_READONLY; } void Label::SetHasFocusBorder(bool has_focus_border) { diff --git a/views/controls/label.h b/views/controls/label.h index a0ef7d2..d916659 100644 --- a/views/controls/label.h +++ b/views/controls/label.h @@ -79,7 +79,7 @@ class Label : public View { virtual void OnPaintBackground(gfx::Canvas* canvas); // Set the font. - virtual void SetFont(const gfx::Font& font); + void SetFont(const gfx::Font& font); // Set the label text. void SetText(const std::wstring& text); @@ -180,7 +180,8 @@ class Label : public View { void SizeToFit(int max_width); // Accessibility accessors, overridden from View. - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole(); + virtual AccessibilityTypes::State GetAccessibleState(); // Gets/sets the flag to determine whether the label should be collapsed when // it's hidden (not visible). If this flag is true, the label will return a diff --git a/views/controls/label_unittest.cc b/views/controls/label_unittest.cc index a7b2ac2..6d2ba91 100644 --- a/views/controls/label_unittest.cc +++ b/views/controls/label_unittest.cc @@ -5,7 +5,6 @@ #include "base/i18n/rtl.h" #include "base/utf_string_conversions.h" #include "testing/gtest/include/gtest/gtest.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/l10n/l10n_util.h" #include "ui/gfx/canvas.h" #include "views/border.h" @@ -160,11 +159,13 @@ TEST(LabelTest, Accessibility) { string16 test_text(ASCIIToUTF16("My special text.")); label.SetText(UTF16ToWideHack(test_text)); - ui::AccessibleViewState state; - label.GetAccessibleState(&state); - EXPECT_EQ(ui::AccessibilityTypes::ROLE_STATICTEXT, state.role); - EXPECT_EQ(test_text, state.name); - EXPECT_TRUE(ui::AccessibilityTypes::STATE_READONLY & state.state); + EXPECT_EQ(AccessibilityTypes::ROLE_STATICTEXT, label.GetAccessibleRole()); + + string16 name; + EXPECT_TRUE(label.GetAccessibleName(&name)); + EXPECT_EQ(test_text, name); + + EXPECT_TRUE(AccessibilityTypes::STATE_READONLY & label.GetAccessibleState()); } TEST(LabelTest, SingleLineSizing) { diff --git a/views/controls/link.cc b/views/controls/link.cc index c6e22f1..de7512b 100644 --- a/views/controls/link.cc +++ b/views/controls/link.cc @@ -9,7 +9,6 @@ #endif #include "base/logging.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/keycodes/keyboard_codes.h" #include "ui/gfx/color_utils.h" #include "ui/gfx/font.h" @@ -149,9 +148,8 @@ bool Link::SkipDefaultKeyEventProcessing(const KeyEvent& e) { (e.key_code() == ui::VKEY_RETURN); } -void Link::GetAccessibleState(ui::AccessibleViewState* state) { - Label::GetAccessibleState(state); - state->role = ui::AccessibilityTypes::ROLE_LINK; +AccessibilityTypes::Role Link::GetAccessibleRole() { + return AccessibilityTypes::ROLE_LINK; } void Link::SetFont(const gfx::Font& font) { diff --git a/views/controls/link.h b/views/controls/link.h index e616317..4c9cb8f 100644 --- a/views/controls/link.h +++ b/views/controls/link.h @@ -46,16 +46,16 @@ class Link : public Label { const LinkController* GetController(); // Overridden from View: - virtual bool OnMousePressed(const MouseEvent& event) OVERRIDE; - virtual bool OnMouseDragged(const MouseEvent& event) OVERRIDE; + virtual bool OnMousePressed(const MouseEvent& event); + virtual bool OnMouseDragged(const MouseEvent& event); virtual void OnMouseReleased(const MouseEvent& event, - bool canceled) OVERRIDE; - virtual bool OnKeyPressed(const KeyEvent& e) OVERRIDE; - virtual bool SkipDefaultKeyEventProcessing(const KeyEvent& e) OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + bool canceled); + virtual bool OnKeyPressed(const KeyEvent& e); + virtual bool SkipDefaultKeyEventProcessing(const KeyEvent& e); - // Overridden from Label: - virtual void SetFont(const gfx::Font& font) OVERRIDE; + // Accessibility accessors, overridden from View: + virtual AccessibilityTypes::Role GetAccessibleRole(); + virtual void SetFont(const gfx::Font& font); // Set whether the link is enabled. virtual void SetEnabled(bool f); diff --git a/views/controls/menu/menu_controller.cc b/views/controls/menu/menu_controller.cc index 075b92e..906bd40 100644 --- a/views/controls/menu/menu_controller.cc +++ b/views/controls/menu/menu_controller.cc @@ -760,10 +760,8 @@ void MenuController::SetSelection(MenuItemView* menu_item, // Notify an accessibility focus event on all menu items except for the root. if (menu_item && (MenuDepth(menu_item) != 1 || - menu_item->GetType() != MenuItemView::SUBMENU)) { - menu_item->GetWidget()->NotifyAccessibilityEvent( - menu_item, ui::AccessibilityTypes::EVENT_FOCUS, true); - } + menu_item->GetType() != MenuItemView::SUBMENU)) + menu_item->NotifyAccessibilityEvent(AccessibilityTypes::EVENT_FOCUS); } // static diff --git a/views/controls/menu/menu_item_view.cc b/views/controls/menu/menu_item_view.cc index c729c2e..ed44c3a 100644 --- a/views/controls/menu/menu_item_view.cc +++ b/views/controls/menu/menu_item_view.cc @@ -6,7 +6,6 @@ #include "base/utf_string_conversions.h" #include "grit/app_strings.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/models/menu_model.h" #include "ui/gfx/canvas.h" @@ -117,23 +116,27 @@ bool MenuItemView::GetTooltipText(const gfx::Point& p, std::wstring* tooltip) { return false; } -void MenuItemView::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_MENUITEM; - state->name = GetAccessibleNameForMenuItem(title_, GetAcceleratorText()); +AccessibilityTypes::Role MenuItemView::GetAccessibleRole() { + return AccessibilityTypes::ROLE_MENUITEM; +} + +AccessibilityTypes::State MenuItemView::GetAccessibleState() { + int state = 0; switch (GetType()) { case SUBMENU: - state->state |= ui::AccessibilityTypes::STATE_HASPOPUP; + state |= AccessibilityTypes::STATE_HASPOPUP; break; case CHECKBOX: case RADIO: - state->state |= GetDelegate()->IsItemChecked(GetCommand()) ? - ui::AccessibilityTypes::STATE_CHECKED : 0; + state |= GetDelegate()->IsItemChecked(GetCommand()) ? + AccessibilityTypes::STATE_CHECKED : 0; break; case NORMAL: case SEPARATOR: // No additional accessibility states currently for these menu states. break; } + return state; } // static @@ -317,6 +320,7 @@ SubmenuView* MenuItemView::CreateSubmenu() { void MenuItemView::SetTitle(const std::wstring& title) { title_ = WideToUTF16Hack(title); + SetAccessibleName(GetAccessibleNameForMenuItem(title_, GetAcceleratorText())); pref_size_.SetSize(0, 0); // Triggers preferred size recalculation. } diff --git a/views/controls/menu/menu_item_view.h b/views/controls/menu/menu_item_view.h index 89eab3c..5b5e09c 100644 --- a/views/controls/menu/menu_item_view.h +++ b/views/controls/menu/menu_item_view.h @@ -93,9 +93,9 @@ class MenuItemView : public View { virtual ~MenuItemView(); // Overridden from View: - virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip) - OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip); + virtual AccessibilityTypes::Role GetAccessibleRole(); + virtual AccessibilityTypes::State GetAccessibleState(); // Returns the preferred height of menu items. This is only valid when the // menu is about to be shown. diff --git a/views/controls/menu/menu_scroll_view_container.cc b/views/controls/menu/menu_scroll_view_container.cc index 7a644b1..6089838 100644 --- a/views/controls/menu/menu_scroll_view_container.cc +++ b/views/controls/menu/menu_scroll_view_container.cc @@ -10,7 +10,6 @@ #include <Vssym32.h> #endif -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/gfx/canvas_skia.h" #include "ui/gfx/color_utils.h" #include "views/border.h" @@ -163,8 +162,7 @@ class MenuScrollViewContainer::MenuScrollView : public View { // MenuScrollViewContainer ---------------------------------------------------- -MenuScrollViewContainer::MenuScrollViewContainer(SubmenuView* content_view) - : content_view_(content_view) { +MenuScrollViewContainer::MenuScrollViewContainer(SubmenuView* content_view) { scroll_up_button_ = new MenuScrollButton(content_view, true); scroll_down_button_ = new MenuScrollButton(content_view, false); AddChildView(scroll_up_button_); @@ -268,16 +266,14 @@ gfx::Size MenuScrollViewContainer::GetPreferredSize() { return prefsize; } -void MenuScrollViewContainer::GetAccessibleState( - ui::AccessibleViewState* state) { - // Get the name from the submenu view. - content_view_->GetAccessibleState(state); +AccessibilityTypes::Role MenuScrollViewContainer::GetAccessibleRole() { + return AccessibilityTypes::ROLE_MENUBAR; +} - // Now change the role. - state->role = ui::AccessibilityTypes::ROLE_MENUBAR; +AccessibilityTypes::State MenuScrollViewContainer::GetAccessibleState() { // Some AT (like NVDA) will not process focus events on menu item children // unless a parent claims to be focused. - state->state = ui::AccessibilityTypes::STATE_FOCUSED; + return AccessibilityTypes::STATE_FOCUSED; } } // namespace views diff --git a/views/controls/menu/menu_scroll_view_container.h b/views/controls/menu/menu_scroll_view_container.h index 48914af..5472091 100644 --- a/views/controls/menu/menu_scroll_view_container.h +++ b/views/controls/menu/menu_scroll_view_container.h @@ -24,11 +24,12 @@ class MenuScrollViewContainer : public View { View* scroll_up_button() const { return scroll_up_button_; } // View overrides. - virtual void OnPaintBackground(gfx::Canvas* canvas) OVERRIDE; - virtual void Layout() OVERRIDE; - virtual void OnBoundsChanged() OVERRIDE; - virtual gfx::Size GetPreferredSize() OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual void OnPaintBackground(gfx::Canvas* canvas); + virtual void Layout(); + virtual void OnBoundsChanged(); + virtual gfx::Size GetPreferredSize(); + virtual AccessibilityTypes::Role GetAccessibleRole(); + virtual AccessibilityTypes::State GetAccessibleState(); private: class MenuScrollView; @@ -40,9 +41,6 @@ class MenuScrollViewContainer : public View { // The scroll view. MenuScrollView* scroll_view_; - // The content view. - SubmenuView* content_view_; - DISALLOW_COPY_AND_ASSIGN(MenuScrollViewContainer); }; diff --git a/views/controls/menu/submenu_view.cc b/views/controls/menu/submenu_view.cc index fb78762..7c1f69e 100644 --- a/views/controls/menu/submenu_view.cc +++ b/views/controls/menu/submenu_view.cc @@ -4,14 +4,12 @@ #include "views/controls/menu/submenu_view.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/gfx/canvas.h" #include "views/controls/menu/menu_config.h" #include "views/controls/menu/menu_controller.h" #include "views/controls/menu/menu_host.h" #include "views/controls/menu/menu_scroll_view_container.h" #include "views/widget/root_view.h" -#include "views/widget/widget.h" // Height of the drop indicator. This should be an even number. static const int kDropIndicatorHeight = 2; @@ -127,10 +125,8 @@ void SubmenuView::OnBoundsChanged() { SchedulePaint(); } -void SubmenuView::GetAccessibleState(ui::AccessibleViewState* state) { - // Inherit most of the state from the parent menu item, except the role. - GetMenuItem()->GetAccessibleState(state); - state->role = ui::AccessibilityTypes::ROLE_MENUPOPUP; +AccessibilityTypes::Role SubmenuView::GetAccessibleRole() { + return AccessibilityTypes::ROLE_MENUPOPUP; } void SubmenuView::PaintChildren(gfx::Canvas* canvas) { @@ -237,14 +233,10 @@ void SubmenuView::ShowAt(gfx::NativeWindow parent, if (host_) { host_->ShowMenuHost(do_capture); - GetScrollViewContainer()->GetWidget()->NotifyAccessibilityEvent( - GetScrollViewContainer(), - ui::AccessibilityTypes::EVENT_MENUSTART, - true); - GetWidget()->NotifyAccessibilityEvent( - this, - ui::AccessibilityTypes::EVENT_MENUPOPUPSTART, - true); + GetScrollViewContainer()->NotifyAccessibilityEvent( + AccessibilityTypes::EVENT_MENUSTART); + + NotifyAccessibilityEvent(AccessibilityTypes::EVENT_MENUPOPUPSTART); return; } @@ -255,14 +247,10 @@ void SubmenuView::ShowAt(gfx::NativeWindow parent, ScrollRectToVisible(gfx::Rect(gfx::Point(), gfx::Size(1, 1))); host_->Init(parent, bounds, scroll_view_container_, do_capture); - GetScrollViewContainer()->GetWidget()->NotifyAccessibilityEvent( - GetScrollViewContainer(), - ui::AccessibilityTypes::EVENT_MENUSTART, - true); - GetWidget()->NotifyAccessibilityEvent( - this, - ui::AccessibilityTypes::EVENT_MENUPOPUPSTART, - true); + GetScrollViewContainer()->NotifyAccessibilityEvent( + AccessibilityTypes::EVENT_MENUSTART); + + NotifyAccessibilityEvent(AccessibilityTypes::EVENT_MENUPOPUPSTART); } void SubmenuView::Reposition(const gfx::Rect& bounds) { @@ -272,14 +260,10 @@ void SubmenuView::Reposition(const gfx::Rect& bounds) { void SubmenuView::Close() { if (host_) { - GetWidget()->NotifyAccessibilityEvent( - this, - ui::AccessibilityTypes::EVENT_MENUPOPUPEND, - true); - GetScrollViewContainer()->GetWidget()->NotifyAccessibilityEvent( - GetScrollViewContainer(), - ui::AccessibilityTypes::EVENT_MENUEND, - true); + NotifyAccessibilityEvent(AccessibilityTypes::EVENT_MENUPOPUPEND); + + GetScrollViewContainer()->NotifyAccessibilityEvent( + AccessibilityTypes::EVENT_MENUEND); host_->DestroyMenuHost(); host_ = NULL; @@ -324,6 +308,12 @@ MenuScrollViewContainer* SubmenuView::GetScrollViewContainer() { scroll_view_container_ = new MenuScrollViewContainer(this); // Otherwise MenuHost would delete us. scroll_view_container_->set_parent_owned(false); + + // Use the parent menu item accessible name for the menu view. + string16 accessible_name; + GetMenuItem()->GetAccessibleName(&accessible_name); + scroll_view_container_->SetAccessibleName(accessible_name); + SetAccessibleName(accessible_name); } return scroll_view_container_; } diff --git a/views/controls/menu/submenu_view.h b/views/controls/menu/submenu_view.h index c16c081..cbe2674 100644 --- a/views/controls/menu/submenu_view.h +++ b/views/controls/menu/submenu_view.h @@ -50,15 +50,15 @@ class SubmenuView : public View { // Positions and sizes the child views. This tiles the views vertically, // giving each child the available width. - virtual void Layout() OVERRIDE; - virtual gfx::Size GetPreferredSize() OVERRIDE; + virtual void Layout(); + virtual gfx::Size GetPreferredSize(); // View method. Overridden to schedule a paint. We do this so that when // scrolling occurs, everything is repainted correctly. - virtual void OnBoundsChanged() OVERRIDE; + virtual void OnBoundsChanged(); // Override from View. - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole(); // Painting. void PaintChildren(gfx::Canvas* canvas); @@ -66,16 +66,16 @@ class SubmenuView : public View { // Drag and drop methods. These are forwarded to the MenuController. virtual bool GetDropFormats( int* formats, - std::set<OSExchangeData::CustomFormat>* custom_formats) OVERRIDE; - virtual bool AreDropTypesRequired() OVERRIDE; - virtual bool CanDrop(const OSExchangeData& data) OVERRIDE; - virtual void OnDragEntered(const DropTargetEvent& event) OVERRIDE; - virtual int OnDragUpdated(const DropTargetEvent& event) OVERRIDE; - virtual void OnDragExited() OVERRIDE; - virtual int OnPerformDrop(const DropTargetEvent& event) OVERRIDE; + std::set<OSExchangeData::CustomFormat>* custom_formats); + virtual bool AreDropTypesRequired(); + virtual bool CanDrop(const OSExchangeData& data); + virtual void OnDragEntered(const DropTargetEvent& event); + virtual int OnDragUpdated(const DropTargetEvent& event); + virtual void OnDragExited(); + virtual int OnPerformDrop(const DropTargetEvent& event); // Scrolls on menu item boundaries. - virtual bool OnMouseWheel(const MouseWheelEvent& e) OVERRIDE; + virtual bool OnMouseWheel(const MouseWheelEvent& e); // Returns true if the menu is showing. bool IsShowing(); diff --git a/views/controls/native_control.cc b/views/controls/native_control.cc index 08d6843..34e243e 100644 --- a/views/controls/native_control.cc +++ b/views/controls/native_control.cc @@ -12,7 +12,6 @@ #include "base/logging.h" #include "base/scoped_ptr.h" -#include "ui/base/accessibility/accessibility_types.h" #include "ui/base/keycodes/keyboard_codes.h" #include "ui/base/keycodes/keyboard_code_conversion_win.h" #include "ui/base/l10n/l10n_util_win.h" @@ -282,8 +281,7 @@ void NativeControl::OnFocus() { if (container_) { DCHECK(container_->GetControl()); ::SetFocus(container_->GetControl()); - GetWidget()->NotifyAccessibilityEvent( - this, ui::AccessibilityTypes::EVENT_FOCUS, false); + NotifyAccessibilityEvent(AccessibilityTypes::EVENT_FOCUS, false); } } diff --git a/views/controls/native_control_gtk.cc b/views/controls/native_control_gtk.cc index 88035c1..a17c4cb 100644 --- a/views/controls/native_control_gtk.cc +++ b/views/controls/native_control_gtk.cc @@ -7,9 +7,7 @@ #include <gtk/gtk.h> #include "base/logging.h" -#include "ui/base/accessibility/accessibility_types.h" #include "views/focus/focus_manager.h" -#include "views/widget/widget.h" namespace views { @@ -68,8 +66,8 @@ void NativeControlGtk::VisibilityChanged(View* starting_from, bool is_visible) { void NativeControlGtk::OnFocus() { DCHECK(native_view()); gtk_widget_grab_focus(native_view()); - GetWidget()->NotifyAccessibilityEvent( - parent(), ui::AccessibilityTypes::EVENT_FOCUS, true); + + parent()->NotifyAccessibilityEvent(AccessibilityTypes::EVENT_FOCUS); } void NativeControlGtk::NativeControlCreated(GtkWidget* native_control) { diff --git a/views/controls/native_control_win.cc b/views/controls/native_control_win.cc index 13a8c2b..7e7312b 100644 --- a/views/controls/native_control_win.cc +++ b/views/controls/native_control_win.cc @@ -7,12 +7,10 @@ #include <windowsx.h> #include "base/logging.h" -#include "ui/base/accessibility/accessibility_types.h" #include "ui/base/l10n/l10n_util_win.h" #include "ui/base/view_prop.h" #include "ui/base/win/hwnd_util.h" #include "views/focus/focus_manager.h" -#include "views/widget/widget.h" using ui::ViewProp; @@ -114,8 +112,8 @@ void NativeControlWin::OnFocus() { parent_view->HasFocus(); // Send the accessibility focus notification. - parent_view->GetWidget()->NotifyAccessibilityEvent( - parent_view, ui::AccessibilityTypes::EVENT_FOCUS, send_native_event); + parent_view->NotifyAccessibilityEvent(AccessibilityTypes::EVENT_FOCUS, + send_native_event); } //////////////////////////////////////////////////////////////////////////////// diff --git a/views/controls/progress_bar.cc b/views/controls/progress_bar.cc index e460e27..a6aabb1 100644 --- a/views/controls/progress_bar.cc +++ b/views/controls/progress_bar.cc @@ -11,7 +11,6 @@ #include "base/utf_string_conversions.h" #include "third_party/skia/include/effects/SkGradientShader.h" #include "third_party/skia/include/effects/SkBlurMaskFilter.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/gfx/canvas_skia.h" #include "ui/gfx/color_utils.h" #include "ui/gfx/font.h" @@ -311,9 +310,12 @@ void ProgressBar::SetEnabled(bool enabled) { // TODO(denisromanov): Need to switch progress bar color here? } -void ProgressBar::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_PROGRESSBAR; - state->state = ui::AccessibilityTypes::STATE_READONLY; +AccessibilityTypes::Role ProgressBar::GetAccessibleRole() { + return AccessibilityTypes::ROLE_PROGRESSBAR; +} + +AccessibilityTypes::State ProgressBar::GetAccessibleState() { + return AccessibilityTypes::STATE_READONLY; } } // namespace views diff --git a/views/controls/progress_bar.h b/views/controls/progress_bar.h index 4366519..b2f1202 100644 --- a/views/controls/progress_bar.h +++ b/views/controls/progress_bar.h @@ -52,14 +52,14 @@ class ProgressBar : public View { virtual void SetTooltipText(const std::wstring& tooltip_text); // Gets the tooltip text if has been specified with SetTooltipText(). - virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip) - OVERRIDE; + virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip); // Sets the enabled state. - virtual void SetEnabled(bool enabled) OVERRIDE; + virtual void SetEnabled(bool enabled); // Accessibility accessors, overridden from View. - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole(); + virtual AccessibilityTypes::State GetAccessibleState(); // Maximum value of progress. static const int kMaxProgress; diff --git a/views/controls/progress_bar_unittest.cc b/views/controls/progress_bar_unittest.cc index c7fc4df..55acfd4 100644 --- a/views/controls/progress_bar_unittest.cc +++ b/views/controls/progress_bar_unittest.cc @@ -5,7 +5,6 @@ #include "base/string_util.h" #include "base/utf_string_conversions.h" #include "testing/gtest/include/gtest/gtest.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "views/controls/progress_bar.h" namespace views { @@ -49,11 +48,17 @@ TEST(ProgressBarTest, Accessibility) { ProgressBar bar; bar.SetProgress(62); - ui::AccessibleViewState state; - bar.GetAccessibleState(&state); - EXPECT_EQ(ui::AccessibilityTypes::ROLE_PROGRESSBAR, state.role); - EXPECT_EQ(string16(), state.name); - EXPECT_TRUE(ui::AccessibilityTypes::STATE_READONLY & state.state); + EXPECT_EQ(AccessibilityTypes::ROLE_PROGRESSBAR, bar.GetAccessibleRole()); + + string16 name; + EXPECT_FALSE(bar.GetAccessibleName(&name)); + EXPECT_EQ(string16(), name); + string16 accessible_name = ASCIIToUTF16("My progress bar"); + bar.SetAccessibleName(accessible_name); + EXPECT_TRUE(bar.GetAccessibleName(&name)); + EXPECT_EQ(accessible_name, name); + + EXPECT_TRUE(AccessibilityTypes::STATE_READONLY & bar.GetAccessibleState()); } } // namespace views diff --git a/views/controls/resize_area.cc b/views/controls/resize_area.cc index 0769cf9..b3897bb 100644 --- a/views/controls/resize_area.cc +++ b/views/controls/resize_area.cc @@ -5,7 +5,6 @@ #include "views/controls/resize_area.h" #include "base/logging.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/resource/resource_bundle.h" #if defined(OS_LINUX) @@ -75,8 +74,8 @@ void ResizeArea::OnMouseReleased(const views::MouseEvent& event, ReportResizeAmount(canceled ? initial_position_ : event.x(), true); } -void ResizeArea::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_SEPARATOR; +AccessibilityTypes::Role ResizeArea::GetAccessibleRole() { + return AccessibilityTypes::ROLE_SEPARATOR; } void ResizeArea::ReportResizeAmount(int resize_amount, bool last_update) { diff --git a/views/controls/resize_area.h b/views/controls/resize_area.h index cf9bea7..9adb60c 100644 --- a/views/controls/resize_area.h +++ b/views/controls/resize_area.h @@ -41,14 +41,13 @@ class ResizeArea : public View { virtual ~ResizeArea(); // Overridden from views::View: - virtual std::string GetClassName() const OVERRIDE; + virtual std::string GetClassName() const; virtual gfx::NativeCursor GetCursorForPoint(ui::EventType event_type, - const gfx::Point& p) OVERRIDE; - virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE; - virtual bool OnMouseDragged(const views::MouseEvent& event) OVERRIDE; - virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled) - OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + const gfx::Point& p); + virtual bool OnMousePressed(const views::MouseEvent& event); + virtual bool OnMouseDragged(const views::MouseEvent& event); + virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled); + virtual AccessibilityTypes::Role GetAccessibleRole(); private: // Report the amount the user resized by to the delegate, accounting for diff --git a/views/controls/scrollbar/scroll_bar.cc b/views/controls/scrollbar/scroll_bar.cc index 880a42a..94360bb 100644 --- a/views/controls/scrollbar/scroll_bar.cc +++ b/views/controls/scrollbar/scroll_bar.cc @@ -5,7 +5,6 @@ #include "views/controls/scrollbar/scroll_bar.h" #include "base/logging.h" -#include "ui/base/accessibility/accessible_view_state.h" namespace views { @@ -23,8 +22,8 @@ ScrollBar::ScrollBar(bool is_horiz) : is_horiz_(is_horiz), ScrollBar::~ScrollBar() { } -void ScrollBar::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_SCROLLBAR; +AccessibilityTypes::Role ScrollBar::GetAccessibleRole() { + return AccessibilityTypes::ROLE_SCROLLBAR; } bool ScrollBar::IsHorizontal() const { diff --git a/views/controls/scrollbar/scroll_bar.h b/views/controls/scrollbar/scroll_bar.h index d7f187b..faed881 100644 --- a/views/controls/scrollbar/scroll_bar.h +++ b/views/controls/scrollbar/scroll_bar.h @@ -60,7 +60,7 @@ class ScrollBar : public View { virtual ~ScrollBar(); // Overridden from View: - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole(); // Return whether this scrollbar is horizontal bool IsHorizontal() const; diff --git a/views/controls/separator.cc b/views/controls/separator.cc index bc1f522..1a3ca70 100644 --- a/views/controls/separator.cc +++ b/views/controls/separator.cc @@ -5,7 +5,6 @@ #include "views/controls/separator.h" #include "base/logging.h" -#include "ui/base/accessibility/accessible_view_state.h" #if defined(OS_LINUX) #include "views/controls/native_control_gtk.h" #elif defined(OS_WIN) @@ -93,8 +92,8 @@ std::string Separator::GetClassName() const { return kViewClassName; } -void Separator::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_SEPARATOR; +AccessibilityTypes::Role Separator::GetAccessibleRole() { + return AccessibilityTypes::ROLE_SEPARATOR; } //////////////////////////////////////////////////////////////////////////////// diff --git a/views/controls/separator.h b/views/controls/separator.h index 6c4d9c4..186d84f 100644 --- a/views/controls/separator.h +++ b/views/controls/separator.h @@ -24,15 +24,14 @@ class Separator : public View { virtual ~Separator(); // Overridden from View: - virtual void Layout() OVERRIDE; - virtual gfx::Size GetPreferredSize() OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual void Layout(); + virtual gfx::Size GetPreferredSize(); + virtual AccessibilityTypes::Role GetAccessibleRole(); protected: - // Overridden from View: virtual void ViewHierarchyChanged(bool is_add, View* parent, - View* child) OVERRIDE; - virtual std::string GetClassName() const OVERRIDE; + View* child); + virtual std::string GetClassName() const; private: void CreateNativeWrapper(); diff --git a/views/controls/single_split_view.cc b/views/controls/single_split_view.cc index 96302f7..2b076d6 100644 --- a/views/controls/single_split_view.cc +++ b/views/controls/single_split_view.cc @@ -9,7 +9,6 @@ #endif #include "skia/ext/skia_utils_win.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/gfx/canvas.h" #include "views/background.h" @@ -66,9 +65,8 @@ void SingleSplitView::Layout() { View::Layout(); } -void SingleSplitView::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_GROUPING; - state->name = accessible_name_; +AccessibilityTypes::Role SingleSplitView::GetAccessibleRole() { + return AccessibilityTypes::ROLE_GROUPING; } gfx::Size SingleSplitView::GetPreferredSize() { @@ -152,10 +150,6 @@ void SingleSplitView::CalculateChildrenBounds( } } -void SingleSplitView::SetAccessibleName(const string16& name) { - accessible_name_ = name; -} - bool SingleSplitView::OnMousePressed(const MouseEvent& event) { if (!IsPointInDivider(event.location())) return false; diff --git a/views/controls/single_split_view.h b/views/controls/single_split_view.h index 38e7bbb..dc69c67 100644 --- a/views/controls/single_split_view.h +++ b/views/controls/single_split_view.h @@ -42,7 +42,7 @@ class SingleSplitView : public views::View { virtual void OnBoundsChanged(); virtual void Layout(); - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole(); // SingleSplitView's preferred size is the sum of the preferred widths // and the max of the heights. @@ -75,8 +75,6 @@ class SingleSplitView : public views::View { gfx::Rect* leading_bounds, gfx::Rect* trailing_bounds) const; - void SetAccessibleName(const string16& name); - protected: virtual bool OnMousePressed(const MouseEvent& event); virtual bool OnMouseDragged(const MouseEvent& event); @@ -134,9 +132,6 @@ class SingleSplitView : public views::View { // Observer to notify about user initiated handle movements. Not own by us. Observer* observer_; - // The accessible name of this view. - string16 accessible_name_; - DISALLOW_COPY_AND_ASSIGN(SingleSplitView); }; diff --git a/views/controls/tabbed_pane/tabbed_pane.cc b/views/controls/tabbed_pane/tabbed_pane.cc index 1091407..eb9f971 100644 --- a/views/controls/tabbed_pane/tabbed_pane.cc +++ b/views/controls/tabbed_pane/tabbed_pane.cc @@ -5,13 +5,11 @@ #include "views/controls/tabbed_pane/tabbed_pane.h" #include "base/logging.h" -#include "ui/base/accessibility/accessible_view_state.h" // TODO(avi): remove when not needed #include "base/utf_string_conversions.h" #include "ui/base/keycodes/keyboard_codes.h" #include "views/controls/native/native_view_host.h" #include "views/controls/tabbed_pane/native_tabbed_pane_wrapper.h" -#include "views/widget/widget.h" namespace views { @@ -40,6 +38,7 @@ void TabbedPane::AddTabAtIndex(int index, bool select_if_first_tab) { native_tabbed_pane_->AddTabAtIndex(index, title, contents, select_if_first_tab); + contents->SetAccessibleName(WideToUTF16Hack(title)); PreferredSizeChanged(); } @@ -61,10 +60,6 @@ void TabbedPane::SelectTabAt(int index) { native_tabbed_pane_->SelectTabAt(index); } -void TabbedPane::SetAccessibleName(const string16& name) { - accessible_name_ = name; -} - int TabbedPane::GetTabCount() { return native_tabbed_pane_->GetTabCount(); } @@ -123,10 +118,8 @@ void TabbedPane::OnFocus() { native_tabbed_pane_->SetFocus(); View* selected_tab = GetSelectedTab(); - if (selected_tab) { - selected_tab->GetWidget()->NotifyAccessibilityEvent( - selected_tab, ui::AccessibilityTypes::EVENT_FOCUS, true); - } + if (selected_tab) + selected_tab->NotifyAccessibilityEvent(AccessibilityTypes::EVENT_FOCUS); } else View::OnFocus(); // Will focus the RootView window (so we still get @@ -138,9 +131,8 @@ void TabbedPane::OnPaintFocusBorder(gfx::Canvas* canvas) { View::OnPaintFocusBorder(canvas); } -void TabbedPane::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_PAGETABLIST; - state->name = accessible_name_; +AccessibilityTypes::Role TabbedPane::GetAccessibleRole() { + return AccessibilityTypes::ROLE_PAGETABLIST; } gfx::Size TabbedPane::GetPreferredSize() { diff --git a/views/controls/tabbed_pane/tabbed_pane.h b/views/controls/tabbed_pane/tabbed_pane.h index a968d36..4fdb727 100644 --- a/views/controls/tabbed_pane/tabbed_pane.h +++ b/views/controls/tabbed_pane/tabbed_pane.h @@ -14,6 +14,7 @@ class NativeTabbedPaneWrapper; // The TabbedPane class is a view that shows tabs. When the user clicks on a // tab, the associated view is displayed. + class TabbedPane : public View { public: TabbedPane(); @@ -62,20 +63,16 @@ class TabbedPane : public View { Listener* listener() const { return listener_; } - void SetAccessibleName(const string16& name); - // View overrides: - virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child) - OVERRIDE; + virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child); // Handles Ctrl+Tab and Ctrl+Shift+Tab navigation of pages. - virtual bool AcceleratorPressed(const views::Accelerator& accelerator) - OVERRIDE; - virtual std::string GetClassName() const OVERRIDE; - virtual void Layout() OVERRIDE; - virtual void OnFocus() OVERRIDE; - virtual void OnPaintFocusBorder(gfx::Canvas* canvas) OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; - virtual gfx::Size GetPreferredSize() OVERRIDE; + virtual bool AcceleratorPressed(const views::Accelerator& accelerator); + virtual std::string GetClassName() const; + virtual void Layout(); + virtual void OnFocus(); + virtual void OnPaintFocusBorder(gfx::Canvas* canvas); + virtual AccessibilityTypes::Role GetAccessibleRole(); + virtual gfx::Size GetPreferredSize(); NativeTabbedPaneWrapper* native_wrapper() const { return native_tabbed_pane_; @@ -99,9 +96,6 @@ class TabbedPane : public View { // The listener we notify about tab selection changes. Listener* listener_; - // The accessible name of this view. - string16 accessible_name_; - DISALLOW_COPY_AND_ASSIGN(TabbedPane); }; diff --git a/views/controls/textfield/native_textfield_win.cc b/views/controls/textfield/native_textfield_win.cc index 8a735d0..2047d40 100644 --- a/views/controls/textfield/native_textfield_win.cc +++ b/views/controls/textfield/native_textfield_win.cc @@ -12,7 +12,6 @@ #include "base/win/windows_version.h" #include "grit/app_strings.h" #include "skia/ext/skia_utils_win.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/clipboard/clipboard.h" #include "ui/base/clipboard/scoped_clipboard_writer.h" #include "ui/base/keycodes/keyboard_codes.h" @@ -442,11 +441,10 @@ void NativeTextfieldWin::InitializeAccessibilityInfo() { // We expect it to be a Label preceeding this view (if it exists). string16 name; View* label_view = parent->GetChildViewAt(label_index); - if (label_view->GetClassName() == Label::kViewClassName) { - ui::AccessibleViewState state; - label_view->GetAccessibleState(&state); + if (label_view->GetClassName() == Label::kViewClassName && + label_view->GetAccessibleName(&name)) { hr = pAccPropServices->SetHwndPropStr(m_hWnd, OBJID_CLIENT, - CHILDID_SELF, PROPID_ACC_NAME, state.name.c_str()); + CHILDID_SELF, PROPID_ACC_NAME, name.c_str()); } } } diff --git a/views/controls/textfield/textfield.cc b/views/controls/textfield/textfield.cc index 4366a0c..2a72712 100644 --- a/views/controls/textfield/textfield.cc +++ b/views/controls/textfield/textfield.cc @@ -12,7 +12,6 @@ #include "base/string_util.h" #include "base/utf_string_conversions.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/keycodes/keyboard_codes.h" #include "ui/gfx/insets.h" #include "views/controls/native/native_view_host.h" @@ -281,10 +280,6 @@ size_t Textfield::GetCursorPosition() const { return native_wrapper_ ? native_wrapper_->GetCursorPosition() : 0; } -void Textfield::SetAccessibleName(const string16& name) { - accessible_name_ = name; -} - //////////////////////////////////////////////////////////////////////////////// // Textfield, View overrides: @@ -365,14 +360,23 @@ void Textfield::OnBlur() { native_wrapper_->HandleBlur(); } -void Textfield::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_TEXT; - state->name = accessible_name_; +AccessibilityTypes::Role Textfield::GetAccessibleRole() { + return AccessibilityTypes::ROLE_TEXT; +} + +AccessibilityTypes::State Textfield::GetAccessibleState() { + int state = 0; if (read_only()) - state->state |= ui::AccessibilityTypes::STATE_READONLY; + state |= AccessibilityTypes::STATE_READONLY; if (IsPassword()) - state->state |= ui::AccessibilityTypes::STATE_PROTECTED; - state->value = text_; + state |= AccessibilityTypes::STATE_PROTECTED; + return state; +} + +string16 Textfield::GetAccessibleValue() { + if (!text_.empty()) + return text_; + return string16(); } void Textfield::SetEnabled(bool enabled) { diff --git a/views/controls/textfield/textfield.h b/views/controls/textfield/textfield.h index 47285f7..c8484d5 100644 --- a/views/controls/textfield/textfield.h +++ b/views/controls/textfield/textfield.h @@ -247,9 +247,6 @@ class Textfield : public View { // only and has to be called after the wrapper is created. size_t GetCursorPosition() const; - // Set the accessible name of the text field. - void SetAccessibleName(const string16& name); - #ifdef UNIT_TEST gfx::NativeView GetTestingHandle() const { return native_wrapper_ ? native_wrapper_->GetTestingHandle() : NULL; @@ -272,7 +269,9 @@ class Textfield : public View { virtual bool OnKeyReleased(const views::KeyEvent& e) OVERRIDE; virtual void OnFocus() OVERRIDE; virtual void OnBlur() OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole() OVERRIDE; + virtual AccessibilityTypes::State GetAccessibleState() OVERRIDE; + virtual string16 GetAccessibleValue() OVERRIDE; protected: virtual void ViewHierarchyChanged(bool is_add, View* parent, @@ -340,9 +339,6 @@ class Textfield : public View { // Text to display when empty. string16 text_to_display_when_empty_; - // The accessible name of the text field. - string16 accessible_name_; - DISALLOW_COPY_AND_ASSIGN(Textfield); }; diff --git a/views/controls/tree/tree_view.cc b/views/controls/tree/tree_view.cc index 4e8a53d..3f6b8bf 100644 --- a/views/controls/tree/tree_view.cc +++ b/views/controls/tree/tree_view.cc @@ -11,7 +11,6 @@ #include "base/stl_util-inl.h" #include "base/win/win_util.h" #include "grit/app_resources.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/keycodes/keyboard_codes.h" #include "ui/base/keycodes/keyboard_code_conversion_win.h" #include "ui/base/resource/resource_bundle.h" @@ -61,9 +60,12 @@ TreeView::~TreeView() { ImageList_Destroy(image_list_); } -void TreeView::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_OUTLINE; - state->state = ui::AccessibilityTypes::STATE_READONLY; +AccessibilityTypes::Role TreeView::GetAccessibleRole() { + return AccessibilityTypes::ROLE_OUTLINE; +} + +AccessibilityTypes::State TreeView::GetAccessibleState() { + return AccessibilityTypes::STATE_READONLY; } void TreeView::SetModel(TreeModel* model) { diff --git a/views/controls/tree/tree_view.h b/views/controls/tree/tree_view.h index a542e85..d4d0771 100644 --- a/views/controls/tree/tree_view.h +++ b/views/controls/tree/tree_view.h @@ -79,7 +79,8 @@ class TreeView : public NativeControl, ui::TreeModelObserver { } // Overridden from View: - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole(); + virtual AccessibilityTypes::State GetAccessibleState(); // Edits the specified node. This cancels the current edit and expands // all parents of node. diff --git a/views/test/test_views_delegate.h b/views/test/test_views_delegate.h index 3d4f2e6..cae1a64f 100644 --- a/views/test/test_views_delegate.h +++ b/views/test/test_views_delegate.h @@ -3,7 +3,6 @@ // found in the LICENSE file. #include "base/scoped_ptr.h" -#include "ui/base/accessibility/accessibility_types.h" #include "ui/base/clipboard/clipboard.h" #include "views/views_delegate.h" @@ -17,7 +16,7 @@ class TestViewsDelegate : public views::ViewsDelegate { virtual ~TestViewsDelegate() {} // Overridden from views::ViewsDelegate: - virtual ui::Clipboard* GetClipboard() const OVERRIDE { + virtual ui::Clipboard* GetClipboard() const { if (!clipboard_.get()) { // Note that we need a MessageLoop for the next call to work. clipboard_.reset(new ui::Clipboard); @@ -27,32 +26,31 @@ class TestViewsDelegate : public views::ViewsDelegate { virtual void SaveWindowPlacement(views::Window* window, const std::wstring& window_name, const gfx::Rect& bounds, - bool maximized) OVERRIDE { + bool maximized) { } virtual bool GetSavedWindowBounds(views::Window* window, const std::wstring& window_name, - gfx::Rect* bounds) const OVERRIDE { + gfx::Rect* bounds) const { return false; } virtual bool GetSavedMaximizedState(views::Window* window, const std::wstring& window_name, - bool* maximized) const OVERRIDE { + bool* maximized) const { return false; } virtual void NotifyAccessibilityEvent( - views::View* view, ui::AccessibilityTypes::Event event_type) OVERRIDE {} - + views::View* view, AccessibilityTypes::Event event_type) {} #if defined(OS_WIN) - virtual HICON GetDefaultWindowIcon() const OVERRIDE { + virtual HICON GetDefaultWindowIcon() const { return NULL; } #endif - - virtual void AddRef() OVERRIDE {} - virtual void ReleaseRef() OVERRIDE {} + virtual void AddRef() {} + virtual void ReleaseRef() {} private: mutable scoped_ptr<ui::Clipboard> clipboard_; DISALLOW_COPY_AND_ASSIGN(TestViewsDelegate); }; + diff --git a/views/view.cc b/views/view.cc index dd511ab..bd778c645 100644 --- a/views/view.cc +++ b/views/view.cc @@ -11,7 +11,6 @@ #include "base/scoped_ptr.h" #include "base/utf_string_conversions.h" #include "third_party/skia/include/core/SkRect.h" -#include "ui/base/accessibility/accessibility_types.h" #include "ui/base/dragdrop/drag_drop_types.h" #include "ui/gfx/canvas_skia.h" #include "ui/gfx/path.h" @@ -27,7 +26,7 @@ #if defined(OS_WIN) #include "base/win/scoped_gdi_object.h" -#include "views/accessibility/native_view_accessibility_win.h" +#include "views/accessibility/view_accessibility.h" #endif #if defined(OS_LINUX) #include "ui/base/gtk/scoped_handle_gtk.h" @@ -87,8 +86,8 @@ View::~View() { } #if defined(OS_WIN) - if (native_view_accessibility_win_.get()) - native_view_accessibility_win_->set_view(NULL); + if (view_accessibility_.get()) + view_accessibility_->set_view(NULL); #endif } @@ -986,6 +985,29 @@ bool View::ExceededDragThreshold(int delta_x, int delta_y) { abs(delta_y) > GetVerticalDragThreshold()); } +// Accessibility --------------------------------------------------------------- + +void View::NotifyAccessibilityEvent(AccessibilityTypes::Event event_type) { + NotifyAccessibilityEvent(event_type, true); +} + +bool View::GetAccessibleName(string16* name) { + DCHECK(name); + + if (accessible_name_.empty()) + return false; + *name = accessible_name_; + return true; +} + +AccessibilityTypes::Role View::GetAccessibleRole() { + return AccessibilityTypes::ROLE_CLIENT; +} + +void View::SetAccessibleName(const string16& name) { + accessible_name_ = name; +} + // Scrolling ------------------------------------------------------------------- void View::ScrollRectToVisible(const gfx::Rect& rect) { @@ -1114,8 +1136,7 @@ void View::OnFocus() { // TODO(beng): Investigate whether it's possible for us to move this to // Focus(). // Notify assistive technologies of the focus change. - GetWidget()->NotifyAccessibilityEvent( - this, ui::AccessibilityTypes::EVENT_FOCUS, true); + NotifyAccessibilityEvent(AccessibilityTypes::EVENT_FOCUS); } void View::OnBlur() { diff --git a/views/view.h b/views/view.h index f784c8e..83af008 100644 --- a/views/view.h +++ b/views/view.h @@ -20,11 +20,13 @@ #include "ui/gfx/native_widget_types.h" #include "ui/gfx/rect.h" #include "views/accelerator.h" +#include "views/accessibility/accessibility_types.h" #include "views/background.h" #include "views/border.h" using ui::OSExchangeData; +class ViewAccessibility; namespace gfx { class Canvas; @@ -33,7 +35,6 @@ class Path; } namespace ui { -struct AccessibleViewState; class ThemeProvider; class Transform; } @@ -51,10 +52,6 @@ class ScrollView; class Widget; class Window; -#if defined(OS_WIN) -class NativeViewAccessibilityWin; -#endif - // ContextMenuController is responsible for showing the context menu for a // View. To use a ContextMenuController invoke SetContextMenuController on a // View. When the appropriate user gesture occurs ShowContextMenu is invoked @@ -533,7 +530,7 @@ class View : public AcceleratorTarget { const Border* border() const { return border_.get(); } // Get the theme provider from the parent widget. - virtual ThemeProvider* GetThemeProvider() const; + ThemeProvider* GetThemeProvider() const; // RTL painting -------------------------------------------------------------- @@ -880,15 +877,55 @@ class View : public AcceleratorTarget { static bool ExceededDragThreshold(int delta_x, int delta_y); // Accessibility ------------------------------------------------------------- + // TODO(ctguil): Move all this out to a AccessibleInfo wrapper class. + + // Notify the platform specific accessibility client of changes in the user + // interface. This will always raise native notifications. + virtual void NotifyAccessibilityEvent(AccessibilityTypes::Event event_type); + + // Raise an accessibility notification with an option to also raise a native + // notification. + virtual void NotifyAccessibilityEvent(AccessibilityTypes::Event event_type, + bool send_native_event); + + // Returns the MSAA default action of the current view. The string returned + // describes the default action that will occur when executing + // IAccessible::DoDefaultAction. For instance, default action of a button is + // 'Press'. + virtual string16 GetAccessibleDefaultAction() { return string16(); } + + // Returns a string containing the mnemonic, or the keyboard shortcut, for a + // given control. + virtual string16 GetAccessibleKeyboardShortcut() { + return string16(); + } - // Modifies |state| to reflect the current accessible state of this view. - virtual void GetAccessibleState(ui::AccessibleViewState* state) { } + // Returns a brief, identifying string, containing a unique, readable name of + // a given control. Sets the input string appropriately, and returns true if + // successful. + bool GetAccessibleName(string16* name); -#if defined(OS_WIN) - // Returns an instance of the Windows-specific accessibility interface - // for this View. - NativeViewAccessibilityWin* GetNativeViewAccessibilityWin(); -#endif + // Returns the accessibility role of the current view. The role is what + // assistive technologies (ATs) use to determine what behavior to expect from + // a given control. + virtual AccessibilityTypes::Role GetAccessibleRole(); + + // Returns the accessibility state of the current view. + virtual AccessibilityTypes::State GetAccessibleState() { + return 0; + } + + // Returns the current value associated with a view. + virtual string16 GetAccessibleValue() { return string16(); } + + // Assigns a string name to the given control. Needed as a View does not know + // which name will be associated with it until it is created to be a + // certain type. + void SetAccessibleName(const string16& name); + + // Returns an instance of the (platform-specific) accessibility interface for + // the View. + ViewAccessibility* GetViewAccessibility(); // Scrolling ----------------------------------------------------------------- // TODO(beng): Figure out if this can live somewhere other than View, i.e. @@ -1371,9 +1408,12 @@ class View : public AcceleratorTarget { // Accessibility ------------------------------------------------------------- + // Name for this view, which can be retrieved by accessibility APIs. + string16 accessible_name_; + #if defined(OS_WIN) - // The Windows-specific accessibility implementation for this View. - scoped_refptr<NativeViewAccessibilityWin> native_view_accessibility_win_; + // The accessibility implementation for this View. + scoped_refptr<ViewAccessibility> view_accessibility_; #endif DISALLOW_COPY_AND_ASSIGN(View); diff --git a/views/view_gtk.cc b/views/view_gtk.cc index 5155099..b666338 100644 --- a/views/view_gtk.cc +++ b/views/view_gtk.cc @@ -7,9 +7,25 @@ #include <gtk/gtk.h> #include "base/logging.h" +#include "views/views_delegate.h" namespace views { +void View::NotifyAccessibilityEvent(AccessibilityTypes::Event event_type, + bool send_native_event) { + // Send the notification to the delegate. + if (ViewsDelegate::views_delegate) + ViewsDelegate::views_delegate->NotifyAccessibilityEvent(this, event_type); + + // In the future if we add native GTK accessibility support, the + // notification should be sent here. +} + +ViewAccessibility* View::GetViewAccessibility() { + NOTIMPLEMENTED(); + return NULL; +} + int View::GetHorizontalDragThreshold() { static bool determined_threshold = false; static int drag_threshold = 8; diff --git a/views/view_win.cc b/views/view_win.cc index 011b319..2c213c2 100644 --- a/views/view_win.cc +++ b/views/view_win.cc @@ -13,7 +13,7 @@ #include "ui/base/dragdrop/drag_drop_types.h" #include "ui/gfx/canvas.h" #include "ui/gfx/path.h" -#include "views/accessibility/native_view_accessibility_win.h" +#include "views/accessibility/view_accessibility.h" #include "views/border.h" #include "views/views_delegate.h" #include "views/widget/root_view.h" @@ -22,11 +22,28 @@ namespace views { -NativeViewAccessibilityWin* View::GetNativeViewAccessibilityWin() { - if (!native_view_accessibility_win_.get()) - native_view_accessibility_win_.swap( - NativeViewAccessibilityWin::Create(this)); - return native_view_accessibility_win_.get(); +void View::NotifyAccessibilityEvent(AccessibilityTypes::Event event_type, + bool send_native_event) { + // Send the notification to the delegate. + if (ViewsDelegate::views_delegate) + ViewsDelegate::views_delegate->NotifyAccessibilityEvent(this, event_type); + + // Now call the Windows-specific method to notify MSAA clients of this + // event. The widget gives us a temporary unique child ID to associate + // with this view so that clients can call get_accChild in ViewAccessibility + // to retrieve the IAccessible associated with this view. + if (send_native_event) { + WidgetWin* view_widget = static_cast<WidgetWin*>(GetWidget()); + int child_id = view_widget->AddAccessibilityViewEvent(this); + ::NotifyWinEvent(ViewAccessibility::MSAAEvent(event_type), + view_widget->GetNativeView(), OBJID_CLIENT, child_id); + } +} + +ViewAccessibility* View::GetViewAccessibility() { + if (!view_accessibility_.get()) + view_accessibility_.swap(ViewAccessibility::Create(this)); + return view_accessibility_.get(); } int View::GetHorizontalDragThreshold() { diff --git a/views/views.gyp b/views/views.gyp index 41f70c5..f8b145c 100644 --- a/views/views.gyp +++ b/views/views.gyp @@ -74,8 +74,9 @@ # All .cc, .h under views, except unittests 'accelerator.cc', 'accelerator.h', - 'accessibility/native_view_accessibility_win.cc', - 'accessibility/native_view_accessibility_win.h', + 'accessibility/accessibility_types.h', + 'accessibility/view_accessibility.cc', + 'accessibility/view_accessibility.h', 'animation/bounds_animator.cc', 'animation/bounds_animator.h', 'background.cc', @@ -388,7 +389,9 @@ '../build/linux/system.gyp:xext', ], 'sources!': [ - 'accessibility/native_view_accessibility_win.cc', + 'accessibility/accessible_wrapper.cc', + 'accessibility/view_accessibility.cc', + 'accessibility/view_accessibility_wrapper.cc', 'controls/scrollbar/bitmap_scroll_bar.cc', 'controls/combo_box.cc', 'controls/hwnd_view.cc', diff --git a/views/views_delegate.h b/views/views_delegate.h index d7411f6..98b734e 100644 --- a/views/views_delegate.h +++ b/views/views_delegate.h @@ -11,7 +11,7 @@ #include <windows.h> #endif -#include "ui/base/accessibility/accessibility_types.h" +#include "views/accessibility/accessibility_types.h" namespace gfx { class Rect; @@ -58,8 +58,10 @@ class ViewsDelegate { const std::wstring& window_name, bool* maximized) const = 0; + // Notify the delegate that an accessibility event has happened in + // a particular view. virtual void NotifyAccessibilityEvent( - views::View* view, ui::AccessibilityTypes::Event event_type) = 0; + views::View* view, AccessibilityTypes::Event event_type) = 0; #if defined(OS_WIN) // Retrieves the default window icon to use for windows if none is specified. diff --git a/views/widget/root_view.cc b/views/widget/root_view.cc index 65e4002..9d4bbc3 100644 --- a/views/widget/root_view.cc +++ b/views/widget/root_view.cc @@ -8,7 +8,6 @@ #include "base/logging.h" #include "base/message_loop.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "ui/base/dragdrop/drag_drop_types.h" #include "ui/base/keycodes/keyboard_codes.h" #include "ui/gfx/canvas_skia.h" @@ -420,8 +419,8 @@ std::string RootView::GetClassName() const { return kViewClassName; } -void RootView::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_APPLICATION; +AccessibilityTypes::Role RootView::GetAccessibleRole() { + return AccessibilityTypes::ROLE_APPLICATION; } void RootView::OnPaint(gfx::Canvas* canvas) { diff --git a/views/widget/root_view.h b/views/widget/root_view.h index d9634b2..e6d5bcb 100644 --- a/views/widget/root_view.h +++ b/views/widget/root_view.h @@ -117,7 +117,7 @@ class RootView : public View, #endif virtual bool IsVisibleInRootView() const OVERRIDE; virtual std::string GetClassName() const OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual AccessibilityTypes::Role GetAccessibleRole() OVERRIDE; protected: // Overridden from View: diff --git a/views/widget/widget.h b/views/widget/widget.h index 46a37d7..a9eb040 100644 --- a/views/widget/widget.h +++ b/views/widget/widget.h @@ -9,7 +9,6 @@ #include <vector> #include "base/scoped_ptr.h" -#include "ui/base/accessibility/accessibility_types.h" #include "ui/gfx/native_widget_types.h" #include "views/focus/focus_manager.h" #include "views/widget/native_widget_delegate.h" @@ -241,17 +240,6 @@ class Widget : public internal::NativeWidgetDelegate, void SetFocusTraversableParent(FocusTraversable* parent); void SetFocusTraversableParentView(View* parent_view); - // Notifies assistive technology that an accessibility event has - // occurred on |view|, such as when the view is focused or when its - // value changes. Pass true for |send_native_event| except for rare - // cases where the view is a native control that's already sending a - // native accessibility event and the duplicate event would cause - // problems. - virtual void NotifyAccessibilityEvent( - View* view, - ui::AccessibilityTypes::Event event_type, - bool send_native_event) = 0; - NativeWidget* native_widget() { return native_widget_; } // Overridden from FocusTraversable: diff --git a/views/widget/widget_gtk.cc b/views/widget/widget_gtk.cc index dfa1b2e..0ae89cb 100644 --- a/views/widget/widget_gtk.cc +++ b/views/widget/widget_gtk.cc @@ -21,7 +21,6 @@ #include "ui/base/x/x11_util.h" #include "ui/gfx/canvas_skia_paint.h" #include "ui/gfx/path.h" -#include "views/views_delegate.h" #include "views/focus/view_storage.h" #include "views/widget/drop_target_gtk.h" #include "views/widget/gtk_views_fixed.h" @@ -780,18 +779,6 @@ void WidgetGtk::ViewHierarchyChanged(bool is_add, View* parent, View* child) { } } -void WidgetGtk::NotifyAccessibilityEvent( - View* view, - ui::AccessibilityTypes::Event event_type, - bool send_native_event) { - // Send the notification to the delegate. - if (ViewsDelegate::views_delegate) - ViewsDelegate::views_delegate->NotifyAccessibilityEvent(view, event_type); - - // In the future if we add native GTK accessibility support, the - // notification should be sent here. -} - void WidgetGtk::ClearNativeFocus() { DCHECK(type_ != TYPE_CHILD); if (!GetNativeView()) { diff --git a/views/widget/widget_gtk.h b/views/widget/widget_gtk.h index a9a7034..9facf90 100644 --- a/views/widget/widget_gtk.h +++ b/views/widget/widget_gtk.h @@ -173,10 +173,6 @@ class WidgetGtk : public Widget, virtual FocusManager* GetFocusManager(); virtual void ViewHierarchyChanged(bool is_add, View *parent, View *child); - virtual void NotifyAccessibilityEvent( - View* view, - ui::AccessibilityTypes::Event event_type, - bool send_native_event); // Clears the focus on the native widget having the focus. virtual void ClearNativeFocus(); diff --git a/views/widget/widget_win.cc b/views/widget/widget_win.cc index cabe472..e81d5c2 100644 --- a/views/widget/widget_win.cc +++ b/views/widget/widget_win.cc @@ -21,7 +21,7 @@ #include "ui/gfx/canvas_skia.h" #include "ui/gfx/native_theme_win.h" #include "ui/gfx/path.h" -#include "views/accessibility/native_view_accessibility_win.h" +#include "views/accessibility/view_accessibility.h" #include "views/controls/native_control_win.h" #include "views/focus/accelerator_handler.h" #include "views/focus/focus_util_win.h" @@ -507,26 +507,6 @@ void WidgetWin::SetCursor(gfx::NativeCursor cursor) { } } -void WidgetWin::NotifyAccessibilityEvent( - View* view, - ui::AccessibilityTypes::Event event_type, - bool send_native_event) { - // Send the notification to the delegate. - if (ViewsDelegate::views_delegate) - ViewsDelegate::views_delegate->NotifyAccessibilityEvent(view, event_type); - - // Now call the Windows-specific method to notify MSAA clients of this - // event. The widget gives us a temporary unique child ID to associate - // with this view so that clients can call get_accChild in - // NativeViewAccessibilityWin to retrieve the IAccessible associated - // with this view. - if (send_native_event) { - int child_id = AddAccessibilityViewEvent(view); - ::NotifyWinEvent(NativeViewAccessibilityWin::MSAAEvent(event_type), - GetNativeView(), OBJID_CLIENT, child_id); - } -} - //////////////////////////////////////////////////////////////////////////////// // WidgetWin, MessageLoop::Observer implementation: @@ -669,7 +649,7 @@ LRESULT WidgetWin::OnGetObject(UINT uMsg, WPARAM w_param, LPARAM l_param) { if (OBJID_CLIENT == l_param) { // Retrieve MSAA dispatch object for the root view. base::win::ScopedComPtr<IAccessible> root( - NativeViewAccessibilityWin::GetAccessibleForView(GetRootView())); + ViewAccessibility::GetAccessibleForView(GetRootView())); // Create a reference that MSAA will marshall to the client. reference_result = LresultFromObject(IID_IAccessible, w_param, diff --git a/views/widget/widget_win.h b/views/widget/widget_win.h index add96c1..72414be 100644 --- a/views/widget/widget_win.h +++ b/views/widget/widget_win.h @@ -106,9 +106,8 @@ class WidgetWin : public ui::WindowImpl, } // Obtain the view event with the given MSAA child id. Used in - // NativeViewAccessibilityWin::get_accChild to support requests for - // children of windowless controls. May return NULL - // (see ViewHierarchyChanged). + // ViewAccessibility::get_accChild to support requests for children of + // windowless controls. May return NULL (see ViewHierarchyChanged). View* GetAccessibilityViewEventAt(int id); // Add a view that has recently fired an accessibility event. Returns a MSAA @@ -146,10 +145,6 @@ class WidgetWin : public ui::WindowImpl, virtual FocusManager* GetFocusManager(); virtual void ViewHierarchyChanged(bool is_add, View *parent, View *child); - virtual void NotifyAccessibilityEvent( - View* view, - ui::AccessibilityTypes::Event event_type, - bool send_native_event); BOOL IsWindow() const { return ::IsWindow(GetNativeView()); diff --git a/views/window/client_view.cc b/views/window/client_view.cc index 92dd06d..de198ed 100644 --- a/views/window/client_view.cc +++ b/views/window/client_view.cc @@ -3,7 +3,6 @@ // found in the LICENSE file. #include "base/logging.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "views/window/client_view.h" #if defined(OS_LINUX) #include "views/window/hit_test.h" @@ -63,8 +62,8 @@ void ClientView::OnBoundsChanged() { // NonClientView::Layout. } -void ClientView::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_CLIENT; +AccessibilityTypes::Role ClientView::GetAccessibleRole() { + return AccessibilityTypes::ROLE_CLIENT; } } // namespace views diff --git a/views/window/client_view.h b/views/window/client_view.h index 6dd39fe..08ddcd4 100644 --- a/views/window/client_view.h +++ b/views/window/client_view.h @@ -60,10 +60,9 @@ class ClientView : public View { protected: // Overridden from View: - virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child) - OVERRIDE; - virtual void OnBoundsChanged() OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child); + virtual void OnBoundsChanged(); + virtual AccessibilityTypes::Role GetAccessibleRole(); // Accessors for private data members. Window* window() const { return window_; } diff --git a/views/window/dialog_delegate.h b/views/window/dialog_delegate.h index 36090ca..ac6d4e9 100644 --- a/views/window/dialog_delegate.h +++ b/views/window/dialog_delegate.h @@ -6,8 +6,8 @@ #define VIEWS_WINDOW_DIALOG_DELEGATE_H_ #pragma once -#include "ui/base/accessibility/accessibility_types.h" #include "ui/base/message_box_flags.h" +#include "views/accessibility/accessibility_types.h" #include "views/window/dialog_client_view.h" #include "views/window/window_delegate.h" @@ -122,10 +122,10 @@ class DialogDelegate : public WindowDelegate { // delegate's Window. DialogClientView* GetDialogClientView() const; - protected: + private: // Overridden from WindowDelegate: - virtual ui::AccessibilityTypes::Role GetAccessibleRole() const { - return ui::AccessibilityTypes::ROLE_DIALOG; + AccessibilityTypes::Role accessible_role() const { + return AccessibilityTypes::ROLE_DIALOG; } }; diff --git a/views/window/non_client_view.cc b/views/window/non_client_view.cc index bb09fa3..210bd10 100644 --- a/views/window/non_client_view.cc +++ b/views/window/non_client_view.cc @@ -4,7 +4,6 @@ #include "views/window/non_client_view.h" -#include "ui/base/accessibility/accessible_view_state.h" #include "views/widget/root_view.h" #include "views/widget/widget.h" #include "views/window/window.h" @@ -122,10 +121,6 @@ void NonClientView::LayoutFrameView() { frame_view_->Layout(); } -void NonClientView::SetAccessibleName(const string16& name) { - accessible_name_ = name; -} - //////////////////////////////////////////////////////////////////////////////// // NonClientView, View overrides: @@ -179,9 +174,8 @@ views::View* NonClientView::GetEventHandlerForPoint(const gfx::Point& point) { return View::GetEventHandlerForPoint(point); } -void NonClientView::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_WINDOW; - state->name = accessible_name_; +AccessibilityTypes::Role NonClientView::GetAccessibleRole() { + return AccessibilityTypes::ROLE_WINDOW; } //////////////////////////////////////////////////////////////////////////////// @@ -254,8 +248,8 @@ bool NonClientFrameView::ShouldPaintAsActive() const { return GetWindow()->IsActive() || paint_as_active_; } -void NonClientFrameView::GetAccessibleState(ui::AccessibleViewState* state) { - state->role = ui::AccessibilityTypes::ROLE_WINDOW; +AccessibilityTypes::Role NonClientFrameView::GetAccessibleRole() { + return AccessibilityTypes::ROLE_WINDOW; } } // namespace views diff --git a/views/window/non_client_view.h b/views/window/non_client_view.h index 10c652c..db1daff 100644 --- a/views/window/non_client_view.h +++ b/views/window/non_client_view.h @@ -69,8 +69,8 @@ class NonClientFrameView : public View { virtual void ResetWindowControls() = 0; // Overridden from View: - virtual bool HitTest(const gfx::Point& l) const OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual bool HitTest(const gfx::Point& l) const; + virtual AccessibilityTypes::Role GetAccessibleRole(); protected: virtual void OnBoundsChanged(); @@ -205,21 +205,16 @@ class NonClientView : public View { // of a window resize message. void LayoutFrameView(); - // Set the accessible name of this view. - void SetAccessibleName(const string16& name); - // NonClientView, View overrides: - virtual gfx::Size GetPreferredSize() OVERRIDE; - virtual gfx::Size GetMinimumSize() OVERRIDE; - virtual void Layout() OVERRIDE; - virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE; + virtual gfx::Size GetPreferredSize(); + virtual gfx::Size GetMinimumSize(); + virtual void Layout(); + virtual AccessibilityTypes::Role GetAccessibleRole(); protected: // NonClientView, View overrides: - virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child) - OVERRIDE; - virtual views::View* GetEventHandlerForPoint(const gfx::Point& point) - OVERRIDE; + virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child); + virtual views::View* GetEventHandlerForPoint(const gfx::Point& point); private: // The frame that hosts this NonClientView. @@ -235,9 +230,6 @@ class NonClientView : public View { // dynamically as the system settings change. scoped_ptr<NonClientFrameView> frame_view_; - // The accessible name of this view. - string16 accessible_name_; - DISALLOW_COPY_AND_ASSIGN(NonClientView); }; diff --git a/views/window/window_delegate.h b/views/window/window_delegate.h index 6ef75cc..04ac6b3 100644 --- a/views/window/window_delegate.h +++ b/views/window/window_delegate.h @@ -9,7 +9,7 @@ #include <string> #include "base/scoped_ptr.h" -#include "ui/base/accessibility/accessibility_types.h" +#include "views/accessibility/accessibility_types.h" class SkBitmap; @@ -56,11 +56,11 @@ class WindowDelegate { return false; } - virtual ui::AccessibilityTypes::Role GetAccessibleRole() const { - return ui::AccessibilityTypes::ROLE_WINDOW; + virtual AccessibilityTypes::Role accessible_role() const { + return AccessibilityTypes::ROLE_WINDOW; } - virtual ui::AccessibilityTypes::State GetAccessibleState() const { + virtual AccessibilityTypes::State accessible_state() const { return 0; } diff --git a/views/window/window_win.cc b/views/window/window_win.cc index 49c9b2a..7776bea 100644 --- a/views/window/window_win.cc +++ b/views/window/window_win.cc @@ -11,7 +11,6 @@ #include "base/win/scoped_gdi_object.h" #include "base/win/win_util.h" #include "base/win/windows_version.h" -#include "ui/base/accessibility/accessibility_types.h" #include "ui/base/keycodes/keyboard_code_conversion_win.h" #include "ui/base/l10n/l10n_util_win.h" #include "ui/base/theme_provider.h" @@ -20,7 +19,7 @@ #include "ui/gfx/font.h" #include "ui/gfx/icon_util.h" #include "ui/gfx/path.h" -#include "views/accessibility/native_view_accessibility_win.h" +#include "views/accessibility/view_accessibility.h" #include "views/widget/root_view.h" #include "views/window/client_view.h" #include "views/window/custom_frame_view.h" @@ -1449,10 +1448,10 @@ void WindowWin::UpdateAccessibleRole() { IID_IAccPropServices, reinterpret_cast<void**>(&pAccPropServices)); if (SUCCEEDED(hr)) { VARIANT var; - ui::AccessibilityTypes::Role role = window_delegate_->GetAccessibleRole(); + AccessibilityTypes::Role role = window_delegate_->accessible_role(); if (role) { var.vt = VT_I4; - var.lVal = NativeViewAccessibilityWin::MSAARole(role); + var.lVal = ViewAccessibility::MSAARole(role); hr = pAccPropServices->SetHwndProp(GetNativeView(), OBJID_CLIENT, CHILDID_SELF, PROPID_ACC_ROLE, var); } @@ -1465,10 +1464,9 @@ void WindowWin::UpdateAccessibleState() { IID_IAccPropServices, reinterpret_cast<void**>(&pAccPropServices)); if (SUCCEEDED(hr)) { VARIANT var; - ui::AccessibilityTypes::State state = - window_delegate_->GetAccessibleState(); + AccessibilityTypes::State state = window_delegate_->accessible_state(); if (state) { - var.lVal = NativeViewAccessibilityWin::MSAAState(state); + var.lVal = ViewAccessibility::MSAAState(state); hr = pAccPropServices->SetHwndProp(GetNativeView(), OBJID_CLIENT, CHILDID_SELF, PROPID_ACC_STATE, var); } |