summaryrefslogtreecommitdiffstats
path: root/webkit/fileapi
diff options
context:
space:
mode:
Diffstat (limited to 'webkit/fileapi')
-rw-r--r--webkit/fileapi/file_system_operation.cc4
-rw-r--r--webkit/fileapi/file_system_operation_unittest.cc14
2 files changed, 16 insertions, 2 deletions
diff --git a/webkit/fileapi/file_system_operation.cc b/webkit/fileapi/file_system_operation.cc
index 5e66453..b01f4d5 100644
--- a/webkit/fileapi/file_system_operation.cc
+++ b/webkit/fileapi/file_system_operation.cc
@@ -326,7 +326,7 @@ void FileSystemOperation::DidDirectoryExists(
if (file_info.is_directory)
dispatcher_->DidSucceed();
else
- dispatcher_->DidFail(base::PLATFORM_FILE_ERROR_FAILED);
+ dispatcher_->DidFail(base::PLATFORM_FILE_ERROR_NOT_A_DIRECTORY);
} else {
dispatcher_->DidFail(rv);
}
@@ -338,7 +338,7 @@ void FileSystemOperation::DidFileExists(
const base::PlatformFileInfo& file_info) {
if (rv == base::PLATFORM_FILE_OK) {
if (file_info.is_directory)
- dispatcher_->DidFail(base::PLATFORM_FILE_ERROR_FAILED);
+ dispatcher_->DidFail(base::PLATFORM_FILE_ERROR_NOT_A_FILE);
else
dispatcher_->DidSucceed();
} else {
diff --git a/webkit/fileapi/file_system_operation_unittest.cc b/webkit/fileapi/file_system_operation_unittest.cc
index b535676..7e3a177 100644
--- a/webkit/fileapi/file_system_operation_unittest.cc
+++ b/webkit/fileapi/file_system_operation_unittest.cc
@@ -570,6 +570,20 @@ TEST_F(FileSystemOperationTest, TestExistsAndMetadataSuccess) {
EXPECT_FALSE(info().is_directory);
}
+TEST_F(FileSystemOperationTest, TestTypeMismatchErrors) {
+ ScopedTempDir dir;
+ ASSERT_TRUE(dir.CreateUniqueTempDir());
+ operation()->FileExists(dir.path());
+ MessageLoop::current()->RunAllPending();
+ EXPECT_EQ(base::PLATFORM_FILE_ERROR_NOT_A_FILE, status());
+
+ FilePath file;
+ ASSERT_TRUE(file_util::CreateTemporaryFileInDir(dir.path(), &file));
+ operation()->DirectoryExists(file);
+ MessageLoop::current()->RunAllPending();
+ EXPECT_EQ(base::PLATFORM_FILE_ERROR_NOT_A_DIRECTORY, status());
+}
+
TEST_F(FileSystemOperationTest, TestReadDirFailure) {
// Path doesn't exists
FilePath nonexisting_dir_path(base_.path().Append(