diff options
Diffstat (limited to 'webkit/tools')
-rw-r--r-- | webkit/tools/layout_tests/flakiness_dashboard.html | 20 |
1 files changed, 18 insertions, 2 deletions
diff --git a/webkit/tools/layout_tests/flakiness_dashboard.html b/webkit/tools/layout_tests/flakiness_dashboard.html index 0e30954..6954bc1 100644 --- a/webkit/tools/layout_tests/flakiness_dashboard.html +++ b/webkit/tools/layout_tests/flakiness_dashboard.html @@ -279,7 +279,7 @@ var BUILD_TYPES = {'DEBUG': 'DBG', 'RELEASE': 'RELEASE'}; var BASE_TABLE_HEADERS = ['bugs', 'modifiers', 'expectations', 'missing', 'extra', 'slowest run', 'flakiness (numbers are runtimes in seconds)']; - var MIN_SECONDS_FOR_SLOW_TEST = 3; + var MIN_SECONDS_FOR_SLOW_TEST = 4; var MIN_SECONDS_FOR_SLOW_TEST_DEBUG = 2 * MIN_SECONDS_FOR_SLOW_TEST; var FAIL_RESULTS = ['IMAGE', 'IMAGE+TEXT', 'TEXT', 'SIMPLIFIED', 'OTHER']; var CHUNK_SIZE = 25; @@ -420,6 +420,7 @@ html: '', flips: 0, slowestTime: 0, + slowestNonTimeoutCrashTime: 0, meetsExpectations: true, isWontFixSkip: false, isFlaky: false, @@ -582,6 +583,10 @@ }); } + /** + * Returns whether this test's slowest time is above the cutoff for + * being a slow test. + */ function isSlowTest(resultsForTest) { var maxTime = isDebug(resultsForTest.builder) ? MIN_SECONDS_FOR_SLOW_TEST_DEBUG : @@ -589,6 +594,17 @@ return resultsForTest.slowestNonTimeoutCrashTime > maxTime; } + /** + * Returns whether this test's slowest time is *well* below the cutoff for + * being a slow test. + */ + function isFastTest(resultsForTest) { + var maxTime = isDebug(resultsForTest.builder) ? + MIN_SECONDS_FOR_SLOW_TEST_DEBUG : + MIN_SECONDS_FOR_SLOW_TEST; + return resultsForTest.slowestNonTimeoutCrashTime < maxTime / 2; + } + function getAllTestsWithCondition(conditionFn) { processTestRunsForAllBuilders(); var tests = getAllTests(); @@ -1068,7 +1084,7 @@ (!resultsForTest.modifiers || !stringContains(resultsForTest.modifiers, 'SLOW'))) { missingExpectations.push('SLOW'); - } else if (resultsForTest.slowestTime < 1 && + } else if (isFastTest(resultsForTest) && resultsForTest.modifiers && stringContains(resultsForTest.modifiers, 'SLOW')) { extraExpectations.push('SLOW'); |